rubocop-rails 2.5.1 → 2.8.0

data/lib/rubocop/cop/rails_cops.rb

@@ -6,8 +6,10 @@ require_relative 'mixin/target_rails_version'
 
 require_relative 'rails/action_filter'
 require_relative 'rails/active_record_aliases'
+require_relative 'rails/active_record_callbacks_order'
 require_relative 'rails/active_record_override'
 require_relative 'rails/active_support_aliases'
+require_relative 'rails/after_commit_override'
 require_relative 'rails/application_controller'
 require_relative 'rails/application_job'
 require_relative 'rails/application_mailer'
@@ -16,8 +18,10 @@ require_relative 'rails/assert_not'
 require_relative 'rails/belongs_to'
 require_relative 'rails/blank'
 require_relative 'rails/bulk_change_table'
+require_relative 'rails/content_tag'
 require_relative 'rails/create_table_with_timestamps'
 require_relative 'rails/date'
+require_relative 'rails/default_scope'
 require_relative 'rails/delegate'
 require_relative 'rails/delegate_allow_blank'
 require_relative 'rails/dynamic_find_by'
@@ -27,6 +31,7 @@ require_relative 'rails/environment_comparison'
 require_relative 'rails/exit'
 require_relative 'rails/file_path'
 require_relative 'rails/find_by'
+require_relative 'rails/find_by_id'
 require_relative 'rails/find_each'
 require_relative 'rails/has_and_belongs_to_many'
 require_relative 'rails/has_many_or_has_one_dependent'
@@ -36,31 +41,47 @@ require_relative 'rails/http_status'
 require_relative 'rails/ignored_skip_action_filter_option'
 require_relative 'rails/index_by'
 require_relative 'rails/index_with'
+require_relative 'rails/inquiry'
 require_relative 'rails/inverse_of'
 require_relative 'rails/lexically_scoped_action_filter'
 require_relative 'rails/link_to_blank'
+require_relative 'rails/mailer_name'
+require_relative 'rails/match_route'
+require_relative 'rails/negate_include'
 require_relative 'rails/not_null_column'
+require_relative 'rails/order_by_id'
 require_relative 'rails/output'
 require_relative 'rails/output_safety'
+require_relative 'rails/pick'
+require_relative 'rails/pluck'
+require_relative 'rails/pluck_id'
+require_relative 'rails/pluck_in_where'
 require_relative 'rails/pluralization_grammar'
 require_relative 'rails/presence'
 require_relative 'rails/present'
 require_relative 'rails/rake_environment'
 require_relative 'rails/read_write_attribute'
 require_relative 'rails/redundant_allow_nil'
+require_relative 'rails/redundant_foreign_key'
 require_relative 'rails/redundant_receiver_in_with_options'
 require_relative 'rails/reflection_class_name'
 require_relative 'rails/refute_methods'
 require_relative 'rails/relative_date_constant'
+require_relative 'rails/render_inline'
+require_relative 'rails/render_plain_text'
 require_relative 'rails/request_referer'
 require_relative 'rails/reversible_migration'
 require_relative 'rails/safe_navigation'
 require_relative 'rails/safe_navigation_with_blank'
 require_relative 'rails/save_bang'
 require_relative 'rails/scope_args'
+require_relative 'rails/short_i18n'
 require_relative 'rails/skips_model_validations'
+require_relative 'rails/squished_sql_heredocs'
 require_relative 'rails/time_zone'
 require_relative 'rails/uniq_before_pluck'
 require_relative 'rails/unique_validation_without_index'
 require_relative 'rails/unknown_env'
 require_relative 'rails/validation'
+require_relative 'rails/where_exists'
+require_relative 'rails/where_not'

data/lib/rubocop/rails/schema_loader.rb

@@ -24,16 +24,6 @@ module RuboCop
         remove_instance_variable(:@schema)
       end
 
-      private
-
-      def load!(target_ruby_version)
-        path = db_schema_path
-        return unless path
-
-        ast = parse(path, target_ruby_version)
-        Schema.new(ast)
-      end
-
       def db_schema_path
         path = Pathname.pwd
         until path.root?
@@ -46,6 +36,16 @@ module RuboCop
         nil
       end
 
+      private
+
+      def load!(target_ruby_version)
+        path = db_schema_path
+        return unless path
+
+        ast = parse(path, target_ruby_version)
+        Schema.new(ast)
+      end
+
       def parse(path, target_ruby_version)
         klass_name = :"Ruby#{target_ruby_version.to_s.sub('.', '')}"
         klass = ::Parser.const_get(klass_name)

data/lib/rubocop/rails/schema_loader/schema.rb

@@ -97,14 +97,12 @@ module RuboCop
           end.compact
         end
 
-        def each_content(node)
+        def each_content(node, &block)
           return enum_for(__method__, node) unless block_given?
 
           case node.body&.type
           when :begin
-            node.body.children.each do |child|
-              yield(child)
-            end
+            node.body.children.each(&block)
           else
             yield(node.body)
           end
@@ -178,6 +176,8 @@ module RuboCop
         attr_reader :table_name
 
         def initialize(node)
+          super(node)
+
           @table_name = node.first_argument.value
           @columns, @expression = build_columns_or_expr(node.arguments[1])
           @unique = nil

data/lib/rubocop/rails/version.rb

@@ -4,7 +4,7 @@ module RuboCop
   module Rails
     # This module holds the RuboCop Rails version information.
     module Version
-      STRING = '2.5.1'
+      STRING = '2.8.0'
     end
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rubocop-rails
 version: !ruby/object:Gem::Version
-  version: 2.5.1
+  version: 2.8.0
 platform: ruby
 authors:
 - Bozhidar Batsov
@@ -10,7 +10,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-04-02 00:00:00.000000000 Z
+date: 2020-09-04 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -18,14 +18,14 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 4.2.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 4.2.0
 - !ruby/object:Gem::Dependency
   name: rack
   requirement: !ruby/object:Gem::Requirement
@@ -46,14 +46,14 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 0.72.0
+        version: 0.87.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 0.72.0
+        version: 0.87.0
 description: |
   Automatic Rails code style checking tool.
   A RuboCop extension focused on enforcing Rails best practices and coding conventions.
@@ -74,8 +74,10 @@ files:
 - lib/rubocop/cop/mixin/target_rails_version.rb
 - lib/rubocop/cop/rails/action_filter.rb
 - lib/rubocop/cop/rails/active_record_aliases.rb
+- lib/rubocop/cop/rails/active_record_callbacks_order.rb
 - lib/rubocop/cop/rails/active_record_override.rb
 - lib/rubocop/cop/rails/active_support_aliases.rb
+- lib/rubocop/cop/rails/after_commit_override.rb
 - lib/rubocop/cop/rails/application_controller.rb
 - lib/rubocop/cop/rails/application_job.rb
 - lib/rubocop/cop/rails/application_mailer.rb
@@ -84,8 +86,10 @@ files:
 - lib/rubocop/cop/rails/belongs_to.rb
 - lib/rubocop/cop/rails/blank.rb
 - lib/rubocop/cop/rails/bulk_change_table.rb
+- lib/rubocop/cop/rails/content_tag.rb
 - lib/rubocop/cop/rails/create_table_with_timestamps.rb
 - lib/rubocop/cop/rails/date.rb
+- lib/rubocop/cop/rails/default_scope.rb
 - lib/rubocop/cop/rails/delegate.rb
 - lib/rubocop/cop/rails/delegate_allow_blank.rb
 - lib/rubocop/cop/rails/dynamic_find_by.rb
@@ -95,6 +99,7 @@ files:
 - lib/rubocop/cop/rails/exit.rb
 - lib/rubocop/cop/rails/file_path.rb
 - lib/rubocop/cop/rails/find_by.rb
+- lib/rubocop/cop/rails/find_by_id.rb
 - lib/rubocop/cop/rails/find_each.rb
 - lib/rubocop/cop/rails/has_and_belongs_to_many.rb
 - lib/rubocop/cop/rails/has_many_or_has_one_dependent.rb
@@ -104,34 +109,50 @@ files:
 - lib/rubocop/cop/rails/ignored_skip_action_filter_option.rb
 - lib/rubocop/cop/rails/index_by.rb
 - lib/rubocop/cop/rails/index_with.rb
+- lib/rubocop/cop/rails/inquiry.rb
 - lib/rubocop/cop/rails/inverse_of.rb
 - lib/rubocop/cop/rails/lexically_scoped_action_filter.rb
 - lib/rubocop/cop/rails/link_to_blank.rb
+- lib/rubocop/cop/rails/mailer_name.rb
+- lib/rubocop/cop/rails/match_route.rb
+- lib/rubocop/cop/rails/negate_include.rb
 - lib/rubocop/cop/rails/not_null_column.rb
+- lib/rubocop/cop/rails/order_by_id.rb
 - lib/rubocop/cop/rails/output.rb
 - lib/rubocop/cop/rails/output_safety.rb
+- lib/rubocop/cop/rails/pick.rb
+- lib/rubocop/cop/rails/pluck.rb
+- lib/rubocop/cop/rails/pluck_id.rb
+- lib/rubocop/cop/rails/pluck_in_where.rb
 - lib/rubocop/cop/rails/pluralization_grammar.rb
 - lib/rubocop/cop/rails/presence.rb
 - lib/rubocop/cop/rails/present.rb
 - lib/rubocop/cop/rails/rake_environment.rb
 - lib/rubocop/cop/rails/read_write_attribute.rb
 - lib/rubocop/cop/rails/redundant_allow_nil.rb
+- lib/rubocop/cop/rails/redundant_foreign_key.rb
 - lib/rubocop/cop/rails/redundant_receiver_in_with_options.rb
 - lib/rubocop/cop/rails/reflection_class_name.rb
 - lib/rubocop/cop/rails/refute_methods.rb
 - lib/rubocop/cop/rails/relative_date_constant.rb
+- lib/rubocop/cop/rails/render_inline.rb
+- lib/rubocop/cop/rails/render_plain_text.rb
 - lib/rubocop/cop/rails/request_referer.rb
 - lib/rubocop/cop/rails/reversible_migration.rb
 - lib/rubocop/cop/rails/safe_navigation.rb
 - lib/rubocop/cop/rails/safe_navigation_with_blank.rb
 - lib/rubocop/cop/rails/save_bang.rb
 - lib/rubocop/cop/rails/scope_args.rb
+- lib/rubocop/cop/rails/short_i18n.rb
 - lib/rubocop/cop/rails/skips_model_validations.rb
+- lib/rubocop/cop/rails/squished_sql_heredocs.rb
 - lib/rubocop/cop/rails/time_zone.rb
 - lib/rubocop/cop/rails/uniq_before_pluck.rb
 - lib/rubocop/cop/rails/unique_validation_without_index.rb
 - lib/rubocop/cop/rails/unknown_env.rb
 - lib/rubocop/cop/rails/validation.rb
+- lib/rubocop/cop/rails/where_exists.rb
+- lib/rubocop/cop/rails/where_not.rb
 - lib/rubocop/cop/rails_cops.rb
 - lib/rubocop/rails.rb
 - lib/rubocop/rails/inject.rb
@@ -142,10 +163,10 @@ homepage: https://github.com/rubocop-hq/rubocop-rails
 licenses:
 - MIT
 metadata:
-  homepage_uri: https://docs.rubocop.org/projects/rails/
+  homepage_uri: https://docs.rubocop.org/rubocop-rails/
   changelog_uri: https://github.com/rubocop-hq/rubocop-rails/blob/master/CHANGELOG.md
   source_code_uri: https://github.com/rubocop-hq/rubocop-rails/
-  documentation_uri: https://docs.rubocop.org/projects/rails/
+  documentation_uri: https://docs.rubocop.org/rubocop-rails/
   bug_tracker_uri: https://github.com/rubocop-hq/rubocop-rails/issues
 post_install_message: 
 rdoc_options: []
@@ -155,14 +176,14 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: 2.3.0
+      version: 2.4.0
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.1.2
+rubygems_version: 3.1.4
 signing_key: 
 specification_version: 4
 summary: Automatic Rails code style checking tool.