rubocop-rails 2.35.1 → 2.35.2
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- checksums.yaml +4 -4
- data/lib/rubocop/cop/rails/strong_parameters_expect.rb +21 -9
- data/lib/rubocop/rails/version.rb +1 -1
- metadata +1 -1
checksums.yaml
CHANGED
|
@@ -1,7 +1,7 @@
|
|
|
1
1
|
---
|
|
2
2
|
SHA256:
|
|
3
|
-
metadata.gz:
|
|
4
|
-
data.tar.gz:
|
|
3
|
+
metadata.gz: e7ef7ef7c6866ef07a53db5870b5a0aa169656ad1235015a6ab1c9eeef58e5ad
|
|
4
|
+
data.tar.gz: 533c4f378c36a4da9e9bbe402884a6137a3150807785ec586907366307591aee
|
|
5
5
|
SHA512:
|
|
6
|
-
metadata.gz:
|
|
7
|
-
data.tar.gz:
|
|
6
|
+
metadata.gz: 577e541755bd86dedfe380196f3526db764b350aad31b4503da926216b67643260507375ec7e8270cc1a8652a8a1c2742b0439275c732b93680512d8e2a39d08
|
|
7
|
+
data.tar.gz: e414a5bf1b501de2af27979b5cb346bbc8ad5105a74e455c7409fcd7463974cbcba97c0bbe2b1bfb99a598e3a8741a7f92dba27f1bd7c5cc4f4b799a19476aa5
|
|
@@ -9,7 +9,9 @@ module RuboCop
|
|
|
9
9
|
# and the cop detects it using the `expect` method.
|
|
10
10
|
#
|
|
11
11
|
# - Method calls on `params[:key]` without comparison methods, methods that are safe to call
|
|
12
|
-
# on `nil` (such as `to_i`, `to_s`, or `is_a?`),
|
|
12
|
+
# on `nil` (such as `to_i`, `to_s`, or `is_a?`), key-check methods such as `key?`,
|
|
13
|
+
# collection methods such as `keys`, `merge`, or `slice`, or block-style calls such as
|
|
14
|
+
# `params[:key].each { ... }` or `params[:key].map(&:to_s)`
|
|
13
15
|
# - Passing `params[:key]` as an argument to finder methods that raise on missing records
|
|
14
16
|
# - Strong parameter methods using `require` or `permit`
|
|
15
17
|
#
|
|
@@ -54,9 +56,18 @@ module RuboCop
|
|
|
54
56
|
|
|
55
57
|
MSG = 'Use `%<prefer>s` instead.'
|
|
56
58
|
RESTRICT_ON_SEND = %i[[] require permit].freeze
|
|
57
|
-
|
|
58
|
-
|
|
59
|
-
|
|
59
|
+
# Method calls on `params[:key]` that should not be rewritten with `expect(:key)`.
|
|
60
|
+
# Covers presence/nil checks, nil-safe conversions and type checks, key-check methods,
|
|
61
|
+
# and collection methods that imply `params[:key]` is a Hash/Array.
|
|
62
|
+
IGNORED_METHODS = %i[
|
|
63
|
+
blank? compact compact! compact_blank compact_blank! deep_merge deep_merge!
|
|
64
|
+
delete delete_if dig each except exclude? extract! fetch has_key? has_value?
|
|
65
|
+
include? instance_of? is_a? keep_if key? keys kind_of? member? merge merge!
|
|
66
|
+
nil? presence present? reverse_merge reverse_merge! slice stringify_keys
|
|
67
|
+
to_a to_f to_h to_hash to_i to_s to_unsafe_h to_unsafe_hash
|
|
68
|
+
transform_keys transform_keys! transform_values transform_values! try try!
|
|
69
|
+
value? values values_at with_defaults with_defaults! without
|
|
70
|
+
].freeze
|
|
60
71
|
RAISING_FINDER_METHODS = %i[find find_by! find_sole_by].freeze
|
|
61
72
|
|
|
62
73
|
minimum_target_rails_version 8.0
|
|
@@ -135,12 +146,9 @@ module RuboCop
|
|
|
135
146
|
|
|
136
147
|
if parent.receiver == node
|
|
137
148
|
return false if parent.comparison_method? || parent.method?(:[])
|
|
149
|
+
return false if block_call?(parent)
|
|
138
150
|
|
|
139
|
-
|
|
140
|
-
|
|
141
|
-
!PRESENCE_CHECK_METHODS.include?(method_name) &&
|
|
142
|
-
!NIL_SAFE_METHODS.include?(method_name) &&
|
|
143
|
-
!KEY_CHECK_METHODS.include?(method_name)
|
|
151
|
+
!IGNORED_METHODS.include?(parent.method_name)
|
|
144
152
|
else
|
|
145
153
|
raising_finder_method?(parent)
|
|
146
154
|
end
|
|
@@ -151,6 +159,10 @@ module RuboCop
|
|
|
151
159
|
RAISING_FINDER_METHODS.include?(node.method_name)
|
|
152
160
|
end
|
|
153
161
|
|
|
162
|
+
def block_call?(send_node)
|
|
163
|
+
send_node.block_literal? || send_node.last_argument&.block_pass_type?
|
|
164
|
+
end
|
|
165
|
+
|
|
154
166
|
def offense_range(method_node, node)
|
|
155
167
|
method_node.loc.selector.join(node.source_range.end)
|
|
156
168
|
end
|