rubocop-rails 2.33.3 → 2.33.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 1dd62ec2504a075e89e8933ab9a8ecc63061d04c75f604d661d21a87b264cdee
-  data.tar.gz: a47a5b0e0d1e2f94b4f5a2976875ce86eb19c2c9fed53a1767ce5c59666d819e
+  metadata.gz: ddb8c79abf97afc451393bd9a309ac575a99057e1143d4e4632fa84568173e8b
+  data.tar.gz: b6cf48b796104788e4d2302f379328071dc5b5042f3cd6923eb625a3ec19128d
 SHA512:
-  metadata.gz: 5c48f2805329e13493881423a0de8549a7e3d3cfacc99be40b5a9dbd36b4a6c3d376845c5b0bcf3b492023835e8b3f5062d291c8ebe87165d82f96a77dbbc102
-  data.tar.gz: b30b183e23a29af49d9a6709d27318d79d4ff24246ba1b21ac8ae14260acbb64fd46ec54661f3d18867ffb331f71d794a33e5b760545b0743645ce902cac1daf
+  metadata.gz: 2618f426daf94c51e8fceb989eca50055dae465b334a5ef83d5dc940959a123e1f3a2337246db86defd3f189970a1848a207b5b6b8afcf9917149877bd3fee3e
+  data.tar.gz: 164f84eeab842a88a39131e8c8949584487ac22893604de862ecc28cd984d6df2e5e244ab82e57295dbe9abba0c71830c018412325eccaa3a6ff376f3517ecfc

data/lib/rubocop/cop/rails/action_controller_flash_before_render.rb

@@ -73,7 +73,7 @@ module RuboCop
             return false if use_redirect_to?(context)
 
             context = node
-          elsif context.right_siblings.empty?
+          elsif context.right_siblings.empty? && !use_redirect_to?(context.parent)
             return true
           end
           context = context.right_siblings

data/lib/rubocop/cop/rails/find_by.rb

@@ -46,7 +46,7 @@ module RuboCop
         private
 
         def where_method?(receiver)
-          return false unless receiver
+          return false if !receiver || receiver.any_block_type?
 
           receiver.respond_to?(:method?) && receiver.method?(:where)
         end

data/lib/rubocop/cop/rails/find_by_or_assignment_memoization.rb

@@ -62,10 +62,12 @@ module RuboCop
                 node.body,
                 <<~RUBY.rstrip
                   return #{varible_name} if defined?(#{varible_name})
-                  
+
                   #{varible_name} = #{find_by.source}
                 RUBY
               )
+
+              correct_to_regular_method_definition(corrector, node) if node.endless?
             end
           end
         end
@@ -89,6 +91,15 @@ module RuboCop
             end
           end
         end
+
+        private
+
+        def correct_to_regular_method_definition(corrector, node)
+          range = node.loc.assignment.join(node.body.source_range.begin)
+
+          corrector.replace(range, "\n")
+          corrector.insert_after(node, "\nend")
+        end
       end
     end
   end

data/lib/rubocop/rails/version.rb

@@ -4,7 +4,7 @@ module RuboCop
   module Rails
     # This module holds the RuboCop Rails version information.
     module Version
-      STRING = '2.33.3'
+      STRING = '2.33.4'
 
       def self.document_version
         STRING.match('\d+\.\d+').to_s

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rubocop-rails
 version: !ruby/object:Gem::Version
-  version: 2.33.3
+  version: 2.33.4
 platform: ruby
 authors:
 - Bozhidar Batsov