rubocop-rails 2.22.0 → 2.22.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 04c91e90b833ac948b90250b28d11aa4800aae35a8b30a6e70f80f21b69f6f3b
-  data.tar.gz: ff6f1a9257f9bb1e1a49e7ff099de9ae138cea69ae3b50c02cccad5872d2040a
+  metadata.gz: 54ac592e4d6ccfd065a9f61d33b9305f0a54cc879af4963b7a0a5f13e34ef5f7
+  data.tar.gz: e7d9a2dc53b76a3b8308b4cb1c2023f1a18d133efd7e14ad0efd43733cb5ffe1
 SHA512:
-  metadata.gz: f4033f539ef9bf1282b0ac5a81d026c683dd618f7a367b59e03117be1092a790f4df71a26b304ea4399c484d9a0c2af31987d8d9f793b822f570ab24df614477
-  data.tar.gz: 0aec6e0248f966e706460fa9796831d2617f04b371a1d37531e9dd52938278e59802b804d7320aec7bfd3677cfe01f55600cb4a5fd07c3c2e4ff68542e2a78fa
+  metadata.gz: e5b230f2623f63afcdba2fd1fd5dc415538e47ab283bc78c40715c3e6d10c8b8af92bd3597c87aa7105aded11dde0ec66e79f857675e57ebff7a3455e59a102e
+  data.tar.gz: 27092e6dc744ce084d4b1eb8eb85c339bc389de861ab6f82cb2956a550921500d4eb012dc74ff702315c6a39dde7b71b7a43ebec70bd8834ba9314365c45b8ea

data/README.md

@@ -82,7 +82,7 @@ module YourCoolApp
 end
 ```
 
-It uses `rubocop -A` to apply `Style/FrozenStringLiteralComment` and other unsafe autocorretion cops.
+It uses `rubocop -A` to apply `Style/FrozenStringLiteralComment` and other unsafe autocorrection cops.
 `rubocop -A` is unsafe autocorrection, but code generated by default is simple and less likely to
 be incompatible with `rubocop -A`. If you have problems you can replace it with `rubocop -a` instead.
 

data/lib/rubocop/cop/rails/action_filter.rb

@@ -9,7 +9,7 @@ module RuboCop
       # something_filter methods or the newer something_action methods.
       #
       # IMPORTANT: This cop is deprecated. Because the `*_filter` methods were removed in Rails 4.2,
-      # and that Rals version is no longer supported by RuboCop Rails. This cop will be removed in RuboCop Rails 3.0.
+      # and that Rails version is no longer supported by RuboCop Rails. This cop will be removed in RuboCop Rails 3.0.
       #
       # @example EnforcedStyle: action (default)
       #   # bad

data/lib/rubocop/cop/rails/active_record_aliases.rb

@@ -11,10 +11,10 @@ module RuboCop
       #   `update` but the method name remained same in the method definition.
       #
       # @example
-      #   #bad
+      #   # bad
       #   book.update_attributes!(author: 'Alice')
       #
-      #   #good
+      #   # good
       #   book.update!(author: 'Alice')
       class ActiveRecordAliases < Base
         extend AutoCorrector

data/lib/rubocop/cop/rails/after_commit_override.rb

@@ -48,7 +48,7 @@ module RuboCop
           seen_callback_names = {}
 
           each_after_commit_callback(class_node) do |node|
-            callback_name = node.arguments[0].value
+            callback_name = node.first_argument.value
             if seen_callback_names.key?(callback_name)
               add_offense(node, message: format(MSG, name: callback_name))
             else

data/lib/rubocop/cop/rails/bulk_change_table.rb

@@ -212,7 +212,7 @@ module RuboCop
         # @param node [RuboCop::AST::SendNode]
         def add_offense_for_alter_methods(node)
           # arguments: [{(sym :table)(str "table")} ...]
-          table_node = node.arguments[0]
+          table_node = node.first_argument
           return unless table_node.is_a? RuboCop::AST::BasicLiteralNode
 
           message = format(MSG_FOR_ALTER_METHODS, table: table_node.value)
@@ -234,10 +234,10 @@ module RuboCop
           # @param new_node [RuboCop::AST::SendNode]
           def process(new_node)
             # arguments: [{(sym :table)(str "table")} ...]
-            table_node = new_node.arguments[0]
+            table_node = new_node.first_argument
             if table_node.is_a? RuboCop::AST::BasicLiteralNode
               flush unless @nodes.all? do |node|
-                node.arguments[0].value.to_s == table_node.value.to_s
+                node.first_argument.value.to_s == table_node.value.to_s
               end
               @nodes << new_node
             else

data/lib/rubocop/cop/rails/dangerous_column_names.rb

@@ -428,7 +428,7 @@ module RuboCop
           when :rename_column
             node.arguments[2]
           when *COLUMN_TYPE_METHOD_NAMES
-            node.arguments[0]
+            node.first_argument
           end
         end
 

data/lib/rubocop/cop/rails/duplicate_association.rb

@@ -21,12 +21,12 @@ module RuboCop
       #   has_one :foo
       #
       #   # bad
-      #   belongs_to :foo, class_name: 'Foo'
-      #   belongs_to :bar, class_name: 'Foo'
+      #   has_many :foo, class_name: 'Foo'
+      #   has_many :bar, class_name: 'Foo'
       #   has_one :baz
       #
       #   # good
-      #   belongs_to :bar, class_name: 'Foo'
+      #   has_many :bar, class_name: 'Foo'
       #   has_one :foo
       #
       class DuplicateAssociation < Base
@@ -87,7 +87,8 @@ module RuboCop
         end
 
         def duplicated_class_name_nodes(association_nodes)
-          grouped_associations = association_nodes.group_by do |node|
+          filtered_nodes = association_nodes.reject { |node| node.method?(:belongs_to) }
+          grouped_associations = filtered_nodes.group_by do |node|
             arguments = association(node).last
             next unless arguments.count == 1
 

data/lib/rubocop/cop/rails/eager_evaluation_log_message.rb

@@ -14,10 +14,10 @@ module RuboCop
       # when no output would be produced anyway.
       #
       # @example
-      #   #bad
+      #   # bad
       #   Rails.logger.debug "The time is #{Time.zone.now}."
       #
-      #   #good
+      #   # good
       #   Rails.logger.debug { "The time is #{Time.zone.now}." }
       #
       class EagerEvaluationLogMessage < Base

data/lib/rubocop/cop/rails/file_path.rb

@@ -163,9 +163,9 @@ module RuboCop
 
         def autocorrect_extension_after_rails_root_join_in_dstr(corrector, node, rails_root_index, extension_node)
           rails_root_node = node.children[rails_root_index].children.first
-          return unless rails_root_node.arguments.last.str_type?
+          return unless rails_root_node.last_argument.str_type?
 
-          corrector.insert_before(rails_root_node.arguments.last.location.end, extension_node.source)
+          corrector.insert_before(rails_root_node.last_argument.location.end, extension_node.source)
           corrector.remove(extension_node)
         end
 
@@ -174,7 +174,7 @@ module RuboCop
           corrector.remove(
             range_with_surrounding_space(
               range_with_surrounding_comma(
-                node.arguments.first.source_range,
+                node.first_argument.source_range,
                 :right
               ),
               side: :right
@@ -187,7 +187,7 @@ module RuboCop
         end
 
         def autocorrect_rails_root_join_with_string_arguments(corrector, node)
-          corrector.replace(node.arguments.first, %("#{node.arguments.map(&:value).join('/')}"))
+          corrector.replace(node.first_argument, %("#{node.arguments.map(&:value).join('/')}"))
           node.arguments[1..].each do |argument|
             corrector.remove(
               range_with_surrounding_comma(
@@ -221,7 +221,7 @@ module RuboCop
         end
 
         def append_argument(corrector, node, argument_source)
-          corrector.insert_after(node.arguments.last, %(, "#{argument_source}"))
+          corrector.insert_after(node.last_argument, %(, "#{argument_source}"))
         end
 
         def replace_with_rails_root_join(corrector, node, argument_source)

data/lib/rubocop/cop/rails/inverse_of.rb

@@ -222,7 +222,7 @@ module RuboCop
 
         def with_options_arguments(recv, node)
           blocks = node.each_ancestor(:block).select do |block|
-            block.send_node.command?(:with_options) && same_context_in_with_options?(block.arguments.first, recv)
+            block.send_node.command?(:with_options) && same_context_in_with_options?(block.first_argument, recv)
           end
           blocks.flat_map { |n| n.send_node.arguments }
         end

data/lib/rubocop/cop/rails/rake_environment.rb

@@ -72,7 +72,7 @@ module RuboCop
         end
 
         def task_name(node)
-          first_arg = node.arguments[0]
+          first_arg = node.first_argument
           case first_arg&.type
           when :sym, :str
             first_arg.value.to_sym
@@ -97,7 +97,7 @@ module RuboCop
         end
 
         def with_dependencies?(node)
-          first_arg = node.arguments[0]
+          first_arg = node.first_argument
           return false unless first_arg
 
           if first_arg.hash_type?

data/lib/rubocop/cop/rails/redundant_active_record_all_method.rb

@@ -3,8 +3,44 @@
 module RuboCop
   module Cop
     module Rails
+      # TODO: In the future, please support only RuboCop 1.52+ and use `RuboCop::Cop::AllowedReceivers`:
+      #       https://github.com/rubocop/rubocop/blob/v1.52.0/lib/rubocop/cop/mixin/allowed_receivers.rb
+      #       At that time, this duplicated module implementation can be removed.
+      module AllowedReceivers
+        def allowed_receiver?(receiver)
+          receiver_name = receiver_name(receiver)
+
+          allowed_receivers.include?(receiver_name)
+        end
+
+        def receiver_name(receiver)
+          return receiver_name(receiver.receiver) if receiver.receiver && !receiver.receiver.const_type?
+
+          if receiver.send_type?
+            if receiver.receiver
+              "#{receiver_name(receiver.receiver)}.#{receiver.method_name}"
+            else
+              receiver.method_name.to_s
+            end
+          else
+            receiver.source
+          end
+        end
+
+        def allowed_receivers
+          cop_config.fetch('AllowedReceivers', [])
+        end
+      end
+
       # Detect redundant `all` used as a receiver for Active Record query methods.
       #
+      # NOTE: For the methods `delete_all` and `destroy_all`,
+      # this cop will only check cases where the receiver is a model.
+      # It will ignore cases where the receiver is an association (e.g., `user.articles.all.delete_all`).
+      # This is because omitting `all` from an association changes the methods
+      # from `ActiveRecord::Relation` to `ActiveRecord::Associations::CollectionProxy`,
+      # which can affect their behavior.
+      #
       # @safety
       #   This cop is unsafe for autocorrection if the receiver for `all` is not an Active Record object.
       #
@@ -144,13 +180,15 @@ module RuboCop
         ].to_set.freeze
 
         POSSIBLE_ENUMERABLE_BLOCK_METHODS = %i[any? count find none? one? select sum].freeze
+        SENSITIVE_METHODS_ON_ASSOCIATION = %i[delete_all destroy_all].freeze
 
         def_node_matcher :followed_by_query_method?, <<~PATTERN
           (send (send _ :all) QUERYING_METHODS ...)
         PATTERN
 
         def on_send(node)
-          return if !followed_by_query_method?(node.parent) || possible_enumerable_block_method?(node)
+          return unless followed_by_query_method?(node.parent)
+          return if possible_enumerable_block_method?(node) || sensitive_association_method?(node)
           return if node.receiver ? allowed_receiver?(node.receiver) : !inherit_active_record_base?(node)
 
           range_of_all_method = offense_range(node)
@@ -169,37 +207,12 @@ module RuboCop
           parent.parent&.block_type? || parent.parent&.numblock_type? || parent.first_argument&.block_pass_type?
         end
 
-        def offense_range(node)
-          range_between(node.loc.selector.begin_pos, node.source_range.end_pos)
+        def sensitive_association_method?(node)
+          !node.receiver&.const_type? && SENSITIVE_METHODS_ON_ASSOCIATION.include?(node.parent.method_name)
         end
 
-        # TODO: In the future, please support only RuboCop 1.52+ and use `RuboCop::Cop::AllowedReceivers`:
-        #       https://github.com/rubocop/rubocop/blob/v1.52.0/lib/rubocop/cop/mixin/allowed_receivers.rb
-        #       At that time, this duplicated module implementation can be removed.
-        module AllowedReceivers
-          def allowed_receiver?(receiver)
-            receiver_name = receiver_name(receiver)
-
-            allowed_receivers.include?(receiver_name)
-          end
-
-          def receiver_name(receiver)
-            return receiver_name(receiver.receiver) if receiver.receiver && !receiver.receiver.const_type?
-
-            if receiver.send_type?
-              if receiver.receiver
-                "#{receiver_name(receiver.receiver)}.#{receiver.method_name}"
-              else
-                receiver.method_name.to_s
-              end
-            else
-              receiver.source
-            end
-          end
-
-          def allowed_receivers
-            cop_config.fetch('AllowedReceivers', [])
-          end
+        def offense_range(node)
+          range_between(node.loc.selector.begin_pos, node.source_range.end_pos)
         end
       end
     end

data/lib/rubocop/cop/rails/redundant_receiver_in_with_options.rb

@@ -100,7 +100,7 @@ module RuboCop
                  else
                    return false if node.arguments.empty?
 
-                   arg = node.arguments.first
+                   arg = node.first_argument
                    ->(n) { same_value?(arg, n.receiver) }
                  end
 

data/lib/rubocop/cop/rails/reversible_migration.rb

@@ -290,10 +290,10 @@ module RuboCop
           when :change
             false
           when :remove
-            target_rails_version >= 6.1 && all_hash_key?(node.arguments.last, :type)
+            target_rails_version >= 6.1 && all_hash_key?(node.last_argument, :type)
           when :change_default, :change_column_default, :change_table_comment,
                :change_column_comment
-            all_hash_key?(node.arguments.last, :from, :to)
+            all_hash_key?(node.last_argument, :from, :to)
           else
             true
           end

data/lib/rubocop/cop/rails/save_bang.rb

@@ -336,10 +336,10 @@ module RuboCop
 
         # Check argument signature as no arguments or one hash
         def expected_signature?(node)
-          !node.arguments? ||
-            (node.arguments.one? &&
-              node.method_name != :destroy &&
-              (node.first_argument.hash_type? || !node.first_argument.literal?))
+          return true unless node.arguments?
+          return false if !node.arguments.one? || node.method?(:destroy)
+
+          node.first_argument.hash_type? || !node.first_argument.literal?
         end
       end
     end

data/lib/rubocop/cop/rails/unique_validation_without_index.rb

@@ -124,7 +124,7 @@ module RuboCop
         end
 
         def uniqueness_part(node)
-          pairs = node.arguments.last
+          pairs = node.last_argument
           return unless pairs&.hash_type?
 
           pairs.each_pair.find do |pair|

data/lib/rubocop/cop/rails/unknown_env.rb

@@ -87,9 +87,9 @@ module RuboCop
 
         def environments
           @environments ||= begin
-            e = cop_config['Environments']
-            e += ['local'] if target_rails_version >= 7.1
-            e
+            environments = cop_config['Environments'] || []
+            environments << 'local' if target_rails_version >= 7.1
+            environments
           end
         end
       end

data/lib/rubocop/cop/rails/validation.rb

@@ -60,7 +60,7 @@ module RuboCop
           range = node.loc.selector
 
           add_offense(range, message: message(node)) do |corrector|
-            last_argument = node.arguments.last
+            last_argument = node.last_argument
             return if !last_argument.literal? && !last_argument.splat_type? && !frozen_array_argument?(last_argument)
 
             corrector.replace(range, 'validates')

data/lib/rubocop/rails/schema_loader/schema.rb

@@ -127,7 +127,7 @@ module RuboCop
         private
 
         def analyze_keywords!(node)
-          pairs = node.arguments.last
+          pairs = node.last_argument
           return unless pairs.hash_type?
 
           pairs.each_pair do |k, v|
@@ -158,7 +158,7 @@ module RuboCop
         end
 
         def analyze_keywords!(node)
-          pairs = node.arguments.last
+          pairs = node.last_argument
           return unless pairs.hash_type?
 
           pairs.each_pair do |k, v|

data/lib/rubocop/rails/version.rb

@@ -4,7 +4,7 @@ module RuboCop
   module Rails
     # This module holds the RuboCop Rails version information.
     module Version
-      STRING = '2.22.0'
+      STRING = '2.22.2'
 
       def self.document_version
         STRING.match('\d+\.\d+').to_s

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rubocop-rails
 version: !ruby/object:Gem::Version
-  version: 2.22.0
+  version: 2.22.2
 platform: ruby
 authors:
 - Bozhidar Batsov
@@ -10,7 +10,7 @@ authors:
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2023-10-27 00:00:00.000000000 Z
+date: 2023-11-19 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -60,6 +60,26 @@ dependencies:
     - - "<"
       - !ruby/object:Gem::Version
         version: '2.0'
+- !ruby/object:Gem::Dependency
+  name: rubocop-ast
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 1.30.0
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: '2.0'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 1.30.0
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: '2.0'
 description: |
   Automatic Rails code style checking tool.
   A RuboCop extension focused on enforcing Rails best practices and coding conventions.