rubocop-rails 2.21.1 → 2.22.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 15c354794d638a6c49b01b74961ea1d55f5541f3a8b653ef68d9a824e042a100
-  data.tar.gz: 3a04d9449daac9515b0be93d1394b1aa260748ab6bc57517cf3b90217f58ec88
+  metadata.gz: 04c91e90b833ac948b90250b28d11aa4800aae35a8b30a6e70f80f21b69f6f3b
+  data.tar.gz: ff6f1a9257f9bb1e1a49e7ff099de9ae138cea69ae3b50c02cccad5872d2040a
 SHA512:
-  metadata.gz: '01167387c8fcee795769724ded84c4eaa373e2d2d936e8a2b0afd5f4bcb239aafd299b1c302d5a029b7ae72f2990290f2f6de1d317d1cb163f707d5f0ee91635'
-  data.tar.gz: 61d8f93f138aceb3c8e7a8ef03604d5de870b8328e452d34c03f77612681e9846ac7a4f0ed127a48806bb2bfad055e6ccebe9d3393e82e0f4e01ea88a1d870a6
+  metadata.gz: f4033f539ef9bf1282b0ac5a81d026c683dd618f7a367b59e03117be1092a790f4df71a26b304ea4399c484d9a0c2af31987d8d9f793b822f570ab24df614477
+  data.tar.gz: 0aec6e0248f966e706460fa9796831d2617f04b371a1d37531e9dd52938278e59802b804d7320aec7bfd3677cfe01f55600cb4a5fd07c3c2e4ff68542e2a78fa

data/README.md

@@ -56,6 +56,8 @@ Note: `--rails` option is required while `rubocop` command supports `--rails` op
 ### Rake task
 
 ```ruby
+require 'rubocop/rake_task'
+
 RuboCop::RakeTask.new do |task|
   task.requires << 'rubocop-rails'
 end
@@ -72,7 +74,9 @@ module YourCoolApp
   class Application < Rails::Application
     config.generators.after_generate do |files|
       parsable_files = files.filter { |file| file.end_with?('.rb') }
-      system("bundle exec rubocop -A --fail-level=E #{parsable_files.shelljoin}", exception: true)
+      unless parsable_files.empty?
+        system("bundle exec rubocop -A --fail-level=E #{parsable_files.shelljoin}", exception: true)
+      end
     end
   end
 end

data/config/default.yml

@@ -95,8 +95,9 @@ Rails/ActionControllerTestCase:
 
 Rails/ActionFilter:
   Description: 'Enforces consistent use of action filter methods.'
-  Enabled: true
+  Enabled: false
   VersionAdded: '0.19'
+  VersionChanged: '2.22'
   EnforcedStyle: action
   SupportedStyles:
     - action
@@ -338,7 +339,6 @@ Rails/Date:
 
 Rails/DefaultScope:
   Description: 'Avoid use of `default_scope`.'
-  StyleGuide: 'https://rails.rubystyle.guide#avoid-default-scope'
   Enabled: false
   VersionAdded: '2.7'
 
@@ -430,6 +430,11 @@ Rails/EnumUniqueness:
   Include:
     - app/models/**/*.rb
 
+Rails/EnvLocal:
+  Description: 'Use `Rails.env.local?` instead of `Rails.env.development? || Rails.env.test?`.'
+  Enabled: pending
+  VersionAdded: '2.22'
+
 Rails/EnvironmentComparison:
   Description: "Favor `Rails.env.production?` over `Rails.env == 'production'`."
   Enabled: true
@@ -690,6 +695,9 @@ Rails/NotNullColumn:
   Enabled: true
   VersionAdded: '0.43'
   VersionChanged: '2.20'
+  Database: null
+  SupportedDatabases:
+    - mysql
   Include:
     - db/**/*.rb
 
@@ -801,6 +809,9 @@ Rails/RedundantActiveRecordAllMethod:
   StyleGuide: 'https://rails.rubystyle.guide/#redundant-all'
   Enabled: pending
   Safe: false
+  AllowedReceivers:
+    - ActionMailer::Preview
+    - ActiveSupport::TimeZone
   VersionAdded: '2.21'
 
 Rails/RedundantAllowNil:

data/lib/rubocop/cop/mixin/database_type_resolvable.rb

@@ -0,0 +1,66 @@
+# frozen_string_literal: true
+
+module RuboCop
+  module Cop
+    # A mixin to extend cops in order to determine the database type.
+    #
+    # This module automatically detect an adapter from `development` environment
+    # in `config/database.yml` or the environment variable `DATABASE_URL`
+    # when the `Database` option is not set.
+    module DatabaseTypeResolvable
+      MYSQL = 'mysql'
+      POSTGRESQL = 'postgresql'
+
+      def database
+        cop_config['Database'] || database_from_yaml || database_from_env
+      end
+
+      private
+
+      def database_from_yaml
+        return unless database_yaml
+
+        case database_adapter
+        when 'mysql2', 'trilogy'
+          MYSQL
+        when 'postgresql'
+          POSTGRESQL
+        end
+      end
+
+      def database_from_env
+        url = ENV['DATABASE_URL'].presence
+        return unless url
+
+        case url
+        when %r{\A(mysql2|trilogy)://}
+          MYSQL
+        when %r{\Apostgres(ql)?://}
+          POSTGRESQL
+        end
+      end
+
+      def database_yaml
+        return unless File.exist?('config/database.yml')
+
+        yaml = if YAML.respond_to?(:unsafe_load_file)
+                 YAML.unsafe_load_file('config/database.yml')
+               else
+                 YAML.load_file('config/database.yml')
+               end
+        return unless yaml.is_a? Hash
+
+        config = yaml['development']
+        return unless config.is_a?(Hash)
+
+        config
+      rescue Psych::SyntaxError
+        # noop
+      end
+
+      def database_adapter
+        database_yaml['adapter'] || database_yaml.first.last['adapter']
+      end
+    end
+  end
+end

data/lib/rubocop/cop/mixin/index_method.rb

@@ -102,7 +102,7 @@ module RuboCop
       end
 
       # Internal helper class to hold match data
-      Captures = Struct.new(
+      Captures = ::Struct.new(
         :transformed_argname,
         :transforming_body_expr
       ) do
@@ -112,7 +112,7 @@ module RuboCop
       end
 
       # Internal helper class to hold autocorrect data
-      Autocorrection = Struct.new(:match, :block_node, :leading, :trailing) do
+      Autocorrection = ::Struct.new(:match, :block_node, :leading, :trailing) do
         def self.from_each_with_object(node, match)
           new(match, node, 0, 0)
         end

data/lib/rubocop/cop/rails/action_filter.rb

@@ -8,6 +8,9 @@ module RuboCop
       # The cop is configurable and can enforce the use of the older
       # something_filter methods or the newer something_action methods.
       #
+      # IMPORTANT: This cop is deprecated. Because the `*_filter` methods were removed in Rails 4.2,
+      # and that Rals version is no longer supported by RuboCop Rails. This cop will be removed in RuboCop Rails 3.0.
+      #
       # @example EnforcedStyle: action (default)
       #   # bad
       #   after_filter :do_stuff

data/lib/rubocop/cop/rails/bulk_change_table.rb

@@ -14,7 +14,7 @@ module RuboCop
       # automatically detect an adapter from `development` environment
       # in `config/database.yml` or the environment variable `DATABASE_URL`
       # when the `Database` option is not set.
-      # If the adapter is not `mysql2` or `postgresql`,
+      # If the adapter is not `mysql2`, `trilogy`, or `postgresql`,
       # this Cop ignores offenses.
       #
       # @example
@@ -64,6 +64,8 @@ module RuboCop
       #     end
       #   end
       class BulkChangeTable < Base
+        include DatabaseTypeResolvable
+
         MSG_FOR_CHANGE_TABLE = <<~MSG.chomp
           You can combine alter queries using `bulk: true` options.
         MSG
@@ -71,9 +73,6 @@ module RuboCop
           You can use `change_table :%<table>s, bulk: true` to combine alter queries.
         MSG
 
-        MYSQL = 'mysql'
-        POSTGRESQL = 'postgresql'
-
         MIGRATION_METHODS = %i[change up down].freeze
 
         COMBINABLE_TRANSFORMATIONS = %i[
@@ -175,55 +174,6 @@ module RuboCop
           options.hash_type? && options.keys.any? { |key| key.sym_type? && key.value == :bulk }
         end
 
-        def database
-          cop_config['Database'] || database_from_yaml || database_from_env
-        end
-
-        def database_from_yaml
-          return nil unless database_yaml
-
-          case database_adapter
-          when 'mysql2'
-            MYSQL
-          when 'postgresql'
-            POSTGRESQL
-          end
-        end
-
-        def database_adapter
-          database_yaml['adapter'] || database_yaml.first.last['adapter']
-        end
-
-        def database_yaml
-          return nil unless File.exist?('config/database.yml')
-
-          yaml = if YAML.respond_to?(:unsafe_load_file)
-                   YAML.unsafe_load_file('config/database.yml')
-                 else
-                   YAML.load_file('config/database.yml')
-                 end
-          return nil unless yaml.is_a? Hash
-
-          config = yaml['development']
-          return nil unless config.is_a?(Hash)
-
-          config
-        rescue Psych::SyntaxError
-          nil
-        end
-
-        def database_from_env
-          url = ENV['DATABASE_URL'].presence
-          return nil unless url
-
-          case url
-          when %r{\Amysql2://}
-            MYSQL
-          when %r{\Apostgres(ql)?://}
-            POSTGRESQL
-          end
-        end
-
         def support_bulk_alter?
           case database
           when MYSQL

data/lib/rubocop/cop/rails/dangerous_column_names.rb

@@ -31,10 +31,11 @@ module RuboCop
           time
         ].to_set.freeze
 
-        # Generated from `ActiveRecord::AttributeMethods.dangerous_attribute_methods` on activerecord 7.0.5.
+        # Generated from `ActiveRecord::AttributeMethods.dangerous_attribute_methods` on activerecord 7.1.0.
         # rubocop:disable Metrics/CollectionLiteralLength
         DANGEROUS_COLUMN_NAMES = %w[
           __callbacks
+          __id__
           _assign_attribute
           _assign_attributes
           _before_commit_callbacks
@@ -195,11 +196,13 @@ module RuboCop
           changes_to_save
           check_record_limit
           ciphertext_for
+          class
           clear_attribute_change
           clear_attribute_changes
           clear_changes_information
           clear_timestamp_attributes
           clear_transaction_record_state
+          clone
           collection_cache_versioning
           column_for_attribute
           committed
@@ -227,6 +230,7 @@ module RuboCop
           destroyed
           destroyed_by_association
           destroyed_by_association=
+          dup
           each_counter_cached_associations
           encode_with
           encrypt
@@ -243,7 +247,9 @@ module RuboCop
           find_parameter_position
           forget_attribute_assignments
           format_for_inspect
+          freeze
           from_json
+          frozen?
           halted_callback_hook
           has_attribute
           has_changes_to_save
@@ -252,6 +258,7 @@ module RuboCop
           has_encrypted_attributes
           has_encrypted_rich_texts
           has_transactional_callbacks
+          hash
           id
           id_before_type_cast
           id_for_database
@@ -283,6 +290,7 @@ module RuboCop
           new_record
           no_touching
           normalize_reflection_attribute
+          object_id
           partial_inserts
           partial_updates
           perform_validations

data/lib/rubocop/cop/rails/duplicate_association.rb

@@ -20,6 +20,15 @@ module RuboCop
       #   belongs_to :bar
       #   has_one :foo
       #
+      #   # bad
+      #   belongs_to :foo, class_name: 'Foo'
+      #   belongs_to :bar, class_name: 'Foo'
+      #   has_one :baz
+      #
+      #   # good
+      #   belongs_to :bar, class_name: 'Foo'
+      #   has_one :foo
+      #
       class DuplicateAssociation < Base
         include RangeHelp
         extend AutoCorrector
@@ -27,31 +36,75 @@ module RuboCop
         include ActiveRecordHelper
 
         MSG = "Association `%<name>s` is defined multiple times. Don't repeat associations."
+        MSG_CLASS_NAME = "Association `class_name: %<name>s` is defined multiple times. Don't repeat associations."
 
         def_node_matcher :association, <<~PATTERN
-          (send nil? {:belongs_to :has_one :has_many :has_and_belongs_to_many} ({sym str} $_) ...)
+          (send nil? {:belongs_to :has_one :has_many :has_and_belongs_to_many} ({sym str} $_) $...)
+        PATTERN
+
+        def_node_matcher :class_name, <<~PATTERN
+          (hash (pair (sym :class_name) $_))
         PATTERN
 
         def on_class(class_node)
           return unless active_record?(class_node.parent_class)
 
-          offenses(class_node).each do |name, nodes|
-            nodes.each do |node|
-              add_offense(node, message: format(MSG, name: name)) do |corrector|
-                next if same_line?(nodes.last, node)
+          association_nodes = association_nodes(class_node)
 
-                corrector.remove(range_by_whole_lines(node.source_range, include_final_newline: true))
-              end
-            end
+          duplicated_association_name_nodes(association_nodes).each do |name, nodes|
+            register_offense(name, nodes, MSG)
+          end
+
+          duplicated_class_name_nodes(association_nodes).each do |class_name, nodes|
+            register_offense(class_name, nodes, MSG_CLASS_NAME)
           end
         end
 
         private
 
-        def offenses(class_node)
-          class_send_nodes(class_node).select { |node| association(node) }
-                                      .group_by { |node| association(node).to_sym }
-                                      .select { |_, nodes| nodes.length > 1 }
+        def register_offense(name, nodes, message_template)
+          nodes.each do |node|
+            add_offense(node, message: format(message_template, name: name)) do |corrector|
+              next if same_line?(nodes.last, node)
+
+              corrector.remove(range_by_whole_lines(node.source_range, include_final_newline: true))
+            end
+          end
+        end
+
+        def association_nodes(class_node)
+          class_send_nodes(class_node).select do |node|
+            association(node)&.first
+          end
+        end
+
+        def duplicated_association_name_nodes(association_nodes)
+          grouped_associations = association_nodes.group_by do |node|
+            association(node).first.to_sym
+          end
+
+          leave_duplicated_association(grouped_associations)
+        end
+
+        def duplicated_class_name_nodes(association_nodes)
+          grouped_associations = association_nodes.group_by do |node|
+            arguments = association(node).last
+            next unless arguments.count == 1
+
+            if (class_name = class_name(arguments.first))
+              class_name.source
+            end
+          end
+
+          grouped_associations.delete(nil)
+
+          leave_duplicated_association(grouped_associations)
+        end
+
+        def leave_duplicated_association(grouped_associations)
+          grouped_associations.select do |_, nodes|
+            nodes.length > 1
+          end
         end
       end
     end

data/lib/rubocop/cop/rails/env_local.rb

@@ -0,0 +1,46 @@
+# frozen_string_literal: true
+
+module RuboCop
+  module Cop
+    module Rails
+      # Checks for usage of `Rails.env.development? || Rails.env.test?` which
+      # can be replaced with `Rails.env.local?`, introduced in Rails 7.1.
+      #
+      # @example
+      #
+      #   # bad
+      #   Rails.env.development? || Rails.env.test?
+      #
+      #   # good
+      #   Rails.env.local?
+      #
+      class EnvLocal < Base
+        extend AutoCorrector
+        extend TargetRailsVersion
+
+        MSG = 'Use `Rails.env.local?` instead.'
+        LOCAL_ENVIRONMENTS = %i[development? test?].to_set.freeze
+
+        minimum_target_rails_version 7.1
+
+        # @!method rails_env_local_candidate?(node)
+        def_node_matcher :rails_env_local_candidate?, <<~PATTERN
+          (or
+            (send (send (const {cbase nil? } :Rails) :env) $%LOCAL_ENVIRONMENTS)
+            (send (send (const {cbase nil? } :Rails) :env) $%LOCAL_ENVIRONMENTS)
+          )
+        PATTERN
+
+        def on_or(node)
+          rails_env_local_candidate?(node) do |*environments|
+            next unless environments.to_set == LOCAL_ENVIRONMENTS
+
+            add_offense(node) do |corrector|
+              corrector.replace(node, 'Rails.env.local?')
+            end
+          end
+        end
+      end
+    end
+  end
+end

data/lib/rubocop/cop/rails/has_many_or_has_one_dependent.rb

@@ -60,7 +60,7 @@ module RuboCop
           (block
             (send nil? :with_options
               (hash $...))
-            (args) ...)
+            (args _?) ...)
         PATTERN
 
         def_node_matcher :association_extension_block?, <<~PATTERN

data/lib/rubocop/cop/rails/helper_instance_variable.rb

@@ -6,7 +6,7 @@ module RuboCop
       # Checks for use of the helper methods which reference
       # instance variables.
       #
-      # Relying on instance variables makes it difficult to re-use helper
+      # Relying on instance variables makes it difficult to reuse helper
       # methods.
       #
       # If it seems awkward to explicitly pass in each dependent

data/lib/rubocop/cop/rails/not_null_column.rb

@@ -3,8 +3,13 @@
 module RuboCop
   module Cop
     module Rails
-      # Checks for add_column call with NOT NULL constraint
-      # in migration file.
+      # Checks for add_column call with NOT NULL constraint in migration file.
+      #
+      # `TEXT` can have default values in PostgreSQL, but not in MySQL.
+      # It will automatically detect an adapter from `development` environment
+      # in `config/database.yml` or the environment variable `DATABASE_URL`
+      # when the `Database` option is not set. If the database is MySQL,
+      # this cop ignores offenses for the `TEXT`.
       #
       # @example
       #   # bad
@@ -17,6 +22,8 @@ module RuboCop
       #   add_reference :products, :category
       #   add_reference :products, :category, null: false, default: 1
       class NotNullColumn < Base
+        include DatabaseTypeResolvable
+
         MSG = 'Do not add a NOT NULL column without a default value.'
         RESTRICT_ON_SEND = %i[add_column add_reference].freeze
 
@@ -45,7 +52,10 @@ module RuboCop
 
         def check_add_column(node)
           add_not_null_column?(node) do |type, pairs|
-            return if type.respond_to?(:value) && (type.value == :virtual || type.value == 'virtual')
+            if type.respond_to?(:value)
+              return if type.value == :virtual || type.value == 'virtual'
+              return if (type.value == :text || type.value == 'text') && database == MYSQL
+            end
 
             check_pairs(pairs)
           end

data/lib/rubocop/cop/rails/output.rb

@@ -23,6 +23,7 @@ module RuboCop
 
         MSG = "Do not write to stdout. Use Rails's logger if you want to log."
         RESTRICT_ON_SEND = %i[ap p pp pretty_print print puts binwrite syswrite write write_nonblock].freeze
+        ALLOWED_TYPES = %i[send csend block numblock].freeze
 
         def_node_matcher :output?, <<~PATTERN
           (send nil? {:ap :p :pp :pretty_print :print :puts} ...)
@@ -39,8 +40,8 @@ module RuboCop
         PATTERN
 
         def on_send(node)
-          return if node.parent&.call_type?
-          return unless output?(node) || io_output?(node)
+          return if ALLOWED_TYPES.include?(node.parent&.type)
+          return if !output?(node) && !io_output?(node)
 
           range = offense_range(node)
 

data/lib/rubocop/cop/rails/redundant_active_record_all_method.rb

@@ -20,19 +20,34 @@ module RuboCop
       #   User.order(:created_at)
       #   users.where(id: ids)
       #   user.articles.order(:created_at)
+      #
+      # @example AllowedReceivers: ['ActionMailer::Preview', 'ActiveSupport::TimeZone'] (default)
+      #   # good
+      #   ActionMailer::Preview.all.first
+      #   ActiveSupport::TimeZone.all.first
       class RedundantActiveRecordAllMethod < Base
         include ActiveRecordHelper
+        include AllowedReceivers
+        include RangeHelp
         extend AutoCorrector
 
         MSG = 'Redundant `all` detected.'
 
         RESTRICT_ON_SEND = [:all].freeze
 
-        # Defined methods in `ActiveRecord::Querying::QUERYING_METHODS` on activerecord 7.0.5.
+        # Defined methods in `ActiveRecord::Querying::QUERYING_METHODS` on activerecord 7.1.0.
         QUERYING_METHODS = %i[
           and
           annotate
           any?
+          async_average
+          async_count
+          async_ids
+          async_maximum
+          async_minimum
+          async_pick
+          async_pluck
+          async_sum
           average
           calculate
           count
@@ -102,6 +117,7 @@ module RuboCop
           preload
           readonly
           references
+          regroup
           reorder
           reselect
           rewhere
@@ -123,23 +139,68 @@ module RuboCop
           unscope
           update_all
           where
+          with
           without
         ].to_set.freeze
 
+        POSSIBLE_ENUMERABLE_BLOCK_METHODS = %i[any? count find none? one? select sum].freeze
+
         def_node_matcher :followed_by_query_method?, <<~PATTERN
           (send (send _ :all) QUERYING_METHODS ...)
         PATTERN
 
         def on_send(node)
-          return unless followed_by_query_method?(node.parent)
-          return if node.receiver.nil? && !inherit_active_record_base?(node)
+          return if !followed_by_query_method?(node.parent) || possible_enumerable_block_method?(node)
+          return if node.receiver ? allowed_receiver?(node.receiver) : !inherit_active_record_base?(node)
 
-          range_of_all_method = node.loc.selector
+          range_of_all_method = offense_range(node)
           add_offense(range_of_all_method) do |collector|
             collector.remove(range_of_all_method)
             collector.remove(node.parent.loc.dot)
           end
         end
+
+        private
+
+        def possible_enumerable_block_method?(node)
+          parent = node.parent
+          return false unless POSSIBLE_ENUMERABLE_BLOCK_METHODS.include?(parent.method_name)
+
+          parent.parent&.block_type? || parent.parent&.numblock_type? || parent.first_argument&.block_pass_type?
+        end
+
+        def offense_range(node)
+          range_between(node.loc.selector.begin_pos, node.source_range.end_pos)
+        end
+
+        # TODO: In the future, please support only RuboCop 1.52+ and use `RuboCop::Cop::AllowedReceivers`:
+        #       https://github.com/rubocop/rubocop/blob/v1.52.0/lib/rubocop/cop/mixin/allowed_receivers.rb
+        #       At that time, this duplicated module implementation can be removed.
+        module AllowedReceivers
+          def allowed_receiver?(receiver)
+            receiver_name = receiver_name(receiver)
+
+            allowed_receivers.include?(receiver_name)
+          end
+
+          def receiver_name(receiver)
+            return receiver_name(receiver.receiver) if receiver.receiver && !receiver.receiver.const_type?
+
+            if receiver.send_type?
+              if receiver.receiver
+                "#{receiver_name(receiver.receiver)}.#{receiver.method_name}"
+              else
+                receiver.method_name.to_s
+              end
+            else
+              receiver.source
+            end
+          end
+
+          def allowed_receivers
+            cop_config.fetch('AllowedReceivers', [])
+          end
+        end
       end
     end
   end

data/lib/rubocop/cop/rails/redundant_presence_validation_on_belongs_to.rb

@@ -53,6 +53,12 @@ module RuboCop
         #   @example source that matches - by a foreign key
         #     validates :user_id, presence: true
         #
+        #   @example source that DOES NOT match - if condition
+        #     validates :user_id, presence: true, if: condition
+        #
+        #   @example source that DOES NOT match - unless condition
+        #     validates :user_id, presence: true, unless: condition
+        #
         #   @example source that DOES NOT match - strict validation
         #     validates :user_id, presence: true, strict: true
         #
@@ -65,6 +71,7 @@ module RuboCop
             $[
               (hash <$(pair (sym :presence) true) ...>)         # presence: true
               !(hash <$(pair (sym :strict) {true const}) ...>)  # strict: true
+              !(hash <$(pair (sym {:if :unless}) _) ...>)       # if: some_condition or unless: some_condition
             ]
           )
         PATTERN

data/lib/rubocop/cop/rails/save_bang.rb

@@ -235,10 +235,10 @@ module RuboCop
 
         def in_condition_or_compound_boolean?(node)
           node = node.block_node || node
-          parent = node.parent
+          parent = node.each_ancestor.find { |ancestor| !ancestor.begin_type? }
           return false unless parent
 
-          operator_or_single_negative?(parent) || (conditional?(parent) && node == parent.condition)
+          operator_or_single_negative?(parent) || (conditional?(parent) && node == deparenthesize(parent.condition))
         end
 
         def operator_or_single_negative?(node)
@@ -249,6 +249,11 @@ module RuboCop
           parent.if_type? || parent.case_type?
         end
 
+        def deparenthesize(node)
+          node = node.children.last while node.begin_type?
+          node
+        end
+
         def checked_immediately?(node)
           node.parent && call_to_persisted?(node.parent)
         end

data/lib/rubocop/cop/rails/select_map.rb

@@ -51,10 +51,13 @@ module RuboCop
           end
         end
 
+        # rubocop:disable Metrics/AbcSize
         def autocorrect(corrector, select_node, node, preferred_method)
-          corrector.remove(select_node.loc.dot.begin.join(select_node.source_range.end))
+          corrector.remove(select_node.loc.dot || node.loc.dot)
+          corrector.remove(select_node.loc.selector.begin.join(select_node.source_range.end))
           corrector.replace(node.loc.selector.begin.join(node.source_range.end), preferred_method)
         end
+        # rubocop:enable Metrics/AbcSize
 
         def match_column_name?(select_candidate, column_name)
           return false unless select_candidate.arguments.one?

data/lib/rubocop/cop/rails/unique_validation_without_index.rb

@@ -125,7 +125,7 @@ module RuboCop
 
         def uniqueness_part(node)
           pairs = node.arguments.last
-          return unless pairs.hash_type?
+          return unless pairs&.hash_type?
 
           pairs.each_pair.find do |pair|
             next unless pair.key.sym_type? && pair.key.value == :uniqueness

data/lib/rubocop/cop/rails/unknown_env.rb

@@ -86,7 +86,11 @@ module RuboCop
         end
 
         def environments
-          cop_config['Environments']
+          @environments ||= begin
+            e = cop_config['Environments']
+            e += ['local'] if target_rails_version >= 7.1
+            e
+          end
         end
       end
     end

data/lib/rubocop/cop/rails/unused_render_content.rb

@@ -14,10 +14,9 @@ module RuboCop
       #   render status: 100, plain: 'Ruby!'
       #
       #   # good
-      #   render status: :continue
-      #   render status: 100
+      #   head :continue
+      #   head 100
       class UnusedRenderContent < Base
-        extend AutoCorrector
         include RangeHelp
 
         MSG = 'Do not specify body content for a response with a non-content status code'

data/lib/rubocop/cop/rails_cops.rb

@@ -3,6 +3,7 @@
 require_relative 'mixin/active_record_helper'
 require_relative 'mixin/active_record_migrations_helper'
 require_relative 'mixin/class_send_node_helper'
+require_relative 'mixin/database_type_resolvable'
 require_relative 'mixin/enforce_superclass'
 require_relative 'mixin/index_method'
 require_relative 'mixin/migrations_helper'
@@ -46,6 +47,7 @@ require_relative 'rails/dynamic_find_by'
 require_relative 'rails/eager_evaluation_log_message'
 require_relative 'rails/enum_hash'
 require_relative 'rails/enum_uniqueness'
+require_relative 'rails/env_local'
 require_relative 'rails/environment_comparison'
 require_relative 'rails/environment_variable_access'
 require_relative 'rails/exit'

data/lib/rubocop/rails/version.rb

@@ -4,7 +4,7 @@ module RuboCop
   module Rails
     # This module holds the RuboCop Rails version information.
     module Version
-      STRING = '2.21.1'
+      STRING = '2.22.0'
 
       def self.document_version
         STRING.match('\d+\.\d+').to_s

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rubocop-rails
 version: !ruby/object:Gem::Version
-  version: 2.21.1
+  version: 2.22.0
 platform: ruby
 authors:
 - Bozhidar Batsov
@@ -10,7 +10,7 @@ authors:
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2023-09-14 00:00:00.000000000 Z
+date: 2023-10-27 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -78,6 +78,7 @@ files:
 - lib/rubocop/cop/mixin/active_record_helper.rb
 - lib/rubocop/cop/mixin/active_record_migrations_helper.rb
 - lib/rubocop/cop/mixin/class_send_node_helper.rb
+- lib/rubocop/cop/mixin/database_type_resolvable.rb
 - lib/rubocop/cop/mixin/enforce_superclass.rb
 - lib/rubocop/cop/mixin/index_method.rb
 - lib/rubocop/cop/mixin/migrations_helper.rb
@@ -120,6 +121,7 @@ files:
 - lib/rubocop/cop/rails/eager_evaluation_log_message.rb
 - lib/rubocop/cop/rails/enum_hash.rb
 - lib/rubocop/cop/rails/enum_uniqueness.rb
+- lib/rubocop/cop/rails/env_local.rb
 - lib/rubocop/cop/rails/environment_comparison.rb
 - lib/rubocop/cop/rails/environment_variable_access.rb
 - lib/rubocop/cop/rails/exit.rb
@@ -223,7 +225,7 @@ metadata:
   homepage_uri: https://docs.rubocop.org/rubocop-rails/
   changelog_uri: https://github.com/rubocop/rubocop-rails/blob/master/CHANGELOG.md
   source_code_uri: https://github.com/rubocop/rubocop-rails/
-  documentation_uri: https://docs.rubocop.org/rubocop-rails/2.21/
+  documentation_uri: https://docs.rubocop.org/rubocop-rails/2.22/
   bug_tracker_uri: https://github.com/rubocop/rubocop-rails/issues
   rubygems_mfa_required: 'true'
 post_install_message: