rubocop-rails 2.21.0 → 2.21.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 9de78b7956de6935004b845bb3a50ae7b751aa5b81abbc4feceb62ea20b9d3a7
-  data.tar.gz: d8f7f57ae1cfe141e6082547f6ea40dbdc6d42f32c2e9f95ba4ec904baaeea7b
+  metadata.gz: 0e154e69d10b43226db08e454d992d724dc7504d54cac804e597156ee5cf13e5
+  data.tar.gz: 60d4697e076620a134f48eff2f81be7b2004fd824796b1a1b15f5822239e3ce3
 SHA512:
-  metadata.gz: e9b3366bdbfa5bd3a53715a3b7ab2fcc5ffd8a6e1eef1da7e557297a827f1caf92bdcfbd2c771e9ef384713d97a347d7f09e4ef792252f8e9900476f034a82ab
-  data.tar.gz: cb54c3f8a7a8ca823055341f531ed2922138c73f101e1cf2455376902b15d545708ddf3c94a06e44146f765277fbdf49e080eb6db085edf438afbaa4a2f61cbc
+  metadata.gz: f0aa0f69a7aa3b90d1e402ab26bdf5a4d03680080d9b06ba157cd92f3c5c290f821e81d4a99636009e17ec4ea2de0cfd405cea00134ebccd4323d424fb790ec8
+  data.tar.gz: 6b6ddbe47c1b112638cc3693464d9509f589a6683317b0bb30925a27788e39351a3a10853ecf286b419d3ec3b17e13aee9fd09ae07581d209635f0a56a44065b

data/README.md

@@ -72,7 +72,9 @@ module YourCoolApp
   class Application < Rails::Application
     config.generators.after_generate do |files|
       parsable_files = files.filter { |file| file.end_with?('.rb') }
-      system("bundle exec rubocop -A --fail-level=E #{parsable_files.shelljoin}", exception: true)
+      unless parsable_files.empty?
+        system("bundle exec rubocop -A --fail-level=E #{parsable_files.shelljoin}", exception: true)
+      end
     end
   end
 end

data/config/default.yml

@@ -801,6 +801,9 @@ Rails/RedundantActiveRecordAllMethod:
   StyleGuide: 'https://rails.rubystyle.guide/#redundant-all'
   Enabled: pending
   Safe: false
+  AllowedReceivers:
+    - ActionMailer::Preview
+    - ActiveSupport::TimeZone
   VersionAdded: '2.21'
 
 Rails/RedundantAllowNil:

data/lib/rubocop/cop/mixin/index_method.rb

@@ -102,7 +102,7 @@ module RuboCop
       end
 
       # Internal helper class to hold match data
-      Captures = Struct.new(
+      Captures = ::Struct.new(
         :transformed_argname,
         :transforming_body_expr
       ) do
@@ -112,7 +112,7 @@ module RuboCop
       end
 
       # Internal helper class to hold autocorrect data
-      Autocorrection = Struct.new(:match, :block_node, :leading, :trailing) do
+      Autocorrection = ::Struct.new(:match, :block_node, :leading, :trailing) do
         def self.from_each_with_object(node, match)
           new(match, node, 0, 0)
         end

data/lib/rubocop/cop/rails/redundant_active_record_all_method.rb

@@ -20,8 +20,15 @@ module RuboCop
       #   User.order(:created_at)
       #   users.where(id: ids)
       #   user.articles.order(:created_at)
+      #
+      # @example AllowedReceivers: ['ActionMailer::Preview', 'ActiveSupport::TimeZone'] (default)
+      #   # good
+      #   ActionMailer::Preview.all.first
+      #   ActiveSupport::TimeZone.all.first
       class RedundantActiveRecordAllMethod < Base
         include ActiveRecordHelper
+        include AllowedReceivers
+        include RangeHelp
         extend AutoCorrector
 
         MSG = 'Redundant `all` detected.'
@@ -124,21 +131,37 @@ module RuboCop
           update_all
           where
           without
-        ].freeze
+        ].to_set.freeze
 
-        def on_send(node)
-          query_node = node.parent
+        POSSIBLE_ENUMERABLE_BLOCK_METHODS = %i[any? count find none? one? select sum].freeze
 
-          return unless query_node&.send_type?
-          return unless QUERYING_METHODS.include?(query_node.method_name)
-          return if node.receiver.nil? && !inherit_active_record_base?(node)
+        def_node_matcher :followed_by_query_method?, <<~PATTERN
+          (send (send _ :all) QUERYING_METHODS ...)
+        PATTERN
 
-          range_of_all_method = node.loc.selector
+        def on_send(node)
+          return if !followed_by_query_method?(node.parent) || possible_enumerable_block_method?(node)
+          return if node.receiver ? allowed_receiver?(node.receiver) : !inherit_active_record_base?(node)
+
+          range_of_all_method = offense_range(node)
           add_offense(range_of_all_method) do |collector|
             collector.remove(range_of_all_method)
-            collector.remove(query_node.loc.dot)
+            collector.remove(node.parent.loc.dot)
           end
         end
+
+        private
+
+        def possible_enumerable_block_method?(node)
+          parent = node.parent
+          return false unless POSSIBLE_ENUMERABLE_BLOCK_METHODS.include?(parent.method_name)
+
+          parent.parent&.block_type? || parent.parent&.numblock_type? || parent.first_argument&.block_pass_type?
+        end
+
+        def offense_range(node)
+          range_between(node.loc.selector.begin_pos, node.source_range.end_pos)
+        end
       end
     end
   end

data/lib/rubocop/cop/rails/select_map.rb

@@ -51,10 +51,13 @@ module RuboCop
           end
         end
 
+        # rubocop:disable Metrics/AbcSize
         def autocorrect(corrector, select_node, node, preferred_method)
-          corrector.remove(select_node.loc.dot.begin.join(select_node.source_range.end))
+          corrector.remove(select_node.loc.dot || node.loc.dot)
+          corrector.remove(select_node.loc.selector.begin.join(select_node.source_range.end))
           corrector.replace(node.loc.selector.begin.join(node.source_range.end), preferred_method)
         end
+        # rubocop:enable Metrics/AbcSize
 
         def match_column_name?(select_candidate, column_name)
           return false unless select_candidate.arguments.one?

data/lib/rubocop/cop/rails/time_zone.rb

@@ -69,7 +69,7 @@ module RuboCop
           return if !node.receiver&.str_type? || !node.method?(:to_time)
 
           add_offense(node.loc.selector, message: MSG_STRING_TO_TIME) do |corrector|
-            autocorrect(corrector, node)
+            corrector.replace(node, "Time.zone.parse(#{node.receiver.source})")
           end
         end
 

data/lib/rubocop/cop/rails/unique_validation_without_index.rb

@@ -125,7 +125,7 @@ module RuboCop
 
         def uniqueness_part(node)
           pairs = node.arguments.last
-          return unless pairs.hash_type?
+          return unless pairs&.hash_type?
 
           pairs.each_pair.find do |pair|
             next unless pair.key.sym_type? && pair.key.value == :uniqueness

data/lib/rubocop/cop/rails/unused_render_content.rb

@@ -14,10 +14,9 @@ module RuboCop
       #   render status: 100, plain: 'Ruby!'
       #
       #   # good
-      #   render status: :continue
-      #   render status: 100
+      #   head :continue
+      #   head 100
       class UnusedRenderContent < Base
-        extend AutoCorrector
         include RangeHelp
 
         MSG = 'Do not specify body content for a response with a non-content status code'

data/lib/rubocop/rails/version.rb

@@ -4,7 +4,7 @@ module RuboCop
   module Rails
     # This module holds the RuboCop Rails version information.
     module Version
-      STRING = '2.21.0'
+      STRING = '2.21.2'
 
       def self.document_version
         STRING.match('\d+\.\d+').to_s

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rubocop-rails
 version: !ruby/object:Gem::Version
-  version: 2.21.0
+  version: 2.21.2
 platform: ruby
 authors:
 - Bozhidar Batsov
@@ -10,7 +10,7 @@ authors:
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2023-09-09 00:00:00.000000000 Z
+date: 2023-09-30 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport