rubocop-rails 2.19.1 → 2.21.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: b020fcc0db6203c33dfe23032cc2c6ec0df139e6abb048409bdf7439ea2d4183
-  data.tar.gz: fc6e892161124d21b9067e01e6b86178857df27d14ae687f3f0fdcceb2b3d078
+  metadata.gz: 0e154e69d10b43226db08e454d992d724dc7504d54cac804e597156ee5cf13e5
+  data.tar.gz: 60d4697e076620a134f48eff2f81be7b2004fd824796b1a1b15f5822239e3ce3
 SHA512:
-  metadata.gz: f09636066a282111462ab5cc3b93463ec0cd8a111e2882b6e7c21889da3b36958766f722926418439e48933d8791ce41c0edadc3e4a590c5f8caeb82f35ad5b1
-  data.tar.gz: 40586400ad94701ee39ee71ab7280f7328889245f4786503cf5a851d158a05e4f736eea42c53f61164a420af8fab7e19854c6302237115a29efd3bdd1f19cc68
+  metadata.gz: f0aa0f69a7aa3b90d1e402ab26bdf5a4d03680080d9b06ba157cd92f3c5c290f821e81d4a99636009e17ec4ea2de0cfd405cea00134ebccd4323d424fb790ec8
+  data.tar.gz: 6b6ddbe47c1b112638cc3693464d9509f589a6683317b0bb30925a27788e39351a3a10853ecf286b419d3ec3b17e13aee9fd09ae07581d209635f0a56a44065b

data/README.md

@@ -72,7 +72,9 @@ module YourCoolApp
   class Application < Rails::Application
     config.generators.after_generate do |files|
       parsable_files = files.filter { |file| file.end_with?('.rb') }
-      system("bundle exec rubocop -A --fail-level=E #{parsable_files.shelljoin}", exception: true)
+      unless parsable_files.empty?
+        system("bundle exec rubocop -A --fail-level=E #{parsable_files.shelljoin}", exception: true)
+      end
     end
   end
 end

data/config/default.yml

@@ -6,6 +6,7 @@ inherit_mode:
 
 AllCops:
   Exclude:
+    - app/assets/**/*
     - bin/*
     # Exclude db/schema.rb and db/[CONFIGURATION_NAMESPACE]_schema.rb by default.
     # See: https://guides.rubyonrails.org/active_record_multiple_databases.html#setting-up-your-application
@@ -47,6 +48,31 @@ Lint/NumberConversion:
     - in_milliseconds
   AllowedPatterns: []
 
+Lint/RedundantSafeNavigation:
+  # Add `presence` and `present?` methods to the default of the RuboCop core.
+  # https://github.com/rubocop/rubocop/blob/v1.51.0/config/default.yml#L2148-L2159
+  AllowedMethods:
+    - instance_of?
+    - kind_of?
+    - is_a?
+    - eql?
+    - respond_to?
+    - equal?
+    - presence
+    - present?
+
+Lint/SafeNavigationChain:
+  # Add `presence_in` method to the default of the RuboCop core:
+  # https://github.com/rubocop/rubocop/blob/v1.56.0/config/default.yml#L2265-L2271
+  AllowedMethods:
+    - present?
+    - blank?
+    - presence
+    - presence_in
+    - try
+    - try!
+    - in?
+
 Rails:
   Enabled: true
   DocumentationBaseURL: https://docs.rubocop.org/rubocop-rails
@@ -146,8 +172,9 @@ Rails/AddColumnIndex:
     index might be used.
   Enabled: pending
   VersionAdded: '2.11'
+  VersionChanged: '2.20'
   Include:
-    - db/migrate/*.rb
+    - db/**/*.rb
 
 Rails/AfterCommitOverride:
   Description: >-
@@ -235,12 +262,13 @@ Rails/BulkChangeTable:
     - https://api.rubyonrails.org/classes/ActiveRecord/ConnectionAdapters/Table.html
   Enabled: true
   VersionAdded: '0.57'
+  VersionChanged: '2.20'
   Database: null
   SupportedDatabases:
     - mysql
     - postgresql
   Include:
-    - db/migrate/*.rb
+    - db/**/*.rb
 
 Rails/CompactBlank:
   Description: 'Checks if collection can be blank-compacted with `compact_blank`.'
@@ -270,18 +298,31 @@ Rails/CreateTableWithTimestamps:
                   when creating a new table.
   Enabled: true
   VersionAdded: '0.52'
+  VersionChanged: '2.20'
   Include:
-    - db/migrate/*.rb
+    - db/**/*.rb
   Exclude:
     # Respect the `active_storage_variant_records` table of `*_create_active_storage_tables.active_storage.rb`
+    # and `*_create_active_storage_variant_records.active_storage.rb`
     # auto-generated by `bin/rails active_storage:install` even if `created_at` is not specified.
-    - db/migrate/*_create_active_storage_tables.active_storage.rb
+    - db/**/*_create_active_storage_tables.active_storage.rb
+    - db/**/*_create_active_storage_variant_records.active_storage.rb
+
+Rails/DangerousColumnNames:
+  Description: >-
+                  Avoid dangerous column names.
+  Enabled: pending
+  Severity: warning
+  VersionAdded: '2.21'
+  Include:
+    - 'db/**/*.rb'
 
 Rails/Date:
   Description: >-
                   Checks the correct usage of date aware methods,
                   such as Date.today, Date.current etc.
   Enabled: true
+  SafeAutoCorrect: false
   VersionAdded: '0.30'
   VersionChanged: '2.11'
   # The value `strict` disallows usage of `Date.today`, `Date.current`,
@@ -443,10 +484,8 @@ Rails/FindBy:
   StyleGuide: 'https://rails.rubystyle.guide#find_by'
   Enabled: true
   VersionAdded: '0.30'
-  VersionChanged: '2.11'
+  VersionChanged: '2.21'
   IgnoreWhereFirst: true
-  Include:
-    - app/models/**/*.rb
 
 Rails/FindById:
   Description: >-
@@ -462,9 +501,7 @@ Rails/FindEach:
   Enabled: true
   Safe: false
   VersionAdded: '0.30'
-  VersionChanged: '2.19'
-  Include:
-    - app/models/**/*.rb
+  VersionChanged: '2.21'
   AllowedMethods:
     # Methods that don't work well with `find_each`.
     - order
@@ -527,6 +564,10 @@ Rails/I18nLazyLookup:
   Reference: 'https://guides.rubyonrails.org/i18n.html#lazy-lookup'
   Enabled: pending
   VersionAdded: '2.14'
+  EnforcedStyle: lazy
+  SupportedStyles:
+    - lazy
+    - explicit
   Include:
     - 'app/controllers/**/*.rb'
 
@@ -632,8 +673,9 @@ Rails/MigrationClassName:
   Description: 'The class name of the migration should match its file name.'
   Enabled: pending
   VersionAdded: '2.14'
+  VersionChanged: '2.20'
   Include:
-    - db/migrate/*.rb
+    - db/**/*.rb
 
 Rails/NegateInclude:
   Description: 'Prefer `collection.exclude?(obj)` over `!collection.include?(obj)`.'
@@ -647,8 +689,9 @@ Rails/NotNullColumn:
   Description: 'Do not add a NOT NULL column without a default value.'
   Enabled: true
   VersionAdded: '0.43'
+  VersionChanged: '2.20'
   Include:
-    - db/migrate/*.rb
+    - db/**/*.rb
 
 Rails/OrderById:
   Description: >-
@@ -753,6 +796,16 @@ Rails/ReadWriteAttribute:
   Include:
     - app/models/**/*.rb
 
+Rails/RedundantActiveRecordAllMethod:
+  Description: Detect redundant `all` used as a receiver for Active Record query methods.
+  StyleGuide: 'https://rails.rubystyle.guide/#redundant-all'
+  Enabled: pending
+  Safe: false
+  AllowedReceivers:
+    - ActionMailer::Preview
+    - ActiveSupport::TimeZone
+  VersionAdded: '2.21'
+
 Rails/RedundantAllowNil:
   Description: >-
                  Finds redundant use of `allow_nil` when `allow_blank` is set to
@@ -933,6 +986,12 @@ Rails/ScopeArgs:
   Include:
     - app/models/**/*.rb
 
+Rails/SelectMap:
+  Description: 'Checks for uses of `select(:column_name)` with `map(&:column_name)`.'
+  Enabled: pending
+  Safe: false
+  VersionAdded: '2.21'
+
 Rails/ShortI18n:
   Description: 'Use the short form of the I18n methods: `t` instead of `translate` and `l` instead of `localize`.'
   StyleGuide: 'https://rails.rubystyle.guide/#short-i18n'
@@ -1061,6 +1120,7 @@ Rails/TransactionExitStatement:
     - https://github.com/rails/rails/commit/15aa4200e083
   Enabled: pending
   VersionAdded: '2.14'
+  TransactionMethods: []
 
 Rails/UniqBeforePluck:
   Description: 'Prefer the use of uniq or distinct before pluck.'
@@ -1098,6 +1158,12 @@ Rails/UnusedIgnoredColumns:
   Include:
     - app/models/**/*.rb
 
+Rails/UnusedRenderContent:
+  Description: 'Do not specify body content for a response with a non-content status code.'
+  Enabled: pending
+  Severity: warning
+  VersionAdded: '2.21'
+
 Rails/Validation:
   Description: 'Use validates :attribute, hash of validations.'
   Enabled: true
@@ -1153,6 +1219,14 @@ Style/FormatStringToken:
   AllowedMethods:
     - redirect
 
+Style/InvertibleUnlessCondition:
+  InverseMethods:
+    # Active Support defines some common inverse methods. They are listed below:
+    :present?: :blank?
+    :blank?: :present?
+    :include?: :exclude?
+    :exclude?: :include?
+
 Style/SymbolProc:
   AllowedMethods:
     - define_method

data/lib/rubocop/cop/mixin/index_method.rb

@@ -102,7 +102,7 @@ module RuboCop
       end
 
       # Internal helper class to hold match data
-      Captures = Struct.new(
+      Captures = ::Struct.new(
         :transformed_argname,
         :transforming_body_expr
       ) do
@@ -112,7 +112,7 @@ module RuboCop
       end
 
       # Internal helper class to hold autocorrect data
-      Autocorrection = Struct.new(:match, :block_node, :leading, :trailing) do
+      Autocorrection = ::Struct.new(:match, :block_node, :leading, :trailing) do
         def self.from_each_with_object(node, match)
           new(match, node, 0, 0)
         end

data/lib/rubocop/cop/rails/action_controller_flash_before_render.rb

@@ -85,7 +85,7 @@ module RuboCop
 
         def inherit_action_controller_base?(node)
           class_node = find_ancestor(node, type: :class)
-          return unless class_node
+          return false unless class_node
 
           action_controller?(class_node)
         end

data/lib/rubocop/cop/rails/action_controller_test_case.rb

@@ -3,8 +3,8 @@
 module RuboCop
   module Cop
     module Rails
-      # Using `ActionController::TestCase`` is discouraged and should be replaced by
-      # `ActionDispatch::IntegrationTest``. Controller tests are too close to the
+      # Using `ActionController::TestCase` is discouraged and should be replaced by
+      # `ActionDispatch::IntegrationTest`. Controller tests are too close to the
       # internals of a controller whereas integration tests mimic the browser/user.
       #
       # @safety

data/lib/rubocop/cop/rails/assert_not.rb

@@ -3,7 +3,6 @@
 module RuboCop
   module Cop
     module Rails
-      #
       # Use `assert_not` instead of `assert !`.
       #
       # @example

data/lib/rubocop/cop/rails/bulk_change_table.rb

@@ -12,7 +12,8 @@ module RuboCop
       # The `bulk` option is only supported on the MySQL and
       # the PostgreSQL (5.2 later) adapter; thus it will
       # automatically detect an adapter from `development` environment
-      # in `config/database.yml` when the `Database` option is not set.
+      # in `config/database.yml` or the environment variable `DATABASE_URL`
+      # when the `Database` option is not set.
       # If the adapter is not `mysql2` or `postgresql`,
       # this Cop ignores offenses.
       #
@@ -175,13 +176,13 @@ module RuboCop
         end
 
         def database
-          cop_config['Database'] || database_from_yaml
+          cop_config['Database'] || database_from_yaml || database_from_env
         end
 
         def database_from_yaml
           return nil unless database_yaml
 
-          case database_yaml['adapter']
+          case database_adapter
           when 'mysql2'
             MYSQL
           when 'postgresql'
@@ -189,6 +190,10 @@ module RuboCop
           end
         end
 
+        def database_adapter
+          database_yaml['adapter'] || database_yaml.first.last['adapter']
+        end
+
         def database_yaml
           return nil unless File.exist?('config/database.yml')
 
@@ -207,6 +212,18 @@ module RuboCop
           nil
         end
 
+        def database_from_env
+          url = ENV['DATABASE_URL'].presence
+          return nil unless url
+
+          case url
+          when %r{\Amysql2://}
+            MYSQL
+          when %r{\Apostgres(ql)?://}
+            POSTGRESQL
+          end
+        end
+
         def support_bulk_alter?
           case database
           when MYSQL