rubocop-petal 0.8.0 → 0.9.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 424a55f53bbcb88794cf8a0122a376217db95d890fc789d0288a76434cdcb023
-  data.tar.gz: 838d1178021d47035f10b7fb139e3fb50955b823ec4f94f80bad0f504d042017
+  metadata.gz: f457dc147b37b31a89fc5f511560442983a438b191e5723fe95d981f8cb32e91
+  data.tar.gz: 197112fd588a74778acc75c2d0da8238dcc4681c49636b5ed7a543728b0abe97
 SHA512:
-  metadata.gz: d1d19b3bb4c94b070a0acb1d06442541aa333ef8a2170a4d2074ab828051909811d90c8e37ad4d10b5f76ba7fde2ba493bb2f1dcbbc9f5e5e2e930561be23412
-  data.tar.gz: a188cc40b0da58690ef31c33698ba33c6043e0d0a52d474b4ee07be5049991357373c97666b5c42996be7efedb56a8e540a4bbbd9d81ac8761bf6144c121ae73
+  metadata.gz: a455e3b3db660c5fa02a148263582aee5e82ad561638d8094f2beff087c08eb0e8414e45f2eccd4f1bbaa7d8740e41317fb5421dea0a9e39a41fbc947cb65f49
+  data.tar.gz: f89c1da3350fccba89c879092bfb8734f2a903714017cf177e24183a3bb44864c86c90ab1648bb9a5cf8cf0f0347b7dc2f4bfdebb139a684ac9a45b7af5676a7

data/config/default.yml

@@ -78,13 +78,6 @@ Chewy/ResetOnType:
   Description: 'Prevent using reset! methods on Chewy type class'
   Enabled: true
 
-RSpec/JsonParseResponseBody:
-  Description: 'Prevent JSON.parse(response.body) in favor of response.parsed_body'
-  Enabled: true
-  SafeAutoCorrect: true
-  Include:
-    - spec/**/*
-
 RSpec/JsonResponse:
   Description: 'Prevent json_response in favor of response.parsed_body'
   Enabled: true

data/lib/rubocop/cop/rspec/sidekiq_inline.rb

@@ -7,19 +7,21 @@ module RuboCop
       # The method will execute inline every perform_async called.
       # Must likely a spec want to test a specific worker and called it.
       # If you don't need to execute it, consider using `have_enqueued_sidekiq_job`
-      # matcher.
+      # matcher. Or if you need to perform the jobs in queue for this worker, use
+      # `drain` method on the worker class.
       #
       # @example
       #   # bad
-      #   Sidekiq::Testing.inline! do; end
+      #   Sidekiq::Testing.inline! do
+      #      OperationThatTriggerWorker.call(some_id)
+      #   end
       #
       #   # good
-      #   expect(MyWorker).to receive(:perform_async).with(some_id) do |id|
-      #     MyWorker.new.perform(id)
-      #   end
+      #   OperationThatTriggerWorker.call(some_id)
+      #   MyWorker.drain
       #
       class SidekiqInline < Base
-        MSG = 'Stub `perform_async` and call inline worker with `new.perform`.'
+        MSG = 'Use `MyWorker.drain` method instead of `Sidekiq::Testing.inline!`.'
         RESTRICT_ON_SEND = [:inline!].freeze
 
         def_node_matcher :sidekiq_inline?, <<~PATTERN

data/lib/rubocop/petal/version.rb

@@ -2,6 +2,6 @@
 
 module RuboCop
   module Petal
-    VERSION = '0.8.0'
+    VERSION = '0.9.0'
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rubocop-petal
 version: !ruby/object:Gem::Version
-  version: 0.8.0
+  version: 0.9.0
 platform: ruby
 authors:
 - Jean-Francis Bastien
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2023-02-21 00:00:00.000000000 Z
+date: 2023-05-12 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop
@@ -70,7 +70,6 @@ files:
 - lib/rubocop/cop/rails/table_name.rb
 - lib/rubocop/cop/rspec/authenticated_as.rb
 - lib/rubocop/cop/rspec/create_list_max.rb
-- lib/rubocop/cop/rspec/json_parse_response_body.rb
 - lib/rubocop/cop/rspec/json_response.rb
 - lib/rubocop/cop/rspec/sidekiq_inline.rb
 - lib/rubocop/cop/rspec/stub_products.rb
@@ -101,7 +100,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.3
+rubygems_version: 3.2.3
 signing_key: 
 specification_version: 4
 summary: Petal custom cops

data/lib/rubocop/cop/rspec/json_parse_response_body.rb

@@ -1,35 +0,0 @@
-# frozen_string_literal: true
-
-module RuboCop
-  module Cop
-    module RSpec
-      # Prevent using `JSON.parse(response.body)` in spec.
-      # Consider using `response.parsed_body`.
-      #
-      # @example
-      #   # bad
-      #   JSON.parse(response.body) do; end
-      #
-      #   # good
-      #   response.parsed_body
-      #
-      class JsonParseResponseBody < Base
-        extend AutoCorrector
-
-        MSG = 'Use `response.parsed_body` instead.'
-
-        def_node_matcher :json_parse_response_body?, <<~PATTERN
-          (send (const _ :JSON) :parse (send (send _ :response) :body))
-        PATTERN
-
-        def on_send(node)
-          return unless json_parse_response_body?(node)
-
-          add_offense(node) do |corrector|
-            corrector.replace(node, 'response.parsed_body')
-          end
-        end
-      end
-    end
-  end
-end