rubocop-petal 0.5.0 → 0.6.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: aa2179fb3df37d962557546e94f204ee9a8789d2850cda31a53e7375b47edb50
-  data.tar.gz: dfeedd44694e75eab2c78f7205d93701a356378d147d6dca9e5adf68bf1e805f
+  metadata.gz: c7d73cfbe6b4f194f1c60d25235331cf7a08b04b516411efeabeafce9e6e7886
+  data.tar.gz: 193dd79a6efd61cdd2edbb5bfae7158497ca7cc2bb52da38b02dfecd776eadfa
 SHA512:
-  metadata.gz: df124d64a0b69c1311c86e47393fd94379f89fac39d5f6752ec8af6f97df783764fcf581de9c5e11d79d5245bba37f8f07464d29d86f102c9b07056c610ffb8c
-  data.tar.gz: dec1a550aa7fbfdfeae58457bd668d671b21a0db0933685d253c18408b913bde81ccbf0e7fbb6ab1b5966741a6d4b3590956fc2641a11a0fda40d55c9980bc9a
+  metadata.gz: 15ef827ea4cf56872e2c85178463e2d3a05a6a47411832439c81cb4dd9a9ff9221efb61603d2a9e6b38d5859fe0aa2745499bd1d98ef516169e1947065bf1ebb
+  data.tar.gz: 0c14a8c68e7af71afbd81cd827fdd76dfbcc8780e06ab7f1f2f662cc7409fe505b2afc05fa6260f18c6d3a1dd8df05176d51c965c71b68c4f75501abe4a9aa96

data/CHANGELOG.md

@@ -2,15 +2,20 @@
 
 # main
 
-#v0.5.0
+# v0.6.0
+
+* Added cop `RSpec::SidekiqInline` ([#24](https://github.com/petalmd/rubocop-petal/pull/24))
+* Remove cop `Rails/ValidateUniquenessCase` ([#21](https://github.com/petalmd/rubocop-petal/pull/21))
+
+# v0.5.0
 
 * Added cop `Rails/ValidateUniquenessCase` ([#20](https://github.com/petalmd/rubocop-petal/pull/20))
 
-#v0.4.1
+# v0.4.1
 
 * Fix typo default config SafeAutoCorrect RSpec/StubProducts ([#19](https://github.com/petalmd/rubocop-petal/pull/19))
 
-#v0.4.0
+# v0.4.0
 
 * Added cop `RSpec/StubProducts` ([#18](https://github.com/petalmd/rubocop-petal/pull/18))
 

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    rubocop-petal (0.5.0)
+    rubocop-petal (0.6.0)
       rubocop (>= 1.7.0, < 2.0)
       rubocop-rails (~> 2.10)
 
@@ -22,7 +22,7 @@ GEM
     parallel (1.21.0)
     parser (3.0.3.2)
       ast (~> 2.4.1)
-    rack (2.2.3)
+    rack (3.0.0)
     rainbow (3.0.0)
     rake (13.0.6)
     regexp_parser (2.2.0)
@@ -51,7 +51,7 @@ GEM
       unicode-display_width (>= 1.4.0, < 3.0)
     rubocop-ast (1.15.0)
       parser (>= 3.0.1.1)
-    rubocop-rails (2.14.2)
+    rubocop-rails (2.15.2)
       activesupport (>= 4.2.0)
       rack (>= 1.1)
       rubocop (>= 1.7.0, < 2.0)

data/config/default.yml

@@ -30,6 +30,13 @@ RSpec/CreateListMax:
   Include:
     - spec/**/*
 
+RSpec/SidekiqInline:
+  Description: 'Prevent using `Sidekiq::Testing.inline!` in spec in favor of stubbing and calling it inline with `new.perform`.'
+  Enabled: pending
+  StyleGuide: https://github.com/mperham/sidekiq/issues/3495
+  Include:
+    - spec/**/*
+
 RSpec/StubProducts:
   Description: 'Suggest to use stub_products instead of veil/unveil_product.'
   Enabled: true
@@ -70,11 +77,3 @@ Rails/TableName:
 Chewy/ResetOnType:
   Description: 'Prevent using reset! methods on Chewy type class'
   Enabled: true
-
-Rails/ValidateUniquenessCase:
-  Description: 'Enforce setting uniqueness case sensitive option.'
-  Enabled: true
-  SafeAutoCorrect: false
-  StyleGuide: 'https://guides.rubyonrails.org/6_1_release_notes.html#active-record-notable-changes'
-  Include:
-    - app/models/**/*

data/lib/rubocop/cop/rspec/sidekiq_inline.rb

@@ -0,0 +1,37 @@
+# frozen_string_literal: true
+
+module RuboCop
+  module Cop
+    module RSpec
+      # Prevent using `Sidekiq::Testing.inline!` in spec.
+      # The method will execute inline every perform_async called.
+      # Must likely a spec want to test a specific worker and called it.
+      # If you don't need to execute it, consider using `have_enqueued_sidekiq_job`
+      # matcher.
+      #
+      # @example
+      #   # bad
+      #   Sidekiq::Testing.inline! do; end
+      #
+      #   # good
+      #   expect(MyWorker).to receive(:perform_async).with(some_id) do |id|
+      #     MyWorker.new.perform(id)
+      #   end
+      #
+      class SidekiqInline < Base
+        MSG = 'Stub `perform_async` and call inline worker with `new.perform`.'
+        RESTRICT_ON_SEND = [:inline!].freeze
+
+        def_node_matcher :sidekiq_inline?, <<~PATTERN
+          (send (const (const _ :Sidekiq) :Testing) :inline!)
+        PATTERN
+
+        def on_send(node)
+          return unless sidekiq_inline?(node)
+
+          add_offense(node)
+        end
+      end
+    end
+  end
+end

data/lib/rubocop/petal/version.rb

@@ -2,6 +2,6 @@
 
 module RuboCop
   module Petal
-    VERSION = '0.5.0'
+    VERSION = '0.6.0'
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rubocop-petal
 version: !ruby/object:Gem::Version
-  version: 0.5.0
+  version: 0.6.0
 platform: ruby
 authors:
 - Jean-Francis Bastien
-autorequire:
+autorequire: 
 bindir: exe
 cert_chain: []
-date: 2022-04-25 00:00:00.000000000 Z
+date: 2022-09-24 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop
@@ -44,7 +44,7 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '2.10'
-description:
+description: 
 email:
 - jfbastien@petalmd.com
 executables: []
@@ -75,9 +75,9 @@ files:
 - lib/rubocop/cop/rails/enum_prefix.rb
 - lib/rubocop/cop/rails/risky_activerecord_invocation.rb
 - lib/rubocop/cop/rails/table_name.rb
-- lib/rubocop/cop/rails/validate_uniqueness_case.rb
 - lib/rubocop/cop/rspec/authenticated_as.rb
 - lib/rubocop/cop/rspec/create_list_max.rb
+- lib/rubocop/cop/rspec/sidekiq_inline.rb
 - lib/rubocop/cop/rspec/stub_products.rb
 - lib/rubocop/petal.rb
 - lib/rubocop/petal/inject.rb
@@ -90,7 +90,7 @@ metadata:
   homepage_uri: https://github.com/petalmd/rubocop-petal
   source_code_uri: https://github.com/petalmd/rubocop-petal
   rubygems_mfa_required: 'true'
-post_install_message:
+post_install_message: 
 rdoc_options: []
 require_paths:
 - lib
@@ -105,8 +105,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.2.3
-signing_key:
+rubygems_version: 3.0.3
+signing_key: 
 specification_version: 4
 summary: Petal custom cops
 test_files: []

data/lib/rubocop/cop/rails/validate_uniqueness_case.rb

@@ -1,89 +0,0 @@
-# frozen_string_literal: true
-
-module RuboCop
-  module Cop
-    module Rails
-      # Enforces to specify a case sensitive or case insensitive option
-      # to the uniqueness validation.
-      #
-      # The default value in Rails 5 is `case_sensitive: true`. Which does not
-      # reflect MySQL's default behavior. In Rails 6.1 the default value will be
-      # `case_sensitive: false` to reflect MySQL's default behavior
-      # (https://guides.rubyonrails.org/6_1_release_notes.html#active-record-notable-changes).
-      #
-      # # bad
-      # validates :name, uniqueness: true
-      # validates :name, uniqueness: { scope: :user_id }
-      #
-      # # good
-      # validates :name, uniqueness: { case_sensitive: true }
-      # validates :name, uniqueness: { scope: :user_id, case_sensitive: false }
-      #
-      class ValidateUniquenessCase < Base
-        extend AutoCorrector
-
-        # Don't force to add the `case_sensitive` option when
-        # the default value is already `false` in Rails 6.
-        MAXIMUM_RAILS_VERSION = 6.1
-        MSG = 'Pass `case_sensitive: true|false` to uniqueness options.'
-        RESTRICT_ON_SEND = %i[validates].freeze
-
-        def_node_search :uniqueness?, <<~PATTERN
-          (sym :uniqueness)
-        PATTERN
-
-        def_node_matcher :have_case_sensitive_options?, <<~PATTERN
-          (pair (sym :case_sensitive) ${true false})
-        PATTERN
-
-        def on_send(node)
-          return unless support_target_rails_version?
-
-          uniqueness_options = match_uniqueness_options(node)
-          return unless uniqueness_options
-
-          uniqueness_child_options = uniqueness_options.children.last
-
-          # When it's just `uniqueness: true`
-          if uniqueness_child_options.boolean_type?
-            boolean_uniqueness(uniqueness_options)
-            return
-          end
-
-          case_sensitive_options = uniqueness_child_options.pairs.detect { |c| have_case_sensitive_options?(c) }
-          hash_uniqueness_offense(uniqueness_options, case_sensitive_options)
-        end
-
-        private
-
-        def match_uniqueness_options(node)
-          node.children.last.children.detect do |c|
-            # Skip if not a hash
-            next if c.is_a?(Symbol)
-
-            uniqueness?(c)
-          end
-        end
-
-        def boolean_uniqueness(node)
-          # When it's just `uniqueness: true`
-          add_offense(node) do |corrector|
-            corrector.replace(node, 'uniqueness: { case_sensitive: false }')
-          end
-        end
-
-        def hash_uniqueness_offense(node, sensitive_options)
-          return if sensitive_options
-
-          add_offense(node) do |corrector|
-            corrector.insert_after(node.loc.expression.adjust(end_pos: -2), ', case_sensitive: false')
-          end
-        end
-
-        def support_target_rails_version?
-          target_rails_version < MAXIMUM_RAILS_VERSION
-        end
-      end
-    end
-  end
-end