rubocop-performance 1.7.1 → 1.8.0

data/lib/rubocop/cop/performance/times_map.rb

@@ -17,7 +17,9 @@ module RuboCop
       #   Array.new(9) do |i|
       #     i.to_s
       #   end
-      class TimesMap < Cop
+      class TimesMap < Base
+        extend AutoCorrector
+
         MESSAGE = 'Use `Array.new(%<count>s)` with a block ' \
                   'instead of `.times.%<map_or_collect>s`'
         MESSAGE_ONLY_IF = 'only if `%<count>s` is always 0 or more'
@@ -30,35 +32,26 @@ module RuboCop
           check(node)
         end
 
-        def autocorrect(node)
-          map_or_collect, count = times_map_call(node)
-
-          replacement =
-            "Array.new(#{count.source}" \
-            "#{map_or_collect.arguments.map { |arg| ", #{arg.source}" }.join})"
-
-          lambda do |corrector|
-            corrector.replace(map_or_collect.loc.expression, replacement)
-          end
-        end
-
         private
 
         def check(node)
           times_map_call(node) do |map_or_collect, count|
-            add_offense(node, message: message(map_or_collect, count))
+            add_offense(node, message: message(map_or_collect, count)) do |corrector|
+              replacement = "Array.new(#{count.source}" \
+                            "#{map_or_collect.arguments.map { |arg| ", #{arg.source}" }.join})"
+
+              corrector.replace(map_or_collect.loc.expression, replacement)
+            end
           end
         end
 
         def message(map_or_collect, count)
           template = if count.literal?
-                       MESSAGE + '.'
+                       "#{MESSAGE}."
                      else
                        "#{MESSAGE} #{MESSAGE_ONLY_IF}."
                      end
-          format(template,
-                 count: count.source,
-                 map_or_collect: map_or_collect.method_name)
+          format(template, count: count.source, map_or_collect: map_or_collect.method_name)
         end
 
         def_node_matcher :times_map_call, <<~PATTERN

data/lib/rubocop/cop/performance/unfreeze_string.rb

@@ -23,7 +23,7 @@ module RuboCop
       #   # good
       #   +'something'
       #   +''
-      class UnfreezeString < Cop
+      class UnfreezeString < Base
         MSG = 'Use unary plus to get an unfrozen string literal.'
 
         def_node_matcher :dup_string?, <<~PATTERN

data/lib/rubocop/cop/performance/uri_default_parser.rb

@@ -13,7 +13,9 @@ module RuboCop
       #   # good
       #   URI::DEFAULT_PARSER
       #
-      class UriDefaultParser < Cop
+      class UriDefaultParser < Base
+        extend AutoCorrector
+
         MSG = 'Use `%<double_colon>sURI::DEFAULT_PARSER` instead of ' \
               '`%<double_colon>sURI::Parser.new`.'
 
@@ -28,17 +30,9 @@ module RuboCop
             double_colon = captured_value ? '::' : ''
             message = format(MSG, double_colon: double_colon)
 
-            add_offense(node, message: message)
-          end
-        end
-
-        def autocorrect(node)
-          lambda do |corrector|
-            double_colon = uri_parser_new?(node) ? '::' : ''
-
-            corrector.replace(
-              node.loc.expression, "#{double_colon}URI::DEFAULT_PARSER"
-            )
+            add_offense(node, message: message) do |corrector|
+              corrector.replace(node.loc.expression, "#{double_colon}URI::DEFAULT_PARSER")
+            end
           end
         end
       end

data/lib/rubocop/cop/performance_cops.rb

@@ -9,6 +9,7 @@ require_relative 'performance/bind_call'
 require_relative 'performance/caller'
 require_relative 'performance/case_when_splat'
 require_relative 'performance/casecmp'
+require_relative 'performance/collection_literal_in_loop'
 require_relative 'performance/compare_with_block'
 require_relative 'performance/count'
 require_relative 'performance/delete_prefix'
@@ -36,6 +37,7 @@ require_relative 'performance/squeeze'
 require_relative 'performance/start_with'
 require_relative 'performance/string_include'
 require_relative 'performance/string_replacement'
+require_relative 'performance/sum'
 require_relative 'performance/times_map'
 require_relative 'performance/unfreeze_string'
 require_relative 'performance/uri_default_parser'

data/lib/rubocop/performance/version.rb

@@ -3,7 +3,7 @@
 module RuboCop
   module Performance
     module Version
-      STRING = '1.7.1'
+      STRING = '1.8.0'
     end
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rubocop-performance
 version: !ruby/object:Gem::Version
-  version: 1.7.1
+  version: 1.8.0
 platform: ruby
 authors:
 - Bozhidar Batsov
@@ -10,7 +10,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-07-17 00:00:00.000000000 Z
+date: 2020-09-04 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop
@@ -18,14 +18,14 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 0.82.0
+        version: 0.87.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 0.82.0
+        version: 0.87.0
 - !ruby/object:Gem::Dependency
   name: simplecov
   requirement: !ruby/object:Gem::Requirement
@@ -63,6 +63,7 @@ files:
 - lib/rubocop/cop/performance/case_when_splat.rb
 - lib/rubocop/cop/performance/casecmp.rb
 - lib/rubocop/cop/performance/chain_array_allocation.rb
+- lib/rubocop/cop/performance/collection_literal_in_loop.rb
 - lib/rubocop/cop/performance/compare_with_block.rb
 - lib/rubocop/cop/performance/count.rb
 - lib/rubocop/cop/performance/delete_prefix.rb
@@ -90,6 +91,7 @@ files:
 - lib/rubocop/cop/performance/start_with.rb
 - lib/rubocop/cop/performance/string_include.rb
 - lib/rubocop/cop/performance/string_replacement.rb
+- lib/rubocop/cop/performance/sum.rb
 - lib/rubocop/cop/performance/times_map.rb
 - lib/rubocop/cop/performance/unfreeze_string.rb
 - lib/rubocop/cop/performance/uri_default_parser.rb