rubocop-performance 1.7.0 → 1.7.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 5be372d62d20424e05201d4b78bb06bf19fc707d845d6b799599ba72958f72b7
-  data.tar.gz: 87c59d78e37de238add70195fa26c95d31b23eb3065695f443a1694d3acf9145
+  metadata.gz: 34605a937c1a3e040428bee06e322220659c105b6e835423d9e0e73869fd83ee
+  data.tar.gz: e3fa0103bd2518cec45334bc162e144963eef9e3d09ab9fd6bd7b2d35b654e84
 SHA512:
-  metadata.gz: d6caf119ca1a8b11d829ed555f3a0653a1087d3a3ee3be078460c9ecfb5a5fb236a7abf2c058f57647d4f74dffccc66aebcf4d330f5a6a5bd5deaa12a8fea480
-  data.tar.gz: d8a6e634d4453300d24e5869bffa690457d07048b1e2978cc00dbc930c40e2dc80789a6faa95823e63414e5c579f8784cbe4f743607e2fd9598cf478aa1801ed
+  metadata.gz: 5fe72ab5a0370aa8e0cc434080a27a38d8979084c53c50cd18e8cbc0896572ddc9d011130d56283f9d588268253ec0e2e44fc32b81483e1458689c60c17e835b
+  data.tar.gz: a60d627b0d1ded2fb6103a78fb4414fc1e1f1ff13ab9f4e82c399289c9a40c3c6e0385ee2509074175bd724755f768dd4625bb9791af993032a1f840a0533ef6

data/config/default.yml

@@ -4,6 +4,7 @@ Performance/AncestorsInclude:
   Description: 'Use `A <= B` instead of `A.ancestors.include?(B)`.'
   Reference: 'https://github.com/JuanitoFatas/fast-ruby#ancestorsinclude-vs--code'
   Enabled: 'pending'
+  Safe: false
   VersionAdded: '1.7'
 
 Performance/BigDecimalWithNumericArgument:
@@ -247,6 +248,8 @@ Performance/StartWith:
 Performance/StringInclude:
   Description: 'Use `String#include?` instead of a regex match with literal-only pattern.'
   Enabled: 'pending'
+  AutoCorrect: false
+  SafeAutoCorrect: false
   VersionAdded: '1.7'
 
 Performance/StringReplacement:

data/lib/rubocop/cop/performance/ancestors_include.rb

@@ -35,7 +35,9 @@ module RuboCop
         def autocorrect(node)
           ancestors_include_candidate?(node) do |subclass, superclass|
             lambda do |corrector|
-              corrector.replace(node, "#{subclass.source} <= #{superclass.source}")
+              subclass_source = subclass ? subclass.source : 'self'
+
+              corrector.replace(node, "#{subclass_source} <= #{superclass.source}")
             end
           end
         end

data/lib/rubocop/cop/performance/big_decimal_with_numeric_argument.rb

@@ -8,14 +8,13 @@ module RuboCop
       # than from Numeric for BigDecimal.
       #
       # @example
-      #
       #   # bad
-      # BigDecimal(1, 2)
-      # BigDecimal(1.2, 3, exception: true)
+      #   BigDecimal(1, 2)
+      #   BigDecimal(1.2, 3, exception: true)
       #
       #   # good
-      # BigDecimal('1', 2)
-      # BigDecimal('1.2', 3, exception: true)
+      #   BigDecimal('1', 2)
+      #   BigDecimal('1.2', 3, exception: true)
       #
       class BigDecimalWithNumericArgument < Cop
         MSG = 'Convert numeric argument to string before passing to `BigDecimal`.'
@@ -26,6 +25,8 @@ module RuboCop
 
         def on_send(node)
           big_decimal_with_numeric_argument?(node) do |numeric|
+            next if numeric.float_type? && specifies_precision?(node)
+
             add_offense(node, location: numeric.source_range)
           end
         end
@@ -37,6 +38,12 @@ module RuboCop
             end
           end
         end
+
+        private
+
+        def specifies_precision?(node)
+          node.arguments.size > 1 && !node.arguments[1].hash_type?
+        end
       end
     end
   end

data/lib/rubocop/cop/performance/string_include.rb

@@ -6,6 +6,8 @@ module RuboCop
       # This cop identifies unnecessary use of a regex where
       # `String#include?` would suffice.
       #
+      # This cop's offenses are not safe to auto-correct if a receiver is nil.
+      #
       # @example
       #   # bad
       #   'abc'.match?(/ab/)

data/lib/rubocop/performance/version.rb

@@ -3,7 +3,7 @@
 module RuboCop
   module Performance
     module Version
-      STRING = '1.7.0'
+      STRING = '1.7.1'
     end
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rubocop-performance
 version: !ruby/object:Gem::Version
-  version: 1.7.0
+  version: 1.7.1
 platform: ruby
 authors:
 - Bozhidar Batsov
@@ -10,7 +10,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-07-07 00:00:00.000000000 Z
+date: 2020-07-17 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop