rubocop-performance 1.4.1 → 1.6.1

data/lib/rubocop/cop/performance/reverse_each.rb

@@ -18,7 +18,7 @@ module RuboCop
         MSG = 'Use `reverse_each` instead of `reverse.each`.'
         UNDERSCORE = '_'
 
-        def_node_matcher :reverse_each?, <<-MATCHER
+        def_node_matcher :reverse_each?, <<~MATCHER
           (send $(send _ :reverse) :each)
         MATCHER
 
@@ -34,7 +34,8 @@ module RuboCop
         end
 
         def autocorrect(node)
-          ->(corrector) { corrector.replace(node.loc.dot, UNDERSCORE) }
+          range = range_between(node.loc.dot.begin_pos, node.loc.selector.begin_pos)
+          ->(corrector) { corrector.replace(range, UNDERSCORE) }
         end
       end
     end

data/lib/rubocop/cop/performance/size.rb

@@ -60,7 +60,7 @@ module RuboCop
 
           _, constant = *node.receiver
 
-          constant == :Array || node.method_name == :to_a
+          constant == :Array || node.method?(:to_a)
         end
 
         def hash?(node)
@@ -69,7 +69,7 @@ module RuboCop
 
           _, constant = *node.receiver
 
-          constant == :Hash || node.method_name == :to_h
+          constant == :Hash || node.method?(:to_h)
         end
       end
     end

data/lib/rubocop/cop/performance/start_with.rb

@@ -3,47 +3,67 @@
 module RuboCop
   module Cop
     module Performance
-      # This cop identifies unnecessary use of a regex where
-      # `String#start_with?` would suffice.
+      # This cop identifies unnecessary use of a regex where `String#start_with?` would suffice.
+      #
+      # This cop has `SafeMultiline` configuration option that `true` by default because
+      # `^start` is unsafe as it will behave incompatible with `start_with?`
+      # for receiver is multiline string.
       #
       # @example
       #   # bad
       #   'abc'.match?(/\Aab/)
+      #   /\Aab/.match?('abc')
       #   'abc' =~ /\Aab/
+      #   /\Aab/ =~ 'abc'
       #   'abc'.match(/\Aab/)
+      #   /\Aab/.match('abc')
       #
       #   # good
       #   'abc'.start_with?('ab')
+      #
+      # @example SafeMultiline: true (default)
+      #
+      #   # good
+      #   'abc'.match?(/^ab/)
+      #   /^ab/.match?('abc')
+      #   'abc' =~ /^ab/
+      #   /^ab/ =~ 'abc'
+      #   'abc'.match(/^ab/)
+      #   /^ab/.match('abc')
+      #
+      # @example SafeMultiline: false
+      #
+      #   # bad
+      #   'abc'.match?(/^ab/)
+      #   /^ab/.match?('abc')
+      #   'abc' =~ /^ab/
+      #   /^ab/ =~ 'abc'
+      #   'abc'.match(/^ab/)
+      #   /^ab/.match('abc')
+      #
       class StartWith < Cop
+        include RegexpMetacharacter
+
         MSG = 'Use `String#start_with?` instead of a regex match anchored to ' \
               'the beginning of the string.'
-        SINGLE_QUOTE = "'"
 
-        def_node_matcher :redundant_regex?, <<-PATTERN
+        def_node_matcher :redundant_regex?, <<~PATTERN
           {(send $!nil? {:match :=~ :match?} (regexp (str $#literal_at_start?) (regopt)))
-           (send (regexp (str $#literal_at_start?) (regopt)) {:match :=~} $_)}
+           (send (regexp (str $#literal_at_start?) (regopt)) {:match :match?} $_)
+           (match-with-lvasgn (regexp (str $#literal_at_start?) (regopt)) $_)}
         PATTERN
 
-        def literal_at_start?(regex_str)
-          # is this regexp 'literal' in the sense of only matching literal
-          # chars, rather than using metachars like `.` and `*` and so on?
-          # also, is it anchored at the start of the string?
-          # (tricky: \s, \d, and so on are metacharacters, but other characters
-          #  escaped with a slash are just literals. LITERAL_REGEX takes all
-          #  that into account.)
-          regex_str =~ /\A\\A(?:#{LITERAL_REGEX})+\z/
-        end
-
         def on_send(node)
           return unless redundant_regex?(node)
 
           add_offense(node)
         end
+        alias on_match_with_lvasgn on_send
 
         def autocorrect(node)
           redundant_regex?(node) do |receiver, regex_str|
             receiver, regex_str = regex_str, receiver if receiver.is_a?(String)
-            regex_str = regex_str[2..-1] # drop \A anchor
+            regex_str = drop_start_metacharacter(regex_str)
             regex_str = interpret_string_escapes(regex_str)
 
             lambda do |corrector|

data/lib/rubocop/cop/performance/string_replacement.rb

@@ -26,9 +26,8 @@ module RuboCop
         DELETE = 'delete'
         TR = 'tr'
         BANG = '!'
-        SINGLE_QUOTE = "'"
 
-        def_node_matcher :string_replacement?, <<-PATTERN
+        def_node_matcher :string_replacement?, <<~PATTERN
           (send _ {:gsub :gsub!}
                     ${regexp str (send (const nil? :Regexp) {:new :compile} _)}
                     $str)
@@ -48,9 +47,7 @@ module RuboCop
           first_source, = first_source(first_param)
           second_source, = *second_param
 
-          unless first_param.str_type?
-            first_source = interpret_string_escapes(first_source)
-          end
+          first_source = interpret_string_escapes(first_source) unless first_param.str_type?
 
           replacement_method =
             replacement_method(node, first_source, second_source)
@@ -67,9 +64,7 @@ module RuboCop
                                 to_string_literal(first))
             end
 
-            if second.empty? && first.length == 1
-              remove_second_param(corrector, node, first_param)
-            end
+            remove_second_param(corrector, node, first_param) if second.empty? && first.length == 1
           end
         end
 
@@ -99,9 +94,7 @@ module RuboCop
 
         def offense(node, first_param, second_param)
           first_source, = first_source(first_param)
-          unless first_param.str_type?
-            first_source = interpret_string_escapes(first_source)
-          end
+          first_source = interpret_string_escapes(first_source) unless first_param.str_type?
           second_source, = *second_param
           message = message(node, first_source, second_source)
 

data/lib/rubocop/cop/performance/times_map.rb

@@ -61,7 +61,7 @@ module RuboCop
                  map_or_collect: map_or_collect.method_name)
         end
 
-        def_node_matcher :times_map_call, <<-PATTERN
+        def_node_matcher :times_map_call, <<~PATTERN
           {(block $(send (send $!nil? :times) {:map :collect}) ...)
            $(send (send $!nil? :times) {:map :collect} (block_pass ...))}
         PATTERN

data/lib/rubocop/cop/performance/unfreeze_string.rb

@@ -7,7 +7,7 @@ module RuboCop
       # literal instead of `String#dup` and `String.new`.
       # Unary plus operator is faster than `String#dup`.
       #
-      # Note: `String.new` (without operator) is not exactly the same as `+''`.
+      # NOTE: `String.new` (without operator) is not exactly the same as `+''`.
       # These differ in encoding. `String.new.encoding` is always `ASCII-8BIT`.
       # However, `(+'').encoding` is the same as script encoding(e.g. `UTF-8`).
       # So, if you expect `ASCII-8BIT` encoding, disable this cop.
@@ -24,17 +24,13 @@ module RuboCop
       #   +'something'
       #   +''
       class UnfreezeString < Cop
-        extend TargetRubyVersion
-
-        minimum_target_ruby_version 2.3
-
         MSG = 'Use unary plus to get an unfrozen string literal.'
 
-        def_node_matcher :dup_string?, <<-PATTERN
+        def_node_matcher :dup_string?, <<~PATTERN
           (send {str dstr} :dup)
         PATTERN
 
-        def_node_matcher :string_new?, <<-PATTERN
+        def_node_matcher :string_new?, <<~PATTERN
           {
             (send (const nil? :String) :new {str dstr})
             (send (const nil? :String) :new)

data/lib/rubocop/cop/performance/uri_default_parser.rb

@@ -17,7 +17,7 @@ module RuboCop
         MSG = 'Use `%<double_colon>sURI::DEFAULT_PARSER` instead of ' \
               '`%<double_colon>sURI::Parser.new`.'
 
-        def_node_matcher :uri_parser_new?, <<-PATTERN
+        def_node_matcher :uri_parser_new?, <<~PATTERN
           (send
             (const
               (const ${nil? cbase} :URI) :Parser) :new)

data/lib/rubocop/cop/performance_cops.rb

@@ -1,10 +1,15 @@
 # frozen_string_literal: true
 
+require_relative 'mixin/regexp_metacharacter'
+
+require_relative 'performance/bind_call'
 require_relative 'performance/caller'
 require_relative 'performance/case_when_splat'
 require_relative 'performance/casecmp'
 require_relative 'performance/compare_with_block'
 require_relative 'performance/count'
+require_relative 'performance/delete_prefix'
+require_relative 'performance/delete_suffix'
 require_relative 'performance/detect'
 require_relative 'performance/double_start_end_with'
 require_relative 'performance/end_with'

data/lib/rubocop/performance/inject.rb

@@ -8,7 +8,7 @@ module RuboCop
       def self.defaults!
         path = CONFIG_DEFAULT.to_s
         hash = ConfigLoader.send(:load_yaml_configuration, path)
-        config = Config.new(hash, path)
+        config = Config.new(hash, path).tap(&:make_excludes_absolute)
         puts "configuration from #{path}" if ConfigLoader.debug?
         config = ConfigLoader.merge_with_default(config, path)
         ConfigLoader.instance_variable_set(:@default_configuration, config)

data/lib/rubocop/performance/version.rb

@@ -3,7 +3,7 @@
 module RuboCop
   module Performance
     module Version
-      STRING = '1.4.1'
+      STRING = '1.6.1'
     end
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rubocop-performance
 version: !ruby/object:Gem::Version
-  version: 1.4.1
+  version: 1.6.1
 platform: ruby
 authors:
 - Bozhidar Batsov
@@ -10,7 +10,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-07-29 00:00:00.000000000 Z
+date: 2020-06-05 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop
@@ -40,9 +40,9 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
-description: |2
-      A collection of RuboCop cops to check for performance optimizations
-      in Ruby code.
+description: |
+  A collection of RuboCop cops to check for performance optimizations
+  in Ruby code.
 email: rubocop@googlegroups.com
 executables: []
 extensions: []
@@ -54,12 +54,16 @@ files:
 - README.md
 - config/default.yml
 - lib/rubocop-performance.rb
+- lib/rubocop/cop/mixin/regexp_metacharacter.rb
+- lib/rubocop/cop/performance/bind_call.rb
 - lib/rubocop/cop/performance/caller.rb
 - lib/rubocop/cop/performance/case_when_splat.rb
 - lib/rubocop/cop/performance/casecmp.rb
 - lib/rubocop/cop/performance/chain_array_allocation.rb
 - lib/rubocop/cop/performance/compare_with_block.rb
 - lib/rubocop/cop/performance/count.rb
+- lib/rubocop/cop/performance/delete_prefix.rb
+- lib/rubocop/cop/performance/delete_suffix.rb
 - lib/rubocop/cop/performance/detect.rb
 - lib/rubocop/cop/performance/double_start_end_with.rb
 - lib/rubocop/cop/performance/end_with.rb
@@ -87,10 +91,10 @@ homepage: https://github.com/rubocop-hq/rubocop-performance
 licenses:
 - MIT
 metadata:
-  homepage_uri: https://docs.rubocop.org/projects/performance
+  homepage_uri: https://docs.rubocop.org/rubocop-performance/
   changelog_uri: https://github.com/rubocop-hq/rubocop-performance/blob/master/CHANGELOG.md
   source_code_uri: https://github.com/rubocop-hq/rubocop-performance/
-  documentation_uri: https://docs.rubocop.org/projects/performance
+  documentation_uri: https://docs.rubocop.org/rubocop-performance/
   bug_tracker_uri: https://github.com/rubocop-hq/rubocop-performance/issues
 post_install_message: 
 rdoc_options: []
@@ -100,14 +104,14 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: 2.3.0
+      version: 2.4.0
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.4
+rubygems_version: 3.1.3
 signing_key: 
 specification_version: 4
 summary: Automatic performance checking tool for Ruby code.