rubocop-performance 1.26.0 → 1.27.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 65d9d36b4437bd92d054b743117d77b7fdb4f5391c012ae656b01dcd2ca2fa51
-  data.tar.gz: 8678a0f7fac0c650fa4c51a25e8c3e06b049c67b5fb369719fe7eee2c04a8820
+  metadata.gz: 6494a135c3883af7e141b3dac6baf9e70f6e3d4389c0bb4970110b09693d979a
+  data.tar.gz: 46f88529d27b31e92492bd9d12ea117771a8c8adedcf275db9e19e91d3b58839
 SHA512:
-  metadata.gz: d0efc235b893328de9dfb9a58a26bb5d4838b9919a2b0a06e77f1f34ad1b53d39433793b1dd24dc04d34e79047aa0ff5e4863d407a48160da6c35fc45d91906f
-  data.tar.gz: 4aafa85fa2c326f532d16b338f55df55e67d9d52ebbd52196b53ae3520e7b30fdce7656081f716c91f6fe6ec3833915a6ac1bc0838d2c3016bfde6cb133689c0
+  metadata.gz: fea19be56b1332f4485a443296aaa1e3e3bf32d335aa7490019de1f564edfdf50521a811df5d3856801e6258eb9b24e8d3b930786c4f3af5c20fc4a4449b82a5
+  data.tar.gz: 41ae92842e1372e7c546d837759cc60489ca11df8889384a010580ce4ce4666cf1546e19f1c7b2ab275017d88c406d25dbe2d61cb5edf614201398e0f2a7d1cf

data/LICENSE.txt

@@ -1,4 +1,4 @@
-Copyright (c) 2012-25 Bozhidar Batsov
+Copyright (c) 2012-26 Bozhidar Batsov
 
 Permission is hereby granted, free of charge, to any person obtaining
 a copy of this software and associated documentation files (the

data/config/default.yml

@@ -22,8 +22,9 @@ Performance/ArraySemiInfiniteRangeSlice:
 
 Performance/BigDecimalWithNumericArgument:
   Description: 'Convert numeric literal to string and pass it to `BigDecimal`.'
-  Enabled: 'pending'
+  Enabled: false
   VersionAdded: '1.7'
+  VersionChanged: '1.26'
 
 Performance/BindCall:
   Description: 'Use `bind_call(obj, args, ...)` instead of `bind(obj).call(args, ...)`.'

data/lib/rubocop/cop/mixin.rb

@@ -0,0 +1,10 @@
+# frozen_string_literal: true
+
+module RuboCop
+  module Cop
+    # Autoloads mixin modules included by cops. Mixins are autoloaded to reduce the number of requires
+    # because they're used only when the relevant cop class is loaded.
+    autoload :RegexpMetacharacter, "#{__dir__}/mixin/regexp_metacharacter"
+    autoload :SortBlock, "#{__dir__}/mixin/sort_block"
+  end
+end

data/lib/rubocop/cop/performance/array_semi_infinite_range_slice.rb

@@ -39,7 +39,7 @@ module RuboCop
         RESTRICT_ON_SEND = SLICE_METHODS
 
         def_node_matcher :endless_range_slice?, <<~PATTERN
-          (call $!{str dstr xstr} $%SLICE_METHODS $#endless_range?)
+          (call $!any_str $%SLICE_METHODS $#endless_range?)
         PATTERN
 
         def_node_matcher :endless_range?, <<~PATTERN

data/lib/rubocop/cop/performance/big_decimal_with_numeric_argument.rb

@@ -9,6 +9,11 @@ module RuboCop
       # Also identifies places where an integer string argument to BigDecimal should be converted to
       # an integer. Initializing from Integer is faster than from String for BigDecimal.
       #
+      # NOTE: This cop is disabled by default because the performance of initializing with a String
+      # and Number differ between versions. Additionally, performance depends on the size of the Number,
+      # and if it is an Integer or a Float. Since this is very specific to `bigdecimal` internals,
+      # suggestions from this cop are not unlikely to result in code that performs worse than before.
+      #
       # @example
       #   # bad
       #   BigDecimal(1.2, 3, exception: true)
@@ -44,7 +49,7 @@ module RuboCop
           (send [!nil? ${float_type? str_type?}] :to_d ...)
         PATTERN
 
-        # rubocop:disable Metrics/AbcSize, Metrics/CyclomaticComplexity, Metrics/PerceivedComplexity, Metrics/MethodLength
+        # rubocop:disable-next Metrics/AbcSize, Metrics/CyclomaticComplexity, Metrics/PerceivedComplexity, Metrics/MethodLength
         def on_send(node)
           if (numeric = big_decimal_with_numeric_argument(node))
             if numeric.numeric_type?
@@ -70,7 +75,6 @@ module RuboCop
             end
           end
         end
-        # rubocop:enable Metrics/AbcSize, Metrics/CyclomaticComplexity, Metrics/PerceivedComplexity, Metrics/MethodLength
       end
     end
   end

data/lib/rubocop/cop/performance/chain_array_allocation.rb

@@ -32,9 +32,9 @@ module RuboCop
 
         # These methods ALWAYS return a new array
         # after they're called it's safe to mutate the resulting array
-        ALWAYS_RETURNS_NEW_ARRAY = %i[* + - collect compact drop
-                                      drop_while flatten map reject
-                                      reverse rotate select shuffle sort
+        ALWAYS_RETURNS_NEW_ARRAY = %i[* + - collect collect_concat compact drop
+                                      drop_while filter_map flat_map flatten map
+                                      reject reverse rotate select shuffle sort
                                       take take_while transpose uniq
                                       values_at |].to_set.freeze
 

data/lib/rubocop/cop/performance/collection_literal_in_loop.rb

@@ -109,7 +109,7 @@ module RuboCop
 
         # Since Ruby 3.4, simple arguments to Array#include? are optimized.
         # See https://github.com/ruby/ruby/pull/12123 for more details.
-        # rubocop:disable Metrics/CyclomaticComplexity
+        # rubocop:disable-next Metrics/CyclomaticComplexity
         def optimized_array_include?(node, method, arguments)
           return false unless target_ruby_version >= 3.4 && node.array_type? && method == :include?
           # Disallow include?(1, 2)
@@ -125,7 +125,6 @@ module RuboCop
           end
           ARRAY_INCLUDE_OPTIMIZED_TYPES.include?(arg.type)
         end
-        # rubocop:enable Metrics/CyclomaticComplexity
 
         def nonmutable_method_of_array_or_hash?(node, method)
           (node.array_type? && ARRAY_METHODS.include?(method)) ||

data/lib/rubocop/cop/performance/compare_with_block.rb

@@ -87,7 +87,7 @@ module RuboCop
           true
         end
 
-        # rubocop:disable Metrics/MethodLength
+        # rubocop:disable-next Metrics/MethodLength
         def message(send, method, var_a, var_b, args)
           compare_method     = send.method_name
           replacement_method = REPLACEMENT[compare_method]
@@ -109,7 +109,6 @@ module RuboCop
                       str_a: str_a,
                       str_b: str_b)
         end
-        # rubocop:enable Metrics/MethodLength
 
         def compare_range(send, node)
           range_between(send.loc.selector.begin_pos, node.loc.end.end_pos)

data/lib/rubocop/cop/performance/delete_prefix.rb

@@ -67,7 +67,7 @@ module RuboCop
           (call $!nil? ${:gsub :gsub! :sub :sub!} (regexp (str $#literal_at_start?) (regopt)) (str $_))
         PATTERN
 
-        # rubocop:disable Metrics/AbcSize
+        # rubocop:disable-next Metrics/AbcSize
         def on_send(node)
           return unless (receiver, bad_method, regexp_str, replace_string = delete_prefix_candidate?(node))
           return unless replace_string.empty?
@@ -86,7 +86,6 @@ module RuboCop
             corrector.replace(node, new_code)
           end
         end
-        # rubocop:enable Metrics/AbcSize
         alias on_csend on_send
       end
     end

data/lib/rubocop/cop/performance/delete_suffix.rb

@@ -67,7 +67,7 @@ module RuboCop
           (call $!nil? ${:gsub :gsub! :sub :sub!} (regexp (str $#literal_at_end?) (regopt)) (str $_))
         PATTERN
 
-        # rubocop:disable Metrics/AbcSize
+        # rubocop:disable-next Metrics/AbcSize
         def on_send(node)
           return unless (receiver, bad_method, regexp_str, replace_string = delete_suffix_candidate?(node))
           return unless replace_string.empty?
@@ -86,7 +86,6 @@ module RuboCop
             corrector.replace(node, new_code)
           end
         end
-        # rubocop:enable Metrics/AbcSize
         alias on_csend on_send
       end
     end

data/lib/rubocop/cop/performance/map_compact.rb

@@ -69,7 +69,7 @@ module RuboCop
         def remove_compact_method(corrector, map_node, compact_node, chained_method)
           compact_method_range = compact_node.loc.selector
 
-          if compact_node.multiline? && chained_method&.loc.respond_to?(:selector) && use_dot?(chained_method) &&
+          if compact_node.multiline? && chained_method&.loc?(:selector) && use_dot?(chained_method) &&
              !map_method_and_compact_method_on_same_line?(map_node, compact_node) &&
              !invoke_method_after_map_compact_on_same_line?(compact_node, chained_method)
             compact_method_range = compact_method_with_final_newline_range(compact_method_range)

data/lib/rubocop/cop/performance/map_method_chain.rb

@@ -68,7 +68,7 @@ module RuboCop
 
         private
 
-        # rubocop:disable Metrics/CyclomaticComplexity
+        # rubocop:disable-next Metrics/CyclomaticComplexity
         def find_begin_of_chained_map_method(node, map_args)
           return unless (chained_map_method = node.receiver)
           return if !chained_map_method.call_type? || !RESTRICT_ON_SEND.include?(chained_map_method.method_name)
@@ -82,7 +82,6 @@ module RuboCop
 
           find_begin_of_chained_map_method(chained_map_method, map_args)
         end
-        # rubocop:enable Metrics/CyclomaticComplexity
       end
     end
   end

data/lib/rubocop/cop/performance/redundant_sort_block.rb

@@ -18,6 +18,7 @@ module RuboCop
 
         MSG = 'Use `sort` without block.'
 
+        # rubocop:disable-next InternalAffairs/ItblockHandler -- `it` block accepts only a single block parameter.
         def on_block(node)
           return unless (send, var_a, var_b, body = sort_with_block?(node))
 

data/lib/rubocop/cop/performance/redundant_string_chars.rb

@@ -54,6 +54,7 @@ module RuboCop
         def on_send(node)
           return unless (receiver, method, args = redundant_chars_call?(node))
           return if method == :last && !args.empty?
+          return if args.count == 2
 
           range = offense_range(receiver, node)
           message = build_message(method, args)

data/lib/rubocop/cop/performance/regexp_match.rb

@@ -81,7 +81,7 @@ module RuboCop
         # Constants are included in this list because it is unlikely that
         # someone will store `nil` as a constant and then use it for comparison
         TYPES_IMPLEMENTING_MATCH = %i[const regexp str sym].freeze
-        MSG = 'Use `match?` instead of `%<current>s` when `MatchData` is not used.'
+        MSG = 'Use `%<negation>smatch?` instead of `%<current>s` when `MatchData` is not used.'
 
         def_node_matcher :match_method?, <<~PATTERN
           {
@@ -175,7 +175,9 @@ module RuboCop
         end
 
         def message(node)
-          format(MSG, current: node.loc.selector.source)
+          negation = ('!' if node.send_type? && node.method?(:!~))
+
+          format(MSG, negation: negation, current: node.loc.selector.source)
         end
 
         def last_match_used?(match_node)

data/lib/rubocop/cop/performance/sort_reverse.rb

@@ -19,6 +19,7 @@ module RuboCop
 
         MSG = 'Use `%<prefer>s` instead.'
 
+        # rubocop:disable-next InternalAffairs/ItblockHandler -- `it` block accepts only a single block parameter.
         def on_block(node)
           sort_with_block?(node) do |send, var_a, var_b, body|
             replaceable_body?(body, var_b, var_a) do

data/lib/rubocop/cop/performance/squeeze.rb

@@ -35,7 +35,7 @@ module RuboCop
             (str $_))
         PATTERN
 
-        # rubocop:disable Metrics/AbcSize
+        # rubocop:disable-next Metrics/AbcSize
         def on_send(node)
           squeeze_candidate?(node) do |receiver, bad_method, regexp_str, replace_str|
             regexp_str = regexp_str[0..-2] # delete '+' from the end
@@ -57,7 +57,6 @@ module RuboCop
             end
           end
         end
-        # rubocop:enable Metrics/AbcSize
         alias on_csend on_send
 
         private

data/lib/rubocop/cop/performance/string_include.rb

@@ -33,7 +33,7 @@ module RuboCop
            (send (regexp (str $#literal?) (regopt)) :=~ $_)}
         PATTERN
 
-        # rubocop:disable Metrics/AbcSize
+        # rubocop:disable-next Metrics/AbcSize
         def on_send(node)
           return unless (receiver, regex_str = redundant_regex?(node))
 
@@ -50,7 +50,6 @@ module RuboCop
             corrector.replace(node, new_source)
           end
         end
-        # rubocop:enable Metrics/AbcSize
         alias on_csend on_send
         alias on_match_with_lvasgn on_send
 

data/lib/rubocop/cop/performance.rb

@@ -0,0 +1,66 @@
+# frozen_string_literal: true
+
+require_relative 'mixin'
+
+module RuboCop
+  module Cop
+    # Cops for the `Performance` department. The department's cops are registered for lazy loading
+    # and their files are loaded on demand.
+    module Performance
+      extend LazyLoader
+
+      register_cop :AncestorsInclude, "#{__dir__}/performance/ancestors_include"
+      register_cop :ArraySemiInfiniteRangeSlice, "#{__dir__}/performance/array_semi_infinite_range_slice"
+      register_cop :BigDecimalWithNumericArgument, "#{__dir__}/performance/big_decimal_with_numeric_argument"
+      register_cop :BindCall, "#{__dir__}/performance/bind_call"
+      register_cop :BlockGivenWithExplicitBlock, "#{__dir__}/performance/block_given_with_explicit_block"
+      register_cop :Caller, "#{__dir__}/performance/caller"
+      register_cop :CaseWhenSplat, "#{__dir__}/performance/case_when_splat"
+      register_cop :Casecmp, "#{__dir__}/performance/casecmp"
+      register_cop :CollectionLiteralInLoop, "#{__dir__}/performance/collection_literal_in_loop"
+      register_cop :CompareWithBlock, "#{__dir__}/performance/compare_with_block"
+      register_cop :ConcurrentMonotonicTime, "#{__dir__}/performance/concurrent_monotonic_time"
+      register_cop :ConstantRegexp, "#{__dir__}/performance/constant_regexp"
+      register_cop :Count, "#{__dir__}/performance/count"
+      register_cop :DeletePrefix, "#{__dir__}/performance/delete_prefix"
+      register_cop :DeleteSuffix, "#{__dir__}/performance/delete_suffix"
+      register_cop :Detect, "#{__dir__}/performance/detect"
+      register_cop :DoubleStartEndWith, "#{__dir__}/performance/double_start_end_with"
+      register_cop :EndWith, "#{__dir__}/performance/end_with"
+      register_cop :FixedSize, "#{__dir__}/performance/fixed_size"
+      register_cop :FlatMap, "#{__dir__}/performance/flat_map"
+      register_cop :InefficientHashSearch, "#{__dir__}/performance/inefficient_hash_search"
+      register_cop :MapCompact, "#{__dir__}/performance/map_compact"
+      register_cop :MapMethodChain, "#{__dir__}/performance/map_method_chain"
+      register_cop :MethodObjectAsBlock, "#{__dir__}/performance/method_object_as_block"
+      register_cop :OpenStruct, "#{__dir__}/performance/open_struct"
+      register_cop :RangeInclude, "#{__dir__}/performance/range_include"
+      register_cop :IoReadlines, "#{__dir__}/performance/io_readlines"
+      register_cop :RedundantBlockCall, "#{__dir__}/performance/redundant_block_call"
+      register_cop :RedundantEqualityComparisonBlock, "#{__dir__}/performance/redundant_equality_comparison_block"
+      register_cop :RedundantMatch, "#{__dir__}/performance/redundant_match"
+      register_cop :RedundantMerge, "#{__dir__}/performance/redundant_merge"
+      register_cop :RedundantSortBlock, "#{__dir__}/performance/redundant_sort_block"
+      register_cop :RedundantSplitRegexpArgument, "#{__dir__}/performance/redundant_split_regexp_argument"
+      register_cop :RedundantStringChars, "#{__dir__}/performance/redundant_string_chars"
+      register_cop :RegexpMatch, "#{__dir__}/performance/regexp_match"
+      register_cop :ReverseEach, "#{__dir__}/performance/reverse_each"
+      register_cop :ReverseFirst, "#{__dir__}/performance/reverse_first"
+      register_cop :SelectMap, "#{__dir__}/performance/select_map"
+      register_cop :Size, "#{__dir__}/performance/size"
+      register_cop :SortReverse, "#{__dir__}/performance/sort_reverse"
+      register_cop :Squeeze, "#{__dir__}/performance/squeeze"
+      register_cop :StringBytesize, "#{__dir__}/performance/string_bytesize"
+      register_cop :StartWith, "#{__dir__}/performance/start_with"
+      register_cop :StringIdentifierArgument, "#{__dir__}/performance/string_identifier_argument"
+      register_cop :StringInclude, "#{__dir__}/performance/string_include"
+      register_cop :StringReplacement, "#{__dir__}/performance/string_replacement"
+      register_cop :Sum, "#{__dir__}/performance/sum"
+      register_cop :TimesMap, "#{__dir__}/performance/times_map"
+      register_cop :UnfreezeString, "#{__dir__}/performance/unfreeze_string"
+      register_cop :UriDefaultParser, "#{__dir__}/performance/uri_default_parser"
+      register_cop :ChainArrayAllocation, "#{__dir__}/performance/chain_array_allocation"
+      register_cop :ZipWithoutBlock, "#{__dir__}/performance/zip_without_block"
+    end
+  end
+end

data/lib/rubocop/cop/performance_cops.rb

@@ -1,57 +1,6 @@
 # frozen_string_literal: true
 
-require_relative 'mixin/regexp_metacharacter'
-require_relative 'mixin/sort_block'
-
-require_relative 'performance/ancestors_include'
-require_relative 'performance/array_semi_infinite_range_slice'
-require_relative 'performance/big_decimal_with_numeric_argument'
-require_relative 'performance/bind_call'
-require_relative 'performance/block_given_with_explicit_block'
-require_relative 'performance/caller'
-require_relative 'performance/case_when_splat'
-require_relative 'performance/casecmp'
-require_relative 'performance/collection_literal_in_loop'
-require_relative 'performance/compare_with_block'
-require_relative 'performance/concurrent_monotonic_time'
-require_relative 'performance/constant_regexp'
-require_relative 'performance/count'
-require_relative 'performance/delete_prefix'
-require_relative 'performance/delete_suffix'
-require_relative 'performance/detect'
-require_relative 'performance/double_start_end_with'
-require_relative 'performance/end_with'
-require_relative 'performance/fixed_size'
-require_relative 'performance/flat_map'
-require_relative 'performance/inefficient_hash_search'
-require_relative 'performance/map_compact'
-require_relative 'performance/map_method_chain'
-require_relative 'performance/method_object_as_block'
-require_relative 'performance/open_struct'
-require_relative 'performance/range_include'
-require_relative 'performance/io_readlines'
-require_relative 'performance/redundant_block_call'
-require_relative 'performance/redundant_equality_comparison_block'
-require_relative 'performance/redundant_match'
-require_relative 'performance/redundant_merge'
-require_relative 'performance/redundant_sort_block'
-require_relative 'performance/redundant_split_regexp_argument'
-require_relative 'performance/redundant_string_chars'
-require_relative 'performance/regexp_match'
-require_relative 'performance/reverse_each'
-require_relative 'performance/reverse_first'
-require_relative 'performance/select_map'
-require_relative 'performance/size'
-require_relative 'performance/sort_reverse'
-require_relative 'performance/squeeze'
-require_relative 'performance/string_bytesize'
-require_relative 'performance/start_with'
-require_relative 'performance/string_identifier_argument'
-require_relative 'performance/string_include'
-require_relative 'performance/string_replacement'
-require_relative 'performance/sum'
-require_relative 'performance/times_map'
-require_relative 'performance/unfreeze_string'
-require_relative 'performance/uri_default_parser'
-require_relative 'performance/chain_array_allocation'
-require_relative 'performance/zip_without_block'
+# @deprecated This file is deprecated. Cops are registered for lazy loading in
+#   `rubocop/cop/performance`; this file is kept for compatibility with code
+#   that requires it directly.
+require_relative 'performance'

data/lib/rubocop/performance/version.rb

@@ -4,7 +4,7 @@ module RuboCop
   module Performance
     # This module holds the RuboCop Performance version information.
     module Version
-      STRING = '1.26.0'
+      STRING = '1.27.0'
 
       def self.document_version
         STRING.match('\d+\.\d+').to_s

data/lib/rubocop-performance.rb

@@ -5,7 +5,7 @@ require 'rubocop'
 require_relative 'rubocop/performance'
 require_relative 'rubocop/performance/version'
 require_relative 'rubocop/performance/plugin'
-require_relative 'rubocop/cop/performance_cops'
+require_relative 'rubocop/cop/performance'
 
 autocorrect_incompatible_with_block_given_with_explicit_block = Module.new do
   def autocorrect_incompatible_with

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rubocop-performance
 version: !ruby/object:Gem::Version
-  version: 1.26.0
+  version: 1.27.0
 platform: ruby
 authors:
 - Bozhidar Batsov
@@ -31,7 +31,7 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 1.75.0
+        version: 1.89.0
     - - "<"
       - !ruby/object:Gem::Version
         version: '2.0'
@@ -41,7 +41,7 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 1.75.0
+        version: 1.89.0
     - - "<"
       - !ruby/object:Gem::Version
         version: '2.0'
@@ -51,7 +51,7 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 1.44.0
+        version: 1.47.1
     - - "<"
       - !ruby/object:Gem::Version
         version: '2.0'
@@ -61,7 +61,7 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 1.44.0
+        version: 1.47.1
     - - "<"
       - !ruby/object:Gem::Version
         version: '2.0'
@@ -80,8 +80,10 @@ files:
 - config/default.yml
 - config/obsoletion.yml
 - lib/rubocop-performance.rb
+- lib/rubocop/cop/mixin.rb
 - lib/rubocop/cop/mixin/regexp_metacharacter.rb
 - lib/rubocop/cop/mixin/sort_block.rb
+- lib/rubocop/cop/performance.rb
 - lib/rubocop/cop/performance/ancestors_include.rb
 - lib/rubocop/cop/performance/array_semi_infinite_range_slice.rb
 - lib/rubocop/cop/performance/big_decimal_with_numeric_argument.rb
@@ -145,7 +147,7 @@ metadata:
   homepage_uri: https://docs.rubocop.org/rubocop-performance/
   changelog_uri: https://github.com/rubocop/rubocop-performance/blob/master/CHANGELOG.md
   source_code_uri: https://github.com/rubocop/rubocop-performance/
-  documentation_uri: https://docs.rubocop.org/rubocop-performance/1.26/
+  documentation_uri: https://docs.rubocop.org/rubocop-performance/1.27/
   bug_tracker_uri: https://github.com/rubocop/rubocop-performance/issues
   rubygems_mfa_required: 'true'
   default_lint_roller_plugin: RuboCop::Performance::Plugin
@@ -163,7 +165,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.6.9
+rubygems_version: 4.0.3
 specification_version: 4
 summary: Automatic performance checking tool for Ruby code.
 test_files: []