rubocop-performance 1.25.0 → 1.26.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: c195b128694fb4d65674a0d361a04e6db9c10671a2d04c59f714b92abf7a7192
-  data.tar.gz: 4e487319e1b81dc1f9aa515960f2b0546cfdf73483f8baac14de35049086a97a
+  metadata.gz: c834e1a3af5e4cc42c7edd0dfe6bdb4e4cfc6e665e2235277f46b15cdb9ab720
+  data.tar.gz: a1e5d0efde3b42af4f7d6293e5595ca30df2d24d7cfb765d6ec87932a331d2ef
 SHA512:
-  metadata.gz: db0f96d9a383aca44da3760e9a22a54aaa17d59f6e24fb4de891954120f57ce38487fae8ce3436f0082d49b414f1c3e2aeea63bf5802e6bff43eea42760a11d9
-  data.tar.gz: 2e351cffc40a87a928472c300a11bd6fe7e4959dbf30d94aadd2246c71e9ab873bcf54971201fe62c2824c2982c381810ea0d8c9e228f09d0f0dbd0ed3cd8e2f
+  metadata.gz: 127936d00884ae6749b2b5511466c09dd696662d02bd34b581582e71e3966f9228f4d8e8ff880db96ff7267023dbfd87a5121888e95c41afea930ee98f6d30c3
+  data.tar.gz: b6cc50f7db2771e41c6700238fe175a5273916ab7da2c3ab487648aa801d04914afa3f0564f67205d2eba436dc694d4cb011fee72e878dffc2c202bcf8a1f011

data/README.md

@@ -84,7 +84,7 @@ You can read a lot more about RuboCop Performance in its [official docs](https:/
 
 ## Compatibility
 
-RuboCop Performance complies with the RuboCop core compatibility.
+RuboCop Performance is compatible with RuboCop core.
 
 See the [compatibility documentation](https://docs.rubocop.org/rubocop/compatibility.html) for further details.
 

data/config/default.yml

@@ -22,8 +22,9 @@ Performance/ArraySemiInfiniteRangeSlice:
 
 Performance/BigDecimalWithNumericArgument:
   Description: 'Convert numeric literal to string and pass it to `BigDecimal`.'
-  Enabled: 'pending'
+  Enabled: false
   VersionAdded: '1.7'
+  VersionChanged: '1.26'
 
 Performance/BindCall:
   Description: 'Use `bind_call(obj, args, ...)` instead of `bind(obj).call(args, ...)`.'
@@ -67,7 +68,6 @@ Performance/ChainArrayAllocation:
   Description: >-
                   Instead of chaining array methods that allocate new arrays, mutate an
                   existing array.
-  Reference: 'https://twitter.com/schneems/status/1034123879978029057'
   Enabled: false
   VersionAdded: '0.59'
 
@@ -187,14 +187,14 @@ Performance/InefficientHashSearch:
 
 Performance/IoReadlines:
   Description: 'Use `IO.each_line` (`IO#each_line`) instead of `IO.readlines` (`IO#readlines`).'
-  Reference: 'https://docs.gitlab.com/ee/development/performance.html#reading-from-files-and-other-data-sources'
+  Reference: 'https://docs.gitlab.com/development/performance/#reading-from-files-and-other-data-sources'
   Enabled: false
   VersionAdded: '1.7'
 
 Performance/MapCompact:
   Description: 'Use `filter_map` instead of `collection.map(&:do_something).compact`.'
   Enabled: pending
-  SafeAutoCorrect: false
+  Safe: false
   VersionAdded: '1.11'
 
 Performance/MapMethodChain:
@@ -356,7 +356,7 @@ Performance/StringReplacement:
 Performance/Sum:
   Description: 'Use `sum` instead of a custom array summation.'
   SafeAutoCorrect: false
-  Reference: 'https://blog.bigbinary.com/2016/11/02/ruby-2-4-introduces-enumerable-sum.html'
+  Reference: 'https://www.bigbinary.com/blog/ruby-2-4-introduces-enumerable-sum'
   Enabled: 'pending'
   VersionAdded: '1.8'
   VersionChanged: '1.13'

data/lib/rubocop/cop/performance/array_semi_infinite_range_slice.rb

@@ -39,7 +39,7 @@ module RuboCop
         RESTRICT_ON_SEND = SLICE_METHODS
 
         def_node_matcher :endless_range_slice?, <<~PATTERN
-          (call $!{str dstr xstr} $%SLICE_METHODS $#endless_range?)
+          (call $!any_str $%SLICE_METHODS $#endless_range?)
         PATTERN
 
         def_node_matcher :endless_range?, <<~PATTERN

data/lib/rubocop/cop/performance/big_decimal_with_numeric_argument.rb

@@ -9,6 +9,11 @@ module RuboCop
       # Also identifies places where an integer string argument to BigDecimal should be converted to
       # an integer. Initializing from Integer is faster than from String for BigDecimal.
       #
+      # NOTE: This cop is disabled by default because the performance of initializing with a String
+      # and Number differ between versions. Additionally, performance depends on the size of the Number,
+      # and if it is an Integer or a Float. Since this is very specific to `bigdecimal` internals,
+      # suggestions from this cop are not unlikely to result in code that performs worse than before.
+      #
       # @example
       #   # bad
       #   BigDecimal(1.2, 3, exception: true)

data/lib/rubocop/cop/performance/block_given_with_explicit_block.rb

@@ -36,7 +36,7 @@ module RuboCop
         def_node_matcher :reassigns_block_arg?, '`(lvasgn %1 ...)'
 
         def on_send(node)
-          def_node = node.each_ancestor(:def, :defs).first
+          def_node = node.each_ancestor(:any_def).first
           return unless def_node
 
           block_arg = def_node.arguments.find(&:blockarg_type?)
@@ -52,7 +52,7 @@ module RuboCop
         end
 
         def self.autocorrect_incompatible_with
-          [Lint::UnusedMethodArgument]
+          [Lint::UnusedMethodArgument, Naming::BlockForwarding]
         end
       end
     end

data/lib/rubocop/cop/performance/count.rb

@@ -81,13 +81,15 @@ module RuboCop
 
           range = source_starting_at(node) { |n| n.loc.dot.begin_pos }
 
-          corrector.remove(range)
+          corrector.remove(range_with_surrounding_space(range, side: :left))
           corrector.replace(selector_loc, 'count')
           negate_reject(corrector, node) if selector == :reject
         end
 
         def eligible_node?(node)
-          !(node.parent && node.parent.block_type?)
+          return false if node.parent&.block_type?
+
+          node.receiver.call_type? || node.receiver.body
         end
 
         def source_starting_at(node)

data/lib/rubocop/cop/performance/double_start_end_with.rb

@@ -3,9 +3,9 @@
 module RuboCop
   module Cop
     module Performance
-      # Checks for double `#start_with?` or `#end_with?` calls
-      # separated by `||`. In some cases such calls can be replaced
-      # with an single `#start_with?`/`#end_with?` call.
+      # Checks for consecutive `#start_with?` or `#end_with?` calls.
+      # These methods accept multiple arguments, so in some cases like when
+      # they are separated by `||`, they can be combined into a single method call.
       #
       # `IncludeActiveSupportAliases` configuration option is used to check for
       # `starts_with?` and `ends_with?`. These methods are defined by Active Support.
@@ -14,11 +14,13 @@ module RuboCop
       #   # bad
       #   str.start_with?("a") || str.start_with?(Some::CONST)
       #   str.start_with?("a", "b") || str.start_with?("c")
+      #   !str.start_with?(foo) && !str.start_with?(bar)
       #   str.end_with?(var1) || str.end_with?(var2)
       #
       #   # good
       #   str.start_with?("a", Some::CONST)
       #   str.start_with?("a", "b", "c")
+      #   !str.start_with?(foo, bar)
       #   str.end_with?(var1, var2)
       #
       # @example IncludeActiveSupportAliases: false (default)
@@ -43,20 +45,33 @@ module RuboCop
 
         MSG = 'Use `%<replacement>s` instead of `%<original_code>s`.'
 
+        METHODS = %i[start_with? end_with?].to_set
+        METHODS_WITH_ACTIVE_SUPPORT = %i[start_with? starts_with? end_with? ends_with?].to_set
+
         def on_or(node)
-          receiver, method, first_call_args, second_call_args = process_source(node)
+          two_start_end_with_calls(node, methods_to_check: methods) do |*matched|
+            check(node, *matched)
+          end
+        end
+
+        def on_and(node)
+          two_start_end_with_calls_negated(node, methods_to_check: methods) do |*matched|
+            check(node, *matched)
+          end
+        end
 
+        private
+
+        def check(node, receiver, method, first_call_args, second_call_args)
           return unless receiver && second_call_args.all?(&:pure?)
 
           combined_args = combine_args(first_call_args, second_call_args)
 
-          add_offense(node, message: message(node, receiver, first_call_args, method, combined_args)) do |corrector|
+          add_offense(node, message: message(node, receiver, method, combined_args)) do |corrector|
             autocorrect(corrector, first_call_args, second_call_args, combined_args)
           end
         end
 
-        private
-
         def autocorrect(corrector, first_call_args, second_call_args, combined_args)
           first_argument = first_call_args.first.source_range
           last_argument = second_call_args.last.source_range
@@ -65,17 +80,20 @@ module RuboCop
           corrector.replace(range, combined_args)
         end
 
-        def process_source(node)
+        def methods
           if check_for_active_support_aliases?
-            check_with_active_support_aliases(node)
+            METHODS_WITH_ACTIVE_SUPPORT
           else
-            two_start_end_with_calls(node)
+            METHODS
           end
         end
 
-        def message(node, receiver, first_call_args, method, combined_args)
-          dot = first_call_args.first.parent.send_type? ? '.' : '&.'
-          replacement = "#{receiver.source}#{dot}#{method}(#{combined_args})"
+        def message(node, receiver, method, combined_args)
+          parent = receiver.parent
+          grandparent = parent.parent
+          dot = parent.send_type? ? '.' : '&.'
+          bang = grandparent.send_type? && grandparent.prefix_bang? ? '!' : ''
+          replacement = "#{bang}#{receiver.source}#{dot}#{method}(#{combined_args})"
           format(MSG, replacement: replacement, original_code: node.source)
         end
 
@@ -89,16 +107,14 @@ module RuboCop
 
         def_node_matcher :two_start_end_with_calls, <<~PATTERN
           (or
-            (call $_recv [{:start_with? :end_with?} $_method] $...)
+            (call $_recv [%methods_to_check $_method] $...)
             (call _recv _method $...))
         PATTERN
 
-        def_node_matcher :check_with_active_support_aliases, <<~PATTERN
-          (or
-            (call $_recv
-                    [{:start_with? :starts_with? :end_with? :ends_with?} $_method]
-                  $...)
-            (call _recv _method $...))
+        def_node_matcher :two_start_end_with_calls_negated, <<~PATTERN
+          (and
+            (send (call $_recv [%methods_to_check $_method] $...) :!)
+            (send (call _recv _method $...) :!))
         PATTERN
       end
     end

data/lib/rubocop/cop/performance/inefficient_hash_search.rb

@@ -74,8 +74,8 @@ module RuboCop
 
         def correct_method(node)
           case current_method(node)
-          when :keys then use_long_method ? 'has_key?' : 'key?'
-          when :values then use_long_method ? 'has_value?' : 'value?'
+          when :keys then use_long_method? ? 'has_key?' : 'key?'
+          when :values then use_long_method? ? 'has_value?' : 'value?'
           end
         end
 
@@ -83,7 +83,7 @@ module RuboCop
           node.receiver.method_name
         end
 
-        def use_long_method
+        def use_long_method?
           config.for_enabled_cop('Style/PreferredHashMethods')['EnforcedStyle'] == 'long'
         end
 

data/lib/rubocop/cop/performance/map_compact.rb

@@ -8,9 +8,9 @@ module RuboCop
       # This cop identifies places where `map { ... }.compact` can be replaced by `filter_map`.
       #
       # @safety
-      #   This cop's autocorrection is unsafe because `map { ... }.compact` might yield
+      #   This cop is unsafe because `map { ... }.compact` might yield
       #   different results than `filter_map`. As illustrated in the example, `filter_map`
-      #   also filters out falsy values, while `compact` only gets rid of `nil`.
+      #   also filters out falsey values, while `compact` only gets rid of `nil`.
       #
       # [source,ruby]
       # ----

data/lib/rubocop/cop/performance/redundant_string_chars.rb

@@ -54,6 +54,7 @@ module RuboCop
         def on_send(node)
           return unless (receiver, method, args = redundant_chars_call?(node))
           return if method == :last && !args.empty?
+          return if args.count == 2
 
           range = offense_range(receiver, node)
           message = build_message(method, args)

data/lib/rubocop/cop/performance/regexp_match.rb

@@ -239,7 +239,7 @@ module RuboCop
 
         def scope_root(node)
           node.each_ancestor.find do |ancestor|
-            ancestor.type?(:def, :defs, :class, :module)
+            ancestor.type?(:any_def, :class, :module)
           end
         end
 

data/lib/rubocop/performance/version.rb

@@ -4,7 +4,7 @@ module RuboCop
   module Performance
     # This module holds the RuboCop Performance version information.
     module Version
-      STRING = '1.25.0'
+      STRING = '1.26.1'
 
       def self.document_version
         STRING.match('\d+\.\d+').to_s

data/lib/rubocop-performance.rb

@@ -7,10 +7,16 @@ require_relative 'rubocop/performance/version'
 require_relative 'rubocop/performance/plugin'
 require_relative 'rubocop/cop/performance_cops'
 
-RuboCop::Cop::Lint::UnusedMethodArgument.singleton_class.prepend(
-  Module.new do
-    def autocorrect_incompatible_with
-      super.push(RuboCop::Cop::Performance::BlockGivenWithExplicitBlock)
-    end
+autocorrect_incompatible_with_block_given_with_explicit_block = Module.new do
+  def autocorrect_incompatible_with
+    super.push(RuboCop::Cop::Performance::BlockGivenWithExplicitBlock)
   end
+end
+
+RuboCop::Cop::Lint::UnusedMethodArgument.singleton_class.prepend(
+  autocorrect_incompatible_with_block_given_with_explicit_block
+)
+
+RuboCop::Cop::Naming::BlockForwarding.singleton_class.prepend(
+  autocorrect_incompatible_with_block_given_with_explicit_block
 )

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rubocop-performance
 version: !ruby/object:Gem::Version
-  version: 1.25.0
+  version: 1.26.1
 platform: ruby
 authors:
 - Bozhidar Batsov
@@ -10,7 +10,7 @@ authors:
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2025-04-01 00:00:00.000000000 Z
+date: 2025-10-18 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: lint_roller
@@ -52,7 +52,7 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 1.38.0
+        version: 1.47.1
     - - "<"
       - !ruby/object:Gem::Version
         version: '2.0'
@@ -62,7 +62,7 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 1.38.0
+        version: 1.47.1
     - - "<"
       - !ruby/object:Gem::Version
         version: '2.0'
@@ -146,7 +146,7 @@ metadata:
   homepage_uri: https://docs.rubocop.org/rubocop-performance/
   changelog_uri: https://github.com/rubocop/rubocop-performance/blob/master/CHANGELOG.md
   source_code_uri: https://github.com/rubocop/rubocop-performance/
-  documentation_uri: https://docs.rubocop.org/rubocop-performance/1.25/
+  documentation_uri: https://docs.rubocop.org/rubocop-performance/1.26/
   bug_tracker_uri: https://github.com/rubocop/rubocop-performance/issues
   rubygems_mfa_required: 'true'
   default_lint_roller_plugin: RuboCop::Performance::Plugin