rubocop-performance 1.21.0 → 1.22.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: c00ee718f283199f3c4f53b54071998b356f7239edcd3c84015bac94ad1b05dc
-  data.tar.gz: a5e7d011cd090fd5d30eb0ef9e12acabb93a993cc3acb46129da46c37294e1ba
+  metadata.gz: 786f01d21be4d9f083fc007c02f4138145970d85b68776aca83fc305bd4f5152
+  data.tar.gz: b15886f0f524d72de2319644d88a46058fe056476a52eef78eca7349e4e142eb
 SHA512:
-  metadata.gz: 711efd2eae8c54dc1b567e198360038fb16eee00c2e6a61db7dbcfb063f219618e36809ac5679cc531e8fe84245ea1f66e6e8eb9fbed5cbb9dcc22f57c10dab6
-  data.tar.gz: 5618f678392ffb6f93b34388e3ef060c017f7e70b53d992ebe48d2bb49b7ec5570adc7b21f5f22f0511cddc4fb1dead044904d7bcf40949191ee6ed8b884565f
+  metadata.gz: 940f52f35280335d6417096c43344e9d582fa22e9a09e7dd60cd08f19f1c68740052a2810dc9d082e5ee66b56c6c631eeb2cc1ee45ccd896bd58d654fdd4b523
+  data.tar.gz: 483d5eedb23cc666c15d5c4bdb6b30f0c7b001547d38406c89ecf18547e0a0ae6c73fa9795f00b260921787b4ffee1c4d628434394c587d7744253759071a2b0

data/README.md

@@ -1,7 +1,7 @@
 # RuboCop Performance
 
 [![Gem Version](https://badge.fury.io/rb/rubocop-performance.svg)](https://badge.fury.io/rb/rubocop-performance)
-[![CircleCI](https://circleci.com/gh/rubocop/rubocop-performance.svg?style=svg)](https://circleci.com/gh/rubocop/rubocop-performance)
+[![CI](https://github.com/rubocop/rubocop-performance/actions/workflows/test.yml/badge.svg)](https://github.com/rubocop/rubocop-performance/actions/workflows/test.yml)
 [![Discord](https://img.shields.io/badge/chat-on%20discord-7289da.svg?sanitize=true)](https://discord.gg/wJjWvGRDmm)
 
 Performance optimization analysis for your projects, as an extension to [RuboCop](https://github.com/rubocop/rubocop).

data/config/default.yml

@@ -32,8 +32,11 @@ Performance/BindCall:
 
 Performance/BlockGivenWithExplicitBlock:
   Description: 'Check block argument explicitly instead of using `block_given?`.'
-  Enabled: pending
+  # This cop was created due to a mistake in microbenchmark.
+  # https://github.com/rubocop/rubocop-performance/issues/385
+  Enabled: false
   VersionAdded: '1.9'
+  VersionChanged: '1.22'
 
 Performance/Caller:
   Description: >-

data/lib/rubocop/cop/performance/big_decimal_with_numeric_argument.rb

@@ -3,45 +3,48 @@
 module RuboCop
   module Cop
     module Performance
-      # Identifies places where numeric argument to BigDecimal should be
-      # converted to string. Initializing from String is faster
-      # than from Numeric for BigDecimal.
+      # Identifies places where string argument to `BigDecimal` should be
+      # converted to numeric. Initializing from Integer is faster
+      # than from String for BigDecimal.
       #
       # @example
       #   # bad
-      #   BigDecimal(1, 2)
-      #   4.to_d(6)
-      #   BigDecimal(1.2, 3, exception: true)
-      #   4.5.to_d(6, exception: true)
-      #
-      #   # good
       #   BigDecimal('1', 2)
       #   BigDecimal('4', 6)
       #   BigDecimal('1.2', 3, exception: true)
       #   BigDecimal('4.5', 6, exception: true)
       #
+      #   # good
+      #   BigDecimal(1, 2)
+      #   4.to_d(6)
+      #   BigDecimal(1.2, 3, exception: true)
+      #   4.5.to_d(6, exception: true)
+      #
       class BigDecimalWithNumericArgument < Base
         extend AutoCorrector
+        extend TargetRubyVersion
+
+        minimum_target_ruby_version 3.1
 
-        MSG = 'Convert numeric literal to string and pass it to `BigDecimal`.'
+        MSG = 'Convert string literal to numeric and pass it to `BigDecimal`.'
         RESTRICT_ON_SEND = %i[BigDecimal to_d].freeze
 
         def_node_matcher :big_decimal_with_numeric_argument?, <<~PATTERN
-          (send nil? :BigDecimal $numeric_type? ...)
+          (send nil? :BigDecimal $str_type? ...)
         PATTERN
 
         def_node_matcher :to_d?, <<~PATTERN
-          (send [!nil? $numeric_type?] :to_d ...)
+          (send [!nil? $str_type?] :to_d ...)
         PATTERN
 
         def on_send(node)
-          if (numeric = big_decimal_with_numeric_argument?(node))
-            add_offense(numeric.source_range) do |corrector|
-              corrector.wrap(numeric, "'", "'")
+          if (string = big_decimal_with_numeric_argument?(node))
+            add_offense(string.source_range) do |corrector|
+              corrector.replace(string, string.value)
             end
-          elsif (numeric_to_d = to_d?(node))
-            add_offense(numeric_to_d.source_range) do |corrector|
-              big_decimal_args = node.arguments.map(&:source).unshift("'#{numeric_to_d.source}'").join(', ')
+          elsif (string_to_d = to_d?(node))
+            add_offense(string_to_d.source_range) do |corrector|
+              big_decimal_args = node.arguments.map(&:source).unshift(string_to_d.value).join(', ')
 
               corrector.replace(node, "BigDecimal(#{big_decimal_args})")
             end

data/lib/rubocop/cop/performance/block_given_with_explicit_block.rb

@@ -6,6 +6,9 @@ module RuboCop
       # Identifies unnecessary use of a `block_given?` where explicit check
       # of block argument would suffice.
       #
+      # NOTE: This cop produces code with significantly worse performance when a
+      # block is being passed to the method and as such should not be enabled.
+      #
       # @example
       #   # bad
       #   def method(&block)

data/lib/rubocop/cop/performance/double_start_end_with.rb

@@ -41,7 +41,7 @@ module RuboCop
       class DoubleStartEndWith < Base
         extend AutoCorrector
 
-        MSG = 'Use `%<receiver>s.%<method>s(%<combined_args>s)` instead of `%<original_code>s`.'
+        MSG = 'Use `%<replacement>s` instead of `%<original_code>s`.'
 
         def on_or(node)
           receiver, method, first_call_args, second_call_args = process_source(node)
@@ -50,7 +50,7 @@ module RuboCop
 
           combined_args = combine_args(first_call_args, second_call_args)
 
-          add_offense(node, message: message(node, receiver, method, combined_args)) do |corrector|
+          add_offense(node, message: message(node, receiver, first_call_args, method, combined_args)) do |corrector|
             autocorrect(corrector, first_call_args, second_call_args, combined_args)
           end
         end
@@ -73,10 +73,10 @@ module RuboCop
           end
         end
 
-        def message(node, receiver, method, combined_args)
-          format(
-            MSG, receiver: receiver.source, method: method, combined_args: combined_args, original_code: node.source
-          )
+        def message(node, receiver, first_call_args, method, combined_args)
+          dot = first_call_args.first.parent.send_type? ? '.' : '&.'
+          replacement = "#{receiver.source}#{dot}#{method}(#{combined_args})"
+          format(MSG, replacement: replacement, original_code: node.source)
         end
 
         def combine_args(first_call_args, second_call_args)
@@ -89,16 +89,16 @@ module RuboCop
 
         def_node_matcher :two_start_end_with_calls, <<~PATTERN
           (or
-            (send $_recv [{:start_with? :end_with?} $_method] $...)
-            (send _recv _method $...))
+            (call $_recv [{:start_with? :end_with?} $_method] $...)
+            (call _recv _method $...))
         PATTERN
 
         def_node_matcher :check_with_active_support_aliases, <<~PATTERN
           (or
-            (send $_recv
+            (call $_recv
                     [{:start_with? :starts_with? :end_with? :ends_with?} $_method]
                   $...)
-            (send _recv _method $...))
+            (call _recv _method $...))
         PATTERN
       end
     end

data/lib/rubocop/cop/performance/map_compact.rb

@@ -8,8 +8,9 @@ module RuboCop
       # This cop identifies places where `map { ... }.compact` can be replaced by `filter_map`.
       #
       # @safety
-      #   This cop's autocorrection is unsafe because `map { ... }.compact` that is not
-      #   compatible with `filter_map`.
+      #   This cop's autocorrection is unsafe because `map { ... }.compact` might yield
+      #   different results than `filter_map`. As illustrated in the example, `filter_map`
+      #   also filters out falsy values, while `compact` only gets rid of `nil`.
       #
       # [source,ruby]
       # ----

data/lib/rubocop/cop/performance/redundant_equality_comparison_block.rb

@@ -64,7 +64,7 @@ module RuboCop
           return unless one_block_argument?(node.arguments)
 
           block_argument = node.first_argument
-          block_body = node.body
+          return unless (block_body = node.body)
           return unless use_equality_comparison_block?(block_body)
           return if same_block_argument_and_is_a_argument?(block_body, block_argument)
           return unless (new_argument = new_argument(block_argument, block_body))

data/lib/rubocop/cop/performance/redundant_merge.rb

@@ -130,9 +130,7 @@ module RuboCop
         end
 
         def rewrite_with_modifier(node, parent, new_source)
-          # FIXME: `|| 2` can be removed when support is limited to RuboCop 1.44 or higher.
-          # https://github.com/rubocop/rubocop/commit/02d1e5b
-          indent = ' ' * (configured_indentation_width || 2)
+          indent = ' ' * configured_indentation_width
           padding = "\n#{indent + leading_spaces(node)}"
           new_source.gsub!("\n", padding)
 

data/lib/rubocop/performance/version.rb

@@ -4,7 +4,7 @@ module RuboCop
   module Performance
     # This module holds the RuboCop Performance version information.
     module Version
-      STRING = '1.21.0'
+      STRING = '1.22.0'
 
       def self.document_version
         STRING.match('\d+\.\d+').to_s

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rubocop-performance
 version: !ruby/object:Gem::Version
-  version: 1.21.0
+  version: 1.22.0
 platform: ruby
 authors:
 - Bozhidar Batsov
@@ -10,7 +10,7 @@ authors:
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2024-03-30 00:00:00.000000000 Z
+date: 2024-09-16 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop
@@ -130,7 +130,7 @@ metadata:
   homepage_uri: https://docs.rubocop.org/rubocop-performance/
   changelog_uri: https://github.com/rubocop/rubocop-performance/blob/master/CHANGELOG.md
   source_code_uri: https://github.com/rubocop/rubocop-performance/
-  documentation_uri: https://docs.rubocop.org/rubocop-performance/1.21/
+  documentation_uri: https://docs.rubocop.org/rubocop-performance/1.22/
   bug_tracker_uri: https://github.com/rubocop/rubocop-performance/issues
   rubygems_mfa_required: 'true'
 post_install_message:
@@ -148,7 +148,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.5.3
+rubygems_version: 3.2.33
 signing_key:
 specification_version: 4
 summary: Automatic performance checking tool for Ruby code.