rubocop-performance 1.2.0 → 1.3.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: d571b90f427f5c2d7212fcf223a975d2426cc5b216832832d3d22c4196c6c7d3
-  data.tar.gz: '09978347ef923455817c3f9e1753011efd618f99e6f72deffdf0e221ece5c5ad'
+  metadata.gz: fef013a3148e1dc068ab3f3e2430a2e43f02641ce888b98178f31f2796d291fa
+  data.tar.gz: 9454d77c9fdddef6fd20f1d9155867c98bf698c71f5e79933d05ed74e5e1458d
 SHA512:
-  metadata.gz: b5886c02136883367f4fadf6818369dd08c344ee2306704a3695cc28f3c19b4d45a434f56d9b3b229d9f01644b530e64057fe6a2ae2830157d181079dc880a7e
-  data.tar.gz: 7139532bfe4d15a47cee1eff3618529ae93faec8cedb693a40a454b866fb1f3e252fbb303e7f393ba70c9e9ab387e2814dd96e15d36b9d1dfcb693a5f08f5608
+  metadata.gz: 5ca78e431963e440efe8a21b4298c69b473717ec3601a80dce40fb5c072360508338aa9de4e8a33f93c9329c033fd410db47d7e7df3ba7afdddf520d1b0487e9
+  data.tar.gz: 1065ae95c427f38581d054e573a5799caaacf46445f601aeb8f200c0f0772c190c4e2499c24b5fbc9bacb64ab30bec71127417d61c4206808d362e8974c6ada9

data/lib/rubocop/cop/performance/caller.rb

@@ -20,9 +20,9 @@ module RuboCop
       #   caller_locations(1..1).first
       class Caller < Cop
         MSG_BRACE = 'Use `%<method>s(%<n>d..%<n>d).first`' \
-                    ' instead of `%<method>s[%<m>d]`.'.freeze
+                    ' instead of `%<method>s[%<m>d]`.'
         MSG_FIRST = 'Use `%<method>s(%<n>d..%<n>d).first`' \
-                    ' instead of `%<method>s.first`.'.freeze
+                    ' instead of `%<method>s.first`.'
 
         def_node_matcher :slow_caller?, <<-PATTERN
           {

data/lib/rubocop/cop/performance/case_when_splat.rb

@@ -58,9 +58,9 @@ module RuboCop
         include RangeHelp
 
         MSG = 'Reordering `when` conditions with a splat to the end ' \
-          'of the `when` branches can improve performance.'.freeze
+          'of the `when` branches can improve performance.'
         ARRAY_MSG = 'Pass the contents of array literals ' \
-          'directly to `when` conditions.'.freeze
+          'directly to `when` conditions.'
 
         def on_case(case_node)
           when_conditions = case_node.when_branches.flat_map(&:conditions)

data/lib/rubocop/cop/performance/casecmp.rb

@@ -18,7 +18,7 @@ module RuboCop
       #   str.casecmp('ABC').zero?
       #   'abc'.casecmp(str).zero?
       class Casecmp < Cop
-        MSG = 'Use `%<good>s` instead of `%<bad>s`.'.freeze
+        MSG = 'Use `%<good>s` instead of `%<bad>s`.'
         CASE_METHODS = %i[downcase upcase].freeze
 
         def_node_matcher :downcase_eq, <<-PATTERN

data/lib/rubocop/cop/performance/chain_array_allocation.rb

@@ -29,10 +29,10 @@ module RuboCop
         #   [1,2].first    # => 1
         #   [1,2].first(1) # => [1]
         #
-        RETURN_NEW_ARRAY_WHEN_ARGS = ':first :last :pop :sample :shift '.freeze
+        RETURN_NEW_ARRAY_WHEN_ARGS = ':first :last :pop :sample :shift '
 
         # These methods return a new array only when called without a block.
-        RETURNS_NEW_ARRAY_WHEN_NO_BLOCK = ':zip :product '.freeze
+        RETURNS_NEW_ARRAY_WHEN_NO_BLOCK = ':zip :product '
 
         # These methods ALWAYS return a new array
         # after they're called it's safe to mutate the the resulting array
@@ -40,16 +40,16 @@ module RuboCop
                                    ':drop_while :flatten :map :reject ' \
                                    ':reverse :rotate :select :shuffle :sort ' \
                                    ':take :take_while :transpose :uniq ' \
-                                   ':values_at :| '.freeze
+                                   ':values_at :| '
 
         # These methods have a mutation alternative. For example :collect
         # can be called as :collect!
         HAS_MUTATION_ALTERNATIVE = ':collect :compact :flatten :map :reject '\
                                    ':reverse :rotate :select :shuffle :sort '\
-                                   ':uniq '.freeze
+                                   ':uniq '
         MSG = 'Use unchained `%<method>s!` and `%<second_method>s!` '\
               '(followed by `return array` if required) instead of chaining '\
-              '`%<method>s...%<second_method>s`.'.freeze
+              '`%<method>s...%<second_method>s`.'
 
         def_node_matcher :flat_map_candidate?, <<-PATTERN
           {

data/lib/rubocop/cop/performance/compare_with_block.rb

@@ -28,7 +28,7 @@ module RuboCop
 
         MSG = 'Use `%<compare_method>s_by%<instead>s` instead of ' \
               '`%<compare_method>s { |%<var_a>s, %<var_b>s| %<str_a>s ' \
-              '<=> %<str_b>s }`.'.freeze
+              '<=> %<str_b>s }`.'
 
         def_node_matcher :compare?, <<-PATTERN
           (block

data/lib/rubocop/cop/performance/count.rb

@@ -41,7 +41,7 @@ module RuboCop
         include SafeMode
         include RangeHelp
 
-        MSG = 'Use `count` instead of `%<selector>s...%<counter>s`.'.freeze
+        MSG = 'Use `count` instead of `%<selector>s...%<counter>s`.'
 
         def_node_matcher :count_candidate?, <<-PATTERN
           {

data/lib/rubocop/cop/performance/detect.rb

@@ -26,9 +26,9 @@ module RuboCop
         include SafeMode
 
         MSG = 'Use `%<prefer>s` instead of ' \
-              '`%<first_method>s.%<second_method>s`.'.freeze
+              '`%<first_method>s.%<second_method>s`.'
         REVERSE_MSG = 'Use `reverse.%<prefer>s` instead of ' \
-                      '`%<first_method>s.%<second_method>s`.'.freeze
+                      '`%<first_method>s.%<second_method>s`.'
 
         def_node_matcher :detect_candidate?, <<-PATTERN
           {

data/lib/rubocop/cop/performance/double_start_end_with.rb

@@ -19,7 +19,7 @@ module RuboCop
       #   str.end_with?(var1, var2)
       class DoubleStartEndWith < Cop
         MSG = 'Use `%<receiver>s.%<method>s(%<combined_args>s)` ' \
-              'instead of `%<original_code>s`.'.freeze
+              'instead of `%<original_code>s`.'
 
         def on_or(node)
           receiver,

data/lib/rubocop/cop/performance/end_with.rb

@@ -16,8 +16,8 @@ module RuboCop
       #   'abc'.end_with?('bc')
       class EndWith < Cop
         MSG = 'Use `String#end_with?` instead of a regex match anchored to ' \
-              'the end of the string.'.freeze
-        SINGLE_QUOTE = "'".freeze
+              'the end of the string.'
+        SINGLE_QUOTE = "'"
 
         def_node_matcher :redundant_regex?, <<-PATTERN
           {(send $!nil? {:match :=~ :match?} (regexp (str $#literal_at_end?) (regopt)))

data/lib/rubocop/cop/performance/fixed_size.rb

@@ -46,7 +46,7 @@ module RuboCop
       #   waldo.size
       #
       class FixedSize < Cop
-        MSG = 'Do not compute the size of statically sized objects.'.freeze
+        MSG = 'Do not compute the size of statically sized objects.'
 
         def_node_matcher :counter, <<-MATCHER
           (send ${array hash str sym} {:count :length :size} $...)

data/lib/rubocop/cop/performance/flat_map.rb

@@ -17,10 +17,10 @@ module RuboCop
       class FlatMap < Cop
         include RangeHelp
 
-        MSG = 'Use `flat_map` instead of `%<method>s...%<flatten>s`.'.freeze
+        MSG = 'Use `flat_map` instead of `%<method>s...%<flatten>s`.'
         FLATTEN_MULTIPLE_LEVELS = ' Beware, `flat_map` only flattens 1 level ' \
                                   'and `flatten` can be used to flatten ' \
-                                  'multiple levels.'.freeze
+                                  'multiple levels.'
 
         def_node_matcher :flat_map_candidate?, <<-PATTERN
           (send (block $(send _ ${:collect :map}) ...) ${:flatten :flatten!} $...)

data/lib/rubocop/cop/performance/open_struct.rb

@@ -29,7 +29,7 @@ module RuboCop
       #
       class OpenStruct < Cop
         MSG = 'Consider using `Struct` over `OpenStruct` ' \
-              'to optimize the performance.'.freeze
+              'to optimize the performance.'
 
         def_node_matcher :open_struct, <<-PATTERN
           (send (const {nil? cbase} :OpenStruct) :new ...)

data/lib/rubocop/cop/performance/range_include.rb

@@ -24,7 +24,7 @@ module RuboCop
       #
       #   ('a'..'z').cover?('yellow') # => true
       class RangeInclude < Cop
-        MSG = 'Use `Range#cover?` instead of `Range#include?`.'.freeze
+        MSG = 'Use `Range#cover?` instead of `Range#include?`.'
 
         # TODO: If we traced out assignments of variables to their uses, we
         # might pick up on a few more instances of this issue

data/lib/rubocop/cop/performance/redundant_block_call.rb

@@ -23,11 +23,11 @@ module RuboCop
       #     yield 1, 2, 3
       #   end
       class RedundantBlockCall < Cop
-        MSG = 'Use `yield` instead of `%<argname>s.call`.'.freeze
-        YIELD = 'yield'.freeze
-        OPEN_PAREN = '('.freeze
-        CLOSE_PAREN = ')'.freeze
-        SPACE = ' '.freeze
+        MSG = 'Use `yield` instead of `%<argname>s.call`.'
+        YIELD = 'yield'
+        OPEN_PAREN = '('
+        CLOSE_PAREN = ')'
+        SPACE = ' '
 
         def_node_matcher :blockarg_def, <<-PATTERN
           {(def  _   (args ... (blockarg $_)) $_)

data/lib/rubocop/cop/performance/redundant_match.rb

@@ -19,7 +19,7 @@ module RuboCop
       #   return value unless regex =~ 'str'
       class RedundantMatch < Cop
         MSG = 'Use `=~` in places where the `MatchData` returned by ' \
-              '`#match` will not be used.'.freeze
+              '`#match` will not be used.'
 
         # 'match' is a fairly generic name, so we don't flag it unless we see
         # a string or regexp literal on one side or the other

data/lib/rubocop/cop/performance/redundant_merge.rb

@@ -11,10 +11,10 @@ module RuboCop
       #   hash.merge!({'key' => 'value'})
       #   hash.merge!(a: 1, b: 2)
       class RedundantMerge < Cop
-        AREF_ASGN = '%<receiver>s[%<key>s] = %<value>s'.freeze
-        MSG = 'Use `%<prefer>s` instead of `%<current>s`.'.freeze
+        AREF_ASGN = '%<receiver>s[%<key>s] = %<value>s'
+        MSG = 'Use `%<prefer>s` instead of `%<current>s`.'
 
-        WITH_MODIFIER_CORRECTION = <<-RUBY.strip_indent
+        WITH_MODIFIER_CORRECTION = <<~RUBY
           %<keyword>s %<condition>s
           %<leading_space>s%<indent>s%<body>s
           %<leading_space>send

data/lib/rubocop/cop/performance/regexp_match.rb

@@ -80,14 +80,14 @@ module RuboCop
         # Constants are included in this list because it is unlikely that
         # someone will store `nil` as a constant and then use it for comparison
         TYPES_IMPLEMENTING_MATCH = %i[const regexp str sym].freeze
-        MSG =
-          'Use `match?` instead of `%<current>s` when `MatchData` ' \
-          'is not used.'.freeze
+        MSG = 'Use `match?` instead of `%<current>s` when `MatchData` ' \
+          'is not used.'
 
         def_node_matcher :match_method?, <<-PATTERN
           {
             (send _recv :match _ <int ...>)
-            (send _recv :match _)
+            (send _recv :match {regexp str sym})
+            (send {regexp str sym} :match _)
           }
         PATTERN
 
@@ -106,7 +106,7 @@ module RuboCop
           regexp.to_regexp.named_captures.empty?
         end
 
-        MATCH_NODE_PATTERN = <<-PATTERN.freeze
+        MATCH_NODE_PATTERN = <<-PATTERN
           {
             #match_method?
             #match_operator?

data/lib/rubocop/cop/performance/reverse_each.rb

@@ -15,8 +15,8 @@ module RuboCop
       class ReverseEach < Cop
         include RangeHelp
 
-        MSG = 'Use `reverse_each` instead of `reverse.each`.'.freeze
-        UNDERSCORE = '_'.freeze
+        MSG = 'Use `reverse_each` instead of `reverse.each`.'
+        UNDERSCORE = '_'
 
         def_node_matcher :reverse_each?, <<-MATCHER
           (send $(send _ :reverse) :each)

data/lib/rubocop/cop/performance/size.rb

@@ -24,7 +24,7 @@ module RuboCop
       # TODO: Add advanced detection of variables that could
       # have been assigned to an array or a hash.
       class Size < Cop
-        MSG = 'Use `size` instead of `count`.'.freeze
+        MSG = 'Use `size` instead of `count`.'
 
         def on_send(node)
           return unless eligible_node?(node)
@@ -51,7 +51,7 @@ module RuboCop
         end
 
         def allowed_parent?(node)
-          node && node.block_type?
+          node&.block_type?
         end
 
         def array?(node)

data/lib/rubocop/cop/performance/start_with.rb

@@ -16,8 +16,8 @@ module RuboCop
       #   'abc'.start_with?('ab')
       class StartWith < Cop
         MSG = 'Use `String#start_with?` instead of a regex match anchored to ' \
-              'the beginning of the string.'.freeze
-        SINGLE_QUOTE = "'".freeze
+              'the beginning of the string.'
+        SINGLE_QUOTE = "'"
 
         def_node_matcher :redundant_regex?, <<-PATTERN
           {(send $!nil? {:match :=~ :match?} (regexp (str $#literal_at_start?) (regopt)))

data/lib/rubocop/cop/performance/string_replacement.rb

@@ -21,12 +21,12 @@ module RuboCop
       class StringReplacement < Cop
         include RangeHelp
 
-        MSG = 'Use `%<prefer>s` instead of `%<current>s`.'.freeze
+        MSG = 'Use `%<prefer>s` instead of `%<current>s`.'
         DETERMINISTIC_REGEX = /\A(?:#{LITERAL_REGEX})+\Z/.freeze
-        DELETE = 'delete'.freeze
-        TR = 'tr'.freeze
-        BANG = '!'.freeze
-        SINGLE_QUOTE = "'".freeze
+        DELETE = 'delete'
+        TR = 'tr'
+        BANG = '!'
+        SINGLE_QUOTE = "'"
 
         def_node_matcher :string_replacement?, <<-PATTERN
           (send _ {:gsub :gsub!}

data/lib/rubocop/cop/performance/times_map.rb

@@ -19,8 +19,8 @@ module RuboCop
       #   end
       class TimesMap < Cop
         MESSAGE = 'Use `Array.new(%<count>s)` with a block ' \
-                  'instead of `.times.%<map_or_collect>s`'.freeze
-        MESSAGE_ONLY_IF = 'only if `%<count>s` is always 0 or more'.freeze
+                  'instead of `.times.%<map_or_collect>s`'
+        MESSAGE_ONLY_IF = 'only if `%<count>s` is always 0 or more'
 
         def on_send(node)
           check(node)

data/lib/rubocop/cop/performance/unfreeze_string.rb

@@ -28,7 +28,7 @@ module RuboCop
 
         minimum_target_ruby_version 2.3
 
-        MSG = 'Use unary plus to get an unfrozen string literal.'.freeze
+        MSG = 'Use unary plus to get an unfrozen string literal.'
 
         def_node_matcher :dup_string?, <<-PATTERN
           (send {str dstr} :dup)

data/lib/rubocop/cop/performance/uri_default_parser.rb

@@ -15,7 +15,7 @@ module RuboCop
       #
       class UriDefaultParser < Cop
         MSG = 'Use `%<double_colon>sURI::DEFAULT_PARSER` instead of ' \
-              '`%<double_colon>sURI::Parser.new`.'.freeze
+              '`%<double_colon>sURI::Parser.new`.'
 
         def_node_matcher :uri_parser_new?, <<-PATTERN
           (send

data/lib/rubocop/performance/version.rb

@@ -3,7 +3,7 @@
 module RuboCop
   module Performance
     module Version
-      STRING = '1.2.0'.freeze
+      STRING = '1.3.0'
     end
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rubocop-performance
 version: !ruby/object:Gem::Version
-  version: 1.2.0
+  version: 1.3.0
 platform: ruby
 authors:
 - Bozhidar Batsov
@@ -10,7 +10,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-05-04 00:00:00.000000000 Z
+date: 2019-05-13 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop
@@ -100,7 +100,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: 2.2.2
+      version: 2.3.0
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="