rubocop-performance 1.18.0 → 1.21.0

data/lib/rubocop/cop/performance/times_map.rb

@@ -39,6 +39,7 @@ module RuboCop
         def on_send(node)
           check(node)
         end
+        alias on_csend on_send
 
         def on_block(node)
           check(node)
@@ -49,6 +50,8 @@ module RuboCop
 
         def check(node)
           times_map_call(node) do |map_or_collect, count|
+            next unless handleable_receiver?(node)
+
             add_offense(node, message: message(map_or_collect, count)) do |corrector|
               replacement = "Array.new(#{count.source}#{map_or_collect.arguments.map { |arg| ", #{arg.source}" }.join})"
 
@@ -57,6 +60,13 @@ module RuboCop
           end
         end
 
+        def handleable_receiver?(node)
+          receiver = node.receiver.receiver
+          return true if receiver.literal? && (receiver.int_type? || receiver.float_type?)
+
+          node.receiver.dot?
+        end
+
         def message(map_or_collect, count)
           template = if count.literal?
                        "#{MESSAGE}."
@@ -67,8 +77,10 @@ module RuboCop
         end
 
         def_node_matcher :times_map_call, <<~PATTERN
-          {({block numblock} $(send (send $!nil? :times) {:map :collect}) ...)
-           $(send (send $!nil? :times) {:map :collect} (block_pass ...))}
+          {
+            ({block numblock} $(call (call $!nil? :times) {:map :collect}) ...)
+            $(call (call $!nil? :times) {:map :collect} (block_pass ...))
+          }
         PATTERN
       end
     end

data/lib/rubocop/cop/performance/unfreeze_string.rb

@@ -15,8 +15,8 @@ module RuboCop
       #
       # @example
       #   # bad
-      #   ''.dup
-      #   "something".dup
+      #   ''.dup          # when Ruby 3.2 or lower
+      #   "something".dup # when Ruby 3.2 or lower
       #   String.new
       #   String.new('')
       #   String.new('something')
@@ -26,6 +26,9 @@ module RuboCop
       #   +''
       class UnfreezeString < Base
         extend AutoCorrector
+        extend TargetRubyVersion
+
+        minimum_target_ruby_version 2.3
 
         MSG = 'Use unary plus to get an unfrozen string literal.'
         RESTRICT_ON_SEND = %i[dup new].freeze
@@ -42,7 +45,7 @@ module RuboCop
         PATTERN
 
         def on_send(node)
-          return unless dup_string?(node) || string_new?(node)
+          return unless (dup_string?(node) && target_ruby_version <= 3.2) || string_new?(node)
 
           add_offense(node) do |corrector|
             string_value = "+#{string_value(node)}"

data/lib/rubocop/cop/performance/uri_default_parser.rb

@@ -25,7 +25,7 @@ module RuboCop
         PATTERN
 
         def on_send(node)
-          return unless uri_parser_new?(node) do |captured_value|
+          uri_parser_new?(node) do |captured_value|
             double_colon = captured_value ? '::' : ''
             message = format(MSG, double_colon: double_colon)
 

data/lib/rubocop/cop/performance_cops.rb

@@ -25,6 +25,7 @@ require_relative 'performance/fixed_size'
 require_relative 'performance/flat_map'
 require_relative 'performance/inefficient_hash_search'
 require_relative 'performance/map_compact'
+require_relative 'performance/map_method_chain'
 require_relative 'performance/method_object_as_block'
 require_relative 'performance/open_struct'
 require_relative 'performance/range_include'

data/lib/rubocop/performance/version.rb

@@ -4,7 +4,7 @@ module RuboCop
   module Performance
     # This module holds the RuboCop Performance version information.
     module Version
-      STRING = '1.18.0'
+      STRING = '1.21.0'
 
       def self.document_version
         STRING.match('\d+\.\d+').to_s

data/lib/rubocop-performance.rb

@@ -9,3 +9,11 @@ require_relative 'rubocop/performance/inject'
 RuboCop::Performance::Inject.defaults!
 
 require_relative 'rubocop/cop/performance_cops'
+
+RuboCop::Cop::Lint::UnusedMethodArgument.singleton_class.prepend(
+  Module.new do
+    def autocorrect_incompatible_with
+      super.push(RuboCop::Cop::Performance::BlockGivenWithExplicitBlock)
+    end
+  end
+)

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rubocop-performance
 version: !ruby/object:Gem::Version
-  version: 1.18.0
+  version: 1.21.0
 platform: ruby
 authors:
 - Bozhidar Batsov
@@ -10,7 +10,7 @@ authors:
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2023-05-21 00:00:00.000000000 Z
+date: 2024-03-30 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop
@@ -18,7 +18,7 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 1.7.0
+        version: 1.48.1
     - - "<"
       - !ruby/object:Gem::Version
         version: '2.0'
@@ -28,7 +28,7 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 1.7.0
+        version: 1.48.1
     - - "<"
       - !ruby/object:Gem::Version
         version: '2.0'
@@ -38,14 +38,20 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 0.4.0
+        version: 1.31.1
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: '2.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 0.4.0
+        version: 1.31.1
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: '2.0'
 description: |
   A collection of RuboCop cops to check for performance optimizations
   in Ruby code.
@@ -87,6 +93,7 @@ files:
 - lib/rubocop/cop/performance/inefficient_hash_search.rb
 - lib/rubocop/cop/performance/io_readlines.rb
 - lib/rubocop/cop/performance/map_compact.rb
+- lib/rubocop/cop/performance/map_method_chain.rb
 - lib/rubocop/cop/performance/method_object_as_block.rb
 - lib/rubocop/cop/performance/open_struct.rb
 - lib/rubocop/cop/performance/range_include.rb
@@ -123,7 +130,7 @@ metadata:
   homepage_uri: https://docs.rubocop.org/rubocop-performance/
   changelog_uri: https://github.com/rubocop/rubocop-performance/blob/master/CHANGELOG.md
   source_code_uri: https://github.com/rubocop/rubocop-performance/
-  documentation_uri: https://docs.rubocop.org/rubocop-performance/1.18/
+  documentation_uri: https://docs.rubocop.org/rubocop-performance/1.21/
   bug_tracker_uri: https://github.com/rubocop/rubocop-performance/issues
   rubygems_mfa_required: 'true'
 post_install_message:
@@ -141,7 +148,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.5.0.dev
+rubygems_version: 3.5.3
 signing_key:
 specification_version: 4
 summary: Automatic performance checking tool for Ruby code.