rubocop-performance 1.14.0 → 1.14.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: f4747d4148deec2021e930aac92abe205f8aeb8492c19e8a465d1e4282184d04
-  data.tar.gz: 82b9caa126eee0699cae6f46b784fa3fdd8f619c4df0dc2b4c083e6ef5c328b3
+  metadata.gz: 7716dc36d8facd9d8604d89d117f85db5fed60efcad66ad8354d673492800140
+  data.tar.gz: 59f4dd4e4df5afef36700a8951e8e91e18567ba978506d9aa02884abafc6d639
 SHA512:
-  metadata.gz: bd64acd6e513565e8f607046bf9598bf0aadb166dc7bf17fab8633e0ed9722af8e4f984468d5f08eb398c7b4f4121537c01ad52e5c24b7226bef3bd8f2c0f6f7
-  data.tar.gz: 017c74d0dadf085c59e0f479dc5359d8c8fb71427d3e217392c349e51219a99933a0ebdd6426ece0aaca2149ee5b6d39a279f1cae8c9e9c4ff75f17d99fe22cd
+  metadata.gz: 748977ac053ddab36afda43c709eee6424957a81ce18daf1048cf42399226e0d2d67f9964ba544594a03862d5650eff369a34b407d49892d72957ab3acf2ca11
+  data.tar.gz: 9a785cd79f0e781643720fd19e2454d6b1cac890c215d5a44762e4173d69e9f6ec6adc57fe43646dba7b3e48bf86663842f595f54db1f51c7e251af75113ecee

data/config/default.yml

@@ -160,7 +160,7 @@ Performance/FlatMap:
   Description: >-
                   Use `Enumerable#flat_map`
                   instead of `Enumerable#map...Array#flatten(1)`
-                  or `Enumberable#collect..Array#flatten(1)`.
+                  or `Enumerable#collect..Array#flatten(1)`.
   Reference: 'https://github.com/JuanitoFatas/fast-ruby#enumerablemaparrayflatten-vs-enumerableflat_map-code'
   Enabled: true
   VersionAdded: '0.30'

data/lib/rubocop/cop/performance/chain_array_allocation.rb

@@ -47,13 +47,13 @@ module RuboCop
 
         RETURNS_NEW_ARRAY = (ALWAYS_RETURNS_NEW_ARRAY + RETURNS_NEW_ARRAY_WHEN_NO_BLOCK).freeze
 
-        MSG = 'Use unchained `%<method>s` and `%<second_method>s!` '\
-              '(followed by `return array` if required) instead of chaining '\
+        MSG = 'Use unchained `%<method>s` and `%<second_method>s!` ' \
+              '(followed by `return array` if required) instead of chaining ' \
               '`%<method>s...%<second_method>s`.'
 
         def_node_matcher :chain_array_allocation?, <<~PATTERN
           (send {
-            (send _ $%RETURN_NEW_ARRAY_WHEN_ARGS {int lvar ivar cvar gvar})
+            (send _ $%RETURN_NEW_ARRAY_WHEN_ARGS {int lvar ivar cvar gvar send})
             (block (send _ $%ALWAYS_RETURNS_NEW_ARRAY) ...)
             (send _ $%RETURNS_NEW_ARRAY ...)
           } $%HAS_MUTATION_ALTERNATIVE ...)

data/lib/rubocop/cop/performance/collection_literal_in_loop.rb

@@ -32,7 +32,7 @@ module RuboCop
       #   end
       #
       class CollectionLiteralInLoop < Base
-        MSG = 'Avoid immutable %<literal_class>s literals in loops. '\
+        MSG = 'Avoid immutable %<literal_class>s literals in loops. ' \
               'It is better to extract it into a local variable or a constant.'
 
         POST_CONDITION_LOOP_TYPES = %i[while_post until_post].freeze

data/lib/rubocop/cop/performance/inefficient_hash_search.rb

@@ -58,8 +58,7 @@ module RuboCop
               # `key?`/`value?` method.
               corrector.replace(
                 node.loc.expression,
-                "#{autocorrect_hash_expression(node)}."\
-                "#{autocorrect_method(node)}(#{autocorrect_argument(node)})"
+                "#{autocorrect_hash_expression(node)}.#{autocorrect_method(node)}(#{autocorrect_argument(node)})"
               )
             end
           end
@@ -68,8 +67,7 @@ module RuboCop
         private
 
         def message(node)
-          "Use `##{autocorrect_method(node)}` instead of "\
-            "`##{current_method(node)}.include?`."
+          "Use `##{autocorrect_method(node)}` instead of `##{current_method(node)}.include?`."
         end
 
         def autocorrect_method(node)

data/lib/rubocop/cop/performance/map_compact.rb

@@ -83,7 +83,7 @@ module RuboCop
         end
 
         def invoke_method_after_map_compact_on_same_line?(compact_node, chained_method)
-          compact_node.loc.selector.line == chained_method.loc.selector.line
+          compact_node.loc.selector.line == chained_method.loc.last_line
         end
 
         def compact_method_with_final_newline_range(compact_method_range)

data/lib/rubocop/cop/performance/regexp_match.rb

@@ -74,6 +74,9 @@ module RuboCop
       #   end
       class RegexpMatch < Base
         extend AutoCorrector
+        extend TargetRubyVersion
+
+        minimum_target_ruby_version 2.4
 
         # Constants are included in this list because it is unlikely that
         # someone will store `nil` as a constant and then use it for comparison

data/lib/rubocop/cop/performance/string_identifier_argument.rb

@@ -38,7 +38,7 @@ module RuboCop
           remove_class_variable remove_method undef_method class_variable_get class_variable_set
           deprecate_constant module_function private private_constant protected public public_constant
           remove_const ruby2_keywords
-          define_singleton_method instance_variable_defined instance_variable_get instance_variable_set
+          define_singleton_method instance_variable_defined? instance_variable_get instance_variable_set
           method public_method public_send remove_instance_variable respond_to? send singleton_method
           __send__
         ].freeze

data/lib/rubocop/cop/performance/sum.rb

@@ -7,7 +7,7 @@ module RuboCop
       # in some Enumerable object can be replaced by `Enumerable#sum` method.
       #
       # @safety
-      #   Auto-corrections are unproblematic wherever an initial value is provided explicitly:
+      #   Autocorrections are unproblematic wherever an initial value is provided explicitly:
       #
       #   [source,ruby]
       #   ----
@@ -43,7 +43,7 @@ module RuboCop
       #
       # @example OnlySumOrWithInitialValue: false (default)
       #   # bad
-      #   [1, 2, 3].inject(:+)                        # Auto-corrections for cases without initial value are unsafe
+      #   [1, 2, 3].inject(:+)                        # Autocorrections for cases without initial value are unsafe
       #   [1, 2, 3].inject(&:+)                       # and will only be performed when using the `-A` option.
       #   [1, 2, 3].reduce { |acc, elem| acc + elem } # They can be prohibited completely using `SafeAutoCorrect: true`.
       #   [1, 2, 3].reduce(10, :+)

data/lib/rubocop/performance/version.rb

@@ -4,7 +4,7 @@ module RuboCop
   module Performance
     # This module holds the RuboCop Performance version information.
     module Version
-      STRING = '1.14.0'
+      STRING = '1.14.3'
 
       def self.document_version
         STRING.match('\d+\.\d+').to_s

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rubocop-performance
 version: !ruby/object:Gem::Version
-  version: 1.14.0
+  version: 1.14.3
 platform: ruby
 authors:
 - Bozhidar Batsov
@@ -10,7 +10,7 @@ authors:
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2022-05-24 00:00:00.000000000 Z
+date: 2022-07-17 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop