rubocop-performance 1.13.3 → 1.19.0

data/lib/rubocop/cop/performance/string_include.rb

@@ -3,47 +3,53 @@
 module RuboCop
   module Cop
     module Performance
-      # This cop identifies unnecessary use of a regex where
-      # `String#include?` would suffice.
+      # Identifies unnecessary use of a regex where `String#include?` would suffice.
       #
       # @safety
-      #   This cop's offenses are not safe to auto-correct if a receiver is nil.
+      #   This cop's offenses are not safe to autocorrect if a receiver is nil or a Symbol.
       #
       # @example
       #   # bad
-      #   'abc'.match?(/ab/)
-      #   /ab/.match?('abc')
-      #   'abc' =~ /ab/
-      #   /ab/ =~ 'abc'
-      #   'abc'.match(/ab/)
-      #   /ab/.match('abc')
+      #   str.match?(/ab/)
+      #   /ab/.match?(str)
+      #   str =~ /ab/
+      #   /ab/ =~ str
+      #   str.match(/ab/)
+      #   /ab/.match(str)
       #
       #   # good
-      #   'abc'.include?('ab')
+      #   str.include?('ab')
       class StringInclude < Base
         extend AutoCorrector
 
-        MSG = 'Use `String#include?` instead of a regex match with literal-only pattern.'
-        RESTRICT_ON_SEND = %i[match =~ match?].freeze
+        MSG = 'Use `%<negation>sString#include?` instead of a regex match with literal-only pattern.'
+        RESTRICT_ON_SEND = %i[match =~ !~ match?].freeze
 
         def_node_matcher :redundant_regex?, <<~PATTERN
-          {(send $!nil? {:match :=~ :match?} (regexp (str $#literal?) (regopt)))
-           (send (regexp (str $#literal?) (regopt)) {:match :match?} $str)
+          {(call $!nil? {:match :=~ :!~ :match?} (regexp (str $#literal?) (regopt)))
+           (send (regexp (str $#literal?) (regopt)) {:match :match?} $_)
            (match-with-lvasgn (regexp (str $#literal?) (regopt)) $_)}
         PATTERN
 
+        # rubocop:disable Metrics/AbcSize
         def on_send(node)
           return unless (receiver, regex_str = redundant_regex?(node))
 
-          add_offense(node) do |corrector|
+          negation = node.send_type? && node.method?(:!~)
+          message = format(MSG, negation: ('!' if negation))
+
+          add_offense(node, message: message) do |corrector|
             receiver, regex_str = regex_str, receiver if receiver.is_a?(String)
             regex_str = interpret_string_escapes(regex_str)
+            dot = node.loc.dot ? node.loc.dot.source : '.'
 
-            new_source = "#{receiver.source}.include?(#{to_string_literal(regex_str)})"
+            new_source = "#{'!' if negation}#{receiver.source}#{dot}include?(#{to_string_literal(regex_str)})"
 
-            corrector.replace(node.source_range, new_source)
+            corrector.replace(node, new_source)
           end
         end
+        # rubocop:enable Metrics/AbcSize
+        alias on_csend on_send
         alias on_match_with_lvasgn on_send
 
         private

data/lib/rubocop/cop/performance/string_replacement.rb

@@ -3,8 +3,7 @@
 module RuboCop
   module Cop
     module Performance
-      # This cop identifies places where `gsub` can be replaced by
-      # `tr` or `delete`.
+      # Identifies places where `gsub` can be replaced by `tr` or `delete`.
       #
       # @example
       #   # bad
@@ -30,7 +29,7 @@ module RuboCop
         BANG = '!'
 
         def_node_matcher :string_replacement?, <<~PATTERN
-          (send _ {:gsub :gsub!}
+          (call _ {:gsub :gsub!}
                     ${regexp str (send (const nil? :Regexp) {:new :compile} _)}
                     $str)
         PATTERN
@@ -43,6 +42,7 @@ module RuboCop
             offense(node, first_param, second_param)
           end
         end
+        alias on_csend on_send
 
         private
 
@@ -71,7 +71,7 @@ module RuboCop
           replacement_method = replacement_method(node, first_source, second_source)
 
           corrector.replace(node.loc.selector, replacement_method)
-          corrector.replace(first_param.source_range, to_string_literal(first_source)) unless first_param.str_type?
+          corrector.replace(first_param, to_string_literal(first_source)) unless first_param.str_type?
 
           remove_second_param(corrector, node, first_param) if second_source.empty? && first_source.length == 1
         end
@@ -87,8 +87,7 @@ module RuboCop
 
           unless first_param.str_type?
             return true if options
-            return true unless first_source.is_a?(String) &&
-                               first_source =~ DETERMINISTIC_REGEX
+            return true unless first_source.is_a?(String) && first_source =~ DETERMINISTIC_REGEX
 
             # This must be done after checking DETERMINISTIC_REGEX
             # Otherwise things like \s will trip us up
@@ -142,8 +141,7 @@ module RuboCop
         end
 
         def message(node, first_source, second_source)
-          replacement_method =
-            replacement_method(node, first_source, second_source)
+          replacement_method = replacement_method(node, first_source, second_source)
 
           format(MSG, prefer: replacement_method, current: node.method_name)
         end
@@ -153,8 +151,7 @@ module RuboCop
         end
 
         def remove_second_param(corrector, node, first_param)
-          end_range = range_between(first_param.source_range.end_pos,
-                                    node.source_range.end_pos)
+          end_range = range_between(first_param.source_range.end_pos, node.source_range.end_pos)
 
           corrector.replace(end_range, method_suffix(node))
         end

data/lib/rubocop/cop/performance/sum.rb

@@ -3,11 +3,11 @@
 module RuboCop
   module Cop
     module Performance
-      # This cop identifies places where custom code finding the sum of elements
+      # Identifies places where custom code finding the sum of elements
       # in some Enumerable object can be replaced by `Enumerable#sum` method.
       #
       # @safety
-      #   Auto-corrections are unproblematic wherever an initial value is provided explicitly:
+      #   Autocorrections are unproblematic wherever an initial value is provided explicitly:
       #
       #   [source,ruby]
       #   ----
@@ -43,7 +43,7 @@ module RuboCop
       #
       # @example OnlySumOrWithInitialValue: false (default)
       #   # bad
-      #   [1, 2, 3].inject(:+)                        # Auto-corrections for cases without initial value are unsafe
+      #   [1, 2, 3].inject(:+)                        # Autocorrections for cases without initial value are unsafe
       #   [1, 2, 3].inject(&:+)                       # and will only be performed when using the `-A` option.
       #   [1, 2, 3].reduce { |acc, elem| acc + elem } # They can be prohibited completely using `SafeAutoCorrect: true`.
       #   [1, 2, 3].reduce(10, :+)
@@ -70,6 +70,9 @@ module RuboCop
       class Sum < Base
         include RangeHelp
         extend AutoCorrector
+        extend TargetRubyVersion
+
+        minimum_target_ruby_version 2.4
 
         MSG = 'Use `%<good_method>s` instead of `%<bad_method>s`.'
         MSG_IF_NO_INIT_VALUE =
@@ -180,7 +183,7 @@ module RuboCop
         end
 
         def sum_method_range(node)
-          range_between(node.loc.selector.begin_pos, node.loc.expression.end_pos)
+          range_between(node.loc.selector.begin_pos, node.source_range.end_pos)
         end
 
         def sum_map_range(map, sum)

data/lib/rubocop/cop/performance/times_map.rb

@@ -3,7 +3,7 @@
 module RuboCop
   module Cop
     module Performance
-      # This cop checks for .times.map calls.
+      # Checks for .times.map calls.
       # In most cases such calls can be replaced
       # with an explicit array creation.
       #
@@ -32,8 +32,7 @@ module RuboCop
       class TimesMap < Base
         extend AutoCorrector
 
-        MESSAGE = 'Use `Array.new(%<count>s)` with a block ' \
-                  'instead of `.times.%<map_or_collect>s`'
+        MESSAGE = 'Use `Array.new(%<count>s)` with a block instead of `.times.%<map_or_collect>s`'
         MESSAGE_ONLY_IF = 'only if `%<count>s` is always 0 or more'
         RESTRICT_ON_SEND = %i[map collect].freeze
 
@@ -44,16 +43,16 @@ module RuboCop
         def on_block(node)
           check(node)
         end
+        alias on_numblock on_block
 
         private
 
         def check(node)
           times_map_call(node) do |map_or_collect, count|
             add_offense(node, message: message(map_or_collect, count)) do |corrector|
-              replacement = "Array.new(#{count.source}" \
-                            "#{map_or_collect.arguments.map { |arg| ", #{arg.source}" }.join})"
+              replacement = "Array.new(#{count.source}#{map_or_collect.arguments.map { |arg| ", #{arg.source}" }.join})"
 
-              corrector.replace(map_or_collect.loc.expression, replacement)
+              corrector.replace(map_or_collect, replacement)
             end
           end
         end
@@ -68,7 +67,7 @@ module RuboCop
         end
 
         def_node_matcher :times_map_call, <<~PATTERN
-          {(block $(send (send $!nil? :times) {:map :collect}) ...)
+          {({block numblock} $(send (send $!nil? :times) {:map :collect}) ...)
            $(send (send $!nil? :times) {:map :collect} (block_pass ...))}
         PATTERN
       end

data/lib/rubocop/cop/performance/uri_default_parser.rb

@@ -3,8 +3,7 @@
 module RuboCop
   module Cop
     module Performance
-      # This cop identifies places where `URI::Parser.new`
-      # can be replaced by `URI::DEFAULT_PARSER`.
+      # Identifies places where `URI::Parser.new` can be replaced by `URI::DEFAULT_PARSER`.
       #
       # @example
       #   # bad
@@ -16,8 +15,7 @@ module RuboCop
       class UriDefaultParser < Base
         extend AutoCorrector
 
-        MSG = 'Use `%<double_colon>sURI::DEFAULT_PARSER` instead of ' \
-              '`%<double_colon>sURI::Parser.new`.'
+        MSG = 'Use `%<double_colon>sURI::DEFAULT_PARSER` instead of `%<double_colon>sURI::Parser.new`.'
         RESTRICT_ON_SEND = %i[new].freeze
 
         def_node_matcher :uri_parser_new?, <<~PATTERN
@@ -27,12 +25,12 @@ module RuboCop
         PATTERN
 
         def on_send(node)
-          return unless uri_parser_new?(node) do |captured_value|
+          uri_parser_new?(node) do |captured_value|
             double_colon = captured_value ? '::' : ''
             message = format(MSG, double_colon: double_colon)
 
             add_offense(node, message: message) do |corrector|
-              corrector.replace(node.loc.expression, "#{double_colon}URI::DEFAULT_PARSER")
+              corrector.replace(node, "#{double_colon}URI::DEFAULT_PARSER")
             end
           end
         end

data/lib/rubocop/cop/performance_cops.rb

@@ -25,6 +25,7 @@ require_relative 'performance/fixed_size'
 require_relative 'performance/flat_map'
 require_relative 'performance/inefficient_hash_search'
 require_relative 'performance/map_compact'
+require_relative 'performance/map_method_chain'
 require_relative 'performance/method_object_as_block'
 require_relative 'performance/open_struct'
 require_relative 'performance/range_include'

data/lib/rubocop/performance/version.rb

@@ -4,7 +4,7 @@ module RuboCop
   module Performance
     # This module holds the RuboCop Performance version information.
     module Version
-      STRING = '1.13.3'
+      STRING = '1.19.0'
 
       def self.document_version
         STRING.match('\d+\.\d+').to_s

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rubocop-performance
 version: !ruby/object:Gem::Version
-  version: 1.13.3
+  version: 1.19.0
 platform: ruby
 authors:
 - Bozhidar Batsov
@@ -10,7 +10,7 @@ authors:
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2022-03-05 00:00:00.000000000 Z
+date: 2023-08-13 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop
@@ -87,6 +87,7 @@ files:
 - lib/rubocop/cop/performance/inefficient_hash_search.rb
 - lib/rubocop/cop/performance/io_readlines.rb
 - lib/rubocop/cop/performance/map_compact.rb
+- lib/rubocop/cop/performance/map_method_chain.rb
 - lib/rubocop/cop/performance/method_object_as_block.rb
 - lib/rubocop/cop/performance/open_struct.rb
 - lib/rubocop/cop/performance/range_include.rb
@@ -123,7 +124,7 @@ metadata:
   homepage_uri: https://docs.rubocop.org/rubocop-performance/
   changelog_uri: https://github.com/rubocop/rubocop-performance/blob/master/CHANGELOG.md
   source_code_uri: https://github.com/rubocop/rubocop-performance/
-  documentation_uri: https://docs.rubocop.org/rubocop-performance/1.13/
+  documentation_uri: https://docs.rubocop.org/rubocop-performance/1.19/
   bug_tracker_uri: https://github.com/rubocop/rubocop-performance/issues
   rubygems_mfa_required: 'true'
 post_install_message:
@@ -134,14 +135,14 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: 2.5.0
+      version: 2.7.0
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.3.3
+rubygems_version: 3.5.0.dev
 signing_key:
 specification_version: 4
 summary: Automatic performance checking tool for Ruby code.