rubocop-performance 1.13.0 → 1.13.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 874ce36b942ed539ead8c3329a7dd6831224459a286c2b3189605775e725fc60
-  data.tar.gz: 584a851432d98e548151baa8afc1f9a30d5dcca05f8eae0d86c68f17bf933f34
+  metadata.gz: cc8de809f0aa167f08fd75ed2f7047fabc37b06b12a0c59e4647530b18fb6d99
+  data.tar.gz: df849a7c117eb44d8851969031cda6d5927e2f271ad41bc3689212bad6b9e2e1
 SHA512:
-  metadata.gz: 102cccbb3be2ba55702a2e7aff3c56c6325c80481d269f87921ca1d16a79fa12830c6f080f49bacdebf4b5726e4f4c42af2527c13a4abac5aae0cf4544fb018e
-  data.tar.gz: 23c8beebceef175caf7e226a136bb3eaff500b71f5e3e26cba9fee9a84e36aa7a3b315b11216844b7980a421a82fff7a5346560ef1418f58fbe5261599fe4dec
+  metadata.gz: 24c72e01dfa6cfe35b3c93e1c83d63aaa0362dff7bc4ed234b8b6f8c1a434927a945b077273ec84c95be86d70e050f28e18dad27ffc9c72350f49c7ff3477b4a
+  data.tar.gz: 3340644f87ea108d8f7022756ff5cdf442b0d2951cd9ea351bb0a4012c2d0721dc921b1402e8b5f952899015b51c402cdbcab5e785d764f4655aa068c71be6b3

data/LICENSE.txt

@@ -1,4 +1,4 @@
-Copyright (c) 2012-21 Bozhidar Batsov
+Copyright (c) 2012-22 Bozhidar Batsov
 
 Permission is hereby granted, free of charge, to any person obtaining
 a copy of this software and associated documentation files (the

data/lib/rubocop/cop/performance/block_given_with_explicit_block.rb

@@ -38,8 +38,9 @@ module RuboCop
 
           block_arg = def_node.arguments.find(&:blockarg_type?)
           return unless block_arg
+          return unless (block_arg_name = block_arg.loc.name)
 
-          block_arg_name = block_arg.loc.name.source.to_sym
+          block_arg_name = block_arg_name.source.to_sym
           return if reassigns_block_arg?(def_node, block_arg_name)
 
           add_offense(node) do |corrector|

data/lib/rubocop/cop/performance/chain_array_allocation.rb

@@ -3,18 +3,16 @@
 module RuboCop
   module Cop
     module Performance
-      # This cop is used to identify usages of
+      # This cop is used to identify usages of `array.compact.flatten.map { |x| x.downcase }`.
+      # Each of these methods (`compact`, `flatten`, `map`) will generate a new intermediate array
+      # that is promptly thrown away. Instead it is faster to mutate when we know it's safe.
+      #
       # @example
       #   # bad
       #   array = ["a", "b", "c"]
       #   array.compact.flatten.map { |x| x.downcase }
       #
-      # Each of these methods (`compact`, `flatten`, `map`) will generate a
-      # new intermediate array that is promptly thrown away. Instead it is
-      # faster to mutate when we know it's safe.
-      #
-      # @example
-      #   # good.
+      #   # good
       #   array = ["a", "b", "c"]
       #   array.compact!
       #   array.flatten!

data/lib/rubocop/cop/performance/map_compact.rb

@@ -58,17 +58,17 @@ module RuboCop
 
           add_offense(range) do |corrector|
             corrector.replace(map_node.loc.selector, 'filter_map')
-            remove_compact_method(corrector, node, node.parent)
+            remove_compact_method(corrector, map_node, node, node.parent)
           end
         end
 
         private
 
-        def remove_compact_method(corrector, compact_node, chained_method)
+        def remove_compact_method(corrector, map_node, compact_node, chained_method)
           compact_method_range = compact_node.loc.selector
 
           if compact_node.multiline? && chained_method&.loc.respond_to?(:selector) && chained_method.dot? &&
-             !map_method_and_compact_method_on_same_line?(compact_node) &&
+             !map_method_and_compact_method_on_same_line?(map_node, compact_node) &&
              !invoke_method_after_map_compact_on_same_line?(compact_node, chained_method)
             compact_method_range = compact_method_with_final_newline_range(compact_method_range)
           else
@@ -78,11 +78,7 @@ module RuboCop
           corrector.remove(compact_method_range)
         end
 
-        def map_method_and_compact_method_on_same_line?(compact_node)
-          return false unless compact_node.children.first.respond_to?(:send_node)
-
-          map_node = compact_node.children.first.send_node
-
+        def map_method_and_compact_method_on_same_line?(map_node, compact_node)
           compact_node.loc.selector.line == map_node.loc.selector.line
         end
 

data/lib/rubocop/cop/performance/string_identifier_argument.rb

@@ -27,8 +27,11 @@ module RuboCop
 
         MSG = 'Use `%<symbol_arg>s` instead of `%<string_arg>s`.'
 
+        # NOTE: `attr` method is not included in this list as it can cause false positives in Nokogiri API.
+        # And `attr` may not be used because `Style/Attr` registers an offense.
+        # https://github.com/rubocop/rubocop-performance/issues/278
         RESTRICT_ON_SEND = %i[
-          alias_method attr attr_accessor attr_reader attr_writer autoload autoload?
+          alias_method attr_accessor attr_reader attr_writer autoload autoload?
           class_variable_defined? const_defined? const_get const_set const_source_location
           define_method instance_method method_defined? private_class_method? private_method_defined?
           protected_method_defined? public_class_method public_instance_method public_method_defined?

data/lib/rubocop/performance/version.rb

@@ -4,7 +4,7 @@ module RuboCop
   module Performance
     # This module holds the RuboCop Performance version information.
     module Version
-      STRING = '1.13.0'
+      STRING = '1.13.3'
 
       def self.document_version
         STRING.match('\d+\.\d+').to_s

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rubocop-performance
 version: !ruby/object:Gem::Version
-  version: 1.13.0
+  version: 1.13.3
 platform: ruby
 authors:
 - Bozhidar Batsov
@@ -10,7 +10,7 @@ authors:
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2021-12-25 00:00:00.000000000 Z
+date: 2022-03-05 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop
@@ -141,7 +141,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.3.0
+rubygems_version: 3.3.3
 signing_key:
 specification_version: 4
 summary: Automatic performance checking tool for Ruby code.