rubocop-performance 1.10.1 → 1.10.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 026fa40bed33c9e7867599f1024ddf6c1ab430b00beae5f5ec52d9b32f5adef9
-  data.tar.gz: d0997dd1a5255e217f5faf2adc4f27b64a43266ff24264aa80307b474cbfa936
+  metadata.gz: 739dfb0dfbef0fa9962b144cb8cb3c600b801a86adc11877898a8eba957a2f39
+  data.tar.gz: 0c5f89ad71bbe81a9c9e42c418401039c9dc0f2ede40fd54c3ba1bc4955011f9
 SHA512:
-  metadata.gz: 7a09ace7478bf3d87dc35897bb677c802c6b191ce0206e1b94e04826091ce8075ad9f267cd7805cd68ba3476c679e3cdb59c219fd71760ac4756c26a209c51bc
-  data.tar.gz: f9ccef454d4c9ff9a8d67db5276d2249d03a2882b169abfc5d4bacc28f9f09391edb15100750480c354fe9cc161463156169f216d482c9504f7d6a17da524a0c
+  metadata.gz: 07cb8c4fc7d80cac74841d9c8bdde26397c4e4273d2ef80b805388020c17cf6820c497a8ea4bfc4a39ca93f538fc2b642399e9fdb1acc401e2e0dad1bf5596d8
+  data.tar.gz: 74696267b3ad0b9ab49aeacfab1de661ab22140a5cea173caa82ddd206159dadc214b996812a5521d1f912c44dfa84cca822d5159c2d8b45426fe1aa55d00896

data/lib/rubocop/cop/performance/redundant_block_call.rb

@@ -78,7 +78,7 @@ module RuboCop
         end
 
         def calls_to_report(argname, body)
-          return [] if blockarg_assigned?(body, argname)
+          return [] if blockarg_assigned?(body, argname) || shadowed_block_argument?(body, argname)
 
           blockarg_calls(body, argname).map do |call|
             return [] if args_include_block_pass?(call)
@@ -87,6 +87,12 @@ module RuboCop
           end
         end
 
+        def shadowed_block_argument?(body, block_argument_of_method_signature)
+          return false unless body.block_type?
+
+          body.arguments.map(&:source).include?(block_argument_of_method_signature.to_s)
+        end
+
         def args_include_block_pass?(blockcall)
           _receiver, _call, *args = *blockcall
 

data/lib/rubocop/cop/performance/redundant_equality_comparison_block.rb

@@ -35,7 +35,8 @@ module RuboCop
         IS_A_METHODS = %i[is_a? kind_of?].freeze
 
         def on_block(node)
-          return unless TARGET_METHODS.include?(node.method_name) && node.arguments.one?
+          return unless TARGET_METHODS.include?(node.method_name)
+          return unless one_block_argument?(node.arguments)
 
           block_argument = node.arguments.first
           block_body = node.body
@@ -53,14 +54,22 @@ module RuboCop
 
         private
 
+        def one_block_argument?(block_arguments)
+          block_arguments.one? && !block_arguments.source.include?(',')
+        end
+
         def use_equality_comparison_block?(block_body)
           block_body.send_type? && COMPARISON_METHODS.include?(block_body.method_name)
         end
 
         def same_block_argument_and_is_a_argument?(block_body, block_argument)
-          return false unless IS_A_METHODS.include?(block_body.method_name)
-
-          block_argument.source == block_body.first_argument.source
+          if block_body.method?(:===)
+            block_argument.source != block_body.children[2].source
+          elsif IS_A_METHODS.include?(block_body.method_name)
+            block_argument.source == block_body.first_argument.source
+          else
+            false
+          end
         end
 
         def new_argument(block_argument, block_body)

data/lib/rubocop/cop/performance/redundant_split_regexp_argument.rb

@@ -26,7 +26,7 @@ module RuboCop
 
         def on_send(node)
           return unless (regexp_node = split_call_with_regexp?(node))
-          return if regexp_node.ignore_case?
+          return if regexp_node.ignore_case? || regexp_node.content == ' '
           return unless determinist_regexp?(regexp_node)
 
           add_offense(regexp_node) do |corrector|

data/lib/rubocop/cop/performance/reverse_each.rb

@@ -6,12 +6,20 @@ module RuboCop
       # This cop is used to identify usages of `reverse.each` and
       # change them to use `reverse_each` instead.
       #
+      # If the return value is used, it will not be detected because the result will be different.
+      #
+      # [source,ruby]
+      # ----
+      # [1, 2, 3].reverse.each {} #=> [3, 2, 1]
+      # [1, 2, 3].reverse_each {} #=> [1, 2, 3]
+      # ----
+      #
       # @example
       #   # bad
-      #   [].reverse.each
+      #   items.reverse.each
       #
       #   # good
-      #   [].reverse_each
+      #   items.reverse_each
       class ReverseEach < Base
         include RangeHelp
         extend AutoCorrector
@@ -24,6 +32,8 @@ module RuboCop
         MATCHER
 
         def on_send(node)
+          return if use_return_value?(node)
+
           reverse_each?(node) do
             range = offense_range(node)
 
@@ -35,6 +45,12 @@ module RuboCop
 
         private
 
+        def use_return_value?(node)
+          !!node.ancestors.detect do |ancestor|
+            ancestor.assignment? || ancestor.send_type? || ancestor.return_type?
+          end
+        end
+
         def offense_range(node)
           range_between(node.children.first.loc.selector.begin_pos, node.loc.selector.end_pos)
         end

data/lib/rubocop/performance/version.rb

@@ -4,7 +4,7 @@ module RuboCop
   module Performance
     # This module holds the RuboCop Performance version information.
     module Version
-      STRING = '1.10.1'
+      STRING = '1.10.2'
 
       def self.document_version
         STRING.match('\d+\.\d+').to_s

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rubocop-performance
 version: !ruby/object:Gem::Version
-  version: 1.10.1
+  version: 1.10.2
 platform: ruby
 authors:
 - Bozhidar Batsov
@@ -10,7 +10,7 @@ authors:
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2021-03-01 00:00:00.000000000 Z
+date: 2021-03-22 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop