rubocop-performance 1.10.0 → 1.10.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: c936c552e05f2364a4256d5f0975973ee3a332270bc1af524db3420e9fc70ba5
-  data.tar.gz: 3cd0086460c2db1c5926caef0737a1d9ae4038808b58b7c91f97e349cfe8f1b6
+  metadata.gz: 026fa40bed33c9e7867599f1024ddf6c1ab430b00beae5f5ec52d9b32f5adef9
+  data.tar.gz: d0997dd1a5255e217f5faf2adc4f27b64a43266ff24264aa80307b474cbfa936
 SHA512:
-  metadata.gz: cdc03f8c28e3ea1f63a8477fe064cf1df766f6334fc017d5f8bc7a830f189ad11c1f5a65a33008469b4fe8438522f64b56e6b026fdadb208abf18181d2a6d261
-  data.tar.gz: 04034d2353dc721670ac494d40fae7383ba3800923feea6140c8ea9d86ee080028bc8fb05e46deeb475f1365705114d6a3848520e01248076f38f6e4ef18282f
+  metadata.gz: 7a09ace7478bf3d87dc35897bb677c802c6b191ce0206e1b94e04826091ce8075ad9f267cd7805cd68ba3476c679e3cdb59c219fd71760ac4756c26a209c51bc
+  data.tar.gz: f9ccef454d4c9ff9a8d67db5276d2249d03a2882b169abfc5d4bacc28f9f09391edb15100750480c354fe9cc161463156169f216d482c9504f7d6a17da524a0c

data/lib/rubocop/cop/performance/redundant_equality_comparison_block.rb

@@ -32,13 +32,15 @@ module RuboCop
 
         TARGET_METHODS = %i[all? any? one? none?].freeze
         COMPARISON_METHODS = %i[== === is_a? kind_of?].freeze
+        IS_A_METHODS = %i[is_a? kind_of?].freeze
 
         def on_block(node)
-          return unless TARGET_METHODS.include?(node.method_name)
+          return unless TARGET_METHODS.include?(node.method_name) && node.arguments.one?
 
           block_argument = node.arguments.first
           block_body = node.body
           return unless use_equality_comparison_block?(block_body)
+          return if same_block_argument_and_is_a_argument?(block_body, block_argument)
           return unless (new_argument = new_argument(block_argument, block_body))
 
           range = offense_range(node)
@@ -55,6 +57,12 @@ module RuboCop
           block_body.send_type? && COMPARISON_METHODS.include?(block_body.method_name)
         end
 
+        def same_block_argument_and_is_a_argument?(block_body, block_argument)
+          return false unless IS_A_METHODS.include?(block_body.method_name)
+
+          block_argument.source == block_body.first_argument.source
+        end
+
         def new_argument(block_argument, block_body)
           if block_argument.source == block_body.receiver.source
             block_body.first_argument.source

data/lib/rubocop/cop/performance/redundant_split_regexp_argument.rb

@@ -21,32 +21,29 @@ module RuboCop
         STR_SPECIAL_CHARS = %w[\n \" \' \\\\ \t \b \f \r].freeze
 
         def_node_matcher :split_call_with_regexp?, <<~PATTERN
-          {(send !nil? :split {regexp})}
+          {(send !nil? :split $regexp)}
         PATTERN
 
         def on_send(node)
-          return unless split_call_with_regexp?(node)
-          return unless determinist_regexp?(node.first_argument)
+          return unless (regexp_node = split_call_with_regexp?(node))
+          return if regexp_node.ignore_case?
+          return unless determinist_regexp?(regexp_node)
 
-          add_offense(node.first_argument) do |corrector|
-            autocorrect(corrector, node)
+          add_offense(regexp_node) do |corrector|
+            new_argument = replacement(regexp_node)
+
+            corrector.replace(regexp_node, "\"#{new_argument}\"")
           end
         end
 
         private
 
-        def determinist_regexp?(first_argument)
-          DETERMINISTIC_REGEX.match?(first_argument.source)
-        end
-
-        def autocorrect(corrector, node)
-          new_argument = replacement(node)
-
-          corrector.replace(node.first_argument, "\"#{new_argument}\"")
+        def determinist_regexp?(regexp_node)
+          DETERMINISTIC_REGEX.match?(regexp_node.source)
         end
 
-        def replacement(node)
-          regexp_content = node.first_argument.content
+        def replacement(regexp_node)
+          regexp_content = regexp_node.content
           stack = []
           chars = regexp_content.chars.each_with_object([]) do |char, strings|
             if stack.empty? && char == '\\'

data/lib/rubocop/performance/version.rb

@@ -4,7 +4,7 @@ module RuboCop
   module Performance
     # This module holds the RuboCop Performance version information.
     module Version
-      STRING = '1.10.0'
+      STRING = '1.10.1'
 
       def self.document_version
         STRING.match('\d+\.\d+').to_s

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rubocop-performance
 version: !ruby/object:Gem::Version
-  version: 1.10.0
+  version: 1.10.1
 platform: ruby
 authors:
 - Bozhidar Batsov
@@ -10,7 +10,7 @@ authors:
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2021-02-28 00:00:00.000000000 Z
+date: 2021-03-01 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop
@@ -135,7 +135,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.2.9
+rubygems_version: 3.2.12
 signing_key:
 specification_version: 4
 summary: Automatic performance checking tool for Ruby code.