rubocop-packs 0.0.33 → 0.0.35

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: e56f9a941b630002bfb4af833716b2cc58a3d2a3f21fbb673f86b04cf0eab0eb
-  data.tar.gz: abd74e0ecf25630da93a7ddff425060373787e33c209e0ce850599675ee6b842
+  metadata.gz: 70a81aaeac4498d122b9386a684f03850bf3493f16d8214d72d9b49a8e3d6b66
+  data.tar.gz: 4a620b25ea514911cb80a74ff7b6c1afccc6d5145c3da11422bb3d1f97bdd8f8
 SHA512:
-  metadata.gz: c45aa69414bc48fe5e0874defaee69dee2ddfc5372f4683ce9644c70aace411e64c46ef3630513d4e6660868116116ef2dc4d03363865e7f39059ffa5630e007
-  data.tar.gz: 794ffd4ad403ca046bac4b22e21d419207fe9bb49215ef8b56f3b5f3b3ef7ced9e8cbd33c331a7b13f9d8e0aebb986d9c512d14b880af757bb6e52cc0ba8b1b0
+  metadata.gz: 7b31d9f3dd7706aee30acd3bc13127bacc8fad829cf7216cc58fd48b5c2443ae4c582d13de8508f17304dfde885f58c01693c3d5b5861df4419fbd574889e2ab
+  data.tar.gz: b696f3b449ddc0fa0300104fdc7fd9402a7c8a7db2d43d282b56a3aaa31d5c41569a0917e7e93d39188a88e068b1ae3cdd4bca45eac5a6feee1d542331cad211

data/config/default.yml

@@ -29,4 +29,9 @@ PackwerkLite/Dependency:
   Enabled: false
 
 # We do this inherit *after* setting the defaults so that pack-specific rubocops can override the defaults
-inherit_from: ./pack_config.yml
+# Relevant documentation:
+#  - Inheriting config from a gem:
+#    - https://docs.rubocop.org/rubocop/configuration.html#inheriting-configuration-from-a-dependency-gem
+#  - ERB in a .rubocop.yml file
+#    - https://docs.rubocop.org/rubocop/configuration.html#pre-processing
+<%= RuboCop::Packs.pack_based_rubocop_config %>

data/lib/rubocop/cop/packs/documented_public_apis.rb

@@ -54,9 +54,14 @@ module RuboCop
           return if non_public?(node) && !require_for_non_public_methods?
 
           left_sibling = node.left_sibling
-          left_sibling_is_sig = left_sibling && (left_sibling.source.include?('sig do') || left_sibling.source.include?('sig {'))
-          # Is there a better way to check if the left sibling is a sorbet signature? Probably!
-          if left_sibling_is_sig
+
+          if left_sibling == :private_class_method
+            if node_is_sorbet_signature?(node.parent.left_sibling)
+              return if documentation_comment?(node.parent.left_sibling)
+            elsif documentation_comment?(node.parent)
+              return
+            end
+          elsif node_is_sorbet_signature?(left_sibling)
             return if documentation_comment?(node.left_sibling)
           elsif documentation_comment?(node)
             return
@@ -64,6 +69,12 @@ module RuboCop
 
           add_offense(node)
         end
+
+        sig { params(node: T.untyped).returns(T::Boolean) }
+        def node_is_sorbet_signature?(node)
+          # Is there a better way to check if a node is a sorbet signature? Probably!
+          !!(node && (node.source.include?('sig do') || node.source.include?('sig {')))
+        end
       end
     end
   end

data/lib/rubocop/packs.rb

@@ -17,7 +17,6 @@ module RuboCop
 
     PROJECT_ROOT   = T.let(Pathname.new(__dir__).parent.parent.expand_path.freeze, Pathname)
     CONFIG_DEFAULT = T.let(PROJECT_ROOT.join('config', 'default.yml').freeze, Pathname)
-    CONFIG         = T.let(YAML.safe_load(CONFIG_DEFAULT.read).freeze, T.untyped)
 
     private_constant(:CONFIG_DEFAULT, :PROJECT_ROOT)
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rubocop-packs
 version: !ruby/object:Gem::Version
-  version: 0.0.33
+  version: 0.0.35
 platform: ruby
 authors:
 - Gusto Engineers
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2022-12-28 00:00:00.000000000 Z
+date: 2023-02-17 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -201,7 +201,6 @@ extra_rdoc_files: []
 files:
 - README.md
 - config/default.yml
-- config/pack_config.yml
 - lib/rubocop-packs.rb
 - lib/rubocop/cop/packs/class_methods_as_public_apis.rb
 - lib/rubocop/cop/packs/documented_public_apis.rb

data/config/pack_config.yml

@@ -1,6 +0,0 @@
-# Relevant documentation:
-#  - Inheriting config from a gem:
-#    - https://docs.rubocop.org/rubocop/configuration.html#inheriting-configuration-from-a-dependency-gem
-#  - ERB in a .rubocop.yml file
-#    - https://docs.rubocop.org/rubocop/configuration.html#pre-processing
-<%= RuboCop::Packs.pack_based_rubocop_config %>