rubocop-packs 0.0.27 → 0.0.29

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: e25f6b7faaf75d2877d830e784211d96ba5d6cb29b442c959552e1de28c5adbd
-  data.tar.gz: eff6ee7fe761edb2bb142f4cf543557b4d17a160990dccc364972bd87208ccd8
+  metadata.gz: 3696297e1ff13e40a7dbfee5a582c67490833b383b968469f9d2d94ab5ffee5d
+  data.tar.gz: ff4e0adde358d7540e3e5a568d9fd4e75b20145df58513579b30d9c754a00509
 SHA512:
-  metadata.gz: cd2ffeb81ef84b49be4ae73216d3318f45d1bf9ad70bcc77061509bbae0f848a1ff0a87ba12082c6091f32b00fef0a1a303d360dba7d07a8c2de60e255186888
-  data.tar.gz: 52163c30ba8037b43c0aaa1659bf42723e4dcd0b570b5b6e7d0f2e72e526a2e3fab6456ed3c9e934bad894b3aed9b9e3103b908dbe9d012be2081c5d42312022
+  metadata.gz: 5a78487b44c2b54f4b4f96f829bb436b928c044005d9625e76d27a4453f278f08fb78b9605246e67125168b64479111ed157d54b129d19df9da98e09d4593772
+  data.tar.gz: 19dbf44e2bb2424e6638efdab5b366b6a06ffdaeb4649cabf5aa6008bc6a4158a5569769f505a040c4dab75b068dac82b64a5cb8c50164818d5f0ee6adaf311e

data/config/default.yml

@@ -5,6 +5,7 @@ Packs/ClassMethodsAsPublicApis:
     - T::Struct
     - Struct
     - OpenStruct
+  AcceptableMixins: []
   FailureMode: default
 
 Packs/RootNamespaceIsPackName:

data/lib/rubocop/cop/packs/class_methods_as_public_apis.rb

@@ -10,6 +10,7 @@ module RuboCop
       # Options:
       #
       # * `AcceptableParentClasses`: A list of classes that, if inherited from, non-class methods are permitted (useful when value objects are a part of your public API)
+      # * `AcceptableMixins`: A list of modules that, if included, non-class methods are permitted
       #
       # @example
       #
@@ -47,11 +48,14 @@ module RuboCop
 
           acceptable_parent_classes = cop_config['AcceptableParentClasses'] || []
 
-          # Used this PR as inspiration to check if we're within a `class << self` block
           uses_implicit_static_methods = node.each_ancestor(:sclass).first&.identifier&.source == 'self'
           class_is_allowed_to_have_instance_methods = acceptable_parent_classes.include?(parent_class&.const_name)
           return if uses_implicit_static_methods || class_is_allowed_to_have_instance_methods
 
+          is_sorbet_interface_or_abstract_class = !module_node.nil? && module_node.descendants.any? { |d| d.is_a?(RuboCop::AST::SendNode) && (d.method_name == :interface! || d.method_name == :abstract!) }
+          return if is_sorbet_interface_or_abstract_class
+          return if node_includes_acceptable_mixin?(class_node || module_node)
+
           add_offense(
             node.source_range,
             message: format(
@@ -59,6 +63,22 @@ module RuboCop
             )
           )
         end
+
+        private
+
+        sig { params(node: T.untyped).returns(T::Boolean) }
+        def node_includes_acceptable_mixin?(node)
+          acceptable_mixins = cop_config['AcceptableMixins'] || []
+          return false if node.nil?
+
+          node.descendants.any? do |d|
+            d.is_a?(RuboCop::AST::SendNode) &&
+              d.method_name == :include &&
+              d.arguments.count == 1 &&
+              d.arguments.first.is_a?(RuboCop::AST::ConstNode) &&
+              acceptable_mixins.include?(d.arguments.first.const_name)
+          end
+        end
       end
     end
   end

data/lib/rubocop/packs.rb

@@ -35,9 +35,14 @@ module RuboCop
       end
 
       paths = packs.empty? ? files : packs.map(&:name).reject { |name| name == ParsePackwerk::ROOT_PACKAGE_NAME }
+
+      cop_names = config.permitted_pack_level_cops.select do |cop_name|
+        YAML.load_file('.rubocop.yml').fetch(cop_name, {})['Enabled']
+      end
+
       offenses = Private.offenses_for(
         paths: paths,
-        cop_names: config.permitted_pack_level_cops
+        cop_names: cop_names
       )
 
       offenses.group_by(&:pack).each do |pack, offenses_for_pack|
@@ -51,9 +56,11 @@ module RuboCop
           rubocop_todo = {}
         end
 
-        offenses_for_pack.each do |offense|
-          rubocop_todo[offense.cop_name] ||= { 'Exclude' => [] }
-          rubocop_todo[offense.cop_name]['Exclude'] << offense.filepath
+        offenses_for_pack.group_by(&:filepath).each do |filepath, offenses_by_filepath|
+          offenses_by_filepath.map(&:cop_name).uniq.each do |cop_name|
+            rubocop_todo[cop_name] ||= { 'Exclude' => [] }
+            rubocop_todo[cop_name]['Exclude'] << filepath
+          end
         end
 
         next if rubocop_todo.empty?

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rubocop-packs
 version: !ruby/object:Gem::Version
-  version: 0.0.27
+  version: 0.0.29
 platform: ruby
 authors:
 - Gusto Engineers
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2022-11-19 00:00:00.000000000 Z
+date: 2022-11-23 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -178,7 +178,7 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
-description: Fill this out!
+description: A collection of Rubocop rules for gradually modularizing a ruby codebase
 email:
 - dev@gusto.com
 executables: []
@@ -230,5 +230,5 @@ requirements: []
 rubygems_version: 3.1.6
 signing_key: 
 specification_version: 4
-summary: Fill this out!
+summary: A collection of Rubocop rules for gradually modularizing a ruby codebase
 test_files: []