rubocop-packs 0.0.15 → 0.0.17

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 36726c94e4904ac2823f941a57fb7f5f725b28bb73fc2e837c7d75d41d55dfbe
-  data.tar.gz: cc6d345f6e81eb66edfaefece8a2c9727d471bbd3b86164ded3baf20d3989378
+  metadata.gz: 36151891d908f1db1ea404ec0890094a874ad30cd49bafe4ba6be84cc07f3234
+  data.tar.gz: d9cd4893c8bc730407e7cc777947a03b0f52290ea11c98d84f74cbafbbb23d41
 SHA512:
-  metadata.gz: 80d9e6eb7777118a44a813c88cdca22eb67281723e1dad9d995db9f7d557fde5cf48da9a4dd6596803a667c6622c714c93137e1bc7e2deae5d4d46c3a1f81849
-  data.tar.gz: 31e23a78b39d7e776c398cfe55f89e78d3d58bc761a69d3d1abc1298120b109c939eef96ce0653ec0337a1f4d05dc40b40b636dde0bb25ce0916b036ada526c1
+  metadata.gz: 9949c24590b6afe33471b75e71319ff6070e1b1040cb62652299f31af2fb9381603250e20e182b7ef0fdacd016e82282aea6c779e5ee242e17a23eac9a8e2459
+  data.tar.gz: ba7cf7c051c6f4e0306e8215e6e3d8cb33f9fb4095ce0634ddb79297a57cc9963323f74b1f69b88a74560f67dfe8342a27fde53d819b46e665a238c011bc6175

data/README.md

@@ -52,9 +52,9 @@ To add a per-pack `.rubocop.yml`, you just need to create a `packs/your_pack/.ru
 inherit_from: '../../.rubocop.yml'
 ```
 
-Note though that inherited paths are relative to your pack-level `.rubocop.yml`. To avoid that, you can rename your `.rubocop.yml` to `.inherited_rubocop.yml`, set `.rubocop.yml` to:
+Note though that inherited paths are relative to your pack-level `.rubocop.yml`. To avoid that, you can rename your `.rubocop.yml` to `.base_rubocop.yml`, set `.rubocop.yml` to:
 ```
-inherit_from: '.inherited_rubocop.yml'
+inherit_from: '.base_rubocop.yml'
 ```
 And then similarly change the `inherit_from` in `packs/your_pack/.rubocop.yml`.
 

data/lib/rubocop/packs/private.rb

@@ -85,6 +85,8 @@ module RuboCop
         end
 
         loaded_rubocop_yml.each_key do |key|
+          next if key.to_s == 'inherit_from'
+
           if !Packs.config.permitted_pack_level_cops.include?(key)
             errors << <<~ERROR_MESSAGE
               #{rubocop_yml} contains invalid configuration for #{key}.

data/lib/rubocop/packs.rb

@@ -64,6 +64,31 @@ module RuboCop
       end
     end
 
+    #
+    # Ideally, this is API that is available to us via `rubocop` itself.
+    # That is: the ability to preserve the location of `.rubocop_todo.yml` files and associate
+    # exclusions with the closest ancestor `.rubocop_todo.yml`
+    #
+    sig { params(packs: T::Array[ParsePackwerk::Package]).void }
+    def self.set_default_rubocop_yml(packs:)
+      packs.each do |pack|
+        rubocop_yml = Pathname.new(pack.directory.join('.rubocop.yml'))
+        rubocop_yml_hash = {}
+        rubocop_yml_hash['inherit_from'] = '../../.base_rubocop.yml'
+        config.required_pack_level_cops.each do |cop|
+          rubocop_yml_hash[cop] = { 'Enabled' => true }
+        end
+
+        formatted_yml = YAML.dump(rubocop_yml_hash).
+          # Remove the `---` header at the top of the file
+          gsub("---\n", '').
+          # Find lines of the form \nCopDepartment/CopName: and add a new line before it.
+          gsub(%r{^(\w+/\w+:)}, "\n\\1")
+
+        rubocop_yml.write(formatted_yml)
+      end
+    end
+
     sig { params(root_pathname: String).returns(String) }
     # It would be great if rubocop (upstream) could take in a glob for `inherit_from`, which
     # would allow us to delete this method and this additional complexity.

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rubocop-packs
 version: !ruby/object:Gem::Version
-  version: 0.0.15
+  version: 0.0.17
 platform: ruby
 authors:
 - Gusto Engineers
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2022-11-01 00:00:00.000000000 Z
+date: 2022-11-10 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport