rubocop-packaging 0.1.0 → 0.5.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 7763971e3ccedea64e6db97b4ec6351d489b99fe36110f4d01374a67bce0c0d1
-  data.tar.gz: 4e4e52ee808aba2ba256a757c225802cff30bafe9521ec33a259dbfe7f037e42
+  metadata.gz: 4e096b94cc72a619f1accaa3fda9021424a1954ddd3364d34df4c36e66cb8926
+  data.tar.gz: d96b87bbb45fd4448665e6578039f3c167818a78894066953cd4a87a0af3e2de
 SHA512:
-  metadata.gz: c2cdd53a7671b724141244e0efec24e8a4eeffbe3a4e9830b3eb6b80fbf487f74649e552b465b6b17f537d985278d7da38bba14fc9a816d781adee54aefb55d3
-  data.tar.gz: 9f16cf74a99ab1d56e01ad056440d2329013a441a62618eccc4e1ee2a6052ed7df4fd5565f095468feb7739c863ca957f9199a8a4e3c8db1de92958e5bf802c6
+  metadata.gz: 2d5f7400a946fc39f6de1907f01445d13e3935299058db606edef6e1527dae2efeb944921bee5e7bce5dfddc73d8e4fd39c1cc3a16105b0e1dcdb550a8962e71
+  data.tar.gz: f122820131b25c3fe87ce4c4abe5cce1f9fa22bed5e0bbf60e5fe68273ca4f8a089a7479ca9bf11a85d34227cae8878fd6875c0b7a3216e0bb7377aee73b27ac

data/README.md

@@ -5,9 +5,18 @@ which is a Ruby static code analyzer (a.k.a. linter) and code formatter.
 
 It helps enforcing some of the guidelines that are expected of upstream
 maintainers so that the downstream can build their packages in a clean
-environment without any problems.  
-Some of the other basic guidelines can be found
-[here](https://wiki.debian.org/Teams/Ruby/RubyExtras/UpstreamDevelopers).
+environment without any problems.
+
+## Documentation
+
+A detailed documentation, explaining what this extension is doing and the
+reasoning behind it, can be found here: https://docs.rubocop.org/rubocop-packaging/
+
+We also have a [packaging-style-guide](https://packaging.rubystyle.guide/),
+listing some good and bad examples and the rationale behind these cops.
+
+In case anything is not clear, please feel free to raise an issue, asking
+for more explanation!
 
 ## Installation
 

data/config/default.yml

@@ -1,6 +1,36 @@
 # This is the default configuration file.
 
+Packaging/BundlerSetupInTests:
+  Description: >-
+                 Using `bundler/setup` in tests is redundant. Consider
+                 removing it.
+  Enabled: true
+  VersionAdded: '0.4'
+  VersionChanged: '0.5'
+
 Packaging/GemspecGit:
-  Description: 'Use pure Ruby alternative instead of `git ls-files`.'
+  Description: >-
+                 Using `bundler/setup` in tests is redundant. Consider
+                 Avoid using git to produce lists of files. Downstreams
+                 often need to build your package in an environment
+                 that does not have git (on purpose). Use some pure
+                 Ruby alternative, like `Dir` or `Dir.glob`.
+  Enabled: true
+  VersionAdded: '0.1'
+  VersionChanged: '0.1'
+
+Packaging/RequireHardcodingLib:
+  Description: >-
+                 Avoid using `require` with relative path to lib. Use
+                 `require` with absolute path instead.
+  Enabled: true
+  VersionAdded: '0.4'
+  VersionChanged: '0.5'
+
+Packaging/RequireRelativeHardcodingLib:
+  Description: >-
+                 Avoid using `require_relative` with relative path to
+                 lib. Use `require` with absolute path instead.
   Enabled: true
-  VersionAdded: '0.86'
+  VersionAdded: '0.2'
+  VersionChanged: '0.5'

data/lib/rubocop-packaging.rb

@@ -1,11 +1,11 @@
 # frozen_string_literal: true
 
-require 'rubocop'
+require "rubocop"
 
-require_relative 'rubocop/packaging'
-require_relative 'rubocop/packaging/version'
-require_relative 'rubocop/packaging/inject'
+require_relative "rubocop/packaging"
+require_relative "rubocop/packaging/version"
+require_relative "rubocop/packaging/inject"
 
 RuboCop::Packaging::Inject.defaults!
 
-require_relative 'rubocop/cop/packaging_cops'
+require_relative "rubocop/cop/packaging_cops"

data/lib/rubocop/cop/packaging/bundler_setup_in_tests.rb

@@ -0,0 +1,77 @@
+# frozen_string_literal: true
+
+require "rubocop/packaging/lib_helper_module"
+
+module RuboCop # :nodoc:
+  module Cop # :nodoc:
+    module Packaging # :nodoc:
+      # This cop flags the `require "bundler/setup"` calls if they're
+      # made from inside the tests directory.
+      #
+      # @example
+      #
+      #   # bad
+      #   require "foo"
+      #   require "bundler/setup"
+      #
+      #   # good
+      #   require "foo"
+      #
+      class BundlerSetupInTests < Base
+        include RuboCop::Packaging::LibHelperModule
+        include RangeHelp
+        extend AutoCorrector
+
+        # This is the message that will be displayed when RuboCop::Packaging finds
+        # an offense of using `require "bundler/setup"` in the tests directory.
+        MSG = "Using `bundler/setup` in tests is redundant. Consider removing it."
+
+        def_node_matcher :bundler_setup?, <<~PATTERN
+          (send nil? :require
+            (str #bundler_setup_in_test_dir?))
+        PATTERN
+
+        # Extended from the Base class.
+        # More about the `#on_new_investigation` method can be found here:
+        # https://github.com/rubocop-hq/rubocop/blob/343f62e4555be0470326f47af219689e21c61a37/lib/rubocop/cop/base.rb
+        #
+        # Processing of the AST happens here.
+        def on_new_investigation
+          @file_path = processed_source.file_path
+          @file_directory = File.dirname(@file_path)
+        end
+
+        # Extended from AST::Traversal.
+        # More about the `#on_send` method can be found here:
+        # https://github.com/rubocop-hq/rubocop-ast/blob/08d0f49a47af1e9a30a6d8f67533ba793c843d67/lib/rubocop/ast/traversal.rb#L112
+        def on_send(node)
+          return unless bundler_setup?(node)
+
+          add_offense(node) do |corrector|
+            autocorrect(corrector, node)
+          end
+        end
+
+        # Called from on_send, this method helps to autocorrect
+        # the offenses flagged by this cop.
+        def autocorrect(corrector, node)
+          range = range_by_whole_lines(node.source_range, include_final_newline: true)
+
+          corrector.remove(range)
+        end
+
+        # This method is called from inside `#def_node_matcher`.
+        # It flags an offense if the `require "bundler/setup"`
+        # call is made from the tests directory.
+        def bundler_setup_in_test_dir?(str)
+          str.eql?("bundler/setup") && falls_in_test_dir?
+        end
+
+        # This method determines if the call is made *from* the tests directory.
+        def falls_in_test_dir?
+          %w[spec specs test tests].any? { |dir| File.expand_path(@file_directory).start_with?("#{root_dir}/#{dir}") }
+        end
+      end
+    end
+  end
+end

data/lib/rubocop/cop/packaging/gemspec_git.rb

@@ -3,56 +3,59 @@
 module RuboCop # :nodoc:
   module Cop # :nodoc:
     module Packaging # :nodoc:
-      # This cop is used to identify the usage of `git ls-files`
+      # This cop flags the usage of `git ls-files` in gemspec
       # and suggests to use a plain Ruby alternative, like `Dir`,
-      # `Dir.glob` or `Rake::FileList` instead.
+      # `Dir.glob`, or `Rake::FileList` instead.
       #
       # @example
       #
       #   # bad
       #   Gem::Specification.new do |spec|
-      #     spec.files = `git ls-files`.split('\n')
+      #     spec.files         = `git ls-files`.split("\n")
+      #     spec.test_files    = `git ls-files -- spec`.split("\n")
       #   end
       #
-      #   # bad
+      #   # good
       #   Gem::Specification.new do |spec|
-      #     spec.files = Dir.chdir(File.expand_path('..', __FILE__)) do
-      #       `git ls-files -z`.split('\\x0').reject { |f| f.match(%r{^(test|spec|features)/}) }
-      #     end
+      #     spec.files         = Dir["lib/**/*", "LICENSE", "README.md"]
+      #     spec.test_files    = Dir["spec/**/*"]
       #   end
       #
       #   # bad
       #   Gem::Specification.new do |spec|
-      #     spec.files         = `git ls-files`.split('\n')
-      #     spec.test_files    = `git ls-files -- test/{functional,unit}/*`.split('\n')
-      #     spec.executables   = `git ls-files -- bin/*`.split('\n').map{ |f| File.basename(f) }
+      #     spec.files = Dir.chdir(File.expand_path(__dir__)) do
+      #       `git ls-files -z`.split("\\x0").reject { |f| f.match(%r{^(test|spec|features)/}) }
+      #     end
       #   end
       #
       #   # good
+      #   require "rake/file_list"
+      #
       #   Gem::Specification.new do |spec|
-      #     spec.files         = Dir['lib/**/*', 'LICENSE', 'README.md']
-      #     spec.test_files    = Dir['spec/**/*']
+      #     spec.files         = Rake::FileList["**/*"].exclude(*File.read(".gitignore").split)
       #   end
       #
-      #   # good
+      #   # bad
       #   Gem::Specification.new do |spec|
-      #     spec.files         = Rake::FileList['**/*'].exclude(*File.read('.gitignore').split)
+      #     spec.files         = `git ls-files -- lib/`.split("\n")
+      #     spec.test_files    = `git ls-files -- test/{functional,unit}/*`.split("\n")
+      #     spec.executables   = `git ls-files -- bin/*`.split("\n").map{ |f| File.basename(f) }
       #   end
       #
       #   # good
       #   Gem::Specification.new do |spec|
-      #     spec.files         = Dir.glob('lib/**/*')
-      #     spec.test_files    = Dir.glob('test/{functional,test}/*')
-      #     spec.executables   = Dir.glob('bin/*').map{ |f| File.basename(f) }
+      #     spec.files         = Dir.glob("lib/**/*")
+      #     spec.test_files    = Dir.glob("test/{functional,test}/*")
+      #     spec.executables   = Dir.glob("bin/*").map{ |f| File.basename(f) }
       #   end
       #
-      class GemspecGit < Cop
+      class GemspecGit < Base
         # This is the message that will be displayed when RuboCop finds an
         # offense of using `git ls-files`.
-        MSG = 'Avoid using git to produce lists of files. ' \
-          'Downstreams often need to build your package in an environment ' \
-          'that does not have git (on purpose). ' \
-          'Use some pure Ruby alternative, like `Dir` or `Dir.glob`.'
+        MSG = "Avoid using git to produce lists of files. " \
+              "Downstreams often need to build your package in an environment " \
+              "that does not have git (on purpose). " \
+              "Use some pure Ruby alternative, like `Dir` or `Dir.glob`."
 
         def_node_search :xstr, <<~PATTERN
           (block
@@ -68,20 +71,21 @@ module RuboCop # :nodoc:
         # https://github.com/rubocop-hq/rubocop/blob/59543c8e2b66bff249de131fa9105f3eb11e9edb/lib/rubocop/cop/cop.rb#L13-L25
         #
         # Processing of the AST happens here.
-        def investigate(processed_source)
+        def on_new_investigation
+          return if processed_source.blank?
+
           xstr(processed_source.ast).each do |node|
             add_offense(
-              processed_source.ast,
-              location: node.loc.expression,
+              node.loc.expression,
               message: MSG
             )
           end
         end
 
         # This method is called from inside `#def_node_search`.
-        # It is used to find strings which start with 'git'.
+        # It is used to find strings which start with "git".
         def starts_with_git?(str)
-          str.start_with?('git')
+          str.start_with?("git")
         end
       end
     end

data/lib/rubocop/cop/packaging/require_hardcoding_lib.rb

@@ -0,0 +1,108 @@
+# frozen_string_literal: true
+
+require "rubocop/packaging/lib_helper_module"
+
+module RuboCop # :nodoc:
+  module Cop # :nodoc:
+    module Packaging # :nodoc:
+      # This cop flags the `require` calls, from anywhere mapping to
+      # the "lib" directory, except originating from lib/.
+      #
+      # @example
+      #
+      #   # bad
+      #   require "../lib/foo/bar"
+      #
+      #   # good
+      #   require "foo/bar"
+      #
+      #   # bad
+      #   require File.expand_path("../../lib/foo", __FILE__)
+      #
+      #   # good
+      #   require "foo"
+      #
+      #   # bad
+      #   require File.expand_path("../../../lib/foo/bar/baz/qux", __dir__)
+      #
+      #   # good
+      #   require "foo/bar/baz/qux"
+      #
+      #   # bad
+      #   require File.dirname(__FILE__) + "/../../lib/baz/qux"
+      #
+      #   # good
+      #   require "baz/qux"
+      #
+      class RequireHardcodingLib < Base
+        include RuboCop::Packaging::LibHelperModule
+        extend AutoCorrector
+
+        # This is the message that will be displayed when RuboCop::Packaging
+        # finds an offense of using `require` with relative path to lib.
+        MSG = "Avoid using `require` with relative path to `lib/`. " \
+              "Use `require` with absolute path instead."
+
+        def_node_matcher :require?, <<~PATTERN
+          {(send nil? :require (str #falls_in_lib?))
+           (send nil? :require (send (const nil? :File) :expand_path (str #falls_in_lib?) (send nil? :__dir__)))
+           (send nil? :require (send (const nil? :File) :expand_path (str #falls_in_lib_using_file?) (str _)))
+           (send nil? :require (send (send (const nil? :File) :dirname {(str _) (send nil? _)}) :+ (str #falls_in_lib_with_file_dirname_plus_str?)))
+           (send nil? :require (dstr (begin (send (const nil? :File) :dirname {(str _) (send nil? _)})) (str #falls_in_lib_with_file_dirname_plus_str?)))}
+        PATTERN
+
+        # Extended from the Base class.
+        # More about the `#on_new_investigation` method can be found here:
+        # https://github.com/rubocop-hq/rubocop/blob/343f62e4555be0470326f47af219689e21c61a37/lib/rubocop/cop/base.rb
+        #
+        # Processing of the AST happens here.
+        def on_new_investigation
+          @file_path = processed_source.file_path
+          @file_directory = File.dirname(@file_path)
+        end
+
+        # Extended from AST::Traversal.
+        # More about the `#on_send` method can be found here:
+        # https://github.com/rubocop-hq/rubocop-ast/blob/08d0f49a47af1e9a30a6d8f67533ba793c843d67/lib/rubocop/ast/traversal.rb#L112
+        def on_send(node)
+          return unless require?(node)
+
+          add_offense(node) do |corrector|
+            corrector.replace(node, good_require_call)
+          end
+        end
+
+        # Called from on_send, this method helps to replace
+        # the "bad" require call with the "good" one.
+        def good_require_call
+          good_call = @str.sub(%r{^.*/lib/}, "")
+          %(require "#{good_call}")
+        end
+
+        # This method is called from inside `#def_node_matcher`.
+        # It flags an offense if the `require` call is made from
+        # anywhere except the "lib" directory.
+        def falls_in_lib?(str)
+          @str = str
+          target_falls_in_lib?(str) && inspected_file_is_not_in_lib_or_gemspec?
+        end
+
+        # This method is called from inside `#def_node_matcher`.
+        # It flags an offense if the `require` call (using the __FILE__
+        # arguement) is made from anywhere except the "lib" directory.
+        def falls_in_lib_using_file?(str)
+          @str = str
+          target_falls_in_lib_using_file?(str) && inspected_file_is_not_in_lib_or_gemspec?
+        end
+
+        # This method preprends a "." to the string that starts with "/".
+        # And then determines if that call is made to "lib/".
+        def falls_in_lib_with_file_dirname_plus_str?(str)
+          @str = str
+          str.prepend(".")
+          target_falls_in_lib?(str) && inspected_file_is_not_in_lib_or_gemspec?
+        end
+      end
+    end
+  end
+end

data/lib/rubocop/cop/packaging/require_relative_hardcoding_lib.rb

@@ -0,0 +1,82 @@
+# frozen_string_literal: true
+
+require "rubocop/packaging/lib_helper_module"
+
+module RuboCop # :nodoc:
+  module Cop # :nodoc:
+    module Packaging # :nodoc:
+      # This cop flags the `require_relative` calls, from anywhere
+      # mapping to the "lib" directory, except originating from lib/ or
+      # the gemspec file, and suggests to use `require` instead.
+      #
+      # @example
+      #
+      #   # bad
+      #   require_relative "lib/foo.rb"
+      #
+      #   # good
+      #   require "foo.rb"
+      #
+      #   # bad
+      #   require_relative "../../lib/foo/bar"
+      #
+      #   # good
+      #   require "foo/bar"
+      #
+      #   # good
+      #   require_relative "spec_helper"
+      #   require_relative "spec/foo/bar"
+      #
+      class RequireRelativeHardcodingLib < Base
+        include RuboCop::Packaging::LibHelperModule
+        extend AutoCorrector
+
+        # This is the message that will be displayed when RuboCop finds an
+        # offense of using `require_relative` with relative path to lib.
+        MSG = "Avoid using `require_relative` with relative path to lib. " \
+              "Use `require` with absolute path instead."
+
+        def_node_matcher :require_relative, <<~PATTERN
+          (send nil? :require_relative
+            (str #falls_in_lib?))
+        PATTERN
+
+        # Extended from the Base class.
+        # More about the `#on_new_investigation` method can be found here:
+        # https://github.com/rubocop-hq/rubocop/blob/343f62e4555be0470326f47af219689e21c61a37/lib/rubocop/cop/base.rb
+        #
+        # Processing of the AST happens here.
+        def on_new_investigation
+          @file_path = processed_source.file_path
+          @file_directory = File.dirname(@file_path)
+        end
+
+        # Extended from AST::Traversal.
+        # More about the `#on_send` method can be found here:
+        # https://github.com/rubocop-hq/rubocop-ast/blob/08d0f49a47af1e9a30a6d8f67533ba793c843d67/lib/rubocop/ast/traversal.rb#L112
+        def on_send(node)
+          return unless require_relative(node)
+
+          add_offense(node) do |corrector|
+            corrector.replace(node, good_require_call)
+          end
+        end
+
+        # Called from on_send, this method helps to replace the
+        # "bad" require_relative call with the "good" one.
+        def good_require_call
+          good_call = File.expand_path(@str, @file_directory).delete_prefix("#{root_dir}/lib/")
+          %(require "#{good_call}")
+        end
+
+        # This method is called from inside `#def_node_matcher`.
+        # It flags an offense if the `require_relative` call is made
+        # from anywhere except the "lib" directory.
+        def falls_in_lib?(str)
+          @str = str
+          target_falls_in_lib?(str) && inspected_file_is_not_in_lib_or_gemspec?
+        end
+      end
+    end
+  end
+end

data/lib/rubocop/cop/packaging_cops.rb

@@ -1,3 +1,6 @@
 # frozen_string_literal: true
 
-require_relative 'packaging/gemspec_git'
+require_relative "packaging/bundler_setup_in_tests"
+require_relative "packaging/gemspec_git"
+require_relative "packaging/require_hardcoding_lib"
+require_relative "packaging/require_relative_hardcoding_lib"

data/lib/rubocop/packaging.rb

@@ -1,12 +1,12 @@
 # frozen_string_literal: true
 
-require 'rubocop/packaging/version'
+require "rubocop/packaging/version"
 
 module RuboCop
   # RuboCop Packaging project namespace
   module Packaging
     PROJECT_ROOT   = Pathname.new(__dir__).parent.parent.expand_path.freeze
-    CONFIG_DEFAULT = PROJECT_ROOT.join('config', 'default.yml').freeze
+    CONFIG_DEFAULT = PROJECT_ROOT.join("config", "default.yml").freeze
     CONFIG         = YAML.safe_load(CONFIG_DEFAULT.read).freeze
 
     private_constant(:CONFIG_DEFAULT, :PROJECT_ROOT)

data/lib/rubocop/packaging/lib_helper_module.rb

@@ -0,0 +1,41 @@
+# frozen_string_literal: true
+
+module RuboCop # :nodoc:
+  module Packaging # :nodoc:
+    # This helper module extracts the methods which can be used
+    # in other cop classes.
+    module LibHelperModule
+      # For determining the root directory of the project.
+      def root_dir
+        RuboCop::ConfigLoader.project_root
+      end
+
+      # This method determines if the calls are made to the "lib" directory.
+      def target_falls_in_lib?(str)
+        File.expand_path(str, @file_directory).start_with?("#{root_dir}/lib")
+      end
+
+      # This method determines if the calls (using the __FILE__ argument)
+      # are made to the "lib" directory.
+      def target_falls_in_lib_using_file?(str)
+        File.expand_path(str, @file_path).start_with?("#{root_dir}/lib")
+      end
+
+      # This method determines if that call is made *from* the "lib" directory.
+      def inspected_file_falls_in_lib?
+        @file_path.start_with?("#{root_dir}/lib")
+      end
+
+      # This method determines if that call is made *from* the "gemspec" file.
+      def inspected_file_is_gemspec?
+        @file_path.end_with?("gemspec")
+      end
+
+      # This method determines if the inspected file is not in lib/ or
+      # isn't a gemspec file.
+      def inspected_file_is_not_in_lib_or_gemspec?
+        !inspected_file_falls_in_lib? && !inspected_file_is_gemspec?
+      end
+    end
+  end
+end

data/lib/rubocop/packaging/version.rb

@@ -2,6 +2,6 @@
 
 module RuboCop
   module Packaging
-    VERSION = '0.1.0'
+    VERSION = "0.5.0"
   end
 end

metadata

@@ -1,43 +1,43 @@
 --- !ruby/object:Gem::Specification
 name: rubocop-packaging
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.5.0
 platform: ruby
 authors:
 - Utkarsh Gupta
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-06-17 00:00:00.000000000 Z
+date: 2020-09-19 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bump
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.8.0
+        version: '0.8'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.8.0
+        version: '0.8'
 - !ruby/object:Gem::Dependency
   name: pry
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.13.0
+        version: '0.13'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.13.0
+        version: '0.13'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
@@ -84,16 +84,16 @@ dependencies:
   name: rubocop
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.75.0
+        version: '0.89'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.75.0
+        version: '0.89'
 description: |
   A collection of RuboCop cops to check for downstream compatability issues in the
   Ruby code.
@@ -107,10 +107,14 @@ files:
 - README.md
 - config/default.yml
 - lib/rubocop-packaging.rb
+- lib/rubocop/cop/packaging/bundler_setup_in_tests.rb
 - lib/rubocop/cop/packaging/gemspec_git.rb
+- lib/rubocop/cop/packaging/require_hardcoding_lib.rb
+- lib/rubocop/cop/packaging/require_relative_hardcoding_lib.rb
 - lib/rubocop/cop/packaging_cops.rb
 - lib/rubocop/packaging.rb
 - lib/rubocop/packaging/inject.rb
+- lib/rubocop/packaging/lib_helper_module.rb
 - lib/rubocop/packaging/version.rb
 homepage: https://github.com/utkarsh2102/rubocop-packaging
 licenses:
@@ -126,7 +130,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: 2.3.0
+      version: 2.4.0
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="