rubocop-openproject 0.6.0 → 0.7.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 821ee2f0425e32049c380dd582471e37feb47c8565b1a8b05e2746809e498993
-  data.tar.gz: b8c1b464b25dbb3f0c07dcd5d7f20fd8bd331b91565f31782c7d27920a6148be
+  metadata.gz: ddc09cf55b857f7ce9d1f944be04ad89fca8733ed2ee571e7a21e61ee0b93531
+  data.tar.gz: 597940571a0def133a1e4c22ba02fc5f277b4e69b43e72be0ae8e63ad2b3959b
 SHA512:
-  metadata.gz: 20ea7aec95cb84472a6e145dfc71e31a542a3cda8e6a126ea5f6adf8832c6852aff30d506c624bb930fca6ef4a2fb324ecf777b88a2afb3d7d9e2e227c7a436e
-  data.tar.gz: 240bcf2a89496e23e73ca909171b754eb92e417bb86d67c07cf3dc2415ca1404879d59fabff2c829bec58d40484b8c49e833a719749c95a2b1b1828b5b0de294
+  metadata.gz: 7b4b3c182974ae3030781217c2a1c37abdff29b21398a1b9644806c36d55b81ec6ec1d22af6d7e44dead45a5ce3950d394a73ab361d15c15834562a67a443296
+  data.tar.gz: cefcaa216a26645a8ca75e6caedae544462cd411bd5b298d0d80b24e0502680075c5bf3ad4bf4b8e3e8d3054ab416c14408b87af9a841eb3950656e488ef3aef

data/.ruby-version

@@ -1 +1 @@
-4.0.2
+4.0.6

data/CHANGELOG.md

@@ -1,5 +1,33 @@
 # rubocop-openproject
 
+## 0.7.1
+
+### Patch Changes
+
+- 2e41102: Widen `OpenProject/UseEffectiveTypeForConfiguration` to catch safe navigation and the derived
+  pattern readers. The cop only defined `on_send`, so `represented.type&.attribute_groups` parsed
+  as a `csend` and slipped through entirely — which is how the whole work package schema
+  representer read its form configuration off the root while the cop was enabled. Both sides of
+  the call are now matched as `send` or `csend`. `enabled_patterns` and
+  `replacement_pattern_defined_for?` join `CONFIGURATION_METHODS`: both resolve through
+  `patterns`, which a variant can own independently, so they are as variant-specific as the
+  aspect readers already listed.
+
+  Expect new offenses in consumers wherever a configuration aspect was read off `type` with `&.`.
+
+## 0.7.0
+
+### Minor Changes
+
+- ad3ff98: Add `OpenProject/UseEffectiveTypeForConfiguration` cop to catch reading a type's
+  configuration off `#type` instead of `#effective_type`. A work package stores the root of its
+  type family while its project may resolve that family to a variant configured differently, so
+  reading an aspect (form configuration, workflows, custom fields, defaults, export templates)
+  off the stored type silently answers with the root's configuration. The failure is quiet — a
+  project running the root behaves correctly, so a spec written without a variant passes while
+  the feature is broken wherever a variant is resolved. Inherited core settings (`name`,
+  `color`, `is_milestone`, `is_in_roadmap`) are read from the root by design and are not flagged.
+
 ## 0.6.0
 
 ### Minor Changes

data/config/default.yml

@@ -23,6 +23,11 @@ OpenProject/NoSleepInFeatureSpecs:
   Enabled: true
   VersionAdded: '0.1.0'
 
+OpenProject/UseEffectiveTypeForConfiguration:
+  Description: 'Read a type''s configuration through `effective_type`, not `type`, so the project''s variant is honoured.'
+  Enabled: true
+  VersionAdded: '0.7.0'
+
 OpenProject/UseRenderModeInsteadOfPrimitives:
   Description: 'Use `render_mode:` instead of `static_html:`/`plain_text:`/`only_path:` on `format_text`.'
   Enabled: true

data/lib/rubocop/cop/open_project/use_effective_type_for_configuration.rb

@@ -0,0 +1,95 @@
+# frozen_string_literal: true
+
+module RuboCop
+  module Cop
+    module OpenProject
+      # Flags reading a type's configuration off `#type` rather than `#effective_type`.
+      #
+      # A work package stores the root of its type family, while the project it lives in may
+      # resolve that family to a variant configured differently — a different form
+      # configuration, workflow, set of custom fields, defaults or export templates. Reading a
+      # configuration aspect off the stored type therefore answers with the root's
+      # configuration and silently ignores the variant.
+      #
+      # The failure mode is quiet: a project running the root behaves correctly, so a spec
+      # written without a variant passes while the feature is broken for every project that
+      # resolves one. That is what this cop is here to catch.
+      #
+      # Only configuration aspects are flagged. `name`, `color`, `is_milestone` and
+      # `is_in_roadmap` are inherited from the root by design, so reading those off `#type` is
+      # correct and left alone.
+      #
+      # Deliberately narrow: it fires when the receiver is literally a `type` call, which is
+      # the shape the mistake takes in practice. Administration code holding an explicit type
+      # (`@type.attribute_groups`) is reading that member's own configuration on purpose and is
+      # not flagged, and neither is a type held in a local variable.
+      #
+      # @example
+      #   # bad
+      #   work_package.type.attribute_groups
+      #
+      #   # bad
+      #   work_package.type.custom_fields
+      #
+      #   # bad — inside WorkPackage itself
+      #   type.statuses(include_default: true)
+      #
+      #   # bad — safe navigation on either side reads the root just the same
+      #   represented.type&.attribute_groups
+      #   model&.type.enabled_patterns
+      #
+      #   # good
+      #   work_package.effective_type.attribute_groups
+      #
+      #   # good — when there is no work package to ask
+      #   project.effective_type(type).attribute_groups
+      #
+      #   # good — inherited from the root by design
+      #   work_package.type.name
+      #   work_package.type.is_milestone?
+      #
+      #   # good — administration reads a specific member's own configuration
+      #   @type.attribute_groups
+      class UseEffectiveTypeForConfiguration < Base
+        MSG = "Read configuration through `effective_type`, not `type` — the stored type is " \
+              "the family's root, so this ignores the variant the project resolves to."
+
+        # Configuration aspects, per Type::ConfigurationLink::ASPECTS and the readers
+        # Type::ConfigurationLinkable resolves through the link chain, plus the derived readers
+        # that sit on top of one — `enabled_patterns` and `replacement_pattern_defined_for?`
+        # both resolve through `patterns` and are just as variant-specific.
+        CONFIGURATION_METHODS = %i[
+          artefact_export_enabled?
+          artefact_export_mode
+          attribute_groups
+          custom_field_ids
+          custom_fields
+          description
+          enabled_patterns
+          export_templates_disabled
+          export_templates_order
+          patterns
+          project_custom_field_type_mappings
+          replacement_pattern_defined_for?
+          statuses
+          workflows
+        ].freeze
+
+        RESTRICT_ON_SEND = CONFIGURATION_METHODS
+
+        # Both node types on both sides: `type&.attribute_groups` reads the root exactly like
+        # `type.attribute_groups` does, and the mistake is written with `&.` at least as often.
+        def_node_matcher :type_call?, <<~PATTERN
+          ({send csend} _ :type)
+        PATTERN
+
+        def on_send(node)
+          return unless type_call?(node.receiver)
+
+          add_offense(node)
+        end
+        alias on_csend on_send
+      end
+    end
+  end
+end

data/lib/rubocop/cop/open_project_cops.rb

@@ -5,4 +5,5 @@ require_relative "open_project/no_not_implemented_error"
 require_relative "open_project/no_params_in_work_package_where_id"
 require_relative "open_project/use_service_result_factory_methods"
 require_relative "open_project/no_sleep_in_feature_specs"
+require_relative "open_project/use_effective_type_for_configuration"
 require_relative "open_project/use_render_mode_instead_of_primitives"

data/lib/rubocop/open_project/version.rb

@@ -2,6 +2,6 @@
 
 module RuboCop
   module OpenProject
-    VERSION = "0.6.0"
+    VERSION = "0.7.1"
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rubocop-openproject
 version: !ruby/object:Gem::Version
-  version: 0.6.0
+  version: 0.7.1
 platform: ruby
 authors:
 - OpenProject GmbH
@@ -43,6 +43,7 @@ files:
 - lib/rubocop/cop/open_project/no_not_implemented_error.rb
 - lib/rubocop/cop/open_project/no_params_in_work_package_where_id.rb
 - lib/rubocop/cop/open_project/no_sleep_in_feature_specs.rb
+- lib/rubocop/cop/open_project/use_effective_type_for_configuration.rb
 - lib/rubocop/cop/open_project/use_render_mode_instead_of_primitives.rb
 - lib/rubocop/cop/open_project/use_service_result_factory_methods.rb
 - lib/rubocop/cop/open_project_cops.rb
@@ -71,7 +72,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 4.0.6
+rubygems_version: 4.0.16
 specification_version: 4
 summary: RuboCop cops for OpenProject
 test_files: []