rubocop-oneoff_codemod 0.0.1 → 0.0.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 3b4ac58f9a620b41b258dbe693788c23ea56e3247fc5a0639af1eb39c33f2009
-  data.tar.gz: dbc5255bf3aa411163ddd2401ad7628d025263da307d1cb8d08ca9e860b975e0
+  metadata.gz: 81bf98f0675cd046786de15ab60f0c0e9d9c9171dadca788e863e366b58c4327
+  data.tar.gz: b59a62f0da18ef1bd0d8caa57d9440fb0eadc7d44d5063ccea33ecfd9b31100e
 SHA512:
-  metadata.gz: 28f7b9e3821fc2efdf61302f37e670370d360e5da558329f5ce8e8969cbbba3fe8225e7aac1a04b89c025e438376391698d97939562175c383cffe16464bb381
-  data.tar.gz: d1f7475a57ecf270d1a1f6219d4eb8f4c7ded2ab520b9ee134d913a49f8f628b2fb4ba8c4dced29365d94a5a2b30fd3c4e70f86987cea693a0a49a13ebe09642
+  metadata.gz: b1dd632033a08bc9e9fef6b3f8d8b70c2df1f97ecae979b2f2518c5a7407426ab611869ff6532cd4fbf5a61a0ca0aca710f2f7ae48f4f7376fbc2361e410312e
+  data.tar.gz: 2c4b31f59f1f2d92d5800bd6577f95dd9e1c0e657c60fd9df242c94128541140629009b01a37f7314e83c7fc8536cd04d646aa6e9ab76b355c209e47d5697b9d

data/.rubocop.yml

@@ -1,9 +1,22 @@
 AllCops:
   TargetRubyVersion: 3.1
   NewCops: enable
+  SuggestExtensions: false
 
 Style/StringLiterals:
   EnforcedStyle: double_quotes
 
 Style/StringLiteralsInInterpolation:
   EnforcedStyle: double_quotes
+
+Metrics/AbcSize:
+  Enabled: false
+
+Metrics/CyclomaticComplexity:
+  Enabled: false
+
+Metrics/MethodLength:
+  Enabled: false
+
+Metrics/PerceivedComplexity:
+  Enabled: false

data/config/default.yml

@@ -0,0 +1 @@
+# It's still empty for now

data/lib/rubocop/oneoff_codemod/cops/keep_unique.rb

@@ -3,8 +3,8 @@
 module RuboCop
   module Cop
     module Codemod
-      # Command
-      class Command < Base
+      # KeepUnique
+      class KeepUnique < Base
         extend AutoCorrector
         include IgnoredNode
 
@@ -17,7 +17,7 @@ module RuboCop
 
         def on_new_investigation
           processed_source.comments.each do |comment|
-            next unless comment.text =~ /@keep-unique/
+            next unless comment.text == "# @keep-unique"
 
             @commands[comment.location.line] = :keep_unique
 
@@ -28,16 +28,35 @@ module RuboCop
         end
 
         def on_array(node)
-          # Parser::AST::Node.location.line で行番号が取れる
-          if @commands[node.location.line - 1] == :keep_unique
-            add_offense(node) do |corrector|
-              next if part_of_ignored_node?(node)
-
-              elements = node.values
-              values = elements.map(&:source)
-              uniq_values = values.uniq
-              corrector.replace(node, "[#{uniq_values.join(", ")}]")
+          return unless @commands[node.location.line - 1] == :keep_unique
+          return unless node.loc.begin.source == "[" || node.loc.begin.source.start_with?("%w")
+
+          add_offense(node) do |corrector|
+            next if part_of_ignored_node?(node)
+
+            indent = " " * node.values.first.loc.column
+            if node.loc.begin.source == "["
+              separator = ", "
+              line_separator = ",\n#{indent}"
+            else
+              separator = " "
+              line_separator = "\n#{indent}"
             end
+
+            content = []
+            content << node.loc.begin.source
+            content << processed_source.raw_source[node.loc.begin.end_pos..(node.values.first.loc.expression.begin_pos - 1)] # rubocop:disable Layout/LineLength
+
+            acc = node.values.uniq(&:source).each_with_object([]) do |v_node, acc|
+              acc << [] if acc.last&.last&.loc&.line != v_node.loc.line # rubocop:disable Style/SafeNavigationChainLength
+              acc.last << v_node
+            end
+            content << acc.map { |a| a.map(&:source).join(separator) }.join(line_separator)
+
+            content << processed_source.raw_source[node.values.last.loc.expression.end_pos..(node.loc.end.begin_pos - 1)] # rubocop:disable Layout/LineLength
+            content << node.loc.end.source
+
+            corrector.replace(node, content)
           end
 
           ignore_node(node)

data/lib/rubocop/oneoff_codemod/plugin.rb

@@ -0,0 +1,30 @@
+# frozen_string_literal: true
+
+require "lint_roller"
+
+module RuboCop
+  module OneoffCodemod
+    # A plugin that integrates RuboCop Oneoff Codemod with RuboCop's plugin system.
+    class Plugin < LintRoller::Plugin
+      def about
+        LintRoller::About.new(
+          name: "rubocop-oneoff_codemod",
+          version: RuboCop::OneoffCodemod::VERSION,
+          homepage: "https://github.com/kozy4324/rubocop-oneoff_codemod",
+          description: "A RuboCop plugin implementing comment-as-command for one-off codemod, inspired " \
+                       "by eslint-plugin-command."
+        )
+      end
+
+      def supported?(context)
+        context.engine == :rubocop
+      end
+
+      def rules(_context)
+        project_root = Pathname.new(__dir__).join("../../../") # steep:ignore
+
+        LintRoller::Rules.new(type: :path, config_format: :rubocop, value: project_root.join("config", "default.yml"))
+      end
+    end
+  end
+end

data/lib/rubocop/oneoff_codemod/version.rb

@@ -2,6 +2,6 @@
 
 module Rubocop
   module OneoffCodemod
-    VERSION = "0.0.1"
+    VERSION = "0.0.3"
   end
 end

data/lib/rubocop/oneoff_codemod.rb

@@ -3,5 +3,6 @@
 require "rubocop"
 
 require_relative "oneoff_codemod/version"
+require_relative "oneoff_codemod/plugin"
 
 require_relative "oneoff_codemod/cops/keep_unique"

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rubocop-oneoff_codemod
 version: !ruby/object:Gem::Version
-  version: 0.0.1
+  version: 0.0.3
 platform: ruby
 authors:
 - Koji NAKAMURA
@@ -9,20 +9,40 @@ bindir: exe
 cert_chain: []
 date: 1980-01-02 00:00:00.000000000 Z
 dependencies:
+- !ruby/object:Gem::Dependency
+  name: lint_roller
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1.1'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1.1'
 - !ruby/object:Gem::Dependency
   name: rubocop
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 1.72.1
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: '2.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 1.72.1
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: '2.0'
 description: A RuboCop plugin implementing comment-as-command for one-off codemod,
   inspired by eslint-plugin-command.
 email:
@@ -38,8 +58,10 @@ files:
 - LICENSE.txt
 - README.md
 - Rakefile
+- config/default.yml
 - lib/rubocop/oneoff_codemod.rb
 - lib/rubocop/oneoff_codemod/cops/keep_unique.rb
+- lib/rubocop/oneoff_codemod/plugin.rb
 - lib/rubocop/oneoff_codemod/version.rb
 - sig/rubocop/oneoff_codemod.rbs
 homepage: https://github.com/kozy4324/rubocop-oneoff_codemod
@@ -50,6 +72,7 @@ metadata:
   homepage_uri: https://github.com/kozy4324/rubocop-oneoff_codemod
   source_code_uri: https://github.com/kozy4324/rubocop-oneoff_codemod
   changelog_uri: https://github.com/kozy4324/rubocop-oneoff_codemod/releases
+  default_lint_roller_plugin: RuboCop::OneoffCodemod::Plugin
 rdoc_options: []
 require_paths:
 - lib