rubocop-on-rbs 1.3.0 → 1.4.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 79ae2335c1cd8ea94cf1e5003b058c1c7d00966f3cc790a0410b3494e7c94ee4
-  data.tar.gz: 4c6697e0dc3ee2b0724bfe34505539608adfb76ae4733781a3d5195dfbc0917e
+  metadata.gz: 22a2658fe60905c8ede887f40b3bf114cd42c945194d0a968804b2f30069af9c
+  data.tar.gz: 3922f3dd22bf0f1b2afd66c0bbf0b8f5449424c3e64dcaa976def99ecdcd47d9
 SHA512:
-  metadata.gz: 0530b33a2394b966e88784add6936f79631ee8b9f9d81019c265273c73d33719d1e65553e75b2c320f45a8a8c40d8d01b225cbe0f94096bdd0700ae3a281dfc3
-  data.tar.gz: f20537912b6b4fcd8fff9d24da715c6abfae186957c3464fa7989bbc9ae2565d9478cb410436e59e1da3ee1c9a1b50b7070602b82f9dda88abb0f1b99b01731c
+  metadata.gz: a690a213a8654d2a9dd28822d6b112848348340956fa7e533d727203b28db67ed8233adb997b728e9fca9bd820bc0688ab1f984eb0498b6dfa645a9165b2e575
+  data.tar.gz: 1ffdd5f0b4305ff3158187a052cb4cd5fcce2ddf3e0629e3847699e7094741c5db66ee9962f9fc252e34d7a7f6f7a514bc32736cd4003e0377911b725b5a4a1a

data/CHANGELOG.md

@@ -1,5 +1,23 @@
 ## [Unreleased]
 
+## [1.3.0] - 2024-12-24
+
+* Add RBS/Lint/AmbiguousKeywordArgumentKey by @ksss in https://github.com/ksss/rubocop-on-rbs/pull/51
+* Fix false positive for TopLevel* by @ksss in https://github.com/ksss/rubocop-on-rbs/pull/52
+* Support `RBS::AST::Members::Var` by @ksss in https://github.com/ksss/rubocop-on-rbs/pull/53
+* [RBS/Layout/SpaceAroundOperators] Support other declarations by @ksss in https://github.com/ksss/rubocop-on-rbs/pull/54
+* Support other declarations by @ksss in https://github.com/ksss/rubocop-on-rbs/pull/55
+* Use 3.4.0-rc1 by @ksss in https://github.com/ksss/rubocop-on-rbs/pull/56
+* Add RBS/Lint/UselessTypeAliasTypeParams by @ksss in https://github.com/ksss/rubocop-on-rbs/pull/57
+* Use "Unused" instead of "Useless" as much as possible. by @ksss in https://github.com/ksss/rubocop-on-rbs/pull/58
+* Check config/default.yml on CI by @ksss in https://github.com/ksss/rubocop-on-rbs/pull/59
+* Use "Unused" instead of "Useless" as much as possible. by @ksss in https://github.com/ksss/rubocop-on-rbs/pull/60
+* Add RBS/Layout/SpaceAfterComma by @ksss in https://github.com/ksss/rubocop-on-rbs/pull/61
+* Add RBS/Style/InstanceWithInstance by @ksss in https://github.com/ksss/rubocop-on-rbs/pull/62
+* Introduce rbs-inline by @ksss in https://github.com/ksss/rubocop-on-rbs/pull/63
+* Reimplement RBS/Style/InstanceWithInstance  by @ksss in https://github.com/ksss/rubocop-on-rbs/pull/64
+* Add RBS/Style/ClassWithSingleton by @ksss in https://github.com/ksss/rubocop-on-rbs/pull/65
+
 ## [1.2.0] - 2024-11-18
 
 * Fix false positive when oneline class by @ksss in https://github.com/ksss/rubocop-on-rbs/pull/41

data/config/default.yml

@@ -121,6 +121,10 @@ RBS/Lint/LiteralIntersection:
   Description: 'Check literal intersection'
   Enabled: true
 
+RBS/Lint/NewReturnsVoid:
+  Description: 'sigleton `new` method should not returns `void` type'
+  Enabled: true
+
 RBS/Lint/Syntax:
   Severity: fatal
   Description: 'Check RBS syntax'
@@ -128,12 +132,12 @@ RBS/Lint/Syntax:
 
 RBS/Lint/TopLevelInterface:
   Description: 'Check top level interface'
-  Enabled: pending
+  Enabled: true
   VersionAdded: '1.2.0'
 
 RBS/Lint/TopLevelTypeAlias:
   Description: 'Check top level type alias'
-  Enabled: pending
+  Enabled: true
   VersionAdded: '1.2.0'
 
 RBS/Lint/UselessAccessModifier:
@@ -164,7 +168,7 @@ RBS/Style/BlockReturnBoolish:
 
 RBS/Style/ClassWithSingleton:
   Description: 'Check `class` with singleton context'
-  Enabled: pending
+  Enabled: true
 
 RBS/Style/ClassicType:
   Description: 'Use simple type'
@@ -184,7 +188,7 @@ RBS/Style/InitializeReturnType:
 
 RBS/Style/InstanceWithInstance:
   Description: 'Check `instance` with instance context'
-  Enabled: pending
+  Enabled: true
 
 RBS/Style/OptionalNil:
   Description: 'Use nil instead of nil?'

data/lib/rubocop/cop/rbs/lint/new_returns_void.rb

@@ -0,0 +1,43 @@
+# frozen_string_literal: true
+
+# rbs_inline: enabled
+
+module RuboCop
+  module Cop
+    module RBS
+      module Lint
+        # Checks that there are void types in the return type of `.new` method
+        # `self.new` is a special and fundamental method, and extra care should be taken regarding its return value.
+        # In most cases, assigning it `void` is an unintended mistake.
+        #
+        # @example default
+        #   # bad
+        #   def self.new: () -> void
+        #
+        #   # good
+        #   def self.new: () -> instance
+        #
+        class NewReturnsVoid < RuboCop::RBS::CopBase
+          MSG = "Don't use `void` in self.new method. Did you mean `instance`?"
+
+          # @rbs decl: RBS::AST::Members::MethodDefinition
+          def on_rbs_def(decl)
+            return unless decl.kind == :singleton
+            return unless decl.name == :new
+
+            decl.overloads.each do |overload|
+              return_type = overload.method_type.type.return_type
+              case return_type
+              when ::RBS::Types::Bases::Void
+                next unless return_type.location
+
+                range = location_to_range(return_type.location)
+                add_offense(range)
+              end
+            end
+          end
+        end
+      end
+    end
+  end
+end

data/lib/rubocop/cop/rbs/lint/will_syntax_error.rb

@@ -45,14 +45,26 @@ module RuboCop
             check_module_or_class(decl)
           end
 
-          def check_module_or_class(decl)
+          def check_type_params(decl)
             decl.type_params.each do |param|
               if ub = param.upper_bound
                 void_type_context_validator(ub)
                 no_self_type_validator(ub)
                 no_classish_type_validator(ub)
               end
+
+              if param.respond_to?(:default_type)
+                if dt = param.default_type
+                  void_type_context_validator(dt)
+                  no_self_type_validator(dt)
+                  no_classish_type_validator(dt)
+                end
+              end
             end
+          end
+
+          def check_module_or_class(decl)
+            check_type_params(decl)
 
             decl.each_member do |member|
               case member
@@ -79,6 +91,8 @@ module RuboCop
           end
 
           def on_rbs_interface(decl)
+            check_type_params(decl)
+
             decl.members.each do |member|
               case member
               when AST::Members::MethodDefinition
@@ -96,7 +110,14 @@ module RuboCop
             void_type_context_validator(decl.type)
           end
           alias on_rbs_global on_rbs_constant
-          alias on_rbs_type_alias on_rbs_constant
+
+          def on_rbs_type_alias(decl)
+            no_self_type_validator(decl.type)
+            no_classish_type_validator(decl.type)
+            void_type_context_validator(decl.type)
+
+            check_type_params(decl)
+          end
 
           private
 
@@ -166,6 +187,7 @@ module RuboCop
               end
             when Types::Proc
               void_type_context_validator(type.type)
+              void_type_context_validator(type.self_type) if type.self_type
               if type.block
                 void_type_context_validator(type.block.type)
                 void_type_context_validator(type.block.self_type) if type.block.self_type

data/lib/rubocop/cop/rbs_cops.rb

@@ -26,6 +26,7 @@ require_relative 'rbs/lint/ambiguous_keyword_argument_key'
 require_relative 'rbs/lint/ambiguous_operator_precedence'
 require_relative 'rbs/lint/duplicate_overload'
 require_relative 'rbs/lint/literal_intersection'
+require_relative 'rbs/lint/new_returns_void'
 require_relative 'rbs/lint/syntax'
 require_relative 'rbs/lint/top_level_interface'
 require_relative 'rbs/lint/top_level_type_alias'

data/lib/rubocop/rbs/version.rb

@@ -2,6 +2,6 @@
 
 module RuboCop
   module RBS
-    VERSION = '1.3.0'
+    VERSION = '1.4.0'
   end
 end

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification
 name: rubocop-on-rbs
 version: !ruby/object:Gem::Version
-  version: 1.3.0
+  version: 1.4.0
 platform: ruby
 authors:
 - ksss
 bindir: exe
 cert_chain: []
-date: 2024-12-24 00:00:00.000000000 Z
+date: 2025-02-23 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rbs
@@ -87,6 +87,7 @@ files:
 - lib/rubocop/cop/rbs/lint/ambiguous_operator_precedence.rb
 - lib/rubocop/cop/rbs/lint/duplicate_overload.rb
 - lib/rubocop/cop/rbs/lint/literal_intersection.rb
+- lib/rubocop/cop/rbs/lint/new_returns_void.rb
 - lib/rubocop/cop/rbs/lint/syntax.rb
 - lib/rubocop/cop/rbs/lint/top_level_interface.rb
 - lib/rubocop/cop/rbs/lint/top_level_type_alias.rb