rubocop-on-rbs 1.1.0 → 1.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 1c58e575d4d662fa8cf0539226bc2c9f2bcd9358cfd751c3e776ce6f66ebcb86
-  data.tar.gz: 7e7411ebc61e2dfc2751fb3cb3e827580ecc5c7715c0eb5accd62532e3aad3eb
+  metadata.gz: 501f65e78ff030f4d111a08793afa70a614c28715e9d9fa4caa95e24bbcc48dd
+  data.tar.gz: 5600ce340c99239465721d201d75881e3bcd8343787659bbf18faaaf8f51f58f
 SHA512:
-  metadata.gz: bba5622fc180ce5d83f368f418d9c2a730f233de4e0c66f4ca8ef07563471d714fbdc614d6149ecb001fbfbedbe4a128df6417dc8a7c1b9f6687b18e5bcf08fc
-  data.tar.gz: 33ab0de3a1621c4298e98f5e2577c0bcc55becc71cf0d688c59256181edcaac513bf4c04b6c9790dd176878489a4b1bd0de897285e36ed5d1d18ad15dd07289b
+  metadata.gz: 9506a4022805eeaabedd6de962bc91812f34176e40251cb902b4abaee2a5b7fc45dd962946032dcf5cedea397f88daec6d46cae9e54ccc8d9c3f35a6b9941b15
+  data.tar.gz: 3b0176a6d2aa9fc2a85c21445720b9571e8881d6cd742c9b1b534ca76ff5103bc340e38a417e0bf6aec32259b5818aa24872553bdff3e6e47096eba19291cc9f

data/CHANGELOG.md

@@ -1,5 +1,10 @@
 ## [Unreleased]
 
+## [1.1.0] - 2024-10-01
+
+* Add RBS/Layout/EmptyLinesAroundAccessModifier by @ksss in https://github.com/ksss/rubocop-on-rbs/pull/39
+* Fix error when same line with `RBS/Layout/EndAlignment` by @ksss in https://github.com/ksss/rubocop-on-rbs/pull/40
+
 ## [1.0.0] - 2024-09-17
 
 * Add RBS/Layout/EmptyLines by @ksss in https://github.com/ksss/rubocop-on-rbs/pull/35

data/config/default.yml

@@ -118,6 +118,16 @@ RBS/Lint/Syntax:
   Description: 'Check RBS syntax'
   Enabled: true
 
+RBS/Lint/TopLevelInterface:
+  Description: 'Check top level interface'
+  Enabled: pending
+  VersionAdded: '1.2.0'
+
+RBS/Lint/TopLevelTypeAlias:
+  Description: 'Check top level type alias'
+  Enabled: pending
+  VersionAdded: '1.2.0'
+
 RBS/Lint/UselessAccessModifier:
   AutoCorrect: contextual
   Description: 'Check useless access modifier'

data/lib/rubocop/cop/rbs/layout/empty_lines_around_body.rb

@@ -12,6 +12,7 @@ module RuboCop
           def check(decl)
             first_line = decl.location.start_line
             last_line = decl.location.end_line
+            return if last_line == first_line
 
             check_beginning(first_line)
             check_ending(last_line)
@@ -29,7 +30,6 @@ module RuboCop
             return unless line_no.positive?
             return unless processed_source.lines[line_no]
             return unless processed_source.lines[line_no].empty?
-            return unless processed_source.lines[line_no + 1]
 
             range = source_range(processed_source.buffer, line_no + 1, 0)
             message = message(MSG_EXTRA, desc)

data/lib/rubocop/cop/rbs/lint/top_level_interface.rb

@@ -0,0 +1,46 @@
+# frozen_string_literal: true
+
+module RuboCop
+  module Cop
+    module RBS
+      module Lint
+        # Top-level namespaces are likely to conflict and should be avoided.
+        #
+        # @example
+        #   # bad
+        #   interface _Option
+        #     def option: () -> untyped
+        #   end
+        #
+        #   # good
+        #   class Foo
+        #     interface _Option
+        #       def option: () -> untyped
+        #     end
+        #   end
+        #
+        class TopLevelInterface < RuboCop::RBS::CopBase
+          MSG = 'Top level interface detected.'
+
+          def on_rbs_new_investigation
+            @last_end = nil
+          end
+
+          def on_rbs_class(decl)
+            return unless @last_end_pos.nil? || (@last_end_pos < decl.location.end_pos)
+
+            @last_end_pos = decl.location.end_pos
+          end
+          alias on_rbs_module on_rbs_class
+
+          def on_rbs_interface(decl)
+            return unless @last_end_pos.nil? || (@last_end_pos < decl.location.start_pos)
+
+            range = location_to_range(decl.location)
+            add_offense(range)
+          end
+        end
+      end
+    end
+  end
+end

data/lib/rubocop/cop/rbs/lint/top_level_type_alias.rb

@@ -0,0 +1,43 @@
+# frozen_string_literal: true
+
+module RuboCop
+  module Cop
+    module RBS
+      module Lint
+        # Top-level namespaces are likely to conflict and should be avoided.
+        #
+        # @example
+        #   # bad
+        #   type foo = String
+        #
+        #   # good
+        #   class Foo
+        #     type bar = Integer
+        #   end
+        #
+        class TopLevelTypeAlias < RuboCop::RBS::CopBase
+          MSG = 'Top level type alias detected.'
+
+          def on_rbs_new_investigation
+            @last_end = nil
+          end
+
+          def on_rbs_class(decl)
+            return unless @last_end_pos.nil? || (@last_end_pos < decl.location.end_pos)
+
+            @last_end_pos = decl.location.end_pos
+          end
+          alias on_rbs_module on_rbs_class
+          alias on_rbs_interface on_rbs_class
+
+          def on_rbs_type_alias(decl)
+            return unless @last_end_pos.nil? || (@last_end_pos < decl.location.start_pos)
+
+            range = location_to_range(decl.location)
+            add_offense(range)
+          end
+        end
+      end
+    end
+  end
+end

data/lib/rubocop/cop/rbs_cops.rb

@@ -25,6 +25,8 @@ require_relative 'rbs/lint/ambiguous_operator_precedence'
 require_relative 'rbs/lint/duplicate_overload'
 require_relative 'rbs/lint/literal_intersection'
 require_relative 'rbs/lint/syntax'
+require_relative 'rbs/lint/top_level_interface'
+require_relative 'rbs/lint/top_level_type_alias'
 require_relative 'rbs/lint/useless_access_modifier'
 require_relative 'rbs/lint/useless_overload_type_params'
 require_relative 'rbs/lint/will_syntax_error'

data/lib/rubocop/rbs/version.rb

@@ -2,6 +2,6 @@
 
 module RuboCop
   module RBS
-    VERSION = '1.1.0'
+    VERSION = '1.2.0'
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rubocop-on-rbs
 version: !ruby/object:Gem::Version
-  version: 1.1.0
+  version: 1.2.0
 platform: ruby
 authors:
 - ksss
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2024-10-01 00:00:00.000000000 Z
+date: 2024-11-18 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rbs
@@ -87,6 +87,8 @@ files:
 - lib/rubocop/cop/rbs/lint/duplicate_overload.rb
 - lib/rubocop/cop/rbs/lint/literal_intersection.rb
 - lib/rubocop/cop/rbs/lint/syntax.rb
+- lib/rubocop/cop/rbs/lint/top_level_interface.rb
+- lib/rubocop/cop/rbs/lint/top_level_type_alias.rb
 - lib/rubocop/cop/rbs/lint/useless_access_modifier.rb
 - lib/rubocop/cop/rbs/lint/useless_overload_type_params.rb
 - lib/rubocop/cop/rbs/lint/will_syntax_error.rb
@@ -128,7 +130,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.5.11
+rubygems_version: 3.5.16
 signing_key:
 specification_version: 4
 summary: RuboCop extension for RBS file.