rubocop-obsession 0.1.7 → 0.1.9

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 53d3c586b21811a0a13b55a84253df3c26febb690ea9585b960c9c93d08a982e
-  data.tar.gz: 00e2f95178bd563b816a8b961b25470115ad2d25249c5b0c9f2921cd23d6df74
+  metadata.gz: 39eccc2042bacc3bca61a4dc992aa38dcca8d7c734e0aa7661b4091e7e1cac2c
+  data.tar.gz: a8f61cd4628e3340e00a144958db6e0eacf60f1505043f6c21a7868a7e4ed664
 SHA512:
-  metadata.gz: 5c5f2748fc138701c397c0952250f3a42a7f810e2830ba2421b7cfc526511bd31ad1f788ab7863ef86546848c8c18586d9e45feef025d14bdec12b232304a401
-  data.tar.gz: 07c03a46b82ee6038f9ed5cdc7cb1358c58334a183827bb4b8908c2634a819aec88cc938dd451fc2b8182d734765dc284ce4059ea70d4e87a8b8b8e8ed3b98b6
+  metadata.gz: 6fc06812358cdcd5b26c776dd964f5b341c02a70c4e8200f7542c75fe19026d913b6626c84da8af5a8b5c7cef6b3f36a8e6c4d80b367b664d769baa6ba8d92ca
+  data.tar.gz: d4367dd495d6e5848ad83122214be0a7b6af21dc4ea92278a0c5e97ccc4442a12f777a98838a231cc5336715e86c18de70ae8a86a99e5a04bc0f125f591ef472

data/lib/rubocop/cop/mixin/helpers.rb

@@ -3,8 +3,6 @@
 module RuboCop
   module Cop
     module Helpers
-      VERBS = File.read("#{__dir__}/files/verbs.txt").split
-
       def rails_callback?(callback)
         return true if callback == 'validate'
 
@@ -20,7 +18,13 @@ module RuboCop
       def verb?(string)
         short_string = string[2..] if string.start_with?('re')
 
-        VERBS.include?(string) || VERBS.include?(short_string)
+        verbs.include?(string) || verbs.include?(short_string)
+      end
+
+      private
+
+      def verbs
+        @@verbs ||= File.read("#{__dir__}/files/verbs.txt").split
       end
     end
   end

data/lib/rubocop/cop/obsession/no_break_or_next.rb

@@ -11,8 +11,8 @@ module RuboCop
       # - For small loops, you can just use normal conditions instead of `next`.
       # `break` is allowed.
       #
-      # Note: Sometimes loops can also be rethought, like transforming a `loop`
-      # + `break` into a `while`.
+      # Note: Sometimes loops can also be rethought, like transforming a
+      # `loop` + `break` into a `while`.
       #
       # @example
       #

data/lib/rubocop/cop/obsession/no_todos.rb

@@ -11,6 +11,19 @@ module RuboCop
       # stale TODOs. Sometimes developers really mean to work on their TODOs
       # soon, but then Product re-prioritizes their work, or the developer
       # leaves the company, and never gets a chance to tackle them.
+      #
+      # @example
+      #
+      #   # bad
+      #   # TODO: remove this method when we ship the new signup flow
+      #   def my_method
+      #     ...
+      #   end
+      #
+      #   # good
+      #   def my_method
+      #     ...
+      #   end
       class NoTodos < Base
         MSG = 'Avoid TODO comment, create a task in your project management tool instead.'
         KEYWORD_REGEX = /(^|[^\w])(TODO|FIXME|OPTIMIZE|HACK)($|[^\w])/i

data/lib/rubocop/cop/obsession/rails/fully_defined_json_field.rb

@@ -18,14 +18,18 @@ module RuboCop
         # @example
         #
         #   # bad
-        #   add_column :languages, :items, :jsonb
+        #   def change
+        #     add_column :languages, :items, :jsonb
+        #   end
         #
         #   # good
-        #   add_column :languages,
-        #              :items,
-        #              :jsonb,
-        #              default: [],
-        #              comment: "Example: [{ 'name': 'ruby' }, { 'name': 'python' }]"
+        #   def change
+        #     add_column :languages,
+        #                :items,
+        #                :jsonb,
+        #                default: [],
+        #                comment: "Example: [{ 'name': 'ruby' }, { 'name': 'python' }]"
+        #   end
         class FullyDefinedJsonField < Base
           def_node_matcher :json_field?, <<~PATTERN
             (send nil? :add_column _ _ (sym {:json :jsonb}) ...)

data/lib/rubocop/cop/obsession/rails/no_callback_conditions.rb

@@ -19,12 +19,14 @@ module RuboCop
         #
         #   # bad
         #   after_update_commit :crawl_rss, if: :rss_changed?
+        #
         #   def crawl_rss
         #     ...
         #   end
         #
         #   # good
         #   after_update_commit :crawl_rss
+        #
         #   def crawl_rss
         #     return if !rss_changed?
         #     ...

data/lib/rubocop/cop/obsession/rails/safety_assured_comment.rb

@@ -13,6 +13,23 @@ module RuboCop
         # of the DB migration. The reason should be detailed and reviewed by a
         # knowledgeable PR reviewer. Failure to follow instructions may bring your
         # app down.
+        #
+        # @example
+        #
+        #   # bad
+        #   class RemoveSourceUrlFromBlogPosts < ActiveRecord::Migration[8.0]
+        #     def change
+        #       safety_assured { remove_column :blog_posts, :source_url }
+        #     end
+        #   end
+        #
+        #   # good
+        #   class RemoveSourceUrlFromBlogPosts < ActiveRecord::Migration[8.0]
+        #     # Safe because this column was ignored with self.ignored_columns in PR #1234
+        #     def change
+        #       safety_assured { remove_column :blog_posts, :source_url }
+        #     end
+        #   end
         class SafetyAssuredComment < Base
           MSG =
             'Add `# Safe because <reason>` comment above safety_assured. ' \

data/lib/rubocop/cop/obsession/rspec/empty_line_after_final_let.rb

@@ -8,15 +8,17 @@ if defined?(RuboCop::RSpec)
           #
           # @example
           #
-          #   describe '#domain' do
-          #     context do
-          #       let(:url) { Url.new('http://www.some-site.com/some-page') }
-          #       it { expect(url.domain).to eq 'some-site.com' }
-          #     end
+          #   describe Url do
+          #     describe '#domain' do
+          #       context do
+          #         let(:url) { Url.new('http://www.some-site.com/some-page') }
+          #         it { expect(url.domain).to eq 'some-site.com' }
+          #       end
           #
-          #     context do
-          #       let(:url) { Url.new('some-site.com') }
-          #       it { expect(url.domain).to eq 'some-site.com' }
+          #       context do
+          #         let(:url) { Url.new('some-site.com') }
+          #         it { expect(url.domain).to eq 'some-site.com' }
+          #       end
           #     end
           #   end
           class EmptyLineAfterFinalLet < RSpec::EmptyLineAfterFinalLet

data/lib/rubocop/obsession/version.rb

@@ -1,5 +1,5 @@
 module Rubocop
   module Obsession
-    VERSION = '0.1.7'
+    VERSION = '0.1.9'
   end
 end

data/lib/rubocop/obsession.rb

@@ -1,5 +1,6 @@
 require 'active_support'
 require 'active_support/core_ext/object/blank'
+require 'active_support/core_ext/string/inflections'
 require 'rubocop'
 
 require_relative 'cop/mixin/helpers'

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rubocop-obsession
 version: !ruby/object:Gem::Version
-  version: 0.1.7
+  version: 0.1.9
 platform: ruby
 authors:
 - Jerome Dalbert
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2024-11-03 00:00:00.000000000 Z
+date: 2024-11-05 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport