rubocop-nueca 2.0.1 → 2.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: e8f3aec7be2554e9ad94e87b3e5258c31f0ade6ec14f4536b95000bed23c5741
-  data.tar.gz: 34a4f7f434ffa20e2550d9993154b2a07be32d5cad2648b72c1429d10ca90c94
+  metadata.gz: 9e2e8263941b4c5f0934ad7fb9f8df991e90583476f10fc3290a3c7dd2f917ff
+  data.tar.gz: 0e503986f5bfd5003b40beee3844cfeb9ae5cdc179b2d4576d139e1d244ba18f
 SHA512:
-  metadata.gz: 29b570015f070e3eed9c1b18d3ea70fee7e341fac6872717c7914daa8895313694cb4a5c1cef8b982bdee1f75467994412b42a2f38727eb06a8534f6fc6f19b4
-  data.tar.gz: 6083470135a843e79501307da511747a2cafb67a0e9d31af28647cd389967aa010c5b0e761e593d20864031bf1252353437db8e341f9f2eda68e090a7b40de66
+  metadata.gz: dc56766f7ecaa64cb93001e8ee3cd4eca0250bbf4b509d41f2fb6bcbe36d3d30e1d34dba4bdcdbcd26a4f8cd143600000364c5b9ad184793b99bc24f3992373e
+  data.tar.gz: 1e89c75c3f19fea9dc29979dd38af0695f4ea4e77f126e7d3d0bc407853f2a3e61baef1f9862016101ee280775bf4ca0c1a24f5cac2f1a48c4418d8cb4c03f05

data/README.md

@@ -18,7 +18,7 @@ Add to your `.rubocop.yml` the following code.
 
 ```yaml
 plugins:
-    - rubocop-nueca
+  - rubocop-nueca
 ```
 
 ## License

data/config/default.yml

@@ -96,6 +96,10 @@ Rails/UnknownEnv:
     - test
     - staging
 
+RSpec/ScatteredSetup:
+  Exclude:
+    - spec/requests/api/**/*_spec.rb
+
 RSpec/MultipleExpectations:
   Enabled: false
 

data/lib/rubocop/cop/rails/route_unnecessary_array_notation.rb

@@ -0,0 +1,72 @@
+# frozen_string_literal: true
+
+require_relative '../shared/route_helper'
+
+module RuboCop
+  module Cop
+    module Rails
+      class RouteUnnecessaryArrayNotation < RuboCop::Cop::Base
+        include RouteHelper
+        extend AutoCorrector
+
+        MSG = 'Unnecessary array notation for single element. ' \
+              'Use `%<key>s: %<value>s` instead of `%<key>s: [%<value>s]`.'
+
+        def on_send(node)
+          return unless route_file?
+          return unless route_method?(node)
+
+          node.arguments.each do |arg|
+            next unless arg.hash_type?
+
+            check_hash_pairs(arg)
+          end
+        end
+
+        private
+
+        def route_method?(node)
+          return false unless node.send_type?
+
+          route_methods = [
+            :get, :post, :put, :patch, :delete, :head, :options, :match, :root,
+            :resource, :resources,
+            :namespace, :scope, :concern, :member, :collection,
+            :draw
+          ]
+
+          route_methods.include?(node.method_name)
+        end
+
+        def check_hash_pairs(hash_node)
+          hash_node.pairs.each do |pair|
+            check_single_element_array(pair)
+          end
+        end
+
+        def check_single_element_array(pair)
+          value = pair.value
+          return unless value.array_type?
+          return unless value.children.size == 1
+
+          element = value.children.first
+          return unless element.sym_type? || element.str_type?
+
+          key = pair.key
+          key_source = key.source
+          element_source = element.source
+
+          message = format(
+            MSG,
+            key: key_source,
+            value: element_source
+          )
+
+          add_offense(value, message: message) do |corrector|
+            corrector.replace(value, element_source)
+          end
+        end
+      end
+    end
+  end
+end

data/lib/rubocop/cop/rswag/scattered_setup.rb

@@ -0,0 +1,35 @@
+# frozen_string_literal: true
+
+module RuboCop
+  module Cop
+    module RSwag
+      class ScatteredSetup < RuboCop::Cop::Base
+        MSG = 'Do not define multiple hooks of the same type in the same response group.'
+
+        def on_block(node)
+          return unless rswag_test?(node)
+
+          hooks = analyzable_hooks(node)
+          hooks.group_by { |hook| hook.send_node.method_name }.each_value do |group|
+            next if group.size <= 1
+
+            group[1..].each { |hook| add_offense(hook) }
+          end
+        end
+
+        private
+
+        def rswag_test?(_node)
+          processed_source.file_path&.include?('spec/requests/api')
+        end
+
+        def analyzable_hooks(node)
+          hook_methods = [:before, :after, :around]
+          node.body&.each_child_node(:block)&.select do |blk|
+            hook_methods.include?(blk.send_node&.method_name)
+          end || []
+        end
+      end
+    end
+  end
+end

data/lib/rubocop/nueca/version.rb

@@ -2,6 +2,6 @@
 
 module RuboCop
   module Nueca
-    VERSION = '2.0.1'
+    VERSION = '2.2.0'
   end
 end

data/lib/rubocop-nueca.rb

@@ -6,7 +6,9 @@ require 'rubocop'
 # Load the plugin
 require_relative 'rubocop/nueca/plugin'
 
-# Load all custom Rails cops
-Dir[File.join(__dir__, 'rubocop', 'cop', 'rails', '*.rb')].each do |file|
-  require file
+# Load all custom cops
+['rails', 'rswag'].each do |subdir|
+  Dir[File.join(__dir__, 'rubocop', 'cop', subdir, '*.rb')].each do |file|
+    require file
+  end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rubocop-nueca
 version: !ruby/object:Gem::Version
-  version: 2.0.1
+  version: 2.2.0
 platform: ruby
 authors:
 - Tien
@@ -152,7 +152,9 @@ files:
 - lib/rubocop/cop/rails/route_root_position.rb
 - lib/rubocop/cop/rails/route_separation.rb
 - lib/rubocop/cop/rails/route_sorting.rb
+- lib/rubocop/cop/rails/route_unnecessary_array_notation.rb
 - lib/rubocop/cop/rails/time_zone_today.rb
+- lib/rubocop/cop/rswag/scattered_setup.rb
 - lib/rubocop/cop/shared/collection_context.rb
 - lib/rubocop/cop/shared/route_collector.rb
 - lib/rubocop/cop/shared/route_helper.rb