rubocop-nueca 2.0.0 → 2.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: bb34764da703f11ac54951f9b92fddc4c12b02484a16db639037492673777fa9
-  data.tar.gz: f5b592ac30bbb9dd3dc453755a3381e24afe704766cd5025a318f92b53eca7d9
+  metadata.gz: 81918c1ee3c1d72d3bfdf6914398dab599378c4a37ae66419afb23792c35386e
+  data.tar.gz: a4348608537bc0876333bb78e4757770f91859623e83c3353b013e4d7233f1a2
 SHA512:
-  metadata.gz: 16f6447cb675eb5d93683147d8bc253b9aad89b0f7eacd6a1c006b07713743ecb20c5ba84cff87361a3184a69000dc08f85bc6121723b11579409f73d98ebcba
-  data.tar.gz: 6efdbd1a9a74ada84396470d81789e4cbc8552bb4b6e92d1e6bee5ae5cd534c12bffdb6152ed25bc8448ce31a999de6d1f447e2a450cc6eece9e5655b6213fd9
+  metadata.gz: 3e41c08ebed4ab33a3b41227cc97d1506d3c289aedf7468f8d8925d8b0ef792f8780d5a510aade458dfd08624bdb36aee4975d63c9689c68f8f9283a0dc7e679
+  data.tar.gz: a0c05dfcf12646d2c881bfa80f87d70bddfed41916b317f2544823b47b93a71233be42331b7926c9a41be39211dfed96cfaa9f07d7b723df18faee1cd41a87a9

data/config/default.yml

@@ -96,6 +96,10 @@ Rails/UnknownEnv:
     - test
     - staging
 
+RSpec/ScatteredSetup:
+  Exclude:
+    - spec/requests/api/**/*_spec.rb
+
 RSpec/MultipleExpectations:
   Enabled: false
 
@@ -166,9 +170,6 @@ Style/ClassMethodsDefinitions:
 Style/ImplicitRuntimeError:
   Enabled: true
 
-Style/InvertibleUnlessCondition:
-  Enabled: true
-
 Style/IpAddresses:
   Enabled: true
 

data/lib/rubocop/cop/deprecated/auto_time_definition.rb

@@ -13,7 +13,7 @@ module RuboCop
         PATTERN
 
         def on_send(node)
-          return if node.source_range.source_buffer.name.exclude?('_spec.rb')
+          return unless node.source_range.source_buffer.name.include?('_spec.rb')
           return unless datetime_usage(node)
 
           add_offense(node)

data/lib/rubocop/cop/deprecated/browser_driver.rb

@@ -11,7 +11,7 @@ module RuboCop
         PATTERN
 
         def on_send(node)
-          return if node.source_range.source_buffer.name.exclude?('_spec.rb')
+          return unless node.source_range.source_buffer.name.include?('_spec.rb')
           return unless browser_usage(node)
 
           add_offense(node)

data/lib/rubocop/cop/deprecated/mongoid_needs.rb

@@ -29,7 +29,7 @@ module RuboCop
 
         def on_send(node)
           buffer = node.source_range.source_buffer
-          return if buffer.name.exclude?('_spec.rb')
+          return unless buffer.name.include?('_spec.rb')
           return unless require_mongoid_helper(node)
 
           root_node = processed_source.ast

data/lib/rubocop/cop/rails/model_association_consistent_spacing.rb

@@ -60,7 +60,7 @@ module RuboCop
             prev_end_line = prev_assoc.loc.last_line
             curr_start_line = curr_assoc.loc.line
 
-            next if curr_start_line - prev_end_line <= 1
+            next unless curr_start_line - prev_end_line > 1
 
             add_offense(curr_assoc, message: MSG)
           end

data/lib/rubocop/cop/rails/model_association_grouping.rb

@@ -67,7 +67,7 @@ module RuboCop
         def check_same_type_grouping(same_type_associations, all_associations)
           groups = find_contiguous_groups(same_type_associations, all_associations)
 
-          return if groups.length <= 1
+          return unless groups.length > 1
 
           groups[1..].each do |group|
             add_offense(group.first, message: MSG)
@@ -99,7 +99,7 @@ module RuboCop
         end
 
         def finalize_group(groups, current_group)
-          return if current_group.none?
+          return unless current_group.any?
 
           groups << current_group.dup
           current_group.clear

data/lib/rubocop/cop/rswag/scattered_setup.rb

@@ -0,0 +1,35 @@
+# frozen_string_literal: true
+
+module RuboCop
+  module Cop
+    module RSwag
+      class ScatteredSetup < RuboCop::Cop::Base
+        MSG = 'Do not define multiple hooks of the same type in the same response group.'
+
+        def on_block(node)
+          return unless rswag_test?(node)
+
+          hooks = analyzable_hooks(node)
+          hooks.group_by { |hook| hook.send_node.method_name }.each_value do |group|
+            next if group.size <= 1
+
+            group[1..].each { |hook| add_offense(hook) }
+          end
+        end
+
+        private
+
+        def rswag_test?(_node)
+          processed_source.file_path&.include?('spec/requests/api')
+        end
+
+        def analyzable_hooks(node)
+          hook_methods = [:before, :after, :around]
+          node.body&.each_child_node(:block)&.select do |blk|
+            hook_methods.include?(blk.send_node&.method_name)
+          end || []
+        end
+      end
+    end
+  end
+end

data/lib/rubocop/cop/shared/collection_context.rb

@@ -44,7 +44,7 @@ module RuboCop
           send_node = node.send_node
           return unless send_node.send_type? && route_method?(send_node)
 
-          add_route_block_if_valid(node) if [:member, :collection].exclude?(send_node.method_name)
+          add_route_block_if_valid(node) unless [:member, :collection].include?(send_node.method_name)
           process_nested_context(node)
         end
 

data/lib/rubocop/nueca/version.rb

@@ -2,6 +2,6 @@
 
 module RuboCop
   module Nueca
-    VERSION = '2.0.0'
+    VERSION = '2.1.0'
   end
 end

data/lib/rubocop-nueca.rb

@@ -6,7 +6,9 @@ require 'rubocop'
 # Load the plugin
 require_relative 'rubocop/nueca/plugin'
 
-# Load all custom Rails cops
-Dir[File.join(__dir__, 'rubocop', 'cop', 'rails', '*.rb')].each do |file|
-  require file
+# Load all custom cops
+['rails', 'rswag'].each do |subdir|
+  Dir[File.join(__dir__, 'rubocop', 'cop', subdir, '*.rb')].each do |file|
+    require file
+  end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rubocop-nueca
 version: !ruby/object:Gem::Version
-  version: 2.0.0
+  version: 2.1.0
 platform: ruby
 authors:
 - Tien
@@ -153,6 +153,7 @@ files:
 - lib/rubocop/cop/rails/route_separation.rb
 - lib/rubocop/cop/rails/route_sorting.rb
 - lib/rubocop/cop/rails/time_zone_today.rb
+- lib/rubocop/cop/rswag/scattered_setup.rb
 - lib/rubocop/cop/shared/collection_context.rb
 - lib/rubocop/cop/shared/route_collector.rb
 - lib/rubocop/cop/shared/route_helper.rb