rubocop-nosolosoftware 0.8.0 → 1.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 36dd7dd406748669e08b9f2c1d1ac6af56b69fc7bdf5e935f9e89a51b1645fd9
-  data.tar.gz: b822e653ecfd14baecbe4166a40956dbe2b2ebcb94cb0e9c70feebb4c8766e6b
+  metadata.gz: 3a56547c0efe7d21679b856918547632944ae698bded671be0130792dc504bc9
+  data.tar.gz: 3af51a4cd0e1da30fcd07ebc4e30e58ed02a5b9bd51c9b70cb2531aa6bf92dd7
 SHA512:
-  metadata.gz: ea6af87a67f7706395bba8f20f399291d01462c51aaeffa43d208318d59e04143858069bc2eaf18c3c5ff8b8ce5953b82de7c10271dcf44657ad4ef8e791c73d
-  data.tar.gz: a380a542038def25b26c2f628dabc454da5de51d1c8c117da25bc7b571e24ec204c66ddf82de120b5b5f6e869cec69ea5fb4ac1c01c90f5f76daae072cb5b52f
+  metadata.gz: b1842c650a3c41b852b195ed69533fa1c28dc948b67a05bf7a16c70142239d4adced938adf342376be53dc854324363eb151a8b04bf49622ce0fee6f672c2adf
+  data.tar.gz: cd442144b1514ef18a35480105b3f89f739488214cdd97710de59e8a2a8d3bd81696f8a9d3b9783c0f533fc5c6b4d520e6eae13db3a406dc05f185c2d5984aae

data/CHANGELOG.md

@@ -5,6 +5,79 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## 1.2.0 - 2020-11-13
+### Added
+- Added new rules introduced in the last version.
+    - Lint/DuplicateBranch (1.3)
+    - Lint/EmptyClass (1.3)
+    - Style/NilLambda (1.3)
+
+## 1.1.0 - 2020-11-13
+### Added
+- Added new rules introduced in the last version.
+    - Lint/NoReturnInBeginEndBlocks (1.2)
+    - Style/CollectionCompact (1.2)
+    - Style/NegatedIfElseCondition (1.2)
+
+### Changed
+- Changed Naming/VariableNumber to start using snake_case
+
+## 1.0.0 - 2020-11-04
+### Added
+- Added new rules introduced in the last version.
+    - Lint/DuplicateRegexpCharacterClassElement (1.1)
+    - Lint/EmptyBlock (1.1)
+    - Lint/ToEnumArguments (1.1)
+    - Lint/UnmodifiedReduceAccumulator (1.1)
+    - Style/ArgumentsForwarding (1.1)
+    - Style/DocumentDynamicEvalDefinition (1.1)
+    - Style/SwapValues (1.1)
+- Added new rules introduced in the last version of rubocop-rspec
+    - RSpec/Rails/HttpStatus (2.pre)
+
+### Changed
+- Removed shared enabled rules with rubocop 1.0
+- Bump dependencies (rubocop 1.0 and rubocop-rspec 2.pre)
+- Bump ruby version to use `...`
+- Reordered some rules following the convention of namespace/file.
+
+
+## 0.10.0 - 2020-11-04
+### Added
+- Added new rules introduced in the last version.
+    - Lint/HashCompareByIdentity (0.93)
+    - Lint/RedundantSafeNavigation (0.93)
+    - Style/ClassEqualityComparison (0.93)
+
+- Added new rules introduced in the last version of rubocop-rspec
+    - RSpec/StubbedMock (1.44)
+
+### Changed
+- Bump dependencies
+
+## 0.9.0 - 2020-09-18
+### Added
+- Added new rules introduced in the last version.
+    - Layout/BeginEndAlignment (0.91)
+    - Lint/ConstantDefinitionInBlock (0.91)
+    - Lint/DuplicateRequire (0.90)
+    - Lint/EmptyFile (0.90)
+    - Lint/IdentityComparison (0.91)
+    - Lint/TrailingCommaInAttributeDeclaration (0.90)
+    - Lint/UselessMethodDefinition (0.90)
+    - Lint/UselessTimes (0.91)
+    - Style/CombinableLoops (0.90)
+    - Style/KeywordParametersOrder (0.90)
+    - Style/RedundantSelfAssignment (0.90)
+    - Style/SoleNestedConditional (0.89)
+    - Performance/Sum (1.8)
+    - Rails/AfterCommitOverride (2.8)
+    - Rails/SquishedSQLHeredocs (2.8)
+    - Rails/WhereNot (2.8)
+
+### Changed
+- Updated all the extensions.
+
 ## 0.8.0 - 2020-08-07
 
 ### Added
@@ -77,6 +150,3 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 ## [0.1.0] - 2019-12-03
 
 First version of this gem.
-
-
-This changelog was generated using [ChangeFu](https://github.com/javierav/changefu).

data/README.md

@@ -2,6 +2,7 @@
 
 Common Rubocop config for all our projects.
 
+Please if you are using `rubocop < 1.0` use the branch [0.x](https://github.com/nosolosoftware/rubocop-nosolosoftware/tree/0.x) and  `rubocop-nosolosoftware < 1.0`.
 
 ## Installation
 

data/rubocop-layout.yml

@@ -2,14 +2,6 @@
 ## https://rubocop.readthedocs.io/en/latest/cops_layout/
 #
 
-# https://docs.rubocop.org/en/stable/cops_layout/#layoutemptylinesaroundattributeaccessor
-Layout/EmptyLinesAroundAttributeAccessor:
-  Enabled: true
-
-# https://docs.rubocop.org/en/stable/cops_layout/#layoutspacearoundmethodcalloperator
-Layout/SpaceAroundMethodCallOperator:
-  Enabled: true
-
 # https://rubocop.readthedocs.io/en/latest/cops_layout/#layoutfirstarrayelementindentation
 Layout/FirstArrayElementIndentation:
   EnforcedStyle: consistent

data/rubocop-lint.yml

@@ -2,58 +2,40 @@
 ## https://rubocop.readthedocs.io/en/latest/cops_lint/
 #
 
-# https://docs.rubocop.org/rubocop/cops_lint.html#lintraiseexception
-Lint/RaiseException:
+# https://docs.rubocop.org/rubocop/cops_lint.html#lintduplicateregexpcharacterclasselement
+Lint/DuplicateRegexpCharacterClassElement:
   Enabled: true
 
-# https://docs.rubocop.org/rubocop/cops_lint.html#lintstructnewoverride
-Lint/StructNewOverride:
+# https://docs.rubocop.org/rubocop/cops_lint.html#lintemptyblock
+Lint/EmptyBlock:
   Enabled: true
+  Exclude:
+    - "**/spec/factories/**/*.rb"
 
-# https://docs.rubocop.org/rubocop/cops_lint.html#lintdeprecatedopensslconstant
-Lint/DeprecatedOpenSSLConstant:
+# https://docs.rubocop.org/rubocop/cops_lint.html#linttoenumarguments
+Lint/ToEnumArguments:
   Enabled: true
 
-# https://docs.rubocop.org/rubocop/cops_lint.html#lintmixedregexpcapturetypes
-Lint/MixedRegexpCaptureTypes:
+# https://docs.rubocop.org/rubocop/cops_lint.html#lintunmodifiedreduceaccumulator
+Lint/UnmodifiedReduceAccumulator:
   Enabled: true
 
-# https://docs.rubocop.org/rubocop/cops_lint.html#lintduplicateelsifcondition
-Lint/DuplicateElsifCondition:
+# https://docs.rubocop.org/rubocop/cops_lint.html#linthashcomparebyidentity
+Lint/HashCompareByIdentity:
   Enabled: true
 
-# https://docs.rubocop.org/rubocop/cops_lint.html#lintbinaryoperatorwithidenticaloperands
-Lint/BinaryOperatorWithIdenticalOperands:
+# https://docs.rubocop.org/rubocop/cops_lint.html#lintredundantsafenavigation
+Lint/RedundantSafeNavigation:
   Enabled: true
 
-# https://docs.rubocop.org/rubocop/cops_lint.html#lintduplicaterescueexception
-Lint/DuplicateRescueException:
+# https://docs.rubocop.org/rubocop/cops_lint.html#lintnoreturninbeginendblocks
+Lint/NoReturnInBeginEndBlocks:
   Enabled: true
 
-# https://docs.rubocop.org/rubocop/cops_lint.html#lintemptyconditionalbody
-Lint/EmptyConditionalBody:
+# https://docs.rubocop.org/rubocop/cops_lint.html#lintduplicatebranch
+Lint/DuplicateBranch:
   Enabled: true
 
-# https://docs.rubocop.org/rubocop/cops_lint.html#lintfloatcomparison
-Lint/FloatComparison:
-  Enabled: true
-
-# https://docs.rubocop.org/rubocop/cops_lint.html#lintoutofrangeregexpref
-Lint/OutOfRangeRegexpRef:
-  Enabled: true
-
-# https://docs.rubocop.org/rubocop/cops_lint.html#lintselfassignment
-Lint/SelfAssignment:
-  Enabled: true
-
-# https://docs.rubocop.org/rubocop/cops_lint.html#linttoplevelreturnwithargument
-Lint/TopLevelReturnWithArgument:
-  Enabled: true
-
-# https://docs.rubocop.org/rubocop/cops_lint.html#lintunreachableloop
-Lint/UnreachableLoop:
-  Enabled: true
-
-# https://docs.rubocop.org/rubocop/cops_lint.html#lintmissingsuper
-Lint/MissingSuper:
+# https://docs.rubocop.org/rubocop/cops_lint.html#lintemptyclass
+Lint/EmptyClass:
   Enabled: true

data/rubocop-metrics.yml

@@ -13,3 +13,17 @@ Metrics/ClassLength:
 # https://rubocop.readthedocs.io/en/latest/cops_metrics/#metricsmethodlength
 Metrics/MethodLength:
   Enabled: false
+
+# https://rubocop.readthedocs.io/en/latest/cops_metrics/#metricsmodulelength
+Metrics/ModuleLength:
+  Exclude:
+    - "**/config/routes.rb"
+    - "**/spec/**/*.rb"
+
+# https://rubocop.readthedocs.io/en/latest/cops_metrics/#blocklength
+Metrics/BlockLength:
+  Exclude:
+    - "**/spec/**/*.rb"
+    - "**/config/environments/*.rb"
+    - "**/config/routes.rb"
+    - "**/lib/tasks/auto_annotate_models.rake"

data/rubocop-naming.yml

@@ -1,3 +1,7 @@
 #
 ## https://rubocop.readthedocs.io/en/latest/cops_naming/
 #
+
+# https://docs.rubocop.org/rubocop/cops_naming.html#namingvariablenumber
+Naming/VariableNumber:
+  EnforcedStyle: snake_case

data/rubocop-performance.yml

@@ -35,3 +35,7 @@ Performance/Squeeze:
 # https://docs.rubocop.org/rubocop-performance/1.7/cops_performance.html#performancestringinclude
 Performance/StringInclude:
   Enabled: true
+
+# https://docs.rubocop.org/rubocop-performance/1.8/cops_performance.html#performancesum
+Performance/Sum:
+  Enabled: true

data/rubocop-rails.yml

@@ -97,3 +97,15 @@ Rails/ShortI18n:
 # https://docs.rubocop.org/rubocop-rails/cops_rails.html#railswhereexists
 Rails/WhereExists:
   Enabled: true
+
+# https://docs.rubocop.org/rubocop-rails/cops_rails.html#railsaftercommitoverride
+Rails/AfterCommitOverride:
+  Enabled: true
+
+# https://docs.rubocop.org/rubocop-rails/cops_rails.html#railssquishedsqlheredocs
+Rails/SquishedSQLHeredocs:
+  Enabled: true
+
+# https://docs.rubocop.org/rubocop-rails/cops_rails.html#railswherenot
+Rails/WhereNot:
+  Enabled: true

data/rubocop-rspec.yml

@@ -38,12 +38,10 @@ RSpec/MultipleExpectations:
 RSpec/NestedGroups:
   Max: 5
 
-# https://rubocop.readthedocs.io/en/latest/cops_style/#styleblockcomments
-Style/BlockComments:
-  Exclude:
-    - "**/spec/**/*.rb"
+# https://docs.rubocop.org/rubocop-rspec/cops_rspec.html#rspecstubbedmock
+RSpec/StubbedMock:
+  Enabled: true
 
-# https://rubocop.readthedocs.io/en/latest/cops_style/#styleblockdelimiters
-Style/BlockDelimiters:
-  Exclude:
-    - "**/spec/**/*.rb"
+# https://docs.rubocop.org/rubocop-rspec/cops_rails.html#railshttpstatus
+RSpec/Rails/HttpStatus:
+  EnforcedStyle: numeric

data/rubocop-style.yml

@@ -9,99 +9,54 @@ Style/AsciiComments:
 # https://rubocop.readthedocs.io/en/latest/cops_style/#styleblockdelimiters
 Style/BlockDelimiters:
   EnforcedStyle: braces_for_chaining
+  Exclude:
+    - "**/spec/**/*.rb"
 
 # https://docs.rubocop.org/rubocop/cops_style.html#styledocumentation
 Style/Documentation:
   Enabled: false
 
-# https://docs.rubocop.org/rubocop/cops_style.html#styleexponentialnotation
-Style/ExponentialNotation:
-  Enabled: true
-
 # https://docs.rubocop.org/rubocop/cops_style.html#stylefrozenstringliteralcommetn
 Style/FrozenStringLiteralComment:
   Enabled: false
 
-# https://docs.rubocop.org/rubocop/cops_style.html#stylehasheachmethods
-Style/HashEachMethods:
-  Enabled: true
-
-# https://docs.rubocop.org/rubocop/cops_style.html#stylehashtransformkeys
-Style/HashTransformKeys:
-  Enabled: true
-
-# https://docs.rubocop.org/rubocop/cops_style.html#stylehashtransformvalues
-Style/HashTransformValues:
-  Enabled: true
-
-# https://docs.rubocop.org/rubocop/cops_style.html#styleregexpliteral
-Style/RegexpLiteral:
-  AllowInnerSlashes: true
-
-# https://docs.rubocop.org/rubocop/cops_style.html#styleslicingwithrange
-Style/SlicingWithRange:
-  Enabled: true
-
 # https://docs.rubocop.org/rubocop/cops_style.html#styleaccessorgrouping
 Style/AccessorGrouping:
   Enabled: false
 
-# https://docs.rubocop.org/rubocop/cops_style.html#stylebisectedattraccessor
-Style/BisectedAttrAccessor:
-  Enabled: true
-
-# https://docs.rubocop.org/rubocop/cops_style.html#styleredundantassignment
-Style/RedundantAssignment:
-  Enabled: true
-
-# https://docs.rubocop.org/rubocop/cops_style.html#styleredundantfetchblock
-Style/RedundantFetchBlock:
-  Enabled: true
-
-# https://docs.rubocop.org/rubocop/cops_style.html#styleredundantregexpcharacterclass
-Style/RedundantRegexpCharacterClass:
-  Enabled: true
-
-# https://docs.rubocop.org/rubocop/cops_style.html#styleredundantregexpescape
-Style/RedundantRegexpEscape:
-  Enabled: true
-
 # https://docs.rubocop.org/rubocop/cops_style.html#stylearraycoercion
 Style/ArrayCoercion:
   Enabled: true
 
-# https://docs.rubocop.org/rubocop/cops_style.html#stylecaselikeif
-Style/CaseLikeIf:
+# https://docs.rubocop.org/rubocop/cops_style.html#styleargumentsforwarding
+Style/ArgumentsForwarding:
   Enabled: true
 
-# https://docs.rubocop.org/rubocop/cops_style.html#stylehashaslastarrayitem
-Style/HashAsLastArrayItem:
+# https://docs.rubocop.org/rubocop/cops_style.html#styledocumentdynamicevaldefinition
+Style/DocumentDynamicEvalDefinition:
   Enabled: true
 
-# https://docs.rubocop.org/rubocop/cops_style.html#stylehashlikecase
-Style/HashLikeCase:
+# https://docs.rubocop.org/rubocop/cops_style.html#styleswapvalues
+Style/SwapValues:
   Enabled: true
 
-# https://docs.rubocop.org/rubocop/cops_style.html#styleredundantfileextensioninrequire
-Style/RedundantFileExtensionInRequire:
-  Enabled: true
-
-# https://docs.rubocop.org/rubocop/cops_style.html#styleexplicitblockargument
-Style/ExplicitBlockArgument:
-  Enabled: true
+# https://rubocop.readthedocs.io/en/latest/cops_style/#styleblockcomments
+Style/BlockComments:
+  Exclude:
+    - "**/spec/**/*.rb"
 
-# https://docs.rubocop.org/rubocop/cops_style.html#styleglobalstdstream
-Style/GlobalStdStream:
-  Enabled: true
+# https://docs.rubocop.org/rubocop/cops_style.html#styleregexpliteral
+Style/RegexpLiteral:
+  AllowInnerSlashes: true
 
-# https://docs.rubocop.org/rubocop/cops_style.html#styleoptionalbooleanparameter
-Style/OptionalBooleanParameter:
+# https://docs.rubocop.org/rubocop/cops_style.html#stylecollectioncompact
+Style/CollectionCompact:
   Enabled: true
 
-# https://docs.rubocop.org/rubocop/cops_style.html#stylesingleargumentdig
-Style/SingleArgumentDig:
+# https://docs.rubocop.org/rubocop/cops_style.html#stylenegatedifelsecondition
+Style/NegatedIfElseCondition:
   Enabled: true
 
-# https://docs.rubocop.org/rubocop/cops_style.html#stylestringconcatenation
-Style/StringConcatenation:
+# https://docs.rubocop.org/rubocop/cops_style.html#stylenillambda
+Style/NilLambda:
   Enabled: true

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rubocop-nosolosoftware
 version: !ruby/object:Gem::Version
-  version: 0.8.0
+  version: 1.2.0
 platform: ruby
 authors:
 - Javier Aranda
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-08-07 00:00:00.000000000 Z
+date: 2020-11-13 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop
@@ -16,14 +16,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.89'
+        version: '1.3'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.89'
+        version: '1.3'
 - !ruby/object:Gem::Dependency
   name: rubocop-faker
   requirement: !ruby/object:Gem::Requirement
@@ -44,28 +44,28 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.7'
+        version: '1.8'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.7'
+        version: '1.8'
 - !ruby/object:Gem::Dependency
   name: rubocop-rails
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '2.7'
+        version: '2.8'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '2.7'
+        version: '2.8'
 - !ruby/object:Gem::Dependency
   name: rubocop-rake
   requirement: !ruby/object:Gem::Requirement
@@ -86,14 +86,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.42'
+        version: 2.pre
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.42'
+        version: 2.pre
 description: ''
 email: jaranda@nosolosoftware.es
 executables: []
@@ -125,8 +125,8 @@ homepage: https://github.com/nosolosoftware/rubocop-nosolosoftware
 licenses:
 - MIT
 metadata:
-  source_code_uri: https://github.com/nosolosoftware/rubocop-nosolosoftware/tree/v0.8.0
-  changelog_uri: https://github.com/nosolosoftware/rubocop-nosolosoftware/blob/v0.8.0/CHANGELOG.md
+  source_code_uri: https://github.com/nosolosoftware/rubocop-nosolosoftware/tree/v1.2.0
+  changelog_uri: https://github.com/nosolosoftware/rubocop-nosolosoftware/blob/v1.2.0/CHANGELOG.md
   homepage_uri: https://github.com/nosolosoftware/rubocop-nosolosoftware
 post_install_message: 
 rdoc_options:
@@ -137,7 +137,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: 2.5.0
+      version: 2.7.0
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="