rubocop-nosolosoftware 0.7.0 → 1.1.0

Sign up to get free protection for your applications and to get access to all the features.
Files changed (12) hide show
  1. checksums.yaml +4 -4
  2. data/CHANGELOG.md +85 -3
  3. data/README.md +1 -0
  4. data/rubocop-layout.yml +0 -8
  5. data/rubocop-lint.yml +20 -10
  6. data/rubocop-metrics.yml +14 -0
  7. data/rubocop-naming.yml +4 -0
  8. data/rubocop-performance.yml +4 -0
  9. data/rubocop-rails.yml +12 -0
  10. data/rubocop-rspec.yml +6 -8
  11. data/rubocop-style.yml +21 -50
  12. metadata +14 -14
checksums.yaml CHANGED
@@ -1,7 +1,7 @@
1
1
  ---
2
2
  SHA256:
3
- metadata.gz: f1f256e884ae63111efa71f5c69acadd0caf7cb57d288a778824562d667c6059
4
- data.tar.gz: b54431a2cd90b1287402bba7433c4f0a86690632192670c25247da5f60bae9fd
3
+ metadata.gz: aab4a3d1c9e9a65f0b69f9798bd72c62deae2ffb4fb00998390e7db8ed3a70ce
4
+ data.tar.gz: b2bc912ea28242d44088704b54f80181963d7f1ed772a9c7aecc771b93d05c00
5
5
  SHA512:
6
- metadata.gz: 57a5ed7a613474b8820ef364a4a7cb08eb31a8e5e56d29a08a156f02bb845b146c8183037e7673f06a463d52e894f99e3b499df8e1160d52326c6ef1daf0b794
7
- data.tar.gz: 9d36f3fd6cfbf65090562c1684e3796957cee41209c4f0d8d4d685ec76b55dac99b286c9d6a0ed1cbaa82afdac8daac0c71683f7990b09e5a1e0d3dd12257093
6
+ metadata.gz: c2db1edca2e3bc75f90ed787d61bf30ca12a42eaa871b2c9d9203ec1756f05ce6d2a702a5b580372bcbca87b15274a01a866072676580976e94aa0c3902cff28
7
+ data.tar.gz: 19e0088b69bd29c3ad3568b61efd9168ed9b63eedbbe9b8bd7b5a42c099e021ca557bc0762dd9195bfbfe072465f0a70ebe2767f406b7af6538a7ed4a916a306
data/CHANGELOG.md CHANGED
@@ -5,6 +5,91 @@ All notable changes to this project will be documented in this file.
5
5
  The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
6
6
  and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
7
7
 
8
+ ## 1.1.0 - 2020-11-13
9
+ ### Added
10
+ - Added new rules introduced in the last version.
11
+ - Lint/NoReturnInBeginEndBlocks (1.2)
12
+ - Style/CollectionCompact (1.2)
13
+ - Style/NegatedIfElseCondition (1.2)
14
+
15
+ ### Changed
16
+ - Changed Naming/VariableNumber to start using snake_case
17
+
18
+ ## 1.0.0 - 2020-11-04
19
+ ### Added
20
+ - Added new rules introduced in the last version.
21
+ - Lint/DuplicateRegexpCharacterClassElement (1.1)
22
+ - Lint/EmptyBlock (1.1)
23
+ - Lint/ToEnumArguments (1.1)
24
+ - Lint/UnmodifiedReduceAccumulator (1.1)
25
+ - Style/ArgumentsForwarding (1.1)
26
+ - Style/DocumentDynamicEvalDefinition (1.1)
27
+ - Style/SwapValues (1.1)
28
+ - Added new rules introduced in the last version of rubocop-rspec
29
+ - RSpec/Rails/HttpStatus (2.pre)
30
+
31
+ ### Changed
32
+ - Removed shared enabled rules with rubocop 1.0
33
+ - Bump dependencies (rubocop 1.0 and rubocop-rspec 2.pre)
34
+ - Bump ruby version to use `...`
35
+ - Reordered some rules following the convention of namespace/file.
36
+
37
+
38
+ ## 0.10.0 - 2020-11-04
39
+ ### Added
40
+ - Added new rules introduced in the last version.
41
+ - Lint/HashCompareByIdentity (0.93)
42
+ - Lint/RedundantSafeNavigation (0.93)
43
+ - Style/ClassEqualityComparison (0.93)
44
+
45
+ - Added new rules introduced in the last version of rubocop-rspec
46
+ - RSpec/StubbedMock (1.44)
47
+
48
+ ### Changed
49
+ - Bump dependencies
50
+
51
+ ## 0.9.0 - 2020-09-18
52
+ ### Added
53
+ - Added new rules introduced in the last version.
54
+ - Layout/BeginEndAlignment (0.91)
55
+ - Lint/ConstantDefinitionInBlock (0.91)
56
+ - Lint/DuplicateRequire (0.90)
57
+ - Lint/EmptyFile (0.90)
58
+ - Lint/IdentityComparison (0.91)
59
+ - Lint/TrailingCommaInAttributeDeclaration (0.90)
60
+ - Lint/UselessMethodDefinition (0.90)
61
+ - Lint/UselessTimes (0.91)
62
+ - Style/CombinableLoops (0.90)
63
+ - Style/KeywordParametersOrder (0.90)
64
+ - Style/RedundantSelfAssignment (0.90)
65
+ - Style/SoleNestedConditional (0.89)
66
+ - Performance/Sum (1.8)
67
+ - Rails/AfterCommitOverride (2.8)
68
+ - Rails/SquishedSQLHeredocs (2.8)
69
+ - Rails/WhereNot (2.8)
70
+
71
+ ### Changed
72
+ - Updated all the extensions.
73
+
74
+ ## 0.8.0 - 2020-08-07
75
+
76
+ ### Added
77
+ - Added new rules introduced in the last version.
78
+ - Lint/BinaryOperatorWithIdenticalOperands (0.89)
79
+ - Lint/DuplicateRescueException (0.89)
80
+ - Lint/EmptyConditionalBody (0.89)
81
+ - Lint/FloatComparison (0.89)
82
+ - Lint/MissingSuper (0.89)
83
+ - Lint/OutOfRangeRegexpRef (0.89)
84
+ - Lint/SelfAssignment (0.89)
85
+ - Lint/TopLevelReturnWithArgument (0.89)
86
+ - Lint/UnreachableLoop (0.89)
87
+ - Style/ExplicitBlockArgument (0.89)
88
+ - Style/GlobalStdStream (0.89)
89
+ - Style/OptionalBooleanParameter (0.89)
90
+ - Style/SingleArgumentDig (0.89)
91
+ - Style/StringConcatenation (0.89)
92
+
8
93
  ## 0.7.0 - 2020-08-03
9
94
 
10
95
  ### Added
@@ -58,6 +143,3 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
58
143
  ## [0.1.0] - 2019-12-03
59
144
 
60
145
  First version of this gem.
61
-
62
-
63
- This changelog was generated using [ChangeFu](https://github.com/javierav/changefu).
data/README.md CHANGED
@@ -2,6 +2,7 @@
2
2
 
3
3
  Common Rubocop config for all our projects.
4
4
 
5
+ Please if you are using `rubocop < 1.0` use the branch [0.x](https://github.com/nosolosoftware/rubocop-nosolosoftware/tree/0.x) and `rubocop-nosolosoftware < 1.0`.
5
6
 
6
7
  ## Installation
7
8
 
data/rubocop-layout.yml CHANGED
@@ -2,14 +2,6 @@
2
2
  ## https://rubocop.readthedocs.io/en/latest/cops_layout/
3
3
  #
4
4
 
5
- # https://docs.rubocop.org/en/stable/cops_layout/#layoutemptylinesaroundattributeaccessor
6
- Layout/EmptyLinesAroundAttributeAccessor:
7
- Enabled: true
8
-
9
- # https://docs.rubocop.org/en/stable/cops_layout/#layoutspacearoundmethodcalloperator
10
- Layout/SpaceAroundMethodCallOperator:
11
- Enabled: true
12
-
13
5
  # https://rubocop.readthedocs.io/en/latest/cops_layout/#layoutfirstarrayelementindentation
14
6
  Layout/FirstArrayElementIndentation:
15
7
  EnforcedStyle: consistent
data/rubocop-lint.yml CHANGED
@@ -2,22 +2,32 @@
2
2
  ## https://rubocop.readthedocs.io/en/latest/cops_lint/
3
3
  #
4
4
 
5
- # https://docs.rubocop.org/rubocop/cops_lint.html#lintraiseexception
6
- Lint/RaiseException:
5
+ # https://docs.rubocop.org/rubocop/cops_lint.html#lintduplicateregexpcharacterclasselement
6
+ Lint/DuplicateRegexpCharacterClassElement:
7
7
  Enabled: true
8
8
 
9
- # https://docs.rubocop.org/rubocop/cops_lint.html#lintstructnewoverride
10
- Lint/StructNewOverride:
9
+ # https://docs.rubocop.org/rubocop/cops_lint.html#lintemptyblock
10
+ Lint/EmptyBlock:
11
11
  Enabled: true
12
+ Exclude:
13
+ - "**/spec/factories/**/*.rb"
12
14
 
13
- # https://docs.rubocop.org/rubocop/cops_lint.html#lintdeprecatedopensslconstant
14
- Lint/DeprecatedOpenSSLConstant:
15
+ # https://docs.rubocop.org/rubocop/cops_lint.html#linttoenumarguments
16
+ Lint/ToEnumArguments:
15
17
  Enabled: true
16
18
 
17
- # https://docs.rubocop.org/rubocop/cops_lint.html#lintmixedregexpcapturetypes
18
- Lint/MixedRegexpCaptureTypes:
19
+ # https://docs.rubocop.org/rubocop/cops_lint.html#lintunmodifiedreduceaccumulator
20
+ Lint/UnmodifiedReduceAccumulator:
19
21
  Enabled: true
20
22
 
21
- # https://docs.rubocop.org/rubocop/cops_lint.html#lintduplicateelsifcondition
22
- Lint/DuplicateElsifCondition:
23
+ # https://docs.rubocop.org/rubocop/cops_lint.html#linthashcomparebyidentity
24
+ Lint/HashCompareByIdentity:
25
+ Enabled: true
26
+
27
+ # https://docs.rubocop.org/rubocop/cops_lint.html#lintredundantsafenavigation
28
+ Lint/RedundantSafeNavigation:
29
+ Enabled: true
30
+
31
+ # https://docs.rubocop.org/rubocop/cops_lint.html#lintnoreturninbeginendblocks
32
+ Lint/NoReturnInBeginEndBlocks:
23
33
  Enabled: true
data/rubocop-metrics.yml CHANGED
@@ -13,3 +13,17 @@ Metrics/ClassLength:
13
13
  # https://rubocop.readthedocs.io/en/latest/cops_metrics/#metricsmethodlength
14
14
  Metrics/MethodLength:
15
15
  Enabled: false
16
+
17
+ # https://rubocop.readthedocs.io/en/latest/cops_metrics/#metricsmodulelength
18
+ Metrics/ModuleLength:
19
+ Exclude:
20
+ - "**/config/routes.rb"
21
+ - "**/spec/**/*.rb"
22
+
23
+ # https://rubocop.readthedocs.io/en/latest/cops_metrics/#blocklength
24
+ Metrics/BlockLength:
25
+ Exclude:
26
+ - "**/spec/**/*.rb"
27
+ - "**/config/environments/*.rb"
28
+ - "**/config/routes.rb"
29
+ - "**/lib/tasks/auto_annotate_models.rake"
data/rubocop-naming.yml CHANGED
@@ -1,3 +1,7 @@
1
1
  #
2
2
  ## https://rubocop.readthedocs.io/en/latest/cops_naming/
3
3
  #
4
+
5
+ # https://docs.rubocop.org/rubocop/cops_naming.html#namingvariablenumber
6
+ Naming/VariableNumber:
7
+ EnforcedStyle: snake_case
data/rubocop-performance.yml CHANGED
@@ -35,3 +35,7 @@ Performance/Squeeze:
35
35
  # https://docs.rubocop.org/rubocop-performance/1.7/cops_performance.html#performancestringinclude
36
36
  Performance/StringInclude:
37
37
  Enabled: true
38
+
39
+ # https://docs.rubocop.org/rubocop-performance/1.8/cops_performance.html#performancesum
40
+ Performance/Sum:
41
+ Enabled: true
data/rubocop-rails.yml CHANGED
@@ -97,3 +97,15 @@ Rails/ShortI18n:
97
97
  # https://docs.rubocop.org/rubocop-rails/cops_rails.html#railswhereexists
98
98
  Rails/WhereExists:
99
99
  Enabled: true
100
+
101
+ # https://docs.rubocop.org/rubocop-rails/cops_rails.html#railsaftercommitoverride
102
+ Rails/AfterCommitOverride:
103
+ Enabled: true
104
+
105
+ # https://docs.rubocop.org/rubocop-rails/cops_rails.html#railssquishedsqlheredocs
106
+ Rails/SquishedSQLHeredocs:
107
+ Enabled: true
108
+
109
+ # https://docs.rubocop.org/rubocop-rails/cops_rails.html#railswherenot
110
+ Rails/WhereNot:
111
+ Enabled: true
data/rubocop-rspec.yml CHANGED
@@ -38,12 +38,10 @@ RSpec/MultipleExpectations:
38
38
  RSpec/NestedGroups:
39
39
  Max: 5
40
40
 
41
- # https://rubocop.readthedocs.io/en/latest/cops_style/#styleblockcomments
42
- Style/BlockComments:
43
- Exclude:
44
- - "**/spec/**/*.rb"
41
+ # https://docs.rubocop.org/rubocop-rspec/cops_rspec.html#rspecstubbedmock
42
+ RSpec/StubbedMock:
43
+ Enabled: true
45
44
 
46
- # https://rubocop.readthedocs.io/en/latest/cops_style/#styleblockdelimiters
47
- Style/BlockDelimiters:
48
- Exclude:
49
- - "**/spec/**/*.rb"
45
+ # https://docs.rubocop.org/rubocop-rspec/cops_rails.html#railshttpstatus
46
+ RSpec/Rails/HttpStatus:
47
+ EnforcedStyle: numeric
data/rubocop-style.yml CHANGED
@@ -9,79 +9,50 @@ Style/AsciiComments:
9
9
  # https://rubocop.readthedocs.io/en/latest/cops_style/#styleblockdelimiters
10
10
  Style/BlockDelimiters:
11
11
  EnforcedStyle: braces_for_chaining
12
+ Exclude:
13
+ - "**/spec/**/*.rb"
12
14
 
13
15
  # https://docs.rubocop.org/rubocop/cops_style.html#styledocumentation
14
16
  Style/Documentation:
15
17
  Enabled: false
16
18
 
17
- # https://docs.rubocop.org/rubocop/cops_style.html#styleexponentialnotation
18
- Style/ExponentialNotation:
19
- Enabled: true
20
-
21
19
  # https://docs.rubocop.org/rubocop/cops_style.html#stylefrozenstringliteralcommetn
22
20
  Style/FrozenStringLiteralComment:
23
21
  Enabled: false
24
22
 
25
- # https://docs.rubocop.org/rubocop/cops_style.html#stylehasheachmethods
26
- Style/HashEachMethods:
27
- Enabled: true
28
-
29
- # https://docs.rubocop.org/rubocop/cops_style.html#stylehashtransformkeys
30
- Style/HashTransformKeys:
31
- Enabled: true
32
-
33
- # https://docs.rubocop.org/rubocop/cops_style.html#stylehashtransformvalues
34
- Style/HashTransformValues:
35
- Enabled: true
36
-
37
- # https://docs.rubocop.org/rubocop/cops_style.html#styleregexpliteral
38
- Style/RegexpLiteral:
39
- AllowInnerSlashes: true
40
-
41
- # https://docs.rubocop.org/rubocop/cops_style.html#styleslicingwithrange
42
- Style/SlicingWithRange:
43
- Enabled: true
44
-
45
23
  # https://docs.rubocop.org/rubocop/cops_style.html#styleaccessorgrouping
46
24
  Style/AccessorGrouping:
47
25
  Enabled: false
48
26
 
49
- # https://docs.rubocop.org/rubocop/cops_style.html#stylebisectedattraccessor
50
- Style/BisectedAttrAccessor:
51
- Enabled: true
52
-
53
- # https://docs.rubocop.org/rubocop/cops_style.html#styleredundantassignment
54
- Style/RedundantAssignment:
27
+ # https://docs.rubocop.org/rubocop/cops_style.html#stylearraycoercion
28
+ Style/ArrayCoercion:
55
29
  Enabled: true
56
30
 
57
- # https://docs.rubocop.org/rubocop/cops_style.html#styleredundantfetchblock
58
- Style/RedundantFetchBlock:
31
+ # https://docs.rubocop.org/rubocop/cops_style.html#styleargumentsforwarding
32
+ Style/ArgumentsForwarding:
59
33
  Enabled: true
60
34
 
61
- # https://docs.rubocop.org/rubocop/cops_style.html#styleredundantregexpcharacterclass
62
- Style/RedundantRegexpCharacterClass:
35
+ # https://docs.rubocop.org/rubocop/cops_style.html#styledocumentdynamicevaldefinition
36
+ Style/DocumentDynamicEvalDefinition:
63
37
  Enabled: true
64
38
 
65
- # https://docs.rubocop.org/rubocop/cops_style.html#styleredundantregexpescape
66
- Style/RedundantRegexpEscape:
39
+ # https://docs.rubocop.org/rubocop/cops_style.html#styleswapvalues
40
+ Style/SwapValues:
67
41
  Enabled: true
68
42
 
69
- # https://docs.rubocop.org/rubocop/cops_style.html#stylearraycoercion
70
- Style/ArrayCoercion:
71
- Enabled: true
43
+ # https://rubocop.readthedocs.io/en/latest/cops_style/#styleblockcomments
44
+ Style/BlockComments:
45
+ Exclude:
46
+ - "**/spec/**/*.rb"
72
47
 
73
- # https://docs.rubocop.org/rubocop/cops_style.html#stylecaselikeif
74
- Style/CaseLikeIf:
75
- Enabled: true
76
-
77
- # https://docs.rubocop.org/rubocop/cops_style.html#stylehashaslastarrayitem
78
- Style/HashAsLastArrayItem:
79
- Enabled: true
48
+ # https://docs.rubocop.org/rubocop/cops_style.html#styleregexpliteral
49
+ Style/RegexpLiteral:
50
+ AllowInnerSlashes: true
80
51
 
81
- # https://docs.rubocop.org/rubocop/cops_style.html#stylehashlikecase
82
- Style/HashLikeCase:
52
+ # https://docs.rubocop.org/rubocop/cops_style.html#stylecollectioncompact
53
+ Style/CollectionCompact:
83
54
  Enabled: true
84
55
 
85
- # https://docs.rubocop.org/rubocop/cops_style.html#styleredundantfileextensioninrequire
86
- Style/RedundantFileExtensionInRequire:
56
+ # https://docs.rubocop.org/rubocop/cops_style.html#stylenegatedifelsecondition
57
+ Style/NegatedIfElseCondition:
87
58
  Enabled: true
metadata CHANGED
@@ -1,14 +1,14 @@
1
1
  --- !ruby/object:Gem::Specification
2
2
  name: rubocop-nosolosoftware
3
3
  version: !ruby/object:Gem::Version
4
- version: 0.7.0
4
+ version: 1.1.0
5
5
  platform: ruby
6
6
  authors:
7
7
  - Javier Aranda
8
8
  autorequire:
9
9
  bindir: bin
10
10
  cert_chain: []
11
- date: 2020-08-03 00:00:00.000000000 Z
11
+ date: 2020-11-13 00:00:00.000000000 Z
12
12
  dependencies:
13
13
  - !ruby/object:Gem::Dependency
14
14
  name: rubocop
@@ -16,14 +16,14 @@ dependencies:
16
16
  requirements:
17
17
  - - "~>"
18
18
  - !ruby/object:Gem::Version
19
- version: '0.88'
19
+ version: '1.2'
20
20
  type: :runtime
21
21
  prerelease: false
22
22
  version_requirements: !ruby/object:Gem::Requirement
23
23
  requirements:
24
24
  - - "~>"
25
25
  - !ruby/object:Gem::Version
26
- version: '0.88'
26
+ version: '1.2'
27
27
  - !ruby/object:Gem::Dependency
28
28
  name: rubocop-faker
29
29
  requirement: !ruby/object:Gem::Requirement
@@ -44,28 +44,28 @@ dependencies:
44
44
  requirements:
45
45
  - - "~>"
46
46
  - !ruby/object:Gem::Version
47
- version: '1.7'
47
+ version: '1.8'
48
48
  type: :runtime
49
49
  prerelease: false
50
50
  version_requirements: !ruby/object:Gem::Requirement
51
51
  requirements:
52
52
  - - "~>"
53
53
  - !ruby/object:Gem::Version
54
- version: '1.7'
54
+ version: '1.8'
55
55
  - !ruby/object:Gem::Dependency
56
56
  name: rubocop-rails
57
57
  requirement: !ruby/object:Gem::Requirement
58
58
  requirements:
59
59
  - - "~>"
60
60
  - !ruby/object:Gem::Version
61
- version: '2.7'
61
+ version: '2.8'
62
62
  type: :runtime
63
63
  prerelease: false
64
64
  version_requirements: !ruby/object:Gem::Requirement
65
65
  requirements:
66
66
  - - "~>"
67
67
  - !ruby/object:Gem::Version
68
- version: '2.7'
68
+ version: '2.8'
69
69
  - !ruby/object:Gem::Dependency
70
70
  name: rubocop-rake
71
71
  requirement: !ruby/object:Gem::Requirement
@@ -86,14 +86,14 @@ dependencies:
86
86
  requirements:
87
87
  - - "~>"
88
88
  - !ruby/object:Gem::Version
89
- version: '1.42'
89
+ version: 2.pre
90
90
  type: :runtime
91
91
  prerelease: false
92
92
  version_requirements: !ruby/object:Gem::Requirement
93
93
  requirements:
94
94
  - - "~>"
95
95
  - !ruby/object:Gem::Version
96
- version: '1.42'
96
+ version: 2.pre
97
97
  description: ''
98
98
  email: jaranda@nosolosoftware.es
99
99
  executables: []
@@ -125,8 +125,8 @@ homepage: https://github.com/nosolosoftware/rubocop-nosolosoftware
125
125
  licenses:
126
126
  - MIT
127
127
  metadata:
128
- source_code_uri: https://github.com/nosolosoftware/rubocop-nosolosoftware/tree/v0.7.0
129
- changelog_uri: https://github.com/nosolosoftware/rubocop-nosolosoftware/blob/v0.7.0/CHANGELOG.md
128
+ source_code_uri: https://github.com/nosolosoftware/rubocop-nosolosoftware/tree/v1.1.0
129
+ changelog_uri: https://github.com/nosolosoftware/rubocop-nosolosoftware/blob/v1.1.0/CHANGELOG.md
130
130
  homepage_uri: https://github.com/nosolosoftware/rubocop-nosolosoftware
131
131
  post_install_message:
132
132
  rdoc_options:
@@ -137,14 +137,14 @@ required_ruby_version: !ruby/object:Gem::Requirement
137
137
  requirements:
138
138
  - - ">="
139
139
  - !ruby/object:Gem::Version
140
- version: 2.5.0
140
+ version: 2.7.0
141
141
  required_rubygems_version: !ruby/object:Gem::Requirement
142
142
  requirements:
143
143
  - - ">="
144
144
  - !ruby/object:Gem::Version
145
145
  version: '0'
146
146
  requirements: []
147
- rubygems_version: 3.1.2
147
+ rubygems_version: 3.0.3
148
148
  signing_key:
149
149
  specification_version: 4
150
150
  summary: Default Rubocop configuration used in NoSoloSoftware developments