rubocop-nosolosoftware 0.5.0 → 1.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: be651a56847d606edfb463d7eb40df524b4bd442b2f82ddd91280dc65a043bab
-  data.tar.gz: 537fee6664ba0550276c2ffc7ae973c66d6630649c2dea68ea9d2a8d1b72f4f4
+  metadata.gz: b1316db6cb779aa63c14de37309e49f1aa454443719e2d37e05bd2456738eece
+  data.tar.gz: a9c63c57b156bad203c1455c2a63e645813e4be2023e1d1d5a8bbc24efe1e1ba
 SHA512:
-  metadata.gz: 57a402c9eaf0a77d7047433d6ded777e2b6183b9c2aeb35bb873bca80111f102b076e1734ceaf404589f5ab497c375e35be8f396b7747719baba193c1669de35
-  data.tar.gz: f59972379f74a613d139bba332e27977e0297bbff19c6a1a4912f2b8f61f089b96020c57f0440e08387879569fde7415323d92808abfab1bcb98633aa00444f6
+  metadata.gz: d4f48333fe7116236116994b3842a6bf7f1403a435a0b66a7731d0569cc26a4e92f624c43b5c50b7e7734230cf39d6eede0f5b275ddc36ee3beb9da061e4eb7f
+  data.tar.gz: 3ef4abd15de78ada30af255655c8780bf9c992fa6274306e9ff250f17394f4a71e39478f1290750ab4b99767605b2e3efd4b8614e68388af41e551cec6f79a93

data/CHANGELOG.md

@@ -5,6 +5,110 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## 1.0.0 - 2020-11-04
+### Added
+- Added new rules introduced in the last version.
+    - Lint/DuplicateRegexpCharacterClassElement (1.1)
+    - Lint/EmptyBlock (1.1)
+    - Lint/ToEnumArguments (1.1)
+    - Lint/UnmodifiedReduceAccumulator (1.1)
+    - Style/ArgumentsForwarding (1.1)
+    - Style/DocumentDynamicEvalDefinition (1.1)
+    - Style/SwapValues (1.1)
+- Added new rules introduced in the last version of rubocop-rspec
+    - RSpec/Rails/HttpStatus (2.pre)
+
+### Changed
+- Removed shared enabled rules with rubocop 1.0
+- Bump dependencies (rubocop 1.0 and rubocop-rspec 2.pre)
+- Bump ruby version to use `...`
+- Reordered some rules following the convention of namespace/file.
+
+
+## 0.10.0 - 2020-11-04
+### Added
+- Added new rules introduced in the last version.
+    - Lint/HashCompareByIdentity (0.93)
+    - Lint/RedundantSafeNavigation (0.93)
+    - Style/ClassEqualityComparison (0.93)
+
+- Added new rules introduced in the last version of rubocop-rspec
+    - RSpec/StubbedMock (1.44)
+
+### Changed
+- Bump dependencies
+
+## 0.9.0 - 2020-09-18
+### Added
+- Added new rules introduced in the last version.
+    - Layout/BeginEndAlignment (0.91)
+    - Lint/ConstantDefinitionInBlock (0.91)
+    - Lint/DuplicateRequire (0.90)
+    - Lint/EmptyFile (0.90)
+    - Lint/IdentityComparison (0.91)
+    - Lint/TrailingCommaInAttributeDeclaration (0.90)
+    - Lint/UselessMethodDefinition (0.90)
+    - Lint/UselessTimes (0.91)
+    - Style/CombinableLoops (0.90)
+    - Style/KeywordParametersOrder (0.90)
+    - Style/RedundantSelfAssignment (0.90)
+    - Style/SoleNestedConditional (0.89)
+    - Performance/Sum (1.8)
+    - Rails/AfterCommitOverride (2.8)
+    - Rails/SquishedSQLHeredocs (2.8)
+    - Rails/WhereNot (2.8)
+
+### Changed
+- Updated all the extensions.
+
+## 0.8.0 - 2020-08-07
+
+### Added
+- Added new rules introduced in the last version.
+    - Lint/BinaryOperatorWithIdenticalOperands (0.89)
+    - Lint/DuplicateRescueException (0.89)
+    - Lint/EmptyConditionalBody (0.89)
+    - Lint/FloatComparison (0.89)
+    - Lint/MissingSuper (0.89)
+    - Lint/OutOfRangeRegexpRef (0.89)
+    - Lint/SelfAssignment (0.89)
+    - Lint/TopLevelReturnWithArgument (0.89)
+    - Lint/UnreachableLoop (0.89)
+    - Style/ExplicitBlockArgument (0.89)
+    - Style/GlobalStdStream (0.89)
+    - Style/OptionalBooleanParameter (0.89)
+    - Style/SingleArgumentDig (0.89)
+    - Style/StringConcatenation (0.89)
+
+## 0.7.0 - 2020-08-03
+
+### Added
+- Added rubocop-faker as new extension
+
+### Changed
+- Updated all the extensions, and configured new rules
+
+## 0.6.0 - 2020-07-13
+
+### Added
+- Added new rules introduced in the last version.
+    - Lint/DeprecatedOpenSSLConstant (0.84)
+    - Lint/MixedRegexpCaptureTypes (0.85)
+    - Style/AccessorGrouping (0.87)
+    - Style/BisectedAttrAccessor (0.87)
+    - Style/RedundantAssignment (0.87)
+    - Style/RedundantFetchBlock (0.86)
+    - Style/RedundantRegexpCharacterClass (0.85)
+    - Style/RedundantRegexpEscape (0.85)
+    - Performance/AncestorsInclude (1.7)
+    - Performance/BigDecimalWithNumericArgument (1.7)
+    - Performance/RedundantSortBlock (1.7)
+    - Performance/RedundantStringChars (1.7)
+    - Performance/ReverseFirst (1.7)
+    - Performance/SortReverse (1.7)
+    - Performance/Squeeze (1.7)
+    - Performance/StringInclude (1.7)
+
 ## 0.5.0 - 2020-07-07
 
 ### Changed
@@ -29,6 +133,3 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 ## [0.1.0] - 2019-12-03
 
 First version of this gem.
-
-
-This changelog was generated using [ChangeFu](https://github.com/javierav/changefu).

data/README.md

@@ -2,6 +2,7 @@
 
 Common Rubocop config for all our projects.
 
+Please if you are using `rubocop < 1.0` use the branch [0.x](https://github.com/nosolosoftware/rubocop-nosolosoftware/tree/0.x) and  `rubocop-nosolosoftware < 1.0`.
 
 ## Installation
 
@@ -44,7 +45,7 @@ inherit_gem:
     - rubocop-rails.yml
 ```
 
-**Optional Rake and Rspec rules**:
+**Optional Rake, Faker and Rspec rules**:
 
 ```yaml
 inherit_gem:
@@ -53,6 +54,7 @@ inherit_gem:
     - rubocop-rails.yml
     - rubocop-rake.yml
     - rubocop-rspec.yml
+    - rubocop-faker.yml
 ```
 
 **For Mongoid projects**:
@@ -64,6 +66,7 @@ inherit_gem:
     - rubocop-rails.yml
     - rubocop-rake.yml
     - rubocop-rspec.yml
+    - rubocop-faker.yml
     - rubocop-mongoid.yml
 ```
 

data/rubocop-faker.yml

@@ -0,0 +1,5 @@
+#
+## https://www.rubydoc.info/gems/rubocop-faker/
+#
+
+require: rubocop-faker

data/rubocop-layout.yml

@@ -2,14 +2,6 @@
 ## https://rubocop.readthedocs.io/en/latest/cops_layout/
 #
 
-# https://docs.rubocop.org/en/stable/cops_layout/#layoutemptylinesaroundattributeaccessor
-Layout/EmptyLinesAroundAttributeAccessor:
-  Enabled: true
-
-# https://docs.rubocop.org/en/stable/cops_layout/#layoutspacearoundmethodcalloperator
-Layout/SpaceAroundMethodCallOperator:
-  Enabled: true
-
 # https://rubocop.readthedocs.io/en/latest/cops_layout/#layoutfirstarrayelementindentation
 Layout/FirstArrayElementIndentation:
   EnforcedStyle: consistent

data/rubocop-lint.yml

@@ -2,10 +2,28 @@
 ## https://rubocop.readthedocs.io/en/latest/cops_lint/
 #
 
-# https://docs.rubocop.org/en/stable/cops_lint/#lintraiseexception
-Lint/RaiseException:
+# https://docs.rubocop.org/rubocop/cops_lint.html#lintduplicateregexpcharacterclasselement
+Lint/DuplicateRegexpCharacterClassElement:
   Enabled: true
 
-# https://docs.rubocop.org/en/stable/cops_lint/#lintstructnewoverride
-Lint/StructNewOverride:
+# https://docs.rubocop.org/rubocop/cops_lint.html#lintemptyblock
+Lint/EmptyBlock:
+  Enabled: true
+  Exclude:
+    - "**/spec/factories/**/*.rb"
+
+# https://docs.rubocop.org/rubocop/cops_lint.html#linttoenumarguments
+Lint/ToEnumArguments:
+  Enabled: true
+
+# https://docs.rubocop.org/rubocop/cops_lint.html#lintunmodifiedreduceaccumulator
+Lint/UnmodifiedReduceAccumulator:
+  Enabled: true
+
+# https://docs.rubocop.org/rubocop/cops_lint.html#linthashcomparebyidentity
+Lint/HashCompareByIdentity:
+  Enabled: true
+
+# https://docs.rubocop.org/rubocop/cops_lint.html#lintredundantsafenavigation
+Lint/RedundantSafeNavigation:
   Enabled: true

data/rubocop-metrics.yml

@@ -13,3 +13,17 @@ Metrics/ClassLength:
 # https://rubocop.readthedocs.io/en/latest/cops_metrics/#metricsmethodlength
 Metrics/MethodLength:
   Enabled: false
+
+# https://rubocop.readthedocs.io/en/latest/cops_metrics/#metricsmodulelength
+Metrics/ModuleLength:
+  Exclude:
+    - "**/config/routes.rb"
+    - "**/spec/**/*.rb"
+
+# https://rubocop.readthedocs.io/en/latest/cops_metrics/#blocklength
+Metrics/BlockLength:
+  Exclude:
+    - "**/spec/**/*.rb"
+    - "**/config/environments/*.rb"
+    - "**/config/routes.rb"
+    - "**/lib/tasks/auto_annotate_models.rake"

data/rubocop-performance.yml

@@ -3,3 +3,39 @@
 #
 
 require: rubocop-performance
+
+# https://docs.rubocop.org/rubocop-performance/1.7/cops_performance.html#performanceancestorsinclude
+Performance/AncestorsInclude:
+  Enabled: true
+
+# https://docs.rubocop.org/rubocop-performance/1.7/cops_performance.html#performancebigdecimalwithnumericargument
+Performance/BigDecimalWithNumericArgument:
+  Enabled: false
+
+# https://docs.rubocop.org/rubocop-performance/1.7/cops_performance.html#performanceredundantsortblock
+Performance/RedundantSortBlock:
+  Enabled: true
+
+# https://docs.rubocop.org/rubocop-performance/1.7/cops_performance.html#performanceredundantstringchars
+Performance/RedundantStringChars:
+  Enabled: true
+
+# https://docs.rubocop.org/rubocop-performance/1.7/cops_performance.html#performancereversefirst
+Performance/ReverseFirst:
+  Enabled: true
+
+# https://docs.rubocop.org/rubocop-performance/1.7/cops_performance.html#performancesortreverse
+Performance/SortReverse:
+  Enabled: true
+
+# https://docs.rubocop.org/rubocop-performance/1.7/cops_performance.html#performancesqueeze
+Performance/Squeeze:
+  Enabled: true
+
+# https://docs.rubocop.org/rubocop-performance/1.7/cops_performance.html#performancestringinclude
+Performance/StringInclude:
+  Enabled: true
+
+# https://docs.rubocop.org/rubocop-performance/1.8/cops_performance.html#performancesum
+Performance/Sum:
+  Enabled: true

data/rubocop-rails.yml

@@ -49,3 +49,63 @@ Naming/FileName:
 Style/SymbolProc:
   Exclude:
     - "**/config/**/*.rb"
+
+# https://docs.rubocop.org/rubocop-rails/cops_rails.html#railsactiverecordcallbacksorder
+Rails/ActiveRecordCallbacksOrder:
+  Enabled: true
+
+# https://docs.rubocop.org/rubocop-rails/cops_rails.html#railsfindbyid
+Rails/FindById:
+  Enabled: true
+
+# https://docs.rubocop.org/rubocop-rails/cops_rails.html#railsinquiry
+Rails/Inquiry:
+  Enabled: true
+
+# https://docs.rubocop.org/rubocop-rails/cops_rails.html#railsmailername
+Rails/MailerName:
+  Enabled: true
+
+# https://docs.rubocop.org/rubocop-rails/cops_rails.html#railsmatchroute
+Rails/MatchRoute:
+  Enabled: true
+
+# https://docs.rubocop.org/rubocop-rails/cops_rails.html#railsnegateinclude
+Rails/NegateInclude:
+  Enabled: true
+
+# https://docs.rubocop.org/rubocop-rails/cops_rails.html#railspick
+Rails/Pluck:
+  Enabled: true
+
+# https://docs.rubocop.org/rubocop-rails/cops_rails.html#railspluckinwhere
+Rails/PluckInWhere:
+  Enabled: true
+
+# https://docs.rubocop.org/rubocop-rails/cops_rails.html#railsrenderinline
+Rails/RenderInline:
+  Enabled: true
+
+# https://docs.rubocop.org/rubocop-rails/cops_rails.html#railsrenderplaintext
+Rails/RenderPlainText:
+  Enabled: true
+
+# https://docs.rubocop.org/rubocop-rails/cops_rails.html#railsshorti18n
+Rails/ShortI18n:
+  Enabled: true
+
+# https://docs.rubocop.org/rubocop-rails/cops_rails.html#railswhereexists
+Rails/WhereExists:
+  Enabled: true
+
+# https://docs.rubocop.org/rubocop-rails/cops_rails.html#railsaftercommitoverride
+Rails/AfterCommitOverride:
+  Enabled: true
+
+# https://docs.rubocop.org/rubocop-rails/cops_rails.html#railssquishedsqlheredocs
+Rails/SquishedSQLHeredocs:
+  Enabled: true
+
+# https://docs.rubocop.org/rubocop-rails/cops_rails.html#railswherenot
+Rails/WhereNot:
+  Enabled: true

data/rubocop-rspec.yml

@@ -38,12 +38,10 @@ RSpec/MultipleExpectations:
 RSpec/NestedGroups:
   Max: 5
 
-# https://rubocop.readthedocs.io/en/latest/cops_style/#styleblockcomments
-Style/BlockComments:
-  Exclude:
-    - "**/spec/**/*.rb"
+# https://docs.rubocop.org/rubocop-rspec/cops_rspec.html#rspecstubbedmock
+RSpec/StubbedMock:
+  Enabled: true
 
-# https://rubocop.readthedocs.io/en/latest/cops_style/#styleblockdelimiters
-Style/BlockDelimiters:
-  Exclude:
-    - "**/spec/**/*.rb"
+# https://docs.rubocop.org/rubocop-rspec/cops_rails.html#railshttpstatus
+RSpec/Rails/HttpStatus:
+  EnforcedStyle: numeric

data/rubocop-style.yml

@@ -9,35 +9,42 @@ Style/AsciiComments:
 # https://rubocop.readthedocs.io/en/latest/cops_style/#styleblockdelimiters
 Style/BlockDelimiters:
   EnforcedStyle: braces_for_chaining
+  Exclude:
+    - "**/spec/**/*.rb"
 
-# https://rubocop.readthedocs.io/en/latest/cops_style/#styledocumentation
+# https://docs.rubocop.org/rubocop/cops_style.html#styledocumentation
 Style/Documentation:
   Enabled: false
 
-# https://docs.rubocop.org/en/stable/cops_style/#styleexponentialnotation
-Style/ExponentialNotation:
-  Enabled: true
-
-# https://rubocop.readthedocs.io/en/latest/cops_style/#stylefrozenstringliteralcomment
+# https://docs.rubocop.org/rubocop/cops_style.html#stylefrozenstringliteralcommetn
 Style/FrozenStringLiteralComment:
   Enabled: false
 
-# https://docs.rubocop.org/en/stable/cops_style/#stylehasheachmethods
-Style/HashEachMethods:
+# https://docs.rubocop.org/rubocop/cops_style.html#styleaccessorgrouping
+Style/AccessorGrouping:
+  Enabled: false
+
+# https://docs.rubocop.org/rubocop/cops_style.html#stylearraycoercion
+Style/ArrayCoercion:
   Enabled: true
 
-# https://docs.rubocop.org/en/stable/cops_style/#stylehashtransformkeys
-Style/HashTransformKeys:
+# https://docs.rubocop.org/rubocop/cops_style.html#styleargumentsforwarding
+Style/ArgumentsForwarding:
   Enabled: true
 
-# https://docs.rubocop.org/en/stable/cops_style/#stylehashtransformvalues
-Style/HashTransformValues:
+# https://docs.rubocop.org/rubocop/cops_style.html#styledocumentdynamicevaldefinition
+Style/DocumentDynamicEvalDefinition:
   Enabled: true
 
-# https://rubocop.readthedocs.io/en/latest/cops_style/#styleregexpliteral
+# https://docs.rubocop.org/rubocop/cops_style.html#styleswapvalues
+Style/SwapValues:
+  Enabled: true
+
+# https://rubocop.readthedocs.io/en/latest/cops_style/#styleblockcomments
+Style/BlockComments:
+  Exclude:
+    - "**/spec/**/*.rb"
+
+# https://docs.rubocop.org/rubocop/cops_style.html#styleregexpliteral
 Style/RegexpLiteral:
   AllowInnerSlashes: true
-
-# https://docs.rubocop.org/en/stable/cops_style/#styleslicingwithrange
-Style/SlicingWithRange:
-  Enabled: true

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rubocop-nosolosoftware
 version: !ruby/object:Gem::Version
-  version: 0.5.0
+  version: 1.0.0
 platform: ruby
 authors:
 - Javier Aranda
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-07-07 00:00:00.000000000 Z
+date: 2020-11-04 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop
@@ -16,42 +16,56 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.83'
+        version: '1.1'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.83'
+        version: '1.1'
+- !ruby/object:Gem::Dependency
+  name: rubocop-faker
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1.1'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1.1'
 - !ruby/object:Gem::Dependency
   name: rubocop-performance
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.5'
+        version: '1.8'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.5'
+        version: '1.8'
 - !ruby/object:Gem::Dependency
   name: rubocop-rails
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '2.5'
+        version: '2.8'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '2.5'
+        version: '2.8'
 - !ruby/object:Gem::Dependency
   name: rubocop-rake
   requirement: !ruby/object:Gem::Requirement
@@ -72,14 +86,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.39'
+        version: 2.pre
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.39'
+        version: 2.pre
 description: ''
 email: jaranda@nosolosoftware.es
 executables: []
@@ -94,6 +108,7 @@ files:
 - rubocop-all.yml
 - rubocop-bundler.yml
 - rubocop-default.yml
+- rubocop-faker.yml
 - rubocop-gemspec.yml
 - rubocop-layout.yml
 - rubocop-lint.yml
@@ -110,8 +125,8 @@ homepage: https://github.com/nosolosoftware/rubocop-nosolosoftware
 licenses:
 - MIT
 metadata:
-  source_code_uri: https://github.com/nosolosoftware/rubocop-nosolosoftware/tree/v0.5.0
-  changelog_uri: https://github.com/nosolosoftware/rubocop-nosolosoftware/blob/v0.5.0/CHANGELOG.md
+  source_code_uri: https://github.com/nosolosoftware/rubocop-nosolosoftware/tree/v1.0.0
+  changelog_uri: https://github.com/nosolosoftware/rubocop-nosolosoftware/blob/v1.0.0/CHANGELOG.md
   homepage_uri: https://github.com/nosolosoftware/rubocop-nosolosoftware
 post_install_message: 
 rdoc_options:
@@ -122,7 +137,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: 2.5.0
+      version: 2.7.0
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="