rubocop-nosolosoftware 0.1.0 → 0.6.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: a61c152b479d508b2373acd221dab0683938ba1a1e872bd008c5dd956a838688
-  data.tar.gz: 5a9f041171d20215d43d53a49925a4ccaed5c69fc9af3af6f3817c9a32822d95
+  metadata.gz: fb5d898222cca337d8a3119aec6ba9cc18f176c6f74833307192e21426cb5b8e
+  data.tar.gz: 68c73a006a6ec77afccb43d997bba6074b06f801b85b213a47932aaeb217751c
 SHA512:
-  metadata.gz: 238b58095cc0ed0acb55597d01edf4197a264ca0a372fdc90bf65b3a6a11dbca5d0d32928ee5a26f8b164d7d6540836d168cc55498f6b69b08c586930109bb4d
-  data.tar.gz: 8a7333d4eaba7f2bdd972187fd858147fdc9186182b9564d96ead26b710ddb341105d7c96e8a550de5ce45888be2fa30d6545a30b03be9d2030e2b450104e527
+  metadata.gz: 9efcc57f05e8918e961190a1953500880ef59927698aec9f4c9fe5c9ef949e70b71c5646fbf80a20ea9982a18d4d38339336599eb4a7a4e1fab9d6fcee0ea821
+  data.tar.gz: f1bec6ecc3b4a1ee3d3811b9826fae7b874f7f16520572c50b9dcbc5f906bbeeaf40dd40daa4bf328188717b112de610591db7021c5b50add46c14d5d5c474f7

data/CHANGELOG.md

@@ -5,14 +5,51 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## 0.6.0 - 2020-07-13
 
-## [Unreleased]
+### Added
+- Added new rules introduced in the last version.
+    - Lint/DeprecatedOpenSSLConstant (0.84)
+    - Lint/MixedRegexpCaptureTypes (0.85)
+    - Style/AccessorGrouping (0.87)
+    - Style/BisectedAttrAccessor (0.87)
+    - Style/RedundantAssignment (0.87)
+    - Style/RedundantFetchBlock (0.86)
+    - Style/RedundantRegexpCharacterClass (0.85)
+    - Style/RedundantRegexpEscape (0.85)
+    - Performance/AncestorsInclude (1.7)
+    - Performance/BigDecimalWithNumericArgument (1.7)
+    - Performance/RedundantSortBlock (1.7)
+    - Performance/RedundantStringChars (1.7)
+    - Performance/ReverseFirst (1.7)
+    - Performance/SortReverse (1.7)
+    - Performance/Squeeze (1.7)
+    - Performance/StringInclude (1.7)
 
+## 0.5.0 - 2020-07-07
+
+### Changed
+- Actualizadas reglas
+
+## 0.4.0 - 2020-02-26
+
+### Changed
+- Remove Style/BracesAroundHashParameters cop
+
+## 0.3.0 - 2020-02-07
+
+### Changed
+- Set enforced style to braces_for_chaining in Style/BlockDelimiters cop.
+- Relax required versions of rubocop gems.
+
+## 0.2.0 - 2019-12-23
+
+### Changed
+- Move LineLength cop from Metrics to Layout and require rubocop 0.78.0.
 
 ## [0.1.0] - 2019-12-03
 
 First version of this gem.
 
 
-[Unreleased]: https://github.com/nosolosoftware/rubocop-nosolosoftware/compare/v0.1.0...HEAD
-[0.1.0]: https://github.com/nosolosoftware/rubocop-nosolosoftware/releases/tag/v0.1.0
+This changelog was generated using [ChangeFu](https://github.com/javierav/changefu).

data/LICENSE

@@ -1,4 +1,4 @@
-Copyright (c) 2019 NoSoloSoftware Network S.L.
+Copyright (c) 2019-2020 NoSoloSoftware Network S.L.
 
 Permission is hereby granted, free of charge, to any person obtaining a copy
 of this software and associated documentation files (the "Software"), to deal

data/README.md

@@ -26,16 +26,16 @@ $ gem install rubocop-nosolosoftware
 
 ## Usage
 
-Include the following in your `.rubocop.yml`:
+Include the following in your `.rubocop.yml`
 
-**For Ruby**
+**For Ruby**:
 
 ```yaml
 inherit_gem:
   rubocop-nosolosoftware: rubocop-default.yml
 ```
 
-**For Rails**
+**For Rails**:
 
 ```yaml
 inherit_gem:
@@ -44,7 +44,7 @@ inherit_gem:
     - rubocop-rails.yml
 ```
 
-**Optional Rake and Rspec rules**
+**Optional Rake and Rspec rules**:
 
 ```yaml
 inherit_gem:
@@ -55,6 +55,30 @@ inherit_gem:
     - rubocop-rspec.yml
 ```
 
+**For Mongoid projects**:
+
+```yaml
+inherit_gem:
+  rubocop-nosolosoftware:
+    - rubocop-default.yml
+    - rubocop-rails.yml
+    - rubocop-rake.yml
+    - rubocop-rspec.yml
+    - rubocop-mongoid.yml
+```
+
+
+### Inheritance of array attributes
+
+Don't forget to include the following in your configuration file:
+
+```yaml
+inherit_mode:
+  merge:
+    - Exclude
+    - Prefixes
+```
+
 
 ## Contributing
 
@@ -72,4 +96,4 @@ be a safe, welcoming space for collaboration, and contributors are expected to a
 
 ## License
 
-Copyright (c) 2019 NoSoloSoftware Network S.L. - Released under [MIT](LICENSE) license
+Copyright (c) 2019-2020 NoSoloSoftware Network S.L. - Released under [MIT](LICENSE) license.

data/rubocop-bundler.yml

@@ -1,7 +1,3 @@
 #
 ## https://rubocop.readthedocs.io/en/latest/cops_bundler/
 #
-
-# https://rubocop.readthedocs.io/en/latest/cops_bundler/#bundlerorderedgems
-Bundler/OrderedGems:
-  Enabled: false

data/rubocop-layout.yml

@@ -2,10 +2,26 @@
 ## https://rubocop.readthedocs.io/en/latest/cops_layout/
 #
 
+# https://docs.rubocop.org/en/stable/cops_layout/#layoutemptylinesaroundattributeaccessor
+Layout/EmptyLinesAroundAttributeAccessor:
+  Enabled: true
+
+# https://docs.rubocop.org/en/stable/cops_layout/#layoutspacearoundmethodcalloperator
+Layout/SpaceAroundMethodCallOperator:
+  Enabled: true
+
 # https://rubocop.readthedocs.io/en/latest/cops_layout/#layoutfirstarrayelementindentation
 Layout/FirstArrayElementIndentation:
   EnforcedStyle: consistent
 
+# https://rubocop.readthedocs.io/en/latest/cops_layout/#layoutlinelength
+Layout/LineLength:
+  Max: 100
+
+# https://rubocop.readthedocs.io/en/stable/cops_layout/#layoutmultilinemethodcallindentation
+Layout/MultilineMethodCallIndentation:
+  EnforcedStyle: indented_relative_to_receiver
+
 # https://rubocop.readthedocs.io/en/latest/cops_layout/#layoutspacearoundequalsinparameterdefault
 Layout/SpaceAroundEqualsInParameterDefault:
   EnforcedStyle: no_space

data/rubocop-lint.yml

@@ -1,3 +1,19 @@
 #
 ## https://rubocop.readthedocs.io/en/latest/cops_lint/
 #
+
+# https://docs.rubocop.org/rubocop/cops_lint.html#lintraiseexception
+Lint/RaiseException:
+  Enabled: true
+
+# https://docs.rubocop.org/rubocop/cops_lint.html#lintstructnewoverride
+Lint/StructNewOverride:
+  Enabled: true
+
+# https://docs.rubocop.org/rubocop/cops_lint.html#lintdeprecatedopensslconstant
+Lint/DeprecatedOpenSSLConstant:
+  Enabled: true
+
+# https://docs.rubocop.org/rubocop/cops_lint.html#lintmixedregexpcapturetypes
+Lint/MixedRegexpCaptureTypes:
+  Enabled: true

data/rubocop-metrics.yml

@@ -10,10 +10,6 @@ Metrics/AbcSize:
 Metrics/ClassLength:
   Enabled: false
 
-# https://rubocop.readthedocs.io/en/latest/cops_metrics/#metricslinelength
-Metrics/LineLength:
-  Max: 100
-
 # https://rubocop.readthedocs.io/en/latest/cops_metrics/#metricsmethodlength
 Metrics/MethodLength:
   Enabled: false

data/rubocop-mongoid.yml

@@ -0,0 +1,7 @@
+#
+## Rubocop cops for Mongoid projects
+#
+
+# https://docs.rubocop.org/projects/rails/en/latest/cops_rails/#railsfindeach
+Rails/FindEach:
+  Enabled: false

data/rubocop-performance.yml

@@ -3,3 +3,35 @@
 #
 
 require: rubocop-performance
+
+# https://docs.rubocop.org/rubocop-performance/1.7/cops_performance.html#performanceancestorsinclude
+Performance/AncestorsInclude:
+  Enabled: true
+
+# https://docs.rubocop.org/rubocop-performance/1.7/cops_performance.html#performancebigdecimalwithnumericargument
+Performance/BigDecimalWithNumericArgument:
+  Enabled: false
+
+# https://docs.rubocop.org/rubocop-performance/1.7/cops_performance.html#performanceredundantsortblock
+Performance/RedundantSortBlock:
+  Enabled: true
+
+# https://docs.rubocop.org/rubocop-performance/1.7/cops_performance.html#performanceredundantstringchars
+Performance/RedundantStringChars:
+  Enabled: true
+
+# https://docs.rubocop.org/rubocop-performance/1.7/cops_performance.html#performancereversefirst
+Performance/ReverseFirst:
+  Enabled: true
+
+# https://docs.rubocop.org/rubocop-performance/1.7/cops_performance.html#performancesortreverse
+Performance/SortReverse:
+  Enabled: true
+
+# https://docs.rubocop.org/rubocop-performance/1.7/cops_performance.html#performancesqueeze
+Performance/Squeeze:
+  Enabled: true
+
+# https://docs.rubocop.org/rubocop-performance/1.7/cops_performance.html#performancestringinclude
+Performance/StringInclude:
+  Enabled: true

data/rubocop-rails.yml

@@ -9,33 +9,41 @@ Rails:
 
 # https://docs.rubocop.org/projects/rails/en/latest/cops_rails/#railshttpstatus
 Rails/HttpStatus:
-  Enabled: false
+  EnforcedStyle: numeric
 
-# https://docs.rubocop.org/projects/rails/en/latest/cops_rails/#railshasandbelongstomany
-Rails/HasAndBelongsToMany:
-  Enabled: false
-
-# https://docs.rubocop.org/projects/rails/en/latest/cops_rails/#railsfindby
-Rails/FindBy:
-  Enabled: false
+# https://rubocop-rails.readthedocs.io/en/stable/cops_rails/#railsrakeenvironment
+Rails/RakeEnvironment:
+  Exclude:
+    - "**/lib/tasks/auto_annotate_models.rake"
 
 AllCops:
   Exclude:
-    - "**/db/schema.rb"
     - "**/bin/**/*"
+    - "**/db/schema.rb"
+
+# https://rubocop.readthedocs.io/en/stable/cops_layout/#layouthashalignment
+Layout/HashAlignment:
+  Exclude:
+    - "**/lib/tasks/auto_annotate_models.rake"
 
 # https://rubocop.readthedocs.io/en/latest/cops_metrics/#metricsblocklength
 Metrics/BlockLength:
   Exclude:
-    - "**/spec/**/*.rb"
-    - "**/config/routes.rb"
     - "**/config/environments/*.rb"
+    - "**/config/routes.rb"
+    - "**/lib/tasks/auto_annotate_models.rake"
+    - "**/spec/**/*.rb"
 
 # https://rubocop.readthedocs.io/en/latest/cops_metrics/#metricsmodulelength
 Metrics/ModuleLength:
   Exclude:
-    - "**/spec/**/*.rb"
     - "**/config/routes.rb"
+    - "**/spec/**/*.rb"
+
+# https://www.rubocop.org/en/stable/cops_naming/#namingfilename
+Naming/FileName:
+  Exclude:
+    - "**/Envfile"
 
 # https://rubocop.readthedocs.io/en/latest/cops_style/#stylesymbolproc
 Style/SymbolProc:

data/rubocop-rake.yml

@@ -1 +1,6 @@
 require: rubocop-rake
+
+# https://github.com/rubocop-hq/rubocop-rake/blob/master/lib/rubocop/cop/rake/desc.rb
+Rake/Desc:
+  Exclude:
+    - "**/lib/tasks/auto_annotate_models.rake"

data/rubocop-rspec.yml

@@ -4,6 +4,40 @@
 
 require: rubocop-rspec
 
+# https://rubocop-rspec.readthedocs.io/en/latest/cops_rspec/#rspeccontextwording
+RSpec/ContextWording:
+  Prefixes:
+    - and
+
+# https://rubocop-rspec.readthedocs.io/en/latest/cops_rspec/#rspecdescribeclass
+RSpec/DescribeClass:
+  Exclude:
+    - "**/spec/requests/**/*.rb"
+    - "**/spec/system/**/*.rb"
+    - "**/spec/features/**/*.rb"
+
+# https://rubocop-rspec.readthedocs.io/en/latest/cops_rspec/#rspecexamplelength
+RSpec/ExampleLength:
+  Exclude:
+    - "**/spec/requests/**/*.rb"
+    - "**/spec/system/**/*.rb"
+    - "**/spec/features/**/*.rb"
+
+# https://rubocop-rspec.readthedocs.io/en/latest/cops_rspec/#rspecimplicitsubject
+RSpec/ImplicitSubject:
+  EnforcedStyle: single_statement_only
+
+# https://rubocop-rspec.readthedocs.io/en/latest/cops_rspec/#rspecmultipleexpectations
+RSpec/MultipleExpectations:
+  Exclude:
+    - "**/spec/requests/**/*.rb"
+    - "**/spec/system/**/*.rb"
+    - "**/spec/features/**/*.rb"
+
+# https://rubocop-rspec.readthedocs.io/en/latest/cops_rspec/#rspecnestedgroups
+RSpec/NestedGroups:
+  Max: 5
+
 # https://rubocop.readthedocs.io/en/latest/cops_style/#styleblockcomments
 Style/BlockComments:
   Exclude:

data/rubocop-style.yml

@@ -6,34 +6,62 @@
 Style/AsciiComments:
   Enabled: false
 
-# https://rubocop.readthedocs.io/en/latest/cops_style/#stylebracesaroundhashparameters
-Style/BracesAroundHashParameters:
-  EnforcedStyle: context_dependent
+# https://rubocop.readthedocs.io/en/latest/cops_style/#styleblockdelimiters
+Style/BlockDelimiters:
+  EnforcedStyle: braces_for_chaining
 
-# https://rubocop.readthedocs.io/en/latest/cops_style/#styledatetime
-Style/DateTime:
-  Enabled: false
-
-# https://rubocop.readthedocs.io/en/latest/cops_style/#styledocumentation
+# https://docs.rubocop.org/rubocop/cops_style.html#styledocumentation
 Style/Documentation:
   Enabled: false
 
-# https://rubocop.readthedocs.io/en/latest/cops_style/#styleemptymethod
-Style/EmptyMethod:
-  Enabled: false
-
-# https://rubocop.readthedocs.io/en/latest/cops_style/#styleformatstringtoken
-Style/FormatStringToken:
-  Enabled: false
+# https://docs.rubocop.org/rubocop/cops_style.html#styleexponentialnotation
+Style/ExponentialNotation:
+  Enabled: true
 
-# https://rubocop.readthedocs.io/en/latest/cops_style/#stylefrozenstringliteralcomment
+# https://docs.rubocop.org/rubocop/cops_style.html#stylefrozenstringliteralcommetn
 Style/FrozenStringLiteralComment:
   Enabled: false
 
-# https://rubocop.readthedocs.io/en/latest/cops_style/#stylemutableconstant
-Style/MutableConstant:
-  Enabled: false
+# https://docs.rubocop.org/rubocop/cops_style.html#stylehasheachmethods
+Style/HashEachMethods:
+  Enabled: true
+
+# https://docs.rubocop.org/rubocop/cops_style.html#stylehashtransformkeys
+Style/HashTransformKeys:
+  Enabled: true
+
+# https://docs.rubocop.org/rubocop/cops_style.html#stylehashtransformvalues
+Style/HashTransformValues:
+  Enabled: true
 
-# https://rubocop.readthedocs.io/en/latest/cops_style/#styleregexpliteral
+# https://docs.rubocop.org/rubocop/cops_style.html#styleregexpliteral
 Style/RegexpLiteral:
+  AllowInnerSlashes: true
+
+# https://docs.rubocop.org/rubocop/cops_style.html#styleslicingwithrange
+Style/SlicingWithRange:
+  Enabled: true
+
+# https://docs.rubocop.org/rubocop/cops_style.html#styleaccessorgrouping
+Style/AccessorGrouping:
   Enabled: false
+
+# https://docs.rubocop.org/rubocop/cops_style.html#stylebisectedattraccessor
+Style/BisectedAttrAccessor:
+  Enabled: true
+
+# https://docs.rubocop.org/rubocop/cops_style.html#styleredundantassignment
+Style/RedundantAssignment:
+  Enabled: true
+
+# https://docs.rubocop.org/rubocop/cops_style.html#styleredundantfetchblock
+Style/RedundantFetchBlock:
+  Enabled: true
+
+# https://docs.rubocop.org/rubocop/cops_style.html#styleredundantregexpcharacterclass
+Style/RedundantRegexpCharacterClass:
+  Enabled: true
+
+# https://docs.rubocop.org/rubocop/cops_style.html#styleredundantregexpescape
+Style/RedundantRegexpEscape:
+  Enabled: true

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rubocop-nosolosoftware
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.6.0
 platform: ruby
 authors:
 - Javier Aranda
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-12-03 00:00:00.000000000 Z
+date: 2020-07-13 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop
@@ -16,70 +16,70 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.77.0
+        version: '0.83'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.77.0
+        version: '0.83'
 - !ruby/object:Gem::Dependency
   name: rubocop-performance
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.5.1
+        version: '1.5'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.5.1
+        version: '1.5'
 - !ruby/object:Gem::Dependency
   name: rubocop-rails
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 2.4.0
+        version: '2.5'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 2.4.0
+        version: '2.5'
 - !ruby/object:Gem::Dependency
   name: rubocop-rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.5.0
+        version: '0.5'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.5.0
+        version: '0.5'
 - !ruby/object:Gem::Dependency
   name: rubocop-rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.37.0
+        version: '1.39'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.37.0
+        version: '1.39'
 description: ''
 email: jaranda@nosolosoftware.es
 executables: []
@@ -91,7 +91,6 @@ files:
 - CHANGELOG.md
 - LICENSE
 - README.md
-- lib/rubocop-nosolosoftware/version.rb
 - rubocop-all.yml
 - rubocop-bundler.yml
 - rubocop-default.yml
@@ -99,6 +98,7 @@ files:
 - rubocop-layout.yml
 - rubocop-lint.yml
 - rubocop-metrics.yml
+- rubocop-mongoid.yml
 - rubocop-naming.yml
 - rubocop-performance.yml
 - rubocop-rails.yml
@@ -110,8 +110,8 @@ homepage: https://github.com/nosolosoftware/rubocop-nosolosoftware
 licenses:
 - MIT
 metadata:
-  source_code_uri: https://github.com/nosolosoftware/rubocop-nosolosoftware/tree/v0.1.0
-  changelog_uri: https://github.com/nosolosoftware/rubocop-nosolosoftware/blob/v0.1.0/CHANGELOG.md
+  source_code_uri: https://github.com/nosolosoftware/rubocop-nosolosoftware/tree/v0.6.0
+  changelog_uri: https://github.com/nosolosoftware/rubocop-nosolosoftware/blob/v0.6.0/CHANGELOG.md
   homepage_uri: https://github.com/nosolosoftware/rubocop-nosolosoftware
 post_install_message: 
 rdoc_options:
@@ -129,7 +129,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.3
+rubygems_version: 3.1.2
 signing_key: 
 specification_version: 4
 summary: Default Rubocop configuration used in NoSoloSoftware developments

data/lib/rubocop-nosolosoftware/version.rb

@@ -1,22 +0,0 @@
-module RubocopNoSoloSoftware
-  module VERSION
-    MAJOR = 0
-    MINOR = 1
-    TINY  = 0
-    PRE   = nil
-
-    STRING = [MAJOR, MINOR, TINY, PRE].compact.join('.')
-  end
-
-  def self.version
-    VERSION::STRING
-  end
-
-  def self.gem_version
-    Gem::Version.new VERSION::STRING
-  end
-
-  def self.required_ruby_version
-    Gem::Requirement.new('>= 2.5.0')
-  end
-end