rubocop-neeto 0.1.18 → 0.1.19
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- checksums.yaml +4 -4
- data/README.md +1 -0
- data/config/default.yml +12 -0
- data/lib/rubocop/cop/neeto/faraday_over_httparty.rb +38 -0
- data/lib/rubocop/cop/neeto_cops.rb +1 -0
- data/lib/rubocop/neeto/version.rb +1 -1
- metadata +3 -2
checksums.yaml
CHANGED
|
@@ -1,7 +1,7 @@
|
|
|
1
1
|
---
|
|
2
2
|
SHA256:
|
|
3
|
-
metadata.gz:
|
|
4
|
-
data.tar.gz:
|
|
3
|
+
metadata.gz: a114d1fda0a6640c867ce32d0882d0c804d1e0b4f273d9bfcf13f35d77e8cda7
|
|
4
|
+
data.tar.gz: 0f27ddfd9cfce7a6e6499716441730003bf5f4657b650020866ba811bc7966ac
|
|
5
5
|
SHA512:
|
|
6
|
-
metadata.gz:
|
|
7
|
-
data.tar.gz:
|
|
6
|
+
metadata.gz: 8c02805a3712d669826caa86ec47a886347bc3657e8d1d72901f3f5465babcdd9c666e76e63374b3e6ac17c52f0511fe65b2bfb4be4bc1f0eb97ea800fef6f19
|
|
7
|
+
data.tar.gz: 726009349f00e1615c5b6e4752bc4cd5be629e3b142af7fb6b3f3bd2d801203a172b70c48a05b4f252063802db1ca001526d0c54a727b676d77177ddca2b29ae
|
data/README.md
CHANGED
|
@@ -6,6 +6,7 @@
|
|
|
6
6
|
2. [Neeto/UnsafeColumnDeletion](https://rubocop-neeto.neetodeployapp.com/docs/RuboCop/Cop/Neeto/UnsafeColumnDeletion)
|
|
7
7
|
3. [Neeto/DirectEnvAccess](https://rubocop-neeto.neetodeployapp.com/docs/RuboCop/Cop/Neeto/DirectEnvAccess)
|
|
8
8
|
4. [Neeto/DeprecatedJobBaseClass](https://rubocop-neeto.neetodeployapp.com/docs/RuboCop/Cop/Neeto/DeprecatedJobBaseClass)
|
|
9
|
+
5. [Neeto/FaradayOverHttparty](https://rubocop-neeto.neetodeployapp.com/docs/RuboCop/Cop/Neeto/FaradayOverHttparty)
|
|
9
10
|
|
|
10
11
|
## Installation
|
|
11
12
|
|
data/config/default.yml
CHANGED
|
@@ -52,3 +52,15 @@ Neeto/DeprecatedJobBaseClass:
|
|
|
52
52
|
- app/workers/**/*.rb
|
|
53
53
|
- test/dummy/app/jobs/**/*.rb
|
|
54
54
|
- test/dummy/app/workers/**/*.rb
|
|
55
|
+
|
|
56
|
+
Neeto/FaradayOverHttparty:
|
|
57
|
+
Description: >-
|
|
58
|
+
HTTParty has been removed from all Neeto applications in favor of Faraday,
|
|
59
|
+
which is already available. Do not re-add the `httparty` gem. See
|
|
60
|
+
https://github.com/neetozone/neeto-engineering/issues/1862 for more details.
|
|
61
|
+
Enabled: true
|
|
62
|
+
Severity: refactor
|
|
63
|
+
VersionAdded: '0.1'
|
|
64
|
+
Include:
|
|
65
|
+
- '**/Gemfile'
|
|
66
|
+
- '**/Gemfile.common.rb'
|
|
@@ -0,0 +1,38 @@
|
|
|
1
|
+
# frozen_string_literal: true
|
|
2
|
+
|
|
3
|
+
module RuboCop
|
|
4
|
+
module Cop
|
|
5
|
+
module Neeto
|
|
6
|
+
# HTTParty has been removed from all Neeto applications in favor of
|
|
7
|
+
# Faraday, which is already available. This cop flags any attempt to add
|
|
8
|
+
# the `httparty` gem to a Gemfile.
|
|
9
|
+
#
|
|
10
|
+
# @example FaradayOverHttparty: true (default)
|
|
11
|
+
# # Disallows adding the `httparty` gem.
|
|
12
|
+
#
|
|
13
|
+
# # bad
|
|
14
|
+
# gem "httparty"
|
|
15
|
+
#
|
|
16
|
+
# # good
|
|
17
|
+
# gem "faraday"
|
|
18
|
+
#
|
|
19
|
+
class FaradayOverHttparty < Base
|
|
20
|
+
MSG = "Do not add the `httparty` gem. Use `faraday` instead, which is " \
|
|
21
|
+
"already available in the application. See " \
|
|
22
|
+
"https://github.com/neetozone/neeto-engineering/issues/1862 for more details."
|
|
23
|
+
|
|
24
|
+
RESTRICT_ON_SEND = %i[gem].freeze
|
|
25
|
+
|
|
26
|
+
def_node_matcher :httparty_gem?, <<~PATTERN
|
|
27
|
+
(send nil? :gem (str $_) ...)
|
|
28
|
+
PATTERN
|
|
29
|
+
|
|
30
|
+
def on_send(node)
|
|
31
|
+
httparty_gem?(node) do |gem_name|
|
|
32
|
+
add_offense(node) if gem_name.casecmp?("httparty")
|
|
33
|
+
end
|
|
34
|
+
end
|
|
35
|
+
end
|
|
36
|
+
end
|
|
37
|
+
end
|
|
38
|
+
end
|
metadata
CHANGED
|
@@ -1,14 +1,14 @@
|
|
|
1
1
|
--- !ruby/object:Gem::Specification
|
|
2
2
|
name: rubocop-neeto
|
|
3
3
|
version: !ruby/object:Gem::Version
|
|
4
|
-
version: 0.1.
|
|
4
|
+
version: 0.1.19
|
|
5
5
|
platform: ruby
|
|
6
6
|
authors:
|
|
7
7
|
- Yedhin Kizhakkethara
|
|
8
8
|
autorequire:
|
|
9
9
|
bindir: exe
|
|
10
10
|
cert_chain: []
|
|
11
|
-
date: 2026-
|
|
11
|
+
date: 2026-06-02 00:00:00.000000000 Z
|
|
12
12
|
dependencies:
|
|
13
13
|
- !ruby/object:Gem::Dependency
|
|
14
14
|
name: rubocop
|
|
@@ -37,6 +37,7 @@ files:
|
|
|
37
37
|
- lib/rubocop-neeto.rb
|
|
38
38
|
- lib/rubocop/cop/neeto/deprecated_job_base_class.rb
|
|
39
39
|
- lib/rubocop/cop/neeto/direct_env_access.rb
|
|
40
|
+
- lib/rubocop/cop/neeto/faraday_over_httparty.rb
|
|
40
41
|
- lib/rubocop/cop/neeto/unsafe_column_deletion.rb
|
|
41
42
|
- lib/rubocop/cop/neeto/unsafe_table_deletion.rb
|
|
42
43
|
- lib/rubocop/cop/neeto_cops.rb
|