rubocop-neeto 0.1.13 → 0.1.15

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 8184d728fee43af3b4bcb59ccf8ecc827ed5c2b7d351dcc352accc96c5747668
-  data.tar.gz: e055d4c63eadc8d751abba0856f443300f124f2c7d8a29f2983f7b217fa77ce4
+  metadata.gz: adbaf8298c1804456d5050900f7e9c1d0688ad5f10e8b66c3db71bf90ad4fd81
+  data.tar.gz: 7f8b07c600c15ae128f6f11586f349aa6376be85fdeda1105568873a518228e5
 SHA512:
-  metadata.gz: 198e1dcb6d07c4ad72761b3d950fa72e27e3cec5717dc5e20c536732b8852fa1dce95e660d507b83193f5a2a2c7a6fdf3a2a49b12950fe4cbacfaf36e0c87749
-  data.tar.gz: 7c1ed69c05f6f73d3e1ce1deab02192720af603dd284368929e118afdd2d7608d3386f8720afd84058c82d5b1904e31be6304b83b26014a564272f36b771ab68
+  metadata.gz: ac72b53c76cb5e555c22a7a33af51a2de10bc3b552e0d6f0bbe57527c3023088f08342744ccb99636a0bca4f4f1a1a8b0c40bf08f6a47a3ea976d21d3a56da38
+  data.tar.gz: 52b490198a4a344ce20397f18bd5518ec76261673f32bfe83ec2236e23f40045a8c4a9cff6fabbdead8d36e7661671e8b0e075a27facac892b9a9be28db93810

data/README.md

@@ -5,6 +5,7 @@
 1. [Neeto/UnsafeTableDeletion](https://rubocop-neeto.neetodeployapp.com/docs/RuboCop/Cop/Neeto/UnsafeTableDeletion)
 2. [Neeto/UnsafeColumnDeletion](https://rubocop-neeto.neetodeployapp.com/docs/RuboCop/Cop/Neeto/UnsafeColumnDeletion)
 3. [Neeto/DirectEnvAccess](https://rubocop-neeto.neetodeployapp.com/docs/RuboCop/Cop/Neeto/DirectEnvAccess)
+4. [Neeto/DeprecatedJobBaseClass](https://rubocop-neeto.neetodeployapp.com/docs/RuboCop/Cop/Neeto/DeprecatedJobBaseClass)
 
 ## Installation
 

data/config/default.yml

@@ -37,3 +37,19 @@ Neeto/DirectEnvAccess:
   VersionAdded: '0.1'
   Include:
     - app/**/*.rb
+
+Neeto/DeprecatedJobBaseClass:
+  Description: >-
+    Jobs should not inherit directly from the legacy
+    `NeetoCommonsBackend::BaseJobs::*` base classes. Use latency-based job
+    classes such as `LatencyBasedJobs::Within5Seconds`,
+    `LatencyBasedJobs::Within1Minute`, `LatencyBasedJobs::Within5Minutes`,
+    or `LatencyBasedJobs::Within1Hour` instead.
+  Enabled: true
+  Severity: refactor
+  VersionAdded: '0.1'
+  Include:
+    - app/jobs/**/*.rb
+    - app/workers/**/*.rb
+    - test/dummy/app/jobs/**/*.rb
+    - test/dummy/app/workers/**/*.rb

data/lib/rubocop/cop/neeto/deprecated_job_base_class.rb

@@ -0,0 +1,72 @@
+# frozen_string_literal: true
+
+module RuboCop
+  module Cop
+    module Neeto
+      # The legacy `NeetoCommonsBackend::BaseJobs::*` base classes have been
+      # replaced with latency-based job classes such as
+      # `LatencyBasedJobs::Within5Seconds`, `LatencyBasedJobs::Within1Minute`,
+      # `LatencyBasedJobs::Within5Minutes`, and `LatencyBasedJobs::Within1Hour`.
+      # This cop prevents new jobs from inheriting directly from the legacy
+      # Neeto Commons base classes.
+      #
+      # @example DeprecatedJobBaseClass: true (default)
+      #   # bad
+      #   class ExportJob < NeetoCommonsBackend::BaseJobs::Default
+      #   end
+      #
+      #   # bad
+      #   class SyncWebhookJob < NeetoCommonsBackend::BaseJobs::Urgent
+      #   end
+      #
+      #   # good
+      #   class ExportJob < LatencyBasedJobs::Within5Minutes
+      #   end
+      #
+      #   # good
+      #   class SyncWebhookJob < LatencyBasedJobs::Within5Seconds
+      #   end
+      #
+      #   # good
+      #   # Defining the latency classes themselves
+      #   module LatencyBasedJobs
+      #     class Within5Seconds < NeetoCommonsBackend::BaseJobs::Base
+      #     end
+      #   end
+      #
+      class DeprecatedJobBaseClass < Base
+        LEGACY_SUPERCLASSES = {
+          "NeetoCommonsBackend::BaseJobs::Urgent" => "Use `LatencyBasedJobs::Within5Seconds` instead.",
+          "NeetoCommonsBackend::BaseJobs::Auth" => "Use `LatencyBasedJobs::Within1Minute` instead.",
+          "NeetoCommonsBackend::BaseJobs::Default" => "Use `LatencyBasedJobs::Within1Minute` or `LatencyBasedJobs::Within5Minutes` based on the job's SLA.",
+          "NeetoCommonsBackend::BaseJobs::Low" => "Use `LatencyBasedJobs::Within1Hour` instead.",
+          "NeetoCommonsBackend::BaseJobs::Base" => "Use a latency-based job base class instead, for example `LatencyBasedJobs::Within5Seconds`, `LatencyBasedJobs::Within1Minute`, `LatencyBasedJobs::Within5Minutes`, or `LatencyBasedJobs::Within1Hour`."
+        }.freeze
+
+        MSG = "Do not inherit jobs directly from `%<superclass>s`. %<replacement>s"
+
+        def on_class(node)
+          return if allowed_file_path?
+
+          superclass = node.parent_class
+          return unless superclass&.const_type?
+
+          superclass_name = superclass.const_name
+          replacement = LEGACY_SUPERCLASSES[superclass_name]
+          return unless replacement
+
+          add_offense(superclass, message: format(MSG, superclass: superclass_name, replacement:))
+        end
+
+        private
+
+          def allowed_file_path?
+            file_path = processed_source.file_path.to_s
+
+            file_path.end_with?("app/jobs/concerns/latency_based_jobs.rb") ||
+              file_path.match?(%r{(?:\A|/)app/jobs/neeto_commons_backend/base_jobs/})
+          end
+      end
+    end
+  end
+end

data/lib/rubocop/cop/neeto_cops.rb

@@ -3,3 +3,4 @@
 require_relative "neeto/unsafe_table_deletion"
 require_relative "neeto/unsafe_column_deletion"
 require_relative "neeto/direct_env_access"
+require_relative "neeto/deprecated_job_base_class"

data/lib/rubocop/neeto/version.rb

@@ -2,6 +2,6 @@
 
 module RuboCop
   module Neeto
-    VERSION = "0.1.13"
+    VERSION = "0.1.15"
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rubocop-neeto
 version: !ruby/object:Gem::Version
-  version: 0.1.13
+  version: 0.1.15
 platform: ruby
 authors:
 - Abhay V Ashokan
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2026-02-10 00:00:00.000000000 Z
+date: 2026-04-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop
@@ -35,6 +35,7 @@ files:
 - Rakefile
 - config/default.yml
 - lib/rubocop-neeto.rb
+- lib/rubocop/cop/neeto/deprecated_job_base_class.rb
 - lib/rubocop/cop/neeto/direct_env_access.rb
 - lib/rubocop/cop/neeto/unsafe_column_deletion.rb
 - lib/rubocop/cop/neeto/unsafe_table_deletion.rb