rubocop-minitest 0.6.2 → 0.7.0

data/relnotes/v0.6.2.md

@@ -0,0 +1,5 @@
+### Bug fixes
+
+* [#55](https://github.com/rubocop-hq/rubocop-minitest/issues/55): Fix an error for `Minitest/AssertIncludes` when using local variable argument. ([@koic][])
+
+[@koic]: https://github.com/koic

data/relnotes/v0.7.0.md

@@ -0,0 +1,13 @@
+### New features
+
+* [#60](https://github.com/rubocop-hq/rubocop-minitest/issues/60): Add new cop `Minitest/GlobalExpectations` to check for deprecated global expectations. ([@tejasbubane][])
+
+### Bug fixes
+
+* [#58](https://github.com/rubocop-hq/rubocop-minitest/pull/58): Fix a false negative for `Minitest/AssertMatch` and `Minitest/RefuteMatch` when an argument is enclosed in redundant parentheses. ([@koic][])
+* [#59](https://github.com/rubocop-hq/rubocop-minitest/pull/59): Fix a false negative for `Minitest/AssertRespondTo` and `Minitest/RefuteRespondTo` when an argument is enclosed in redundant parentheses. ([@koic][])
+* [#61](https://github.com/rubocop-hq/rubocop-minitest/pull/61): Fix a false negative for `Minitest/AssertInstanceOf` and `Minitest/RefuteInstanceOf` when an argument is enclosed in redundant parentheses. ([@koic][])
+* [#62](https://github.com/rubocop-hq/rubocop-minitest/pull/62): Fix a false negative for `Minitest/AssertEmpty` and `Minitest/RefuteEmpty` when an argument is enclosed in redundant parentheses. ([@koic][])
+
+[@tejasbubane]: https://github.com/tejasbubane
+[@koic]: https://github.com/koic

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rubocop-minitest
 version: !ruby/object:Gem::Version
-  version: 0.6.2
+  version: 0.7.0
 platform: ruby
 authors:
 - Bozhidar Batsov
@@ -10,7 +10,7 @@ authors:
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2020-02-19 00:00:00.000000000 Z
+date: 2020-03-09 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop
@@ -49,6 +49,7 @@ extensions: []
 extra_rdoc_files: []
 files:
 - ".circleci/config.yml"
+- ".gitattributes"
 - ".github/FUNDING.yml"
 - ".github/ISSUE_TEMPLATE/bug_report.md"
 - ".github/ISSUE_TEMPLATE/feature_request.md"
@@ -75,6 +76,7 @@ files:
 - lib/rubocop/cop/minitest/assert_nil.rb
 - lib/rubocop/cop/minitest/assert_respond_to.rb
 - lib/rubocop/cop/minitest/assert_truthy.rb
+- lib/rubocop/cop/minitest/global_expectations.rb
 - lib/rubocop/cop/minitest/refute_empty.rb
 - lib/rubocop/cop/minitest/refute_equal.rb
 - lib/rubocop/cop/minitest/refute_false.rb
@@ -85,7 +87,7 @@ files:
 - lib/rubocop/cop/minitest/refute_respond_to.rb
 - lib/rubocop/cop/minitest_cops.rb
 - lib/rubocop/cop/mixin/argument_range_helper.rb
-- lib/rubocop/cop/mixin/includes_cop_rule.rb
+- lib/rubocop/cop/mixin/minitest_cop_rule.rb
 - lib/rubocop/minitest.rb
 - lib/rubocop/minitest/inject.rb
 - lib/rubocop/minitest/version.rb
@@ -106,6 +108,8 @@ files:
 - relnotes/v0.5.1.md
 - relnotes/v0.6.0.md
 - relnotes/v0.6.1.md
+- relnotes/v0.6.2.md
+- relnotes/v0.7.0.md
 - rubocop-minitest.gemspec
 - tasks/cops_documentation.rake
 - tasks/cut_release.rake
@@ -133,8 +137,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.5.2.3
+rubygems_version: 3.1.2
 signing_key: 
 specification_version: 4
 summary: Automatic Minitest code style checking tool.

data/lib/rubocop/cop/mixin/includes_cop_rule.rb

@@ -1,78 +0,0 @@
-# frozen_string_literal: true
-
-module RuboCop
-  module Cop
-    # Define the rule for `Minitest/AssertIncludes` and `Minitest/RefuteIncludes` cops.
-    module IncludesCopRule
-      def rule(target_method:, prefer_method:)
-        class_eval(<<~RUBY, __FILE__, __LINE__ + 1)
-          include ArgumentRangeHelper
-
-          MSG = 'Prefer using `#{prefer_method}(%<new_arguments>s)` over ' \
-                '`#{target_method}(%<original_arguments>s)`.'
-
-          def on_send(node)
-            return unless node.method?(:#{target_method})
-            return unless (arguments = peel_redundant_parentheses_from(node.arguments))
-            return unless arguments.first.respond_to?(:method?) && arguments.first.method?(:include?)
-
-            add_offense(node, message: offense_message(arguments))
-          end
-
-          def autocorrect(node)
-            lambda do |corrector|
-              corrector.replace(node.loc.selector, '#{prefer_method}')
-
-              arguments = peel_redundant_parentheses_from(node.arguments)
-
-              new_arguments = [
-                arguments.first.receiver.source,
-                arguments.first.arguments.map(&:source)
-              ].join(', ')
-
-              if enclosed_in_redundant_parentheses?(node)
-                new_arguments = '(' + new_arguments + ')'
-              end
-
-              corrector.replace(first_argument_range(node), new_arguments)
-            end
-          end
-
-          private
-
-          def peel_redundant_parentheses_from(arguments)
-            return arguments unless arguments.first.begin_type?
-
-            peel_redundant_parentheses_from(arguments.first.children)
-          end
-
-          def offense_message(arguments)
-            new_arguments = new_arguments(arguments)
-
-            original_arguments = arguments.map(&:source).join(', ')
-
-            format(
-              MSG,
-              new_arguments: new_arguments,
-              original_arguments: original_arguments
-            )
-          end
-
-          def new_arguments(arguments)
-            message_argument = arguments.last if arguments.first != arguments.last
-
-            [
-              arguments.first.receiver,
-              arguments.first.arguments.first,
-              message_argument
-            ].compact.map(&:source).join(', ')
-          end
-
-          def enclosed_in_redundant_parentheses?(node)
-            node.arguments.first.begin_type?
-          end
-        RUBY
-      end
-    end
-  end
-end