rubocop-minitest 0.38.0 → 0.38.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 7bd6b6a1346ed5b630ee67a043672d05c5503f55fe6d104f002193140856c1b3
-  data.tar.gz: 80c6c476bf82f3b285974d3516f95695957a1806f616fb4de0ad5aa0d7ba2ac7
+  metadata.gz: b9b5ea8a4137a723a3fa2dd0a77f58667f3c91f64dc2396e7db1c80865415bc4
+  data.tar.gz: 61a9a98f38a54140e137ae6c87e846305f1c2c015d4bc5a17207693623babca1
 SHA512:
-  metadata.gz: 1b6546efa373b0e0d922ef620e0bceb64047f017eabc26cdc55558f6258dd1dbd469c63a96961f8b377594d82eae0104bcfdeb19b80e4d748bf986ca96d8fd7b
-  data.tar.gz: 70247d05b6b0c83398307b877f27c0ddc88e88820f3efcd0e223b1f19fd052fd0ffa76c433a27f87edc55af2c28c68da6b40b4ce828553d8337a3cf172ec9314
+  metadata.gz: 9d9fc8561127373fc7d3d344192042e8ea6fb69137b9d6cb30589aa15ba625369709b415ce115a92d152d284d1da3f848be7c54052a71caf547d6342d3a263b0
+  data.tar.gz: 8ba825723997d2cbd9f84287eb32b7bd82c47a501b074674dc929ecb6b5646b3d18d5335f170eae7766c388d59ee3b16c95d04598ed547ec3111293ebe38b7ec

data/lib/rubocop/cop/minitest/global_expectations.rb

@@ -87,20 +87,10 @@ module RuboCop
 
         MSG = 'Use `%<preferred>s` instead.'
 
-        VALUE_MATCHERS = %i[
-          must_be_empty must_equal must_be_close_to must_be_within_delta
-          must_be_within_epsilon must_include must_be_instance_of must_be_kind_of
-          must_match must_be_nil must_be must_respond_to must_be_same_as
-          path_must_exist path_wont_exist wont_be_empty wont_equal wont_be_close_to
-          wont_be_within_delta wont_be_within_epsilon wont_include wont_be_instance_of
-          wont_be_kind_of wont_match wont_be_nil wont_be wont_respond_to wont_be_same_as
-        ].freeze
-
-        BLOCK_MATCHERS = %i[
-          must_output must_pattern_match must_raise must_be_silent must_throw wont_pattern_match
-        ].freeze
-
-        RESTRICT_ON_SEND = VALUE_MATCHERS + BLOCK_MATCHERS
+        VALUE_MATCHERS = MinitestExplorationHelpers::VALUE_MATCHERS
+        BLOCK_MATCHERS = MinitestExplorationHelpers::BLOCK_MATCHERS
+
+        RESTRICT_ON_SEND = MinitestExplorationHelpers::MATCHER_METHODS
 
         # There are aliases for the `_` method - `expect` and `value`
         DSL_METHODS = %i[_ expect value].freeze

data/lib/rubocop/cop/minitest/no_assertions.rb

@@ -5,6 +5,8 @@ module RuboCop
     module Minitest
       # Checks if test cases contain any assertion calls.
       #
+      # Matchers such as `must_equal` and `wont_match` are also treated as assertion methods.
+      #
       # @example
       #   # bad
       #   class FooTest < Minitest::Test
@@ -19,6 +21,23 @@ module RuboCop
       #     end
       #   end
       #
+      #   # bad
+      #   class FooTest < ActiveSupport::TestCase
+      #     describe 'foo' do
+      #       it 'test equal' do
+      #       end
+      #     end
+      #   end
+      #
+      #   # good
+      #   class FooTest < ActiveSupport::TestCase
+      #     describe 'foo' do
+      #       it 'test equal' do
+      #         musts.must_equal expected_musts
+      #       end
+      #     end
+      #   end
+      #
       class NoAssertions < Base
         include MinitestExplorationHelpers
 

data/lib/rubocop/cop/{generator.rb → minitest_generator.rb}

@@ -1,12 +1,14 @@
 # frozen_string_literal: true
 
+require 'rubocop/cop/generator'
+
 module RuboCop
   module Cop
     # Source and test generator for new cops
     #
     # This generator will take a cop name and generate a source file
     # and test file when given a valid qualified cop name.
-    class Generator
+    module MinitestGenerator
       TEST_TEMPLATE = <<~TEST
         # frozen_string_literal: true
 
@@ -48,3 +50,5 @@ module RuboCop
     end
   end
 end
+
+RuboCop::Cop::Generator.include(RuboCop::Cop::MinitestGenerator)

data/lib/rubocop/cop/mixin/minitest_exploration_helpers.rb

@@ -10,7 +10,22 @@ module RuboCop
       include DefNode
       extend NodePattern::Macros
 
-      ASSERTION_PREFIXES = %w[assert refute].freeze
+      VALUE_MATCHERS = %i[
+        must_be_empty must_equal must_be_close_to must_be_within_delta
+        must_be_within_epsilon must_include must_be_instance_of must_be_kind_of
+        must_match must_be_nil must_be must_respond_to must_be_same_as
+        path_must_exist path_wont_exist wont_be_empty wont_equal wont_be_close_to
+        wont_be_within_delta wont_be_within_epsilon wont_include wont_be_instance_of
+        wont_be_kind_of wont_match wont_be_nil wont_be wont_respond_to wont_be_same_as
+      ].freeze
+
+      BLOCK_MATCHERS = %i[
+        must_output must_pattern_match must_raise must_be_silent must_throw wont_pattern_match
+      ].freeze
+
+      MATCHER_METHODS = VALUE_MATCHERS + BLOCK_MATCHERS
+
+      ASSERTION_PREFIXES = %i[assert refute].freeze
 
       LIFECYCLE_HOOK_METHODS_IN_ORDER = %i[
         before_setup
@@ -104,16 +119,19 @@ module RuboCop
         return assertion_method?(node.expression) if node.assignment? && node.respond_to?(:expression)
         return false unless node.type?(:send, :any_block)
 
-        ASSERTION_PREFIXES.any? do |prefix|
-          method_name = node.method_name
-
-          method_name.start_with?(prefix) || node.method?(:flunk)
-        end
+        assertion_prefix_method?(node) || node.method?(:flunk) || MATCHER_METHODS.include?(node.method_name)
       end
 
       def lifecycle_hook_method?(node)
         node.def_type? && LIFECYCLE_HOOK_METHODS.include?(node.method_name)
       end
+
+      def assertion_prefix_method?(node)
+        return false if node.receiver
+
+        method_name = node.method_name
+        ASSERTION_PREFIXES.any? { |prefix| method_name.start_with?(prefix.to_s) }
+      end
     end
   end
 end

data/lib/rubocop/cop/mixin/predicate_assertion_handleable.rb

@@ -11,7 +11,7 @@ module RuboCop
         def on_send(node)
           return if node.first_argument&.any_block_type?
           return unless predicate_method?(node.first_argument)
-          return unless node.first_argument.arguments.count.zero?
+          return unless node.first_argument.arguments.none?
 
           add_offense(node, message: offense_message(node.arguments)) do |corrector|
             autocorrect(corrector, node, node.arguments)

data/lib/rubocop/minitest/version.rb

@@ -4,7 +4,7 @@ module RuboCop
   module Minitest
     # This module holds the RuboCop Minitest version information.
     module Version
-      STRING = '0.38.0'
+      STRING = '0.38.2'
 
       def self.document_version
         STRING.match('\d+\.\d+').to_s

metadata

@@ -1,16 +1,15 @@
 --- !ruby/object:Gem::Specification
 name: rubocop-minitest
 version: !ruby/object:Gem::Version
-  version: 0.38.0
+  version: 0.38.2
 platform: ruby
 authors:
 - Bozhidar Batsov
 - Jonas Arvidsson
 - Koichi ITO
-autorequire:
 bindir: exe
 cert_chain: []
-date: 2025-04-01 00:00:00.000000000 Z
+date: 1980-01-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: lint_roller
@@ -69,7 +68,6 @@ dependencies:
 description: |
   Automatic Minitest code style checking tool.
   A RuboCop extension focused on enforcing Minitest best practices and coding conventions.
-email:
 executables: []
 extensions: []
 extra_rdoc_files: []
@@ -78,7 +76,6 @@ files:
 - README.md
 - config/default.yml
 - lib/rubocop-minitest.rb
-- lib/rubocop/cop/generator.rb
 - lib/rubocop/cop/minitest/assert_empty.rb
 - lib/rubocop/cop/minitest/assert_empty_literal.rb
 - lib/rubocop/cop/minitest/assert_equal.rb
@@ -135,6 +132,7 @@ files:
 - lib/rubocop/cop/minitest/unspecified_exception.rb
 - lib/rubocop/cop/minitest/useless_assertion.rb
 - lib/rubocop/cop/minitest_cops.rb
+- lib/rubocop/cop/minitest_generator.rb
 - lib/rubocop/cop/mixin/argument_range_helper.rb
 - lib/rubocop/cop/mixin/in_delta_mixin.rb
 - lib/rubocop/cop/mixin/instance_of_assertion_handleable.rb
@@ -147,7 +145,6 @@ files:
 - lib/rubocop/minitest/plugin.rb
 - lib/rubocop/minitest/support.rb
 - lib/rubocop/minitest/version.rb
-homepage:
 licenses:
 - MIT
 metadata:
@@ -158,7 +155,6 @@ metadata:
   bug_tracker_uri: https://github.com/rubocop/rubocop-minitest/issues
   rubygems_mfa_required: 'true'
   default_lint_roller_plugin: RuboCop::Minitest::Plugin
-post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -173,8 +169,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.1.6
-signing_key:
+rubygems_version: 3.6.9
 specification_version: 4
 summary: Automatic Minitest code style checking tool.
 test_files: []