rubocop-minitest 0.36.0 → 0.38.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 3ad79ea9356e7da6ffabb9e38d689691f31a87b3bffc156e77c071290d20aec1
-  data.tar.gz: c142cdc5b3e0855e1d54bd6899d5a01c87b9efcc7abb60ebb6c4852c763a1199
+  metadata.gz: 7bd6b6a1346ed5b630ee67a043672d05c5503f55fe6d104f002193140856c1b3
+  data.tar.gz: 80c6c476bf82f3b285974d3516f95695957a1806f616fb4de0ad5aa0d7ba2ac7
 SHA512:
-  metadata.gz: fda798b03c1883da9465da94ec0d70e3170f5d71a624dc29a73559f14a9888e1b43c78f1e888ef2e0e2c40a05d6f6b5cb6d2a9b5315a48136fc02b172e6b72f4
-  data.tar.gz: daa8a4405a1815cfafd52809fce1f6cff4ac68b8af4b63038fab69da0594e8c84a8a60b2a5df40e2c89f16a04df578674e82060745ebad949297558d4b933ddc
+  metadata.gz: 1b6546efa373b0e0d922ef620e0bceb64047f017eabc26cdc55558f6258dd1dbd469c63a96961f8b377594d82eae0104bcfdeb19b80e4d748bf986ca96d8fd7b
+  data.tar.gz: 70247d05b6b0c83398307b877f27c0ddc88e88820f3efcd0e223b1f19fd052fd0ffa76c433a27f87edc55af2c28c68da6b40b4ce828553d8337a3cf172ec9314

data/LICENSE.txt

@@ -1,6 +1,6 @@
 The MIT License (MIT)
 
-Copyright (c) 2019-2023 Bozhidar Batsov, Jonas Arvidsson, Koichi ITO
+Copyright (c) 2019-2025 Bozhidar Batsov, Jonas Arvidsson, Koichi ITO
 
 Permission is hereby granted, free of charge, to any person obtaining a copy
 of this software and associated documentation files (the "Software"), to deal

data/README.md

@@ -30,13 +30,13 @@ ways to do this:
 Put this into your `.rubocop.yml`.
 
 ```yaml
-require: rubocop-minitest
+plugins: rubocop-minitest
 ```
 
 Alternatively, use the following array notation when specifying multiple extensions.
 
 ```yaml
-require:
+plugins:
   - rubocop-other-extension
   - rubocop-minitest
 ```
@@ -44,10 +44,13 @@ require:
 Now you can run `rubocop` and it will automatically load the RuboCop Minitest
 cops together with the standard cops.
 
+> [!NOTE]
+> The plugin system is supported in RuboCop 1.72+. In earlier versions, use `require` instead of `plugins`.
+
 ### Command line
 
 ```sh
-$ rubocop --require rubocop-minitest
+$ rubocop --plugin rubocop-minitest
 ```
 
 ### Rake task
@@ -56,7 +59,7 @@ $ rubocop --require rubocop-minitest
 require 'rubocop/rake_task'
 
 RuboCop::RakeTask.new do |task|
-  task.requires << 'rubocop-minitest'
+  task.plugins << 'rubocop-minitest'
 end
 ```
 

data/lib/rubocop/cop/minitest/assert_with_expected_argument.rb

@@ -36,7 +36,7 @@ module RuboCop
 
         def on_send(node)
           assert_with_two_arguments?(node) do |_expected, message|
-            return if message.str_type? || message.dstr_type? || MESSAGE_VARIABLES.include?(message.source)
+            return if message.type?(:str, :dstr) || MESSAGE_VARIABLES.include?(message.source)
 
             arguments = node.arguments.map(&:source).join(', ')
             add_offense(node, message: format(MSG, arguments: arguments))

data/lib/rubocop/cop/minitest/duplicate_test_run.rb

@@ -55,8 +55,7 @@ module RuboCop
           return unless test_methods?(class_node)
           return unless parent_class_has_test_methods?(class_node)
 
-          message = format(MSG)
-          add_offense(class_node, message: message)
+          add_offense(class_node)
         end
 
         private

data/lib/rubocop/cop/minitest/multiple_assertions.rb

@@ -65,7 +65,7 @@ module RuboCop
             assertions_count_in_branches(node.branches)
           when :rescue
             assertions_count(node.body) + assertions_count_in_branches(node.branches)
-          when :block, :numblock
+          when :block, :numblock, :itblock
             assertions_count(node.body)
           when *RuboCop::AST::Node::ASSIGNMENTS
             assertions_count_in_assignment(node)

data/lib/rubocop/cop/minitest/return_in_test_method.rb

@@ -36,7 +36,7 @@ module RuboCop
         private
 
         def inside_block?(node)
-          node.ancestors.any?(&:block_type?) || node.ancestors.any?(&:numblock_type?)
+          node.ancestors.any?(&:any_block_type?)
         end
       end
     end

data/lib/rubocop/cop/minitest/skip_ensure.rb

@@ -86,10 +86,10 @@ module RuboCop
 
         def valid_conditional_skip?(skip_method, ensure_node)
           if_node = skip_method.ancestors.detect(&:if_type?)
-          return false unless ensure_node.body.if_type?
+          return false unless ensure_node.branch.if_type?
 
-          match_keyword = ensure_node.body.if? ? if_node.if? : if_node.unless?
-          match_keyword && ensure_node.body.condition == if_node.condition
+          match_keyword = ensure_node.branch.if? ? if_node.if? : if_node.unless?
+          match_keyword && ensure_node.branch.condition == if_node.condition
         end
       end
     end

data/lib/rubocop/cop/minitest/skip_without_reason.rb

@@ -49,7 +49,7 @@ module RuboCop
         def conditional_parent(node)
           return unless (parent = node.parent)
 
-          if parent.if_type? || parent.case_type?
+          if parent.type?(:if, :case)
             parent
           elsif parent.when_type?
             parent.parent

data/lib/rubocop/cop/minitest/useless_assertion.rb

@@ -67,7 +67,7 @@ module RuboCop
         def empty_composite?(node)
           return true if node.str_type? && node.value.empty?
 
-          (node.array_type? || node.hash_type?) && node.children.empty?
+          node.type?(:array, :hash) && node.children.empty?
         end
       end
     end

data/lib/rubocop/cop/mixin/minitest_exploration_helpers.rb

@@ -99,11 +99,10 @@ module RuboCop
         end
       end
 
-      # rubocop:disable Metrics/CyclomaticComplexity, Metrics/PerceivedComplexity
       def assertion_method?(node)
         return false unless node
         return assertion_method?(node.expression) if node.assignment? && node.respond_to?(:expression)
-        return false if !node.send_type? && !node.block_type? && !node.numblock_type?
+        return false unless node.type?(:send, :any_block)
 
         ASSERTION_PREFIXES.any? do |prefix|
           method_name = node.method_name
@@ -111,7 +110,6 @@ module RuboCop
           method_name.start_with?(prefix) || node.method?(:flunk)
         end
       end
-      # rubocop:enable Metrics/CyclomaticComplexity, Metrics/PerceivedComplexity
 
       def lifecycle_hook_method?(node)
         node.def_type? && LIFECYCLE_HOOK_METHODS.include?(node.method_name)

data/lib/rubocop/cop/mixin/predicate_assertion_handleable.rb

@@ -9,8 +9,7 @@ module RuboCop
         MSG = 'Prefer using `%<assertion_type>s_predicate(%<new_arguments>s)`.'
 
         def on_send(node)
-          return unless node.first_argument
-          return if node.first_argument.block_type? || node.first_argument.numblock_type?
+          return if node.first_argument&.any_block_type?
           return unless predicate_method?(node.first_argument)
           return unless node.first_argument.arguments.count.zero?
 

data/lib/rubocop/minitest/assert_offense.rb

@@ -167,6 +167,7 @@ module RuboCop
 
         # This is just here for a pretty diff if the source actually got changed
         new_source = @last_corrector.rewrite
+
         assert_equal(@processed_source.buffer.source, new_source)
 
         # There is an infinite loop if a corrector is present that did not make
@@ -229,8 +230,8 @@ module RuboCop
       end
 
       def ruby_version
-        #  Prism supports parsing Ruby 3.3+.
-        ENV['PARSER_ENGINE'] == 'parser_prism' ? 3.3 : RuboCop::TargetRuby::DEFAULT_VERSION
+        # Prism is the default backend parser for Ruby 3.4+.
+        ENV['PARSER_ENGINE'] == 'parser_prism' ? 3.4 : RuboCop::TargetRuby::DEFAULT_VERSION
       end
 
       def parser_engine

data/lib/rubocop/minitest/plugin.rb

@@ -0,0 +1,31 @@
+# frozen_string_literal: true
+
+require 'lint_roller'
+
+module RuboCop
+  module Minitest
+    # A plugin that integrates RuboCop Minitest with RuboCop's plugin system.
+    class Plugin < LintRoller::Plugin
+      def about
+        LintRoller::About.new(
+          name: 'rubocop-minitest',
+          version: Version::STRING,
+          homepage: 'https://github.com/rubocop/rubocop-minitest',
+          description: 'Automatic Minitest code style checking tool.'
+        )
+      end
+
+      def supported?(context)
+        context.engine == :rubocop
+      end
+
+      def rules(_context)
+        LintRoller::Rules.new(
+          type: :path,
+          config_format: :rubocop,
+          value: Pathname.new(__dir__).join('../../../config/default.yml')
+        )
+      end
+    end
+  end
+end

data/lib/rubocop/minitest/support.rb

@@ -3,8 +3,7 @@
 # Require this file to load code that supports testing using Minitest.
 
 require 'rubocop'
-require 'minitest/autorun'
-require 'minitest/pride'
+require 'minitest'
 require_relative 'assert_offense'
 
 Minitest::Test.include RuboCop::Minitest::AssertOffense

data/lib/rubocop/minitest/version.rb

@@ -4,7 +4,7 @@ module RuboCop
   module Minitest
     # This module holds the RuboCop Minitest version information.
     module Version
-      STRING = '0.36.0'
+      STRING = '0.38.0'
 
       def self.document_version
         STRING.match('\d+\.\d+').to_s

data/lib/rubocop/minitest.rb

@@ -1,12 +1,7 @@
 # frozen_string_literal: true
 
 module RuboCop
-  # RuboCop minitest project namespace
+  # RuboCop minitest project namespace.
   module Minitest
-    PROJECT_ROOT   = Pathname.new(__dir__).parent.parent.expand_path.freeze
-    CONFIG_DEFAULT = PROJECT_ROOT.join('config', 'default.yml').freeze
-    CONFIG         = YAML.safe_load(CONFIG_DEFAULT.read).freeze
-
-    private_constant(:CONFIG_DEFAULT, :PROJECT_ROOT)
   end
 end

data/lib/rubocop-minitest.rb

@@ -4,8 +4,5 @@ require 'rubocop'
 
 require_relative 'rubocop/minitest'
 require_relative 'rubocop/minitest/version'
-require_relative 'rubocop/minitest/inject'
-
-RuboCop::Minitest::Inject.defaults!
-
+require_relative 'rubocop/minitest/plugin'
 require_relative 'rubocop/cop/minitest_cops'

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rubocop-minitest
 version: !ruby/object:Gem::Version
-  version: 0.36.0
+  version: 0.38.0
 platform: ruby
 authors:
 - Bozhidar Batsov
@@ -10,15 +10,29 @@ authors:
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2024-08-31 00:00:00.000000000 Z
+date: 2025-04-01 00:00:00.000000000 Z
 dependencies:
+- !ruby/object:Gem::Dependency
+  name: lint_roller
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1.1'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1.1'
 - !ruby/object:Gem::Dependency
   name: rubocop
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '1.61'
+        version: 1.75.0
     - - "<"
       - !ruby/object:Gem::Version
         version: '2.0'
@@ -28,7 +42,7 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '1.61'
+        version: 1.75.0
     - - "<"
       - !ruby/object:Gem::Version
         version: '2.0'
@@ -38,7 +52,7 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 1.31.1
+        version: 1.38.0
     - - "<"
       - !ruby/object:Gem::Version
         version: '2.0'
@@ -48,7 +62,7 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 1.31.1
+        version: 1.38.0
     - - "<"
       - !ruby/object:Gem::Version
         version: '2.0'
@@ -130,7 +144,7 @@ files:
 - lib/rubocop/cop/mixin/predicate_assertion_handleable.rb
 - lib/rubocop/minitest.rb
 - lib/rubocop/minitest/assert_offense.rb
-- lib/rubocop/minitest/inject.rb
+- lib/rubocop/minitest/plugin.rb
 - lib/rubocop/minitest/support.rb
 - lib/rubocop/minitest/version.rb
 homepage:
@@ -140,9 +154,10 @@ metadata:
   homepage_uri: https://docs.rubocop.org/rubocop-minitest/
   changelog_uri: https://github.com/rubocop/rubocop-minitest/blob/master/CHANGELOG.md
   source_code_uri: https://github.com/rubocop/rubocop-minitest
-  documentation_uri: https://docs.rubocop.org/rubocop-minitest/0.36
+  documentation_uri: https://docs.rubocop.org/rubocop-minitest/0.38
   bug_tracker_uri: https://github.com/rubocop/rubocop-minitest/issues
   rubygems_mfa_required: 'true'
+  default_lint_roller_plugin: RuboCop::Minitest::Plugin
 post_install_message:
 rdoc_options: []
 require_paths:
@@ -158,7 +173,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.5.3
+rubygems_version: 3.1.6
 signing_key:
 specification_version: 4
 summary: Automatic Minitest code style checking tool.

data/lib/rubocop/minitest/inject.rb

@@ -1,18 +0,0 @@
-# frozen_string_literal: true
-
-module RuboCop
-  module Minitest
-    # Because RuboCop doesn't yet support plugins, we have to monkey patch in a
-    # bit of our configuration.
-    module Inject
-      def self.defaults!
-        path = CONFIG_DEFAULT.to_s
-        hash = ConfigLoader.send(:load_yaml_configuration, path)
-        config = Config.new(hash, path).tap(&:make_excludes_absolute)
-        puts "configuration from #{path}" if ConfigLoader.debug?
-        config = ConfigLoader.merge_with_default(config, path)
-        ConfigLoader.instance_variable_set(:@default_configuration, config)
-      end
-    end
-  end
-end