rubocop-minitest 0.35.0 → 0.36.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: b38207770e46d47923f0558a40d051717d6909d540875bdb72cd63594e7b172b
-  data.tar.gz: b0b493b7e7ae9bf171379bf8a9c5ac6b02d44e2edbe29246928a71d9e5c6e81f
+  metadata.gz: 3ad79ea9356e7da6ffabb9e38d689691f31a87b3bffc156e77c071290d20aec1
+  data.tar.gz: c142cdc5b3e0855e1d54bd6899d5a01c87b9efcc7abb60ebb6c4852c763a1199
 SHA512:
-  metadata.gz: df6202e016d32b4ffc3fe066ca3785ecf8bc30dd2e0b76f858be48fe9399439b779762eed9f49d812ffeb47c4389926611f58ae06027832b331e89b7390407db
-  data.tar.gz: 6b2d444f5b2bd62fb31fe5e6808628eb03b5f3843f69b3e91d677abf57351d12140ba52ba06f6dab49bbffaf12ac5255df4553efa258a069d1cf5bb39a16f719
+  metadata.gz: fda798b03c1883da9465da94ec0d70e3170f5d71a624dc29a73559f14a9888e1b43c78f1e888ef2e0e2c40a05d6f6b5cb6d2a9b5315a48136fc02b172e6b72f4
+  data.tar.gz: daa8a4405a1815cfafd52809fce1f6cff4ac68b8af4b63038fab69da0594e8c84a8a60b2a5df40e2c89f16a04df578674e82060745ebad949297558d4b933ddc

data/README.md

@@ -1,7 +1,7 @@
 # RuboCop Minitest
 
 [![Gem Version](https://badge.fury.io/rb/rubocop-minitest.svg)](https://badge.fury.io/rb/rubocop-minitest)
-[![CircleCI](https://circleci.com/gh/rubocop/rubocop-minitest.svg?style=svg)](https://circleci.com/gh/rubocop/rubocop-minitest)
+[![CI](https://github.com/rubocop/rubocop-minitest/actions/workflows/test.yml/badge.svg)](https://github.com/rubocop/rubocop-minitest/actions/workflows/test.yml)
 
 A [RuboCop](https://github.com/rubocop/rubocop) extension focused on enforcing [Minitest](https://github.com/minitest/minitest) best practices and coding conventions.
 The library is based on the guidelines outlined in the community [Minitest Style Guide](https://minitest.rubystyle.guide).

data/lib/rubocop/cop/minitest/multiple_assertions.rb

@@ -28,11 +28,12 @@ module RuboCop
       #   end
       #
       class MultipleAssertions < Base
-        include ConfigurableMax
         include MinitestExplorationHelpers
 
         MSG = 'Test case has too many assertions [%<total>d/%<max>d].'
 
+        exclude_limit 'Max'
+
         def on_class(class_node)
           return unless test_class?(class_node)
 
@@ -74,7 +75,11 @@ module RuboCop
         end
 
         def assertions_count_in_assignment(node)
-          return assertions_count_based_on_type(node.expression) unless node.masgn_type?
+          unless node.masgn_type?
+            return 0 unless node.expression # for-style loop
+
+            return assertions_count_based_on_type(node.expression)
+          end
 
           rhs = node.children.last
 

data/lib/rubocop/cop/minitest/skip_ensure.rb

@@ -75,7 +75,9 @@ module RuboCop
         private
 
         def find_skip(node)
-          node.node_parts.first.descendants.detect { |n| n.send_type? && n.receiver.nil? && n.method?(:skip) }
+          return unless (body = node.node_parts.first)
+
+          body.descendants.detect { |n| n.send_type? && n.receiver.nil? && n.method?(:skip) }
         end
 
         def use_skip_in_rescue?(skip_method)

data/lib/rubocop/minitest/assert_offense.rb

@@ -75,11 +75,13 @@ module RuboCop
     module AssertOffense
       private
 
-      def setup
-        cop_name = self.class.to_s.delete_suffix('Test')
-        return unless RuboCop::Cop::Minitest.const_defined?(cop_name)
+      def cop
+        @cop ||= begin
+          cop_name = self.class.to_s.delete_suffix('Test')
+          raise "Cop not defined: #{cop_name}" unless RuboCop::Cop::Minitest.const_defined?(cop_name)
 
-        @cop = RuboCop::Cop::Minitest.const_get(cop_name).new(configuration)
+          RuboCop::Cop::Minitest.const_get(cop_name).new(configuration)
+        end
       end
 
       def format_offense(source, **replacements)
@@ -95,7 +97,7 @@ module RuboCop
       def assert_no_offenses(source, file = nil)
         setup_assertion
 
-        offenses = inspect_source(source, @cop, file)
+        offenses = inspect_source(source, cop, file)
 
         expected_annotations = RuboCop::RSpec::ExpectOffense::AnnotatedSource.parse(source)
         actual_annotations = expected_annotations.with_offense_annotations(offenses)
@@ -105,8 +107,7 @@ module RuboCop
 
       def assert_offense(source, file = nil, **replacements)
         setup_assertion
-
-        @cop.instance_variable_get(:@options)[:autocorrect] = true
+        enable_autocorrect
 
         source = format_offense(source, **replacements)
         expected_annotations = RuboCop::RSpec::ExpectOffense::AnnotatedSource.parse(source)
@@ -116,9 +117,9 @@ module RuboCop
 
         @processed_source = parse_source!(expected_annotations.plain_source, file)
 
-        offenses = _investigate(@cop, @processed_source)
+        @offenses = _investigate(cop, @processed_source)
 
-        actual_annotations = expected_annotations.with_offense_annotations(offenses)
+        actual_annotations = expected_annotations.with_offense_annotations(@offenses)
 
         assert_equal(expected_annotations.to_s, actual_annotations.to_s)
       end
@@ -130,6 +131,10 @@ module RuboCop
         report.offenses
       end
 
+      def enable_autocorrect
+        cop.instance_variable_get(:@options)[:autocorrect] = true
+      end
+
       def assert_correction(correction, loop: true)
         raise '`assert_correction` must follow `assert_offense`' unless @processed_source
 
@@ -143,18 +148,32 @@ module RuboCop
           break corrected_source if @last_corrector.empty? || corrected_source == @processed_source.buffer.source
 
           if iteration > RuboCop::Runner::MAX_ITERATIONS
-            raise RuboCop::Runner::InfiniteCorrectionLoop.new(@processed_source.path, [])
+            raise RuboCop::Runner::InfiniteCorrectionLoop.new(@processed_source.path, [@offenses])
           end
 
           # Prepare for next loop
           @processed_source = parse_source!(corrected_source, @processed_source.path)
 
-          _investigate(@cop, @processed_source)
+          _investigate(cop, @processed_source)
         end
 
         assert_equal(correction, new_source)
       end
 
+      def assert_no_corrections
+        raise '`assert_no_corrections` must follow `assert_offense`' unless @processed_source
+
+        return if @last_corrector.empty?
+
+        # This is just here for a pretty diff if the source actually got changed
+        new_source = @last_corrector.rewrite
+        assert_equal(@processed_source.buffer.source, new_source)
+
+        # There is an infinite loop if a corrector is present that did not make
+        # any changes. It will cause the same offense/correction on the next loop.
+        raise RuboCop::Runner::InfiniteCorrectionLoop.new(@processed_source.path, [@offenses])
+      end
+
       def setup_assertion
         RuboCop::Formatter::DisabledConfigFormatter.config_to_allow_offenses = {}
         RuboCop::Formatter::DisabledConfigFormatter.detected_styles = {}

data/lib/rubocop/minitest/version.rb

@@ -4,7 +4,7 @@ module RuboCop
   module Minitest
     # This module holds the RuboCop Minitest version information.
     module Version
-      STRING = '0.35.0'
+      STRING = '0.36.0'
 
       def self.document_version
         STRING.match('\d+\.\d+').to_s

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rubocop-minitest
 version: !ruby/object:Gem::Version
-  version: 0.35.0
+  version: 0.36.0
 platform: ruby
 authors:
 - Bozhidar Batsov
@@ -10,7 +10,7 @@ authors:
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2024-03-10 00:00:00.000000000 Z
+date: 2024-08-31 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop
@@ -140,7 +140,7 @@ metadata:
   homepage_uri: https://docs.rubocop.org/rubocop-minitest/
   changelog_uri: https://github.com/rubocop/rubocop-minitest/blob/master/CHANGELOG.md
   source_code_uri: https://github.com/rubocop/rubocop-minitest
-  documentation_uri: https://docs.rubocop.org/rubocop-minitest/0.35
+  documentation_uri: https://docs.rubocop.org/rubocop-minitest/0.36
   bug_tracker_uri: https://github.com/rubocop/rubocop-minitest/issues
   rubygems_mfa_required: 'true'
 post_install_message: