rubocop-minitest 0.34.5 → 0.35.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: cc9ea3b370ec30f86a9e1ddb422255552f643a605b6e744518afcfa1e6ae6de0
-  data.tar.gz: ba67151e3d30de7f5634ef62feb6663fb0109c69886bdf231417dea06a55ba99
+  metadata.gz: '05352938661fc7fcd76a982a2a9154061c503eac54de9f2de2e0f358d8e166a4'
+  data.tar.gz: 38db4cb7b31a2829857ccd97f57d4991a482ce7fd7406032bbcf680051581075
 SHA512:
-  metadata.gz: d7ab44585e54b9cd0cd85d8e36adfd9ba9f9a7b560c791e15af082691e391a38f313857f323eb897c831d277d73b67e13707cdb76db45bce8cf38286099d7640
-  data.tar.gz: d592eb50f633074ac727f0fb493d734ca70320ff8fb9441dfab46b45916a7d730a5e439486642755cc83797bacbdfaf85cbb6b6cc95415a491230f64e2645102
+  metadata.gz: a0935959142328adc6acedeccabe3abda0cf0284de0a4069a3612101d2cccd67d5374c343f2f3de176c05d9a7db6cc2f85a63eae59c826a888bea6d0505515ae
+  data.tar.gz: 033b27f081581b35cc46c55fcea3ac3a2c09c069fe35d0bb41635bbaea4626cbb89b5ff4fa892ec32a9ae8df8f9f9106edb0ac9e4dd7ca3125e218410bb4dc42

data/README.md

@@ -1,7 +1,7 @@
 # RuboCop Minitest
 
 [![Gem Version](https://badge.fury.io/rb/rubocop-minitest.svg)](https://badge.fury.io/rb/rubocop-minitest)
-[![CircleCI](https://circleci.com/gh/rubocop/rubocop-minitest.svg?style=svg)](https://circleci.com/gh/rubocop/rubocop-minitest)
+[![CI](https://github.com/rubocop/rubocop-minitest/actions/workflows/test.yml/badge.svg)](https://github.com/rubocop/rubocop-minitest/actions/workflows/test.yml)
 
 A [RuboCop](https://github.com/rubocop/rubocop) extension focused on enforcing [Minitest](https://github.com/minitest/minitest) best practices and coding conventions.
 The library is based on the guidelines outlined in the community [Minitest Style Guide](https://minitest.rubystyle.guide).

data/config/default.yml

@@ -146,6 +146,12 @@ Minitest/EmptyLineBeforeAssertionMethods:
   Enabled: pending
   VersionAdded: '0.23'
 
+Minitest/Focus:
+  Description: 'Checks for focused tests.'
+  Enabled: pending
+  AutoCorrect: contextual
+  VersionAdded: '0.35'
+
 Minitest/GlobalExpectations:
   Description: 'This cop checks for deprecated global expectations.'
   StyleGuide: 'https://minitest.rubystyle.guide#global-expectations'

data/lib/rubocop/cop/minitest/assert_empty_literal.rb

@@ -22,7 +22,7 @@ module RuboCop
         RESTRICT_ON_SEND = %i[assert_equal].freeze
 
         def_node_matcher :assert_equal_with_empty_literal, <<~PATTERN
-          (send nil? :assert_equal ${hash array} $...)
+          (send nil? :assert_equal ${hash array} $_+)
         PATTERN
 
         def on_send(node)

data/lib/rubocop/cop/minitest/focus.rb

@@ -0,0 +1,49 @@
+# frozen_string_literal: true
+
+module RuboCop
+  module Cop
+    module Minitest
+      # Enforces tests are not focused.
+      #
+      # @example
+      #   # bad
+      #   focus test 'foo' do
+      #   end
+      #
+      #   # bad
+      #   focus
+      #   test 'foo' do
+      #   end
+      #
+      #   # good
+      #   test 'foo' do
+      #   end
+      #
+      class Focus < Base
+        extend AutoCorrector
+        include RangeHelp
+
+        MSG = 'Remove `focus` from tests.'
+        RESTRICT_ON_SEND = [:focus].freeze
+
+        def_node_matcher :focused?, <<~PATTERN
+          (send nil? :focus ...)
+        PATTERN
+
+        def on_send(node)
+          return if node.receiver
+
+          add_offense(node.loc.selector) do |corrector|
+            range = if node.arguments.none?
+                      range_by_whole_lines(node.source_range, include_final_newline: true)
+                    else
+                      node.loc.selector.join(node.first_argument.source_range.begin)
+                    end
+
+            corrector.remove(range)
+          end
+        end
+      end
+    end
+  end
+end

data/lib/rubocop/cop/minitest/multiple_assertions.rb

@@ -28,11 +28,12 @@ module RuboCop
       #   end
       #
       class MultipleAssertions < Base
-        include ConfigurableMax
         include MinitestExplorationHelpers
 
         MSG = 'Test case has too many assertions [%<total>d/%<max>d].'
 
+        exclude_limit 'Max'
+
         def on_class(class_node)
           return unless test_class?(class_node)
 

data/lib/rubocop/cop/minitest_cops.rb

@@ -30,6 +30,7 @@ require_relative 'minitest/assert_silent'
 require_relative 'minitest/assert_truthy'
 require_relative 'minitest/duplicate_test_run'
 require_relative 'minitest/empty_line_before_assertion_methods'
+require_relative 'minitest/focus'
 require_relative 'minitest/non_executable_test_method'
 require_relative 'minitest/redundant_message_argument'
 require_relative 'minitest/return_in_test_method'

data/lib/rubocop/minitest/assert_offense.rb

@@ -116,9 +116,9 @@ module RuboCop
 
         @processed_source = parse_source!(expected_annotations.plain_source, file)
 
-        offenses = _investigate(@cop, @processed_source)
+        @offenses = _investigate(@cop, @processed_source)
 
-        actual_annotations = expected_annotations.with_offense_annotations(offenses)
+        actual_annotations = expected_annotations.with_offense_annotations(@offenses)
 
         assert_equal(expected_annotations.to_s, actual_annotations.to_s)
       end
@@ -143,7 +143,7 @@ module RuboCop
           break corrected_source if @last_corrector.empty? || corrected_source == @processed_source.buffer.source
 
           if iteration > RuboCop::Runner::MAX_ITERATIONS
-            raise RuboCop::Runner::InfiniteCorrectionLoop.new(@processed_source.path, [])
+            raise RuboCop::Runner::InfiniteCorrectionLoop.new(@processed_source.path, [@offenses])
           end
 
           # Prepare for next loop
@@ -155,6 +155,20 @@ module RuboCop
         assert_equal(correction, new_source)
       end
 
+      def assert_no_corrections
+        raise '`assert_no_corrections` must follow `assert_offense`' unless @processed_source
+
+        return if @last_corrector.empty?
+
+        # This is just here for a pretty diff if the source actually got changed
+        new_source = @last_corrector.rewrite
+        assert_equal(@processed_source.buffer.source, new_source)
+
+        # There is an infinite loop if a corrector is present that did not make
+        # any changes. It will cause the same offense/correction on the next loop.
+        raise RuboCop::Runner::InfiniteCorrectionLoop.new(@processed_source.path, [@offenses])
+      end
+
       def setup_assertion
         RuboCop::Formatter::DisabledConfigFormatter.config_to_allow_offenses = {}
         RuboCop::Formatter::DisabledConfigFormatter.detected_styles = {}
@@ -186,15 +200,9 @@ module RuboCop
           file = file.path
         end
 
-        processed_source = RuboCop::ProcessedSource.new(source, ruby_version, file)
-
-        # Follow up https://github.com/rubocop/rubocop/pull/10987.
-        # When support for RuboCop 1.37.1 ends, this condition can be removed.
-        if processed_source.respond_to?(:config) && processed_source.respond_to?(:registry)
-          processed_source.config = configuration
-          processed_source.registry = registry
-        end
-
+        processed_source = RuboCop::ProcessedSource.new(source, ruby_version, file, parser_engine: parser_engine)
+        processed_source.config = configuration
+        processed_source.registry = registry
         processed_source
       end
 
@@ -216,7 +224,12 @@ module RuboCop
       end
 
       def ruby_version
-        RuboCop::TargetRuby::DEFAULT_VERSION
+        #  Prism supports parsing Ruby 3.3+.
+        ENV['PARSER_ENGINE'] == 'parser_prism' ? 3.3 : RuboCop::TargetRuby::DEFAULT_VERSION
+      end
+
+      def parser_engine
+        ENV.fetch('PARSER_ENGINE', :parser_whitequark).to_sym
       end
     end
     # rubocop:enable Metrics/ModuleLength

data/lib/rubocop/minitest/version.rb

@@ -4,7 +4,7 @@ module RuboCop
   module Minitest
     # This module holds the RuboCop Minitest version information.
     module Version
-      STRING = '0.34.5'
+      STRING = '0.35.1'
 
       def self.document_version
         STRING.match('\d+\.\d+').to_s

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rubocop-minitest
 version: !ruby/object:Gem::Version
-  version: 0.34.5
+  version: 0.35.1
 platform: ruby
 authors:
 - Bozhidar Batsov
@@ -10,7 +10,7 @@ authors:
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2024-01-20 00:00:00.000000000 Z
+date: 2024-07-10 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop
@@ -18,7 +18,7 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '1.39'
+        version: '1.61'
     - - "<"
       - !ruby/object:Gem::Version
         version: '2.0'
@@ -28,7 +28,7 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '1.39'
+        version: '1.61'
     - - "<"
       - !ruby/object:Gem::Version
         version: '2.0'
@@ -38,7 +38,7 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 1.30.0
+        version: 1.31.1
     - - "<"
       - !ruby/object:Gem::Version
         version: '2.0'
@@ -48,7 +48,7 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 1.30.0
+        version: 1.31.1
     - - "<"
       - !ruby/object:Gem::Version
         version: '2.0'
@@ -88,6 +88,7 @@ files:
 - lib/rubocop/cop/minitest/assertion_in_lifecycle_hook.rb
 - lib/rubocop/cop/minitest/duplicate_test_run.rb
 - lib/rubocop/cop/minitest/empty_line_before_assertion_methods.rb
+- lib/rubocop/cop/minitest/focus.rb
 - lib/rubocop/cop/minitest/global_expectations.rb
 - lib/rubocop/cop/minitest/lifecycle_hooks_order.rb
 - lib/rubocop/cop/minitest/literal_as_actual_argument.rb
@@ -139,7 +140,7 @@ metadata:
   homepage_uri: https://docs.rubocop.org/rubocop-minitest/
   changelog_uri: https://github.com/rubocop/rubocop-minitest/blob/master/CHANGELOG.md
   source_code_uri: https://github.com/rubocop/rubocop-minitest
-  documentation_uri: https://docs.rubocop.org/rubocop-minitest/0.34
+  documentation_uri: https://docs.rubocop.org/rubocop-minitest/0.35
   bug_tracker_uri: https://github.com/rubocop/rubocop-minitest/issues
   rubygems_mfa_required: 'true'
 post_install_message: