rubocop-minitest 0.34.4 → 0.35.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 1e4b8d1f63d66f8d5c75e7df19dba8c07f62d7da0ac637a9b92014d865fe0314
-  data.tar.gz: 1bf5ef6960646dd7b2e84b947bde08fe5b6fabbdd40a4c78c41cc59112a9181b
+  metadata.gz: b38207770e46d47923f0558a40d051717d6909d540875bdb72cd63594e7b172b
+  data.tar.gz: b0b493b7e7ae9bf171379bf8a9c5ac6b02d44e2edbe29246928a71d9e5c6e81f
 SHA512:
-  metadata.gz: a5bf6ff7d580d5223a90735e7f4f81a528ef14ce943689b24fad9561070bb02f2bbd569bd4dd5c79466781b1e5292e5008be428b1b5694b6c501c91d567fc933
-  data.tar.gz: 37f1a56983839444e99921b3f8c664e4b7d3388e6dff081e17b899a3281e44ec45fe9bca3fcd06aef6791d955a88053010efddaa5ffd9d30e2b875a54aff3118
+  metadata.gz: df6202e016d32b4ffc3fe066ca3785ecf8bc30dd2e0b76f858be48fe9399439b779762eed9f49d812ffeb47c4389926611f58ae06027832b331e89b7390407db
+  data.tar.gz: 6b2d444f5b2bd62fb31fe5e6808628eb03b5f3843f69b3e91d677abf57351d12140ba52ba06f6dab49bbffaf12ac5255df4553efa258a069d1cf5bb39a16f719

data/config/default.yml

@@ -46,6 +46,7 @@ Minitest/AssertKindOf:
   StyleGuide: 'https://github.com/rubocop/minitest-style-guide#assert-kind-of'
   Enabled: 'pending'
   VersionAdded: '0.10'
+  VersionChanged: '0.34'
 
 Minitest/AssertMatch:
   Description: 'This cop enforces the test to use `assert_match` instead of using `assert(matcher.match(object))`.'
@@ -145,6 +146,12 @@ Minitest/EmptyLineBeforeAssertionMethods:
   Enabled: pending
   VersionAdded: '0.23'
 
+Minitest/Focus:
+  Description: 'Checks for focused tests.'
+  Enabled: pending
+  AutoCorrect: contextual
+  VersionAdded: '0.35'
+
 Minitest/GlobalExpectations:
   Description: 'This cop checks for deprecated global expectations.'
   StyleGuide: 'https://minitest.rubystyle.guide#global-expectations'
@@ -252,6 +259,7 @@ Minitest/RefuteKindOf:
   StyleGuide: 'https://github.com/rubocop/minitest-style-guide#refute-kind-of'
   Enabled: 'pending'
   VersionAdded: '0.10'
+  VersionChanged: '0.34'
 
 Minitest/RefuteMatch:
   Description: 'This cop enforces the test to use `refute_match` instead of using `refute(matcher.match(object))`.'

data/lib/rubocop/cop/minitest/assert_empty_literal.rb

@@ -22,7 +22,7 @@ module RuboCop
         RESTRICT_ON_SEND = %i[assert_equal].freeze
 
         def_node_matcher :assert_equal_with_empty_literal, <<~PATTERN
-          (send nil? :assert_equal ${hash array} $...)
+          (send nil? :assert_equal ${hash array} $_+)
         PATTERN
 
         def on_send(node)

data/lib/rubocop/cop/minitest/assert_kind_of.rb

@@ -11,6 +11,11 @@ module RuboCop
       #   assert(object.kind_of?(Class))
       #   assert(object.kind_of?(Class), 'message')
       #
+      #   # bad
+      #   # `is_a?` is an alias for `kind_of?`
+      #   assert(object.is_a?(Class))
+      #   assert(object.is_a?(Class), 'message')
+      #
       #   # good
       #   assert_kind_of(Class, object)
       #   assert_kind_of(Class, object, 'message')
@@ -18,7 +23,7 @@ module RuboCop
       class AssertKindOf < Base
         extend MinitestCopRule
 
-        define_rule :assert, target_method: :kind_of?, inverse: true
+        define_rule :assert, target_method: %i[kind_of? is_a?], preferred_method: :assert_kind_of, inverse: true
       end
     end
   end

data/lib/rubocop/cop/minitest/focus.rb

@@ -0,0 +1,49 @@
+# frozen_string_literal: true
+
+module RuboCop
+  module Cop
+    module Minitest
+      # Enforces tests are not focused.
+      #
+      # @example
+      #   # bad
+      #   focus test 'foo' do
+      #   end
+      #
+      #   # bad
+      #   focus
+      #   test 'foo' do
+      #   end
+      #
+      #   # good
+      #   test 'foo' do
+      #   end
+      #
+      class Focus < Base
+        extend AutoCorrector
+        include RangeHelp
+
+        MSG = 'Remove `focus` from tests.'
+        RESTRICT_ON_SEND = [:focus].freeze
+
+        def_node_matcher :focused?, <<~PATTERN
+          (send nil? :focus ...)
+        PATTERN
+
+        def on_send(node)
+          return if node.receiver
+
+          add_offense(node.loc.selector) do |corrector|
+            range = if node.arguments.none?
+                      range_by_whole_lines(node.source_range, include_final_newline: true)
+                    else
+                      node.loc.selector.join(node.first_argument.source_range.begin)
+                    end
+
+            corrector.remove(range)
+          end
+        end
+      end
+    end
+  end
+end

data/lib/rubocop/cop/minitest/refute_kind_of.rb

@@ -11,6 +11,11 @@ module RuboCop
       #   refute(object.kind_of?(Class))
       #   refute(object.kind_of?(Class), 'message')
       #
+      #   # bad
+      #   # `is_a?` is an alias for `kind_of?`
+      #   refute(object.is_of?(Class))
+      #   refute(object.is_of?(Class), 'message')
+      #
       #   # good
       #   refute_kind_of(Class, object)
       #   refute_kind_of(Class, object, 'message')
@@ -18,7 +23,7 @@ module RuboCop
       class RefuteKindOf < Base
         extend MinitestCopRule
 
-        define_rule :refute, target_method: :kind_of?, inverse: true
+        define_rule :refute, target_method: %i[kind_of? is_a?], preferred_method: :refute_kind_of, inverse: true
       end
     end
   end

data/lib/rubocop/cop/minitest/useless_assertion.rb

@@ -48,7 +48,7 @@ module RuboCop
           when *SINGLE_ASSERTION_ARGUMENT_METHODS
             actual.nil? && expected&.literal? && !expected.xstr_type?
           when *TWO_ASSERTION_ARGUMENTS_METHODS
-            return false unless expected || actual
+            return false unless expected && actual
             return false if expected.source != actual.source
 
             (expected.variable? && actual.variable?) ||

data/lib/rubocop/cop/minitest_cops.rb

@@ -30,6 +30,7 @@ require_relative 'minitest/assert_silent'
 require_relative 'minitest/assert_truthy'
 require_relative 'minitest/duplicate_test_run'
 require_relative 'minitest/empty_line_before_assertion_methods'
+require_relative 'minitest/focus'
 require_relative 'minitest/non_executable_test_method'
 require_relative 'minitest/redundant_message_argument'
 require_relative 'minitest/return_in_test_method'

data/lib/rubocop/minitest/assert_offense.rb

@@ -186,15 +186,9 @@ module RuboCop
           file = file.path
         end
 
-        processed_source = RuboCop::ProcessedSource.new(source, ruby_version, file)
-
-        # Follow up https://github.com/rubocop/rubocop/pull/10987.
-        # When support for RuboCop 1.37.1 ends, this condition can be removed.
-        if processed_source.respond_to?(:config) && processed_source.respond_to?(:registry)
-          processed_source.config = configuration
-          processed_source.registry = registry
-        end
-
+        processed_source = RuboCop::ProcessedSource.new(source, ruby_version, file, parser_engine: parser_engine)
+        processed_source.config = configuration
+        processed_source.registry = registry
         processed_source
       end
 
@@ -216,7 +210,12 @@ module RuboCop
       end
 
       def ruby_version
-        RuboCop::TargetRuby::DEFAULT_VERSION
+        #  Prism supports parsing Ruby 3.3+.
+        ENV['PARSER_ENGINE'] == 'parser_prism' ? 3.3 : RuboCop::TargetRuby::DEFAULT_VERSION
+      end
+
+      def parser_engine
+        ENV.fetch('PARSER_ENGINE', :parser_whitequark).to_sym
       end
     end
     # rubocop:enable Metrics/ModuleLength

data/lib/rubocop/minitest/version.rb

@@ -4,7 +4,7 @@ module RuboCop
   module Minitest
     # This module holds the RuboCop Minitest version information.
     module Version
-      STRING = '0.34.4'
+      STRING = '0.35.0'
 
       def self.document_version
         STRING.match('\d+\.\d+').to_s

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rubocop-minitest
 version: !ruby/object:Gem::Version
-  version: 0.34.4
+  version: 0.35.0
 platform: ruby
 authors:
 - Bozhidar Batsov
@@ -10,7 +10,7 @@ authors:
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2024-01-09 00:00:00.000000000 Z
+date: 2024-03-10 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop
@@ -18,7 +18,7 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '1.39'
+        version: '1.61'
     - - "<"
       - !ruby/object:Gem::Version
         version: '2.0'
@@ -28,7 +28,7 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '1.39'
+        version: '1.61'
     - - "<"
       - !ruby/object:Gem::Version
         version: '2.0'
@@ -38,7 +38,7 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 1.30.0
+        version: 1.31.1
     - - "<"
       - !ruby/object:Gem::Version
         version: '2.0'
@@ -48,7 +48,7 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 1.30.0
+        version: 1.31.1
     - - "<"
       - !ruby/object:Gem::Version
         version: '2.0'
@@ -88,6 +88,7 @@ files:
 - lib/rubocop/cop/minitest/assertion_in_lifecycle_hook.rb
 - lib/rubocop/cop/minitest/duplicate_test_run.rb
 - lib/rubocop/cop/minitest/empty_line_before_assertion_methods.rb
+- lib/rubocop/cop/minitest/focus.rb
 - lib/rubocop/cop/minitest/global_expectations.rb
 - lib/rubocop/cop/minitest/lifecycle_hooks_order.rb
 - lib/rubocop/cop/minitest/literal_as_actual_argument.rb
@@ -139,7 +140,7 @@ metadata:
   homepage_uri: https://docs.rubocop.org/rubocop-minitest/
   changelog_uri: https://github.com/rubocop/rubocop-minitest/blob/master/CHANGELOG.md
   source_code_uri: https://github.com/rubocop/rubocop-minitest
-  documentation_uri: https://docs.rubocop.org/rubocop-minitest/0.34
+  documentation_uri: https://docs.rubocop.org/rubocop-minitest/0.35
   bug_tracker_uri: https://github.com/rubocop/rubocop-minitest/issues
   rubygems_mfa_required: 'true'
 post_install_message: