rubocop-minitest 0.34.3 → 0.34.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: afd3efb3693514e425f01041e37235e7e78fd0259689c6e638a8d567c0bd4692
-  data.tar.gz: c6886e41faf35b0b801394e71b07c550359ff94bff8a074b8df5bd872db588f6
+  metadata.gz: cc9ea3b370ec30f86a9e1ddb422255552f643a605b6e744518afcfa1e6ae6de0
+  data.tar.gz: ba67151e3d30de7f5634ef62feb6663fb0109c69886bdf231417dea06a55ba99
 SHA512:
-  metadata.gz: 35a275c7a0e6d17dab0a838ebe10f4a913d0d6fa854b6836129a35a8765d2f49d672a5cbb2dd1286fff3f71437eea297aa09e74539f618ff278c17359467da67
-  data.tar.gz: 7db0be71cbcebc36bf79fd2002d773a608c78333436d4b01d5fda05255683fde98c845e0267ab4ba8a54c400df52c4a53c53eee0f4eda5649d9bf55acd1c77ef
+  metadata.gz: d7ab44585e54b9cd0cd85d8e36adfd9ba9f9a7b560c791e15af082691e391a38f313857f323eb897c831d277d73b67e13707cdb76db45bce8cf38286099d7640
+  data.tar.gz: d592eb50f633074ac727f0fb493d734ca70320ff8fb9441dfab46b45916a7d730a5e439486642755cc83797bacbdfaf85cbb6b6cc95415a491230f64e2645102

data/config/default.yml

@@ -46,6 +46,7 @@ Minitest/AssertKindOf:
   StyleGuide: 'https://github.com/rubocop/minitest-style-guide#assert-kind-of'
   Enabled: 'pending'
   VersionAdded: '0.10'
+  VersionChanged: '0.34'
 
 Minitest/AssertMatch:
   Description: 'This cop enforces the test to use `assert_match` instead of using `assert(matcher.match(object))`.'
@@ -252,6 +253,7 @@ Minitest/RefuteKindOf:
   StyleGuide: 'https://github.com/rubocop/minitest-style-guide#refute-kind-of'
   Enabled: 'pending'
   VersionAdded: '0.10'
+  VersionChanged: '0.34'
 
 Minitest/RefuteMatch:
   Description: 'This cop enforces the test to use `refute_match` instead of using `refute(matcher.match(object))`.'

data/lib/rubocop/cop/minitest/assert_kind_of.rb

@@ -11,6 +11,11 @@ module RuboCop
       #   assert(object.kind_of?(Class))
       #   assert(object.kind_of?(Class), 'message')
       #
+      #   # bad
+      #   # `is_a?` is an alias for `kind_of?`
+      #   assert(object.is_a?(Class))
+      #   assert(object.is_a?(Class), 'message')
+      #
       #   # good
       #   assert_kind_of(Class, object)
       #   assert_kind_of(Class, object, 'message')
@@ -18,7 +23,7 @@ module RuboCop
       class AssertKindOf < Base
         extend MinitestCopRule
 
-        define_rule :assert, target_method: :kind_of?, inverse: true
+        define_rule :assert, target_method: %i[kind_of? is_a?], preferred_method: :assert_kind_of, inverse: true
       end
     end
   end

data/lib/rubocop/cop/minitest/multiple_assertions.rb

@@ -74,11 +74,21 @@ module RuboCop
         end
 
         def assertions_count_in_assignment(node)
-          # checking the direct expression is handled by assertion_method?
-          return 0 unless node.expression.block_type? || node.expression.numblock_type?
+          return assertions_count_based_on_type(node.expression) unless node.masgn_type?
 
-          # this will only trigger the branches for :block and :numblock type nodes
-          assertions_count_based_on_type(node.expression)
+          rhs = node.children.last
+
+          case rhs.type
+          when :array
+            rhs.children.sum { |child| assertions_count_based_on_type(child) }
+          when :send
+            assertion_method?(rhs) ? 1 : 0
+          else
+            # Play it safe and bail if we don't have any explicit handling for whatever
+            # the RHS type is, since at this point we're already probably dealing with
+            # a pretty exotic situation that's unlikely in the real world.
+            0
+          end
         end
 
         def assertions_count_in_branches(branches)

data/lib/rubocop/cop/minitest/non_executable_test_method.rb

@@ -36,6 +36,8 @@ module RuboCop
           add_offense(node)
         end
 
+        private
+
         def use_test_class?
           root_node = processed_source.ast
 

data/lib/rubocop/cop/minitest/refute_kind_of.rb

@@ -11,6 +11,11 @@ module RuboCop
       #   refute(object.kind_of?(Class))
       #   refute(object.kind_of?(Class), 'message')
       #
+      #   # bad
+      #   # `is_a?` is an alias for `kind_of?`
+      #   refute(object.is_of?(Class))
+      #   refute(object.is_of?(Class), 'message')
+      #
       #   # good
       #   refute_kind_of(Class, object)
       #   refute_kind_of(Class, object, 'message')
@@ -18,7 +23,7 @@ module RuboCop
       class RefuteKindOf < Base
         extend MinitestCopRule
 
-        define_rule :refute, target_method: :kind_of?, inverse: true
+        define_rule :refute, target_method: %i[kind_of? is_a?], preferred_method: :refute_kind_of, inverse: true
       end
     end
   end

data/lib/rubocop/cop/minitest/useless_assertion.rb

@@ -48,7 +48,7 @@ module RuboCop
           when *SINGLE_ASSERTION_ARGUMENT_METHODS
             actual.nil? && expected&.literal? && !expected.xstr_type?
           when *TWO_ASSERTION_ARGUMENTS_METHODS
-            return false unless expected || actual
+            return false unless expected && actual
             return false if expected.source != actual.source
 
             (expected.variable? && actual.variable?) ||

data/lib/rubocop/minitest/version.rb

@@ -4,7 +4,7 @@ module RuboCop
   module Minitest
     # This module holds the RuboCop Minitest version information.
     module Version
-      STRING = '0.34.3'
+      STRING = '0.34.5'
 
       def self.document_version
         STRING.match('\d+\.\d+').to_s

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rubocop-minitest
 version: !ruby/object:Gem::Version
-  version: 0.34.3
+  version: 0.34.5
 platform: ruby
 authors:
 - Bozhidar Batsov
@@ -10,7 +10,7 @@ authors:
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2024-01-01 00:00:00.000000000 Z
+date: 2024-01-20 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop
@@ -157,7 +157,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.1.6
+rubygems_version: 3.5.3
 signing_key:
 specification_version: 4
 summary: Automatic Minitest code style checking tool.