rubocop-minitest 0.34.1 → 0.34.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 8e59babe7e9ae552aee440a3e5eb5767af585357899d8f4fbac8f54247494b87
-  data.tar.gz: 4f61d9b471cdda223fbd1fe239656b2a47e5216a2903588ce05f5a4909d5fb21
+  metadata.gz: afd3efb3693514e425f01041e37235e7e78fd0259689c6e638a8d567c0bd4692
+  data.tar.gz: c6886e41faf35b0b801394e71b07c550359ff94bff8a074b8df5bd872db588f6
 SHA512:
-  metadata.gz: 7d14b60b50dacf5f28470b18ea5d03c19507e21063bf54a971b67a5b4d10255e048bcf75052f4645aa049a25ff54dd6f8022255b5c11bdef650c63f84fa4ed1f
-  data.tar.gz: 3e3389f3ba19ea5a8c08ee1b57c5eb9d8da15b17c1b80d36c21470bd096a6753e9108c7de8d84ebb0f702b797310af241e401a16ea2207dc12d4891135c5efa9
+  metadata.gz: 35a275c7a0e6d17dab0a838ebe10f4a913d0d6fa854b6836129a35a8765d2f49d672a5cbb2dd1286fff3f71437eea297aa09e74539f618ff278c17359467da67
+  data.tar.gz: 7db0be71cbcebc36bf79fd2002d773a608c78333436d4b01d5fda05255683fde98c845e0267ab4ba8a54c400df52c4a53c53eee0f4eda5649d9bf55acd1c77ef

data/lib/rubocop/cop/minitest/assert_raises_compound_body.rb

@@ -37,7 +37,7 @@ module RuboCop
         private
 
         def multi_statement_begin?(node)
-          node.begin_type? && node.children.size > 1
+          node&.begin_type? && node.children.size > 1
         end
       end
     end

data/lib/rubocop/cop/minitest/multiple_assertions.rb

@@ -53,22 +53,34 @@ module RuboCop
         def assertions_count(node)
           return 0 unless node.is_a?(RuboCop::AST::Node)
 
-          assertions =
-            case node.type
-            when :if, :case, :case_match
-              assertions_count_in_branches(node.branches)
-            when :rescue
-              assertions_count(node.body) + assertions_count_in_branches(node.branches)
-            when :block, :numblock
-              assertions_count(node.body)
-            else
-              node.each_child_node.sum { |child| assertions_count(child) }
-            end
-
+          assertions = assertions_count_based_on_type(node)
           assertions += 1 if assertion_method?(node)
           assertions
         end
 
+        def assertions_count_based_on_type(node)
+          case node.type
+          when :if, :case, :case_match
+            assertions_count_in_branches(node.branches)
+          when :rescue
+            assertions_count(node.body) + assertions_count_in_branches(node.branches)
+          when :block, :numblock
+            assertions_count(node.body)
+          when *RuboCop::AST::Node::ASSIGNMENTS
+            assertions_count_in_assignment(node)
+          else
+            node.each_child_node.sum { |child| assertions_count(child) }
+          end
+        end
+
+        def assertions_count_in_assignment(node)
+          # checking the direct expression is handled by assertion_method?
+          return 0 unless node.expression.block_type? || node.expression.numblock_type?
+
+          # this will only trigger the branches for :block and :numblock type nodes
+          assertions_count_based_on_type(node.expression)
+        end
+
         def assertions_count_in_branches(branches)
           branches.map { |branch| assertions_count(branch) }.max
         end

data/lib/rubocop/cop/mixin/minitest_exploration_helpers.rb

@@ -99,8 +99,9 @@ module RuboCop
         end
       end
 
-      # rubocop:disable Metrics/CyclomaticComplexity
+      # rubocop:disable Metrics/CyclomaticComplexity, Metrics/PerceivedComplexity
       def assertion_method?(node)
+        return false unless node
         return assertion_method?(node.expression) if node.assignment? && node.respond_to?(:expression)
         return false if !node.send_type? && !node.block_type? && !node.numblock_type?
 
@@ -110,7 +111,7 @@ module RuboCop
           method_name.start_with?(prefix) || node.method?(:flunk)
         end
       end
-      # rubocop:enable Metrics/CyclomaticComplexity
+      # rubocop:enable Metrics/CyclomaticComplexity, Metrics/PerceivedComplexity
 
       def lifecycle_hook_method?(node)
         node.def_type? && LIFECYCLE_HOOK_METHODS.include?(node.method_name)

data/lib/rubocop/minitest/version.rb

@@ -4,7 +4,7 @@ module RuboCop
   module Minitest
     # This module holds the RuboCop Minitest version information.
     module Version
-      STRING = '0.34.1'
+      STRING = '0.34.3'
 
       def self.document_version
         STRING.match('\d+\.\d+').to_s

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rubocop-minitest
 version: !ruby/object:Gem::Version
-  version: 0.34.1
+  version: 0.34.3
 platform: ruby
 authors:
 - Bozhidar Batsov
@@ -10,7 +10,7 @@ authors:
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2023-12-16 00:00:00.000000000 Z
+date: 2024-01-01 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop