rubocop-minitest 0.23.1 → 0.24.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: c6e9ec7344a17911ca56ab072c8b89337ffc3836d113e9ffea4036d9681b7066
-  data.tar.gz: 5c0e810d17f4a1a125c3012a102c9401d368d0c803098b1afa9c43c54f00247b
+  metadata.gz: b0a695c307538885f790b2efe35af28113a4f76baf8ba870ae41d870a54b31fe
+  data.tar.gz: 40f94eb2dfa3d962e9ffba5dc989d281ae74f81ec3cbfac442e15095ac3d612c
 SHA512:
-  metadata.gz: bd836b3634c13de72ccdabd10cd16cd2f8bd4bf342a6b2ebae47c2784236706b2eb9d232126f0b6b75113af2f9b3e9d98707652342989f5c6900b62859c30ea8
-  data.tar.gz: 10dbb5f63df667ff8935d1616ac6508b40c858d3468b6bae010301b8ced80a0ca0ec30032d10b639fd9c575fd4ca59666ff63853f717f4ad9a5377c1e6c750f7
+  metadata.gz: 04c9af1d29a613536c03c372fac160ad7df0d32e68354f765bfbb178dfcca27b670da7f55bce7923dbbc048c227346f9656b31b8f641ba07254a7bf61c2a6d10
+  data.tar.gz: 9e3c8090307fa86ba39e2b917e583815616e4ae82bbb32d36cadcaa7f1eca3ca293d8907b71bfaa3bebf9e643fd5380040983802f624094a4f1776794c98b838

data/config/default.yml

@@ -239,6 +239,11 @@ Minitest/SkipEnsure:
   Enabled: pending
   VersionAdded: '0.20'
 
+Minitest/SkipWithoutReason:
+  Description: 'Checks for skipped tests missing the skipping reason.'
+  Enabled: pending
+  VersionAdded: '0.24'
+
 Minitest/TestMethodName:
   Description: 'This cop enforces that test method names start with `test_` prefix.'
   Enabled: 'pending'

data/lib/rubocop/cop/minitest/empty_line_before_assertion_methods.rb

@@ -43,8 +43,10 @@ module RuboCop
         def assertion_method(node)
           return node if assertion_method?(node)
           return unless (parent = node.parent)
+          return unless parent.block_type?
+          return if parent.method?(:test)
 
-          node.parent if parent.block_type? && parent.body && assertion_method?(parent.body)
+          node.parent if parent.body && assertion_method?(parent.body)
         end
 
         def accept_previous_line?(previous_line_node, node)

data/lib/rubocop/cop/minitest/skip_without_reason.rb

@@ -0,0 +1,66 @@
+# frozen_string_literal: true
+
+module RuboCop
+  module Cop
+    module Minitest
+      # Checks for skipped tests missing the skipping reason.
+      #
+      # @example
+      #   # bad
+      #   skip
+      #   skip('')
+      #
+      #   # bad
+      #   if condition?
+      #     skip
+      #   else
+      #     skip
+      #   end
+      #
+      #   # good
+      #   skip("Reason why the test was skipped")
+      #
+      #   # good
+      #   skip if condition?
+      #
+      class SkipWithoutReason < Base
+        MSG = 'Add a reason explaining why the test is skipped.'
+
+        RESTRICT_ON_SEND = %i[skip].freeze
+
+        def on_send(node)
+          return if node.receiver || !blank_argument?(node)
+
+          conditional_node = conditional_parent(node)
+          return if conditional_node && !only_skip_branches?(conditional_node)
+
+          return if node.parent&.resbody_type?
+
+          add_offense(node)
+        end
+
+        private
+
+        def blank_argument?(node)
+          message = node.first_argument
+          message.nil? || (message.str_type? && message.value == '')
+        end
+
+        def conditional_parent(node)
+          return unless (parent = node.parent)
+
+          if parent.if_type? || parent.case_type?
+            parent
+          elsif parent.when_type?
+            parent.parent
+          end
+        end
+
+        def only_skip_branches?(node)
+          branches = node.branches.compact
+          branches.size > 1 && branches.all? { |branch| branch.send_type? && branch.method?(:skip) }
+        end
+      end
+    end
+  end
+end

data/lib/rubocop/cop/minitest_cops.rb

@@ -44,6 +44,7 @@ require_relative 'minitest/refute_path_exists'
 require_relative 'minitest/refute_predicate'
 require_relative 'minitest/refute_respond_to'
 require_relative 'minitest/skip_ensure'
+require_relative 'minitest/skip_without_reason'
 require_relative 'minitest/test_method_name'
 require_relative 'minitest/unreachable_assertion'
 require_relative 'minitest/unspecified_exception'

data/lib/rubocop/minitest/version.rb

@@ -4,7 +4,7 @@ module RuboCop
   module Minitest
     # This module holds the RuboCop Minitest version information.
     module Version
-      STRING = '0.23.1'
+      STRING = '0.24.0'
 
       def self.document_version
         STRING.match('\d+\.\d+').to_s

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rubocop-minitest
 version: !ruby/object:Gem::Version
-  version: 0.23.1
+  version: 0.24.0
 platform: ruby
 authors:
 - Bozhidar Batsov
@@ -10,7 +10,7 @@ authors:
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2022-11-07 00:00:00.000000000 Z
+date: 2022-11-27 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop
@@ -97,6 +97,7 @@ files:
 - lib/rubocop/cop/minitest/refute_predicate.rb
 - lib/rubocop/cop/minitest/refute_respond_to.rb
 - lib/rubocop/cop/minitest/skip_ensure.rb
+- lib/rubocop/cop/minitest/skip_without_reason.rb
 - lib/rubocop/cop/minitest/test_method_name.rb
 - lib/rubocop/cop/minitest/unreachable_assertion.rb
 - lib/rubocop/cop/minitest/unspecified_exception.rb
@@ -119,7 +120,7 @@ metadata:
   homepage_uri: https://docs.rubocop.org/rubocop-minitest/
   changelog_uri: https://github.com/rubocop/rubocop-minitest/blob/master/CHANGELOG.md
   source_code_uri: https://github.com/rubocop/rubocop-minitest
-  documentation_uri: https://docs.rubocop.org/rubocop-minitest/0.23
+  documentation_uri: https://docs.rubocop.org/rubocop-minitest/0.24
   bug_tracker_uri: https://github.com/rubocop/rubocop-minitest/issues
   rubygems_mfa_required: 'true'
 post_install_message:
@@ -137,7 +138,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.3.7
+rubygems_version: 3.3.26
 signing_key:
 specification_version: 4
 summary: Automatic Minitest code style checking tool.