rubocop-minitest 0.22.1 → 0.23.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 6db30fddaa89f75fb61790465161c9de6e0fd0c7d3808afa9d091e9eac97a30e
-  data.tar.gz: fbf5dac86cbf247ded62e437f5cb79e8c1dece32b7ec78eeda0b3c8c20fdd7d7
+  metadata.gz: 27c1c1e73140c8a3b7a03627a9e7a8772a91468924a78a55ef9d7eb1de01c41b
+  data.tar.gz: b04c7e1341cbe6792b360ef49fc495a0534dbbc817cc1c3643465018c5ef7776
 SHA512:
-  metadata.gz: b5c7535584d692c5a2e4c62ddcfdd89939594b6c51082ba2d497f81b36b8a0b7153940c2846a14dfea681f5fe51753324e90e4d7488fb477a96e99b7aa8f2a77
-  data.tar.gz: 5e53402c171a4dabe59f71a8d102cfd5e8dd963c47d082f305803c749f258bcf1c114e552cbc8fde60a0486002348520c6dd46fa06d3476a80b5b967835e2013
+  metadata.gz: 60a86b10b510ca5da0d49d647ff5e20d8296e6fbb89214b3e2cb371eaf3096d4e866b3ebafeac446ae7ee6e0d2a139eadbcc77a4e23c144c10332acdef92f552
+  data.tar.gz: 31acd00dd4c8cbe95e50926694a1c844cb21c1ac6c9695d6a9fa120e9d936b16a7869f44552bcc413e737bf4983be67a2481935940fb5515422e5d14a2b4f0bf

data/config/default.yml

@@ -122,6 +122,11 @@ Minitest/DuplicateTestRun:
   Enabled: pending
   VersionAdded: '0.19'
 
+Minitest/EmptyLineBeforeAssertionMethods:
+  Description: 'Add empty line before assertion methods.'
+  Enabled: pending
+  VersionAdded: '0.23'
+
 Minitest/GlobalExpectations:
   Description: 'This cop checks for deprecated global expectations.'
   StyleGuide: 'https://minitest.rubystyle.guide#global-expectations'

data/lib/rubocop/cop/minitest/empty_line_before_assertion_methods.rb

@@ -0,0 +1,76 @@
+# frozen_string_literal: true
+
+module RuboCop
+  module Cop
+    module Minitest
+      # Enforces empty line before assertion methods because it separates assertion phase.
+      #
+      # @example
+      #
+      #   # bad
+      #   do_something
+      #   assert_equal(expected, actual)
+      #
+      #   # good
+      #   do_something
+      #
+      #   assert_equal(expected, actual)
+      #
+      class EmptyLineBeforeAssertionMethods < Base
+        include MinitestExplorationHelpers
+        extend AutoCorrector
+
+        MSG = 'Add empty line before assertion.'
+
+        def on_send(node)
+          return unless assertion_method?(node)
+          return unless (previous_line_node = node.left_sibling)
+          return if accept_previous_line?(previous_line_node, node)
+
+          previous_line_node = previous_line_node.arguments.last if use_heredoc_argument?(previous_line_node)
+          return unless no_empty_line?(previous_line_node, node)
+
+          register_offense(node, previous_line_node)
+        end
+
+        private
+
+        def accept_previous_line?(previous_line_node, node)
+          return true if previous_line_node.args_type? || node.parent.basic_conditional?
+
+          previous_line_node.send_type? && assertion_method?(previous_line_node)
+        end
+
+        def use_heredoc_argument?(node)
+          node.respond_to?(:arguments) && heredoc?(node.arguments.last)
+        end
+
+        def heredoc?(last_argument)
+          last_argument.respond_to?(:heredoc?) && last_argument.heredoc?
+        end
+
+        def no_empty_line?(previous_line_node, node)
+          previous_line = if heredoc?(previous_line_node)
+                            previous_line_node.loc.heredoc_end.line
+                          else
+                            previous_line_node.loc.last_line
+                          end
+
+          previous_line + 1 == node.loc.line
+        end
+
+        def register_offense(node, previous_line_node)
+          add_offense(node) do |corrector|
+            range = if heredoc?(previous_line_node)
+                      previous_line_node.loc.heredoc_end
+                    else
+                      previous_line_node
+                    end
+
+            corrector.insert_after(range, "\n")
+          end
+        end
+      end
+    end
+  end
+end

data/lib/rubocop/cop/minitest/refute_match.rb

@@ -18,7 +18,7 @@ module RuboCop
       class RefuteMatch < Base
         extend MinitestCopRule
 
-        define_rule :refute, target_method: :match
+        define_rule :refute, target_method: :match, inverse: 'regexp_type?'
       end
     end
   end

data/lib/rubocop/cop/minitest_cops.rb

@@ -26,6 +26,7 @@ require_relative 'minitest/assert_respond_to'
 require_relative 'minitest/assert_silent'
 require_relative 'minitest/assert_truthy'
 require_relative 'minitest/duplicate_test_run'
+require_relative 'minitest/empty_line_before_assertion_methods'
 require_relative 'minitest/global_expectations'
 require_relative 'minitest/literal_as_actual_argument'
 require_relative 'minitest/multiple_assertions'

data/lib/rubocop/minitest/assert_offense.rb

@@ -172,7 +172,33 @@ module RuboCop
           file = file.path
         end
 
-        RuboCop::ProcessedSource.new(source, ruby_version, file)
+        processed_source = RuboCop::ProcessedSource.new(source, ruby_version, file)
+
+        # Follow up https://github.com/rubocop/rubocop/pull/10987.
+        # When support for RuboCop 1.37.1 ends, this condition can be removed.
+        if processed_source.respond_to?(:config) && processed_source.respond_to?(:registry)
+          processed_source.config = configuration
+          processed_source.registry = registry
+        end
+
+        processed_source
+      end
+
+      def configuration
+        @configuration ||= if defined?(config)
+                             config
+                           else
+                             RuboCop::Config.new({}, "#{Dir.pwd}/.rubocop.yml")
+                           end
+      end
+
+      def registry
+        @registry ||= begin
+          cops = configuration.keys.map { |cop| RuboCop::Cop::Registry.global.find_by_cop_name(cop) }
+          cops << cop_class if defined?(cop_class) && !cops.include?(cop_class)
+          cops.compact!
+          RuboCop::Cop::Registry.new(cops)
+        end
       end
 
       def ruby_version

data/lib/rubocop/minitest/version.rb

@@ -4,7 +4,7 @@ module RuboCop
   module Minitest
     # This module holds the RuboCop Minitest version information.
     module Version
-      STRING = '0.22.1'
+      STRING = '0.23.0'
 
       def self.document_version
         STRING.match('\d+\.\d+').to_s

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rubocop-minitest
 version: !ruby/object:Gem::Version
-  version: 0.22.1
+  version: 0.23.0
 platform: ruby
 authors:
 - Bozhidar Batsov
@@ -10,7 +10,7 @@ authors:
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2022-09-18 00:00:00.000000000 Z
+date: 2022-10-30 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop
@@ -79,6 +79,7 @@ files:
 - lib/rubocop/cop/minitest/assert_with_expected_argument.rb
 - lib/rubocop/cop/minitest/assertion_in_lifecycle_hook.rb
 - lib/rubocop/cop/minitest/duplicate_test_run.rb
+- lib/rubocop/cop/minitest/empty_line_before_assertion_methods.rb
 - lib/rubocop/cop/minitest/global_expectations.rb
 - lib/rubocop/cop/minitest/literal_as_actual_argument.rb
 - lib/rubocop/cop/minitest/multiple_assertions.rb
@@ -118,7 +119,7 @@ metadata:
   homepage_uri: https://docs.rubocop.org/rubocop-minitest/
   changelog_uri: https://github.com/rubocop/rubocop-minitest/blob/master/CHANGELOG.md
   source_code_uri: https://github.com/rubocop/rubocop-minitest
-  documentation_uri: https://docs.rubocop.org/rubocop-minitest/0.22
+  documentation_uri: https://docs.rubocop.org/rubocop-minitest/0.23
   bug_tracker_uri: https://github.com/rubocop/rubocop-minitest/issues
   rubygems_mfa_required: 'true'
 post_install_message: