rubocop-minitest 0.21.1 → 0.22.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 32fe1532cdbac42cfc34dd6be3ce6c06af43c58b0fdac50d4d0afafb92006db8
-  data.tar.gz: bfdd3899218529e728b777b77092103c1bf9db73523835666988d953a6b47f3d
+  metadata.gz: 6db30fddaa89f75fb61790465161c9de6e0fd0c7d3808afa9d091e9eac97a30e
+  data.tar.gz: fbf5dac86cbf247ded62e437f5cb79e8c1dece32b7ec78eeda0b3c8c20fdd7d7
 SHA512:
-  metadata.gz: a6c4de4a42725e76f84de44313534b07a958f7c84ac5a63b8c7948b1edb9eadc27e81734721f7adda6b6b0b2d4a9e9ee8a90f9fa401fde7bd2faf799b229dded
-  data.tar.gz: 01d06e6462b2fc9f4dbdc133392d4b266a2df33ebac5ebbe042dd6d3185062bfd4df1017b4a3e255e12b56152284f2d2484668e650262907c9de3a3bccaee299
+  metadata.gz: b5c7535584d692c5a2e4c62ddcfdd89939594b6c51082ba2d497f81b36b8a0b7153940c2846a14dfea681f5fe51753324e90e4d7488fb477a96e99b7aa8f2a77
+  data.tar.gz: 5e53402c171a4dabe59f71a8d102cfd5e8dd963c47d082f305803c749f258bcf1c114e552cbc8fde60a0486002348520c6dd46fa06d3476a80b5b967835e2013

data/config/default.yml

@@ -82,6 +82,11 @@ Minitest/AssertRaisesCompoundBody:
   Enabled: pending
   VersionAdded: '0.21'
 
+Minitest/AssertRaisesWithRegexpArgument:
+  Description: 'This cop enforces checks for regular expression literals passed to `assert_raises`.'
+  Enabled: pending
+  VersionAdded: '0.22'
+
 Minitest/AssertRespondTo:
   Description: 'This cop enforces the test to use `assert_respond_to(object, :do_something)` over `assert(object.respond_to?(:do_something))`.'
   StyleGuide: 'https://minitest.rubystyle.guide#assert-responds-to-method'

data/lib/rubocop/cop/minitest/assert_match.rb

@@ -18,7 +18,7 @@ module RuboCop
       class AssertMatch < Base
         extend MinitestCopRule
 
-        define_rule :assert, target_method: :match
+        define_rule :assert, target_method: :match, inverse: 'regexp_type?'
       end
     end
   end

data/lib/rubocop/cop/minitest/assert_raises_with_regexp_argument.rb

@@ -0,0 +1,36 @@
+# frozen_string_literal: true
+
+module RuboCop
+  module Cop
+    module Minitest
+      # Checks for `assert_raises` with arguments of regular expression literals.
+      # Arguments should be exception classes.
+      # Optionally the last argument can be a custom message string to help explain failures.
+      # Either way, it's not the argument that `exception.message` is compared to.
+      # The raised exception is returned and can be used
+      # to match against a regular expression.
+      #
+      # @example
+      #
+      #   # bad
+      #   assert_raises FooError, /some message/ do
+      #     obj.occur_error
+      #   end
+      #
+      #   # good
+      #   exception = assert_raises FooError do
+      #     obj.occur_error
+      #   end
+      #   assert_match(/some message/, exception.message)
+      #
+      class AssertRaisesWithRegexpArgument < Base
+        MSG = 'Do not pass regular expression literals to `assert_raises`. Test the resulting exception.'
+        RESTRICT_ON_SEND = %i[assert_raises].freeze
+
+        def on_send(node)
+          add_offense(node) if node.last_argument&.regexp_type?
+        end
+      end
+    end
+  end
+end

data/lib/rubocop/cop/minitest_cops.rb

@@ -12,6 +12,7 @@ require_relative 'minitest/assert_equal'
 require_relative 'minitest/assert_in_delta'
 require_relative 'minitest/assert_predicate'
 require_relative 'minitest/assert_raises_compound_body'
+require_relative 'minitest/assert_raises_with_regexp_argument'
 require_relative 'minitest/assert_with_expected_argument'
 require_relative 'minitest/assertion_in_lifecycle_hook'
 require_relative 'minitest/assert_kind_of'

data/lib/rubocop/cop/mixin/argument_range_helper.rb

@@ -3,6 +3,7 @@
 module RuboCop
   module Cop
     # Methods that calculate and return `Parser::Source::Ranges`.
+    # @api private
     module ArgumentRangeHelper
       include RangeHelp
 

data/lib/rubocop/cop/mixin/in_delta_mixin.rb

@@ -3,6 +3,7 @@
 module RuboCop
   module Cop
     # Common functionality for `AssertInDelta` and `RefuteInDelta` cops.
+    # @api private
     module InDeltaMixin
       MSG = 'Prefer using `%<good_method>s`.'
 

data/lib/rubocop/cop/mixin/minitest_cop_rule.rb

@@ -19,7 +19,9 @@ module RuboCop
       #                                  autocorrection. The preferred method name that connects
       #                                  `assertion_method` and `target_method` with `_` is
       #                                  the default name.
-      # @param inverse [Boolean] An optional param. Order of arguments replaced by autocorrection.
+      # @param inverse [Boolean, String] An optional param. Order of arguments replaced by autocorrection.
+      #                                  If string is passed, it becomes a predicate method for the first argument node.
+      # @api private
       #
       def define_rule(assertion_method, target_method:, preferred_method: nil, inverse: false)
         preferred_method = "#{assertion_method}_#{target_method.to_s.delete('?')}" if preferred_method.nil?
@@ -34,7 +36,8 @@ module RuboCop
           def on_send(node)
             return unless node.method?(:#{assertion_method})
             return unless (arguments = peel_redundant_parentheses_from(node.arguments))
-            return unless arguments.first.respond_to?(:method?) && arguments.first.method?(:#{target_method})
+            return unless arguments.first&.call_type?
+            return if arguments.first.arguments.empty? || !arguments.first.method?(:#{target_method})
 
             add_offense(node, message: offense_message(arguments)) do |corrector|
               autocorrect(corrector, node, arguments)
@@ -77,10 +80,15 @@ module RuboCop
 
           def new_arguments(arguments)
             receiver = correct_receiver(arguments.first.receiver)
-            method_argument = arguments.first.arguments.first&.source
+            method_argument = arguments.first.arguments.first
 
-            new_arguments = [receiver, method_argument].compact
-            new_arguments.reverse! if #{inverse}
+            new_arguments = [receiver, method_argument&.source].compact
+            inverse_condition = if %w[true false].include?('#{inverse}')
+              #{inverse}
+            else
+              method_argument.#{inverse}
+            end
+            new_arguments.reverse! if inverse_condition
             new_arguments
           end
 

data/lib/rubocop/cop/mixin/minitest_exploration_helpers.rb

@@ -5,6 +5,7 @@ require 'set'
 module RuboCop
   module Cop
     # Helper methods for different explorations against test files and test cases.
+    # @api private
     module MinitestExplorationHelpers
       extend NodePattern::Macros
 

data/lib/rubocop/cop/mixin/nil_assertion_handleable.rb

@@ -4,6 +4,7 @@ module RuboCop
   module Cop
     module Minitest
       # Common functionality for `AssertNil` and `RefuteNil` cops.
+      # @api private
       module NilAssertionHandleable
         MSG = 'Prefer using `%<assertion_type>s_nil(%<preferred_args>s)`.'
 

data/lib/rubocop/cop/mixin/predicate_assertion_handleable.rb

@@ -4,6 +4,7 @@ module RuboCop
   module Cop
     module Minitest
       # Common functionality for `Minitest/AssertPredicate` and `Minitest/RefutePredicate` cops.
+      # @api private
       module PredicateAssertionHandleable
         MSG = 'Prefer using `%<assertion_type>s_predicate(%<new_arguments>s)`.'
 

data/lib/rubocop/minitest/version.rb

@@ -4,7 +4,7 @@ module RuboCop
   module Minitest
     # This module holds the RuboCop Minitest version information.
     module Version
-      STRING = '0.21.1'
+      STRING = '0.22.1'
 
       def self.document_version
         STRING.match('\d+\.\d+').to_s

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rubocop-minitest
 version: !ruby/object:Gem::Version
-  version: 0.21.1
+  version: 0.22.1
 platform: ruby
 authors:
 - Bozhidar Batsov
@@ -10,7 +10,7 @@ authors:
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2022-08-28 00:00:00.000000000 Z
+date: 2022-09-18 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop
@@ -54,41 +54,9 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
-- ".circleci/config.yml"
-- ".gitattributes"
-- ".github/FUNDING.yml"
-- ".github/ISSUE_TEMPLATE/bug_report.md"
-- ".github/ISSUE_TEMPLATE/feature_request.md"
-- ".github/PULL_REQUEST_TEMPLATE.md"
-- ".github/workflows/linting.yml"
-- ".github/workflows/spell_checking.yml"
-- ".gitignore"
-- ".rubocop.yml"
-- ".rubocop_todo.yml"
-- ".yamllint.yml"
-- ".yardopts"
-- CHANGELOG.md
-- CONTRIBUTING.md
-- Gemfile
 - LICENSE.txt
 - README.md
-- Rakefile
-- bin/console
-- bin/setup
-- codespell.txt
 - config/default.yml
-- docs/antora.yml
-- docs/modules/ROOT/nav.adoc
-- docs/modules/ROOT/pages/cops.adoc
-- docs/modules/ROOT/pages/cops_minitest.adoc
-- docs/modules/ROOT/pages/index.adoc
-- docs/modules/ROOT/pages/installation.adoc
-- docs/modules/ROOT/pages/usage.adoc
-- legacy-docs/cops.md
-- legacy-docs/cops_minitest.md
-- legacy-docs/index.md
-- legacy-docs/installation.md
-- legacy-docs/usage.md
 - lib/rubocop-minitest.rb
 - lib/rubocop/cop/generator.rb
 - lib/rubocop/cop/minitest/assert_empty.rb
@@ -104,6 +72,7 @@ files:
 - lib/rubocop/cop/minitest/assert_path_exists.rb
 - lib/rubocop/cop/minitest/assert_predicate.rb
 - lib/rubocop/cop/minitest/assert_raises_compound_body.rb
+- lib/rubocop/cop/minitest/assert_raises_with_regexp_argument.rb
 - lib/rubocop/cop/minitest/assert_respond_to.rb
 - lib/rubocop/cop/minitest/assert_silent.rb
 - lib/rubocop/cop/minitest/assert_truthy.rb
@@ -142,52 +111,6 @@ files:
 - lib/rubocop/minitest/inject.rb
 - lib/rubocop/minitest/support.rb
 - lib/rubocop/minitest/version.rb
-- mkdocs.yml
-- readthedocs.yml
-- relnotes/v0.1.0.md
-- relnotes/v0.10.0.md
-- relnotes/v0.10.1.md
-- relnotes/v0.10.2.md
-- relnotes/v0.10.3.md
-- relnotes/v0.11.0.md
-- relnotes/v0.11.1.md
-- relnotes/v0.12.0.md
-- relnotes/v0.12.1.md
-- relnotes/v0.13.0.md
-- relnotes/v0.14.0.md
-- relnotes/v0.15.0.md
-- relnotes/v0.15.1.md
-- relnotes/v0.15.2.md
-- relnotes/v0.16.0.md
-- relnotes/v0.17.0.md
-- relnotes/v0.17.1.md
-- relnotes/v0.17.2.md
-- relnotes/v0.18.0.md
-- relnotes/v0.19.0.md
-- relnotes/v0.19.1.md
-- relnotes/v0.2.0.md
-- relnotes/v0.2.1.md
-- relnotes/v0.20.0.md
-- relnotes/v0.20.1.md
-- relnotes/v0.21.0.md
-- relnotes/v0.21.1.md
-- relnotes/v0.3.0.md
-- relnotes/v0.4.0.md
-- relnotes/v0.4.1.md
-- relnotes/v0.5.0.md
-- relnotes/v0.5.1.md
-- relnotes/v0.6.0.md
-- relnotes/v0.6.1.md
-- relnotes/v0.6.2.md
-- relnotes/v0.7.0.md
-- relnotes/v0.8.0.md
-- relnotes/v0.8.1.md
-- relnotes/v0.9.0.md
-- rubocop-minitest.gemspec
-- tasks/changelog.rake
-- tasks/changelog.rb
-- tasks/cops_documentation.rake
-- tasks/cut_release.rake
 homepage:
 licenses:
 - MIT
@@ -195,7 +118,7 @@ metadata:
   homepage_uri: https://docs.rubocop.org/rubocop-minitest/
   changelog_uri: https://github.com/rubocop/rubocop-minitest/blob/master/CHANGELOG.md
   source_code_uri: https://github.com/rubocop/rubocop-minitest
-  documentation_uri: https://docs.rubocop.org/rubocop-minitest/0.21
+  documentation_uri: https://docs.rubocop.org/rubocop-minitest/0.22
   bug_tracker_uri: https://github.com/rubocop/rubocop-minitest/issues
   rubygems_mfa_required: 'true'
 post_install_message:

data/.circleci/config.yml

@@ -1,55 +0,0 @@
-version: 2.1
-
-jobs:
-  rake_default:
-    parameters:
-      image:
-        description: "Name of the Docker image."
-        type: string
-        default: "circleci/ruby"
-    docker:
-      - image: << parameters.image >>
-    environment:
-      # CircleCI container has two cores, but Ruby can see 32 cores. So we
-      # configure test-queue.
-      # See https://github.com/tmm1/test-queue#environment-variables
-      TEST_QUEUE_WORKERS: 2
-      JRUBY_OPTS: "--dev -J-Xmx1000M"
-    steps:
-      - checkout
-      - run: bundle install
-      - run: bundle exec rake
-
-  # Miscellaneous tasks
-  documentation-checks:
-    docker:
-      - image: circleci/ruby
-    steps:
-      - checkout
-      - run: bundle install
-      - run:
-          name: Check documentation syntax
-          command: bundle exec rake documentation_syntax_check
-
-workflows:
-  build:
-    jobs:
-      - documentation-checks
-      - rake_default:
-          name: Ruby 2.6
-          image: cimg/ruby:2.6
-      - rake_default:
-          name: Ruby 2.7
-          image: cimg/ruby:2.7
-      - rake_default:
-          name: Ruby 3.0
-          image: cimg/ruby:3.0
-      - rake_default:
-          name: Ruby 3.1
-          image: cimg/ruby:3.1
-      - rake_default:
-          name: Ruby HEAD
-          image: rubocophq/circleci-ruby-snapshot:latest # Nightly snapshot build
-      - rake_default:
-          name: JRuby 9.3
-          image: circleci/jruby:9.3

data/.gitattributes

@@ -1 +0,0 @@
-CHANGELOG.md merge=union

data/.github/FUNDING.yml

@@ -1,7 +0,0 @@
-# These are supported funding model platforms
-
-github: [bbatsov, koic]
-patreon: bbatsov
-open_collective: rubocop
-tidelift: "rubygems/rubocop"
-custom: https://www.paypal.me/bbatsov

data/.github/ISSUE_TEMPLATE/bug_report.md

@@ -1,43 +0,0 @@
----
-name: Bug Report
-about: Report an issue with RuboCop Minitest you've discovered.
----
-
-*Be clear, concise and precise in your description of the problem.
-Open an issue with a descriptive title and a summary in grammatically correct,
-complete sentences.*
-
-*Use the template below when reporting bugs. Please, make sure that
-you're running the latest stable RuboCop and that the problem you're reporting
-hasn't been reported (and potentially fixed) already.*
-
-*Before filing the ticket you should replace all text above the horizontal
-rule with your own words.*
-
---------
-
-## Expected behavior
-
-Describe here how you expected RuboCop Minitest to behave in this particular situation.
-
-## Actual behavior
-
-Describe here what actually happened.
-
-## Steps to reproduce the problem
-
-This is extremely important! Providing us with a reliable way to reproduce
-a problem will expedite its solution.
-
-## RuboCop version
-
-Include the output of `rubocop -V` or `bundle exec rubocop -V` if using Bundler. Here's an example:
-You see extension cop versions (e.g. rubocop-minitest, rubocop-performance, and others) output by rubocop -V,
-include them as well. Here's an example:
-
-```
-$ [bundle exec] rubocop -V
-1.10.0 (using Parser 3.0.0.0, rubocop-ast 1.4.1, running on ruby 3.0.0 x86_64-darwin19)
-  - rubocop-minitest 0.10.3
-  - rubocop-performance 1.9.2
-```

data/.github/ISSUE_TEMPLATE/feature_request.md

@@ -1,20 +0,0 @@
----
-name: Feature Request
-about: Suggest new RuboCop Minitest features or improvements to existing features.
----
-
-## Is your feature request related to a problem? Please describe.
-
-A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
-
-## Describe the solution you'd like
-
-A clear and concise description of what you want to happen.
-
-## Describe alternatives you've considered
-
-A clear and concise description of any alternative solutions or features you've considered.
-
-## Additional context
-
-Add any other context or screenshots about the feature request here.

data/.github/PULL_REQUEST_TEMPLATE.md

@@ -1,17 +0,0 @@
-**Replace this text with a summary of the changes in your PR.
-The more detailed you are, the better.**
-
------------------
-
-Before submitting the PR make sure the following are checked:
-
-* [ ] The PR relates to *only* one subject with a clear title and description in grammatically correct, complete sentences.
-* [ ] Wrote [good commit messages][1].
-* [ ] Commit message starts with `[Fix #issue-number]` (if the related issue exists).
-* [ ] Feature branch is up-to-date with `master` (if not - rebase it).
-* [ ] Squashed related commits together.
-* [ ] Added tests.
-* [ ] Ran `bundle exec rake default`. It executes all tests and runs RuboCop on its own code.
-* [ ] Added an entry (file) to the [changelog folder](https://github.com/rubocop/rubocop-minitest/blob/master/changelog/) named `{change_type}_{change_description}.md` if the new code introduces user-observable changes. See [changelog entry format](https://github.com/rubocop/rubocop/blob/master/CONTRIBUTING.md#changelog-entry-format) for details.
-
-[1]: https://chris.beams.io/posts/git-commit/

data/.github/workflows/linting.yml

@@ -1,15 +0,0 @@
-name: Linting
-on:
-  - pull_request
-jobs:
-  yamllint:
-    name: Yamllint
-    runs-on: ubuntu-latest
-    steps:
-      - uses: actions/checkout@v3
-      - name: Yamllint
-        uses: karancode/yamllint-github-action@master
-        with:
-          yamllint_comment: true
-        env:
-          GITHUB_ACCESS_TOKEN: ${{ secrets.GITHUB_TOKEN }}

data/.github/workflows/spell_checking.yml

@@ -1,33 +0,0 @@
-name: Spell Checking
-
-on: [pull_request]
-
-jobs:
-  codespell:
-    name: Check spelling of all files with codespell
-    runs-on: ubuntu-latest
-    strategy:
-      matrix:
-        python-version: [3.8]
-    steps:
-      - uses: actions/checkout@v3
-      - name: Set up Python ${{ matrix.python-version }}
-        uses: actions/setup-python@v2
-        with:
-          python-version: ${{ matrix.python-version }}
-      - name: Install dependencies
-        run: |
-          python -m pip install --upgrade pip
-          pip install codespell
-          if [ -f requirements.txt ]; then pip install -r requirements.txt; fi
-      - name: Check spelling with codespell
-        run: codespell --ignore-words=codespell.txt || exit 1
-  misspell:
-    name: Check spelling of all files in commit with misspell
-    runs-on: ubuntu-latest
-    steps:
-      - uses: actions/checkout@v3
-      - name: Install
-        run: wget -O - -q https://raw.githubusercontent.com/client9/misspell/master/install-misspell.sh | sh -s -- -b .
-      - name: Misspell
-        run: git ls-files --empty-directory | xargs ./misspell -error

data/.gitignore

@@ -1,61 +0,0 @@
-# rcov generated
-coverage
-coverage.data
-
-# rdoc generated
-rdoc
-
-# yard generated
-doc
-.yardoc
-
-# bundler
-.bundle
-Gemfile.lock
-Gemfile.local
-
-# rbenv
-.ruby-version
-
-# rspec
-/spec/examples.txt
-/.test_queue_stats
-
-# jeweler generated
-pkg
-
-# etags
-TAGS
-
-# Have editor/IDE/OS specific files you need to ignore? Consider using a global gitignore:
-#
-# * Create a file at ~/.gitignore
-# * Include files you want ignored
-# * Run: git config --global core.excludesfile ~/.gitignore
-#
-# After doing this, these files will be ignored in all your git projects,
-# saving you from having to 'pollute' every project you touch with them
-#
-# Not sure what to needs to be ignored for particular editors/OSes? Here's some ideas to get you started. (Remember, remove the leading # of the line)
-#
-# For MacOS:
-#
-#.DS_Store
-
-# For TextMate
-#*.tmproj
-#tmtags
-
-# For emacs:
-#*~
-#\#*
-#.\#*
-
-# For vim:
-*.swp
-
-# For redcar:
-#.redcar
-
-# For rubinius:
-#*.rbc

data/.rubocop.yml

@@ -1,110 +0,0 @@
-inherit_from: .rubocop_todo.yml
-
-# This is the configuration used to check the rubocop source code.
-
-require:
-  - rubocop/cop/internal_affairs
-  - rubocop-performance
-  - rubocop-minitest
-
-AllCops:
-  NewCops: enable
-  TargetRubyVersion: 2.6
-  SuggestExtensions: false
-
-InternalAffairs/NodeMatcherDirective:
-  Enabled: false
-
-# FIXME: Workaround for a false positive caused by this cop when using `bundle exec rake`.
-InternalAffairs/UndefinedConfig:
-  Enabled: false
-
-Naming/PredicateName:
-  # Method define macros for dynamically generated method.
-  MethodDefinitionMacros:
-    - define_method
-    - define_singleton_method
-    - def_node_matcher
-    - def_node_search
-
-Naming/InclusiveLanguage:
-  Enabled: true
-  CheckStrings: true
-  FlaggedTerms:
-    auto-correct:
-      Suggestions:
-        - autocorrect
-    auto_correct:
-      Suggestions:
-        - autocorrect
-    behaviour:
-      Suggestions:
-        - behavior
-    offence:
-      Suggestions:
-        - offense
-
-Style/FormatStringToken:
-  # Because we parse a lot of source codes from strings. Percent arrays
-  # look like unannotated format string tokens to this cop.
-  Exclude:
-    - test/**/*
-
-Metrics/ClassLength:
-  Exclude:
-    - test/**/*
-    - tasks/changelog.rb
-
-Layout/EndOfLine:
-  EnforcedStyle: lf
-
-Layout/ClassStructure:
-  Enabled: true
-  Categories:
-    module_inclusion:
-      - include
-      - prepend
-      - extend
-  ExpectedOrder:
-    - module_inclusion
-    - constants
-    - public_class_methods
-    - initializer
-    - instance_methods
-    - protected_methods
-    - private_methods
-
-Layout/RedundantLineBreak:
-  Enabled: true
-
-# Trailing white space is meaningful in code examples
-Layout/TrailingWhitespace:
-  AllowInHeredoc: true
-
-Lint/AmbiguousBlockAssociation:
-  Exclude:
-    - 'test/**/*.rb'
-
-Lint/InterpolationCheck:
-  Exclude:
-    - 'test/**/*.rb'
-
-Lint/UselessAccessModifier:
-  MethodCreatingMethods:
-    - 'def_matcher'
-    - 'def_node_matcher'
-
-Metrics/BlockLength:
-  Exclude:
-    - 'Rakefile'
-    - '**/*.rake'
-    - 'test/**/*.rb'
-    - 'rubocop-minitest.gemspec'
-
-Naming/FileName:
-  Exclude:
-    - lib/rubocop-minitest.rb
-
-Metrics/ModuleLength:
-  Exclude:
-    - 'test/**/*.rb'